21610 2008-10-15 05:36:22 -0700 run-webkit-threads --threaded crashes in StructureID destructor 2008-10-15 23:41:36 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P1 Normal --- 1 ap ap oldest_to_newest 95397 0 ap 2008-10-15 05:36:22 -0700 There is a debug-only HashSet in StructureID.cpp that is not protected with locks. This makes run-webkit-tests crash quickly. 95398 1 24359 ap 2008-10-15 05:58:32 -0700 Created attachment 24359 proposed fix 95409 2 24359 darin 2008-10-15 09:11:40 -0700 Comment on attachment 24359 proposed fix #include <wtf/RefPtr.h> +#if ENABLE(JSC_MULTIPLE_THREADS) +#include <wtf/Threading.h> +#endif #ifdef'd includes normally go in a separate paragraph. Since this is debug-only code it would be nice if there was some no-op version of Mutex and MutexLocker for the single-thread case to keep the #if to a minimum -- performance is not a critical concern. r=me 95508 3 ap 2008-10-15 23:41:36 -0700 Committed revision 37630. 24359 2008-10-15 05:58:32 -0700 2008-10-15 09:11:40 -0700 proposed fix StructureID.txt text/plain 2039 ap SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM3NjAyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTAtMTUgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTYxMAorICAgICAgICBydW4td2Via2l0LXRocmVhZHMgLS10aHJlYWRlZCBjcmFzaGVz IGluIFN0cnVjdHVyZUlEIGRlc3RydWN0b3IKKworICAgICAgICAqIGtqcy9TdHJ1Y3R1cmVJRC5j cHA6CisgICAgICAgIChKU0M6OlN0cnVjdHVyZUlEOjpTdHJ1Y3R1cmVJRCk6CisgICAgICAgIChK U0M6OlN0cnVjdHVyZUlEOjp+U3RydWN0dXJlSUQpOgorICAgICAgICBQcm90ZWN0IGFjY2VzcyB0 byBhIHN0YXRpYyAoZGVidWctb25seSkgSGFzaFNldCB3aXRoIGEgbG9jay4KKwogMjAwOC0xMC0x NSAgR2Fib3IgTG9raSAgPGxva2lAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2Vk IGJ5IENhbWVyb24gWndhcmljaC4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9TdHJ1Y3R1cmVJ RC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL1N0cnVjdHVyZUlELmNwcAko cmV2aXNpb24gMzc1ODUpCisrKyBKYXZhU2NyaXB0Q29yZS9ranMvU3RydWN0dXJlSUQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0zMiw2ICszMiw5IEBACiAjaW5jbHVkZSAibG9va3VwLmgiCiAjaW5j bHVkZSA8d3RmL1JlZkNvdW50ZWRMZWFrQ291bnRlci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZQdHIu aD4KKyNpZiBFTkFCTEUoSlNDX01VTFRJUExFX1RIUkVBRFMpCisjaW5jbHVkZSA8d3RmL1RocmVh ZGluZy5oPgorI2VuZGlmCiAKIHVzaW5nIG5hbWVzcGFjZSBzdGQ7CiAKQEAgLTQwLDYgKzQzLDEw IEBAIG5hbWVzcGFjZSBKU0MgewogI2lmbmRlZiBOREVCVUcgICAgCiBzdGF0aWMgV1RGOjpSZWZD b3VudGVkTGVha0NvdW50ZXIgc3RydWN0dXJlSURDb3VudGVyKCJTdHJ1Y3R1cmVJRCIpOwogCisj aWYgRU5BQkxFKEpTQ19NVUxUSVBMRV9USFJFQURTKQorc3RhdGljIE11dGV4IGlnbm9yZVNldE11 dGV4OworI2VuZGlmCisKIHN0YXRpYyBib29sIHNob3VsZElnbm9yZUxlYWtzOwogc3RhdGljIEhh c2hTZXQ8U3RydWN0dXJlSUQqPiBpZ25vcmVTZXQ7CiAjZW5kaWYKQEAgLTYwLDYgKzY3LDkgQEAg U3RydWN0dXJlSUQ6OlN0cnVjdHVyZUlEKEpTVmFsdWUqIHByb3RvdAogICAgIEFTU0VSVChtX3By b3RvdHlwZS0+aXNPYmplY3QoKSB8fCBtX3Byb3RvdHlwZS0+aXNOdWxsKCkpOwogCiAjaWZuZGVm IE5ERUJVRworI2lmIEVOQUJMRShKU0NfTVVMVElQTEVfVEhSRUFEUykKKyAgICBNdXRleExvY2tl ciBwcm90ZWN0KGlnbm9yZVNldE11dGV4KTsKKyNlbmRpZgogICAgIGlmIChzaG91bGRJZ25vcmVM ZWFrcykKICAgICAgICAgaWdub3JlU2V0LmFkZCh0aGlzKTsKICAgICBlbHNlCkBAIC03OCw2ICs4 OCw5IEBAIFN0cnVjdHVyZUlEOjp+U3RydWN0dXJlSUQoKQogICAgICAgICBtX2NhY2hlZFByb3Bl cnR5TmFtZUFycmF5RGF0YS0+c2V0Q2FjaGVkU3RydWN0dXJlSUQoMCk7CiAKICNpZm5kZWYgTkRF QlVHCisjaWYgRU5BQkxFKEpTQ19NVUxUSVBMRV9USFJFQURTKQorICAgIE11dGV4TG9ja2VyIHBy b3RlY3QoaWdub3JlU2V0TXV0ZXgpOworI2VuZGlmCiAgICAgSGFzaFNldDxTdHJ1Y3R1cmVJRCo+ OjppdGVyYXRvciBpdCA9IGlnbm9yZVNldC5maW5kKHRoaXMpOwogICAgIGlmIChpdCAhPSBpZ25v cmVTZXQuZW5kKCkpCiAgICAgICAgIGlnbm9yZVNldC5yZW1vdmUoaXQpOwo=