216092 2020-09-02 13:10:15 -0700 REGRESSION (r237835): WebCore::TextDecorationThickness constructor fails to initialize m_length 2020-09-03 10:23:15 -0700 1 1 1 Unclassified WebKit Text Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 191242 1 ddkilzer ddkilzer changseok esprehn+autocc ews-watchlist glenn kondapallykalyan mmaxfield pdr simon.fraser thorton webkit-bug-importer oldest_to_newest 1684940 0 ddkilzer 2020-09-02 13:10:15 -0700 WebCore::TextDecorationThickness constructor fails to initialize m_length. Regressed here: Bug 191242: Parsing support for text-underline-offset and text-decoration-thickness <https://bugs.webkit.org/show_bug.cgi?id=191242> <https://trac.webkit.org/r237835> Found by clang static analyzer using the optin.cplusplus.UninitializedObject checker. 1684941 1 407792 ddkilzer 2020-09-02 13:11:08 -0700 Created attachment 407792 Patch v1 1684942 2 407792 thorton 2020-09-02 13:13:24 -0700 Comment on attachment 407792 Patch v1 Technically there is no path there, but I guess it doesn't hurt? 1684955 3 ddkilzer 2020-09-02 13:41:46 -0700 (In reply to Tim Horton from comment #2) > Comment on attachment 407792 [details] > Patch v1 > > Technically there is no path there, but I guess it doesn't hurt? Yes. this is a hardening fix. 1685315 4 407792 ddkilzer 2020-09-03 10:06:18 -0700 Comment on attachment 407792 Patch v1 Adding cq+ since failures in fast/block/margin-collapse/103.html are happening across multiple patches. Not related to this patch. 1685323 5 ews-feeder 2020-09-03 10:22:31 -0700 Committed r266531: <https://trac.webkit.org/changeset/266531> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407792. 1685325 6 webkit-bug-importer 2020-09-03 10:23:15 -0700 <rdar://problem/68287137> 407792 2020-09-02 13:11:08 -0700 2020-09-03 10:22:32 -0700 Patch v1 bug-216092-20200902131358.patch text/plain 1656 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjcwOTIyOWEyZTg1ZGIz ZjZlOWM4YjQ3ZTc0MDQ4NTdiYjI3Nzc2MC4uYzFiYjAyMmViNzgxMGNkODJjYzMyOTk1NDk2MjBi OTRlNzU2MGVjYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA5LTAyICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjIz NzgzNSk6IFdlYkNvcmU6OlRleHREZWNvcmF0aW9uVGhpY2tuZXNzIGNvbnN0cnVjdG9yIGZhaWxz IHRvIGluaXRpYWxpemUgbV9sZW5ndGgKKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIx NjA5Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IHJlbmRlcmluZy9zdHlsZS9UZXh0RGVjb3JhdGlvblRoaWNrbmVzcy5oOgorICAgICAgICAoV2Vi Q29yZTo6VGV4dERlY29yYXRpb25UaGlja25lc3MpOgorICAgICAgICAtIEFkZCBkZWZhdWx0IGlu aXRpYWxpemVyIGZvciBtX2xlbmd0aC4KKwogMjAyMC0wOS0wMiAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYkNvcmU6OkRPTVRpbWVyRmlyZVN0YXRlIGNv bnN0cnVjdG9yIGZhaWxzIHRvIGluaXRpYWxpemUgbV9pbml0aWFsRE9NVHJlZVZlcnNpb24sIG1f cHJldmlvdXMgb24gd29ya2VyIHRocmVhZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9UZXh0RGVjb3JhdGlvblRoaWNrbmVzcy5oIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1RleHREZWNvcmF0aW9uVGhpY2tuZXNzLmgKaW5kZXggOTZiM2I0YmU4 Njc3MGZmYTBkNDIxM2Y1NzBiMGM0NDcyMzFlMzNlZi4uYmIwYmRlZDkyYzUyZjNkODE5ZGU5NjYx Y2M1YzIwMGJhMmZjMzVhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0 eWxlL1RleHREZWNvcmF0aW9uVGhpY2tuZXNzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1RleHREZWNvcmF0aW9uVGhpY2tuZXNzLmgKQEAgLTEsNSArMSw1IEBACiAvKgot ICogQ29weXJpZ2h0IChDKSAyMDE4IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAxOC0yMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K ICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1z LCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRl ZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMTE5LDcgKzExOSw3IEBAIHByaXZh dGU6CiAgICAgfQogCiAgICAgVHlwZSBtX3R5cGU7Ci0gICAgZmxvYXQgbV9sZW5ndGg7CisgICAg ZmxvYXQgbV9sZW5ndGggeyAwIH07CiB9OwogCiBpbmxpbmUgVGV4dFN0cmVhbSYgb3BlcmF0b3I8 PChUZXh0U3RyZWFtJiB0cywgY29uc3QgVGV4dERlY29yYXRpb25UaGlja25lc3MmIHRoaWNrbmVz cykK