216087 2020-09-02 11:36:43 -0700 Sampling profiler should dump hash as part of the top function key to prevent incorrectly grouping nameless functions together 2020-09-03 15:48:17 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist keith_miller mark.lam msaboff tzagallo webkit-bug-importer oldest_to_newest 1684898 0 saam 2020-09-02 11:36:43 -0700 ... 1684952 1 407796 saam 2020-09-02 13:40:25 -0700 Created attachment 407796 patch 1684953 2 407796 saam 2020-09-02 13:40:56 -0700 Comment on attachment 407796 patch View in context: https://bugs.webkit.org/attachment.cgi?id=407796&action=review > Source/JavaScriptCore/runtime/SamplingProfiler.cpp:1039 > + hash = "<nil"_s; will fix to <nil> 1684954 3 407797 saam 2020-09-02 13:41:22 -0700 Created attachment 407797 patch 1684958 4 407797 tzagallo 2020-09-02 13:42:48 -0700 Comment on attachment 407797 patch r=me 1685034 5 ews-feeder 2020-09-02 15:46:10 -0700 Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 42, in <module> from webkitpy.tool.main import WebKitPatch File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/main.py", line 41, in <module> from webkitpy.tool import commands File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/__init__.py", line 16, in <module> from webkitpy.tool.commands.queries import * File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/tool/commands/queries.py", line 45, in <module> from webkitpy.common.net.buildbot import BuildBot File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/net/buildbot/__init__.py", line 5, in <module> from .buildbot import BuildBot, Builder, Build File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 43, in <module> from webkitpy.thirdparty.autoinstalled.mechanize import Browser File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 97, in find_module self._install_mechanize() File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 138, in _install_mechanize self._install_html5lib() File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 134, in _install_html5lib "html5lib-1.0.1/html5lib") File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/__init__.py", line 279, in _install return installer.install(url=url, url_subpath=url_subpath, target_name=target_name) File "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/common/system/autoinstall.py", line 540, in install raise Exception(message) Exception: Error auto-installing the html5lib package to: "/Volumes/Data/worker/Commit-Queue/build/Tools/Scripts/webkitpy/thirdparty/autoinstalled/html5lib" --> Inner message: Command '['curl', 'https://files.pythonhosted.org/packages/85/3e/cf449cf1b5004e87510b9368e7a5f1acd8831c2d6691edd3c62a0823f98f/html5lib-1.0.1.tar.gz', '-L', '--output', '/var/folders/33/15r3ggyd4fb52p4t38_rbd9w0000gn/T/html5lib_ymPUTH/html5lib-1.0.1.tar.gz']' returned non-zero exit status 7 1685468 6 ews-feeder 2020-09-03 15:47:38 -0700 Committed r266560: <https://trac.webkit.org/changeset/266560> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407797. 1685469 7 webkit-bug-importer 2020-09-03 15:48:17 -0700 <rdar://problem/68306505> 407796 2020-09-02 13:40:25 -0700 2020-09-02 13:41:22 -0700 patch c-backup.diff text/plain 2243 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjY2MjQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDIwLTA5LTAyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFNhbXBsaW5nIHByb2ZpbGVyIHNob3VsZCBkdW1wIGhhc2ggYXMgcGFydCBvZiB0aGUgdG9wIGZ1 bmN0aW9uIGtleSB0byBwcmV2ZW50IGluY29ycmVjdGx5IGdyb3VwaW5nIG5hbWVsZXNzIGZ1bmN0 aW9ucyB0b2dldGhlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE2MDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBydW50aW1lL1NhbXBsaW5nUHJvZmlsZXIuY3BwOgorICAgICAgICAoSlNDOjpTYW1w bGluZ1Byb2ZpbGVyOjpyZXBvcnRUb3BGdW5jdGlvbnMpOgorCiAyMDIwLTA4LTI3ICBLZWl0aCBN aWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE9TUiBhdmFpbGFiaWxp dHkgdmFsaWRhdGlvbiBzaG91bGQgcnVuIGZvciBhbnkgbm9kZSB3aXRoIGV4aXRPSwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5j cHAJKHJldmlzaW9uIDI2NjI0NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Nh bXBsaW5nUHJvZmlsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMwLDcgKzEwMzAsMTQgQEAg dm9pZCBTYW1wbGluZ1Byb2ZpbGVyOjpyZXBvcnRUb3BGdW5jdGlvbgogICAgICAgICAgICAgY29u dGludWU7CiAKICAgICAgICAgU3RhY2tGcmFtZSYgZnJhbWUgPSBzdGFja1RyYWNlLmZyYW1lcy5m aXJzdCgpOwotICAgICAgICBTdHJpbmcgZnJhbWVEZXNjcmlwdGlvbiA9IG1ha2VTdHJpbmcoZnJh bWUuZGlzcGxheU5hbWUobV92bSksICc6JywgZnJhbWUuc291cmNlSUQoKSk7CisgICAgICAgIFN0 cmluZyBoYXNoID0gIiJfczsKKyAgICAgICAgaWYgKGZyYW1lLnNlbWFudGljTG9jYXRpb24uaGFz Q29kZUJsb2NrSGFzaCgpKSB7CisgICAgICAgICAgICBTdHJpbmdQcmludFN0cmVhbSBzdHJlYW07 CisgICAgICAgICAgICBmcmFtZS5zZW1hbnRpY0xvY2F0aW9uLmNvZGVCbG9ja0hhc2guZHVtcChz dHJlYW0pOworICAgICAgICAgICAgaGFzaCA9IHN0cmVhbS50b1N0cmluZygpOworICAgICAgICB9 IGVsc2UKKyAgICAgICAgICAgIGhhc2ggPSAiPG5pbCJfczsKKyAgICAgICAgU3RyaW5nIGZyYW1l RGVzY3JpcHRpb24gPSBtYWtlU3RyaW5nKGZyYW1lLmRpc3BsYXlOYW1lKG1fdm0pLCAnIycsIGhh c2gsICc6JywgZnJhbWUuc291cmNlSUQoKSk7CiAgICAgICAgIGZ1bmN0aW9uQ291bnRzLmFkZChm cmFtZURlc2NyaXB0aW9uLCAwKS5pdGVyYXRvci0+dmFsdWUrKzsKICAgICB9CiAKQEAgLTEwNTAs NyArMTA1Nyw3IEBAIHZvaWQgU2FtcGxpbmdQcm9maWxlcjo6cmVwb3J0VG9wRnVuY3Rpb24KIAog ICAgIGlmIChPcHRpb25zOjpzYW1wbGluZ1Byb2ZpbGVyVG9wRnVuY3Rpb25zQ291bnQoKSkgewog ICAgICAgICBvdXQucHJpbnQoIlxuXG5TYW1wbGluZyByYXRlOiAiLCBtX3RpbWluZ0ludGVydmFs Lm1pY3Jvc2Vjb25kcygpLCAiIG1pY3Jvc2Vjb25kc1xuIik7Ci0gICAgICAgIG91dC5wcmludCgi VG9wIGZ1bmN0aW9ucyBhcyA8bnVtU2FtcGxlcyAgJ2Z1bmN0aW9uTmFtZTpzb3VyY2VJRCc+XG4i KTsKKyAgICAgICAgb3V0LnByaW50KCJUb3AgZnVuY3Rpb25zIGFzIDxudW1TYW1wbGVzICAnZnVu Y3Rpb25OYW1lI2hhc2g6c291cmNlSUQnPlxuIik7CiAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgT3B0aW9uczo6c2FtcGxpbmdQcm9maWxlclRvcEZ1bmN0aW9uc0NvdW50KCk7IGkrKykg ewogICAgICAgICAgICAgYXV0byBwYWlyID0gdGFrZU1heCgpOwogICAgICAgICAgICAgaWYgKHBh aXIuZmlyc3QuaXNFbXB0eSgpKQo= 407797 2020-09-02 13:41:22 -0700 2020-09-03 15:47:38 -0700 patch c-backup.diff text/plain 2244 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjY2MjQ3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDIwLTA5LTAyICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFNhbXBsaW5nIHByb2ZpbGVyIHNob3VsZCBkdW1wIGhhc2ggYXMgcGFydCBvZiB0aGUgdG9wIGZ1 bmN0aW9uIGtleSB0byBwcmV2ZW50IGluY29ycmVjdGx5IGdyb3VwaW5nIG5hbWVsZXNzIGZ1bmN0 aW9ucyB0b2dldGhlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjE2MDg3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBydW50aW1lL1NhbXBsaW5nUHJvZmlsZXIuY3BwOgorICAgICAgICAoSlNDOjpTYW1w bGluZ1Byb2ZpbGVyOjpyZXBvcnRUb3BGdW5jdGlvbnMpOgorCiAyMDIwLTA4LTI3ICBLZWl0aCBN aWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE9TUiBhdmFpbGFiaWxp dHkgdmFsaWRhdGlvbiBzaG91bGQgcnVuIGZvciBhbnkgbm9kZSB3aXRoIGV4aXRPSwpJbmRleDog U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU2FtcGxpbmdQcm9maWxlci5j cHAJKHJldmlzaW9uIDI2NjI0NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1Nh bXBsaW5nUHJvZmlsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDMwLDcgKzEwMzAsMTQgQEAg dm9pZCBTYW1wbGluZ1Byb2ZpbGVyOjpyZXBvcnRUb3BGdW5jdGlvbgogICAgICAgICAgICAgY29u dGludWU7CiAKICAgICAgICAgU3RhY2tGcmFtZSYgZnJhbWUgPSBzdGFja1RyYWNlLmZyYW1lcy5m aXJzdCgpOwotICAgICAgICBTdHJpbmcgZnJhbWVEZXNjcmlwdGlvbiA9IG1ha2VTdHJpbmcoZnJh bWUuZGlzcGxheU5hbWUobV92bSksICc6JywgZnJhbWUuc291cmNlSUQoKSk7CisgICAgICAgIFN0 cmluZyBoYXNoID0gIiJfczsKKyAgICAgICAgaWYgKGZyYW1lLnNlbWFudGljTG9jYXRpb24uaGFz Q29kZUJsb2NrSGFzaCgpKSB7CisgICAgICAgICAgICBTdHJpbmdQcmludFN0cmVhbSBzdHJlYW07 CisgICAgICAgICAgICBmcmFtZS5zZW1hbnRpY0xvY2F0aW9uLmNvZGVCbG9ja0hhc2guZHVtcChz dHJlYW0pOworICAgICAgICAgICAgaGFzaCA9IHN0cmVhbS50b1N0cmluZygpOworICAgICAgICB9 IGVsc2UKKyAgICAgICAgICAgIGhhc2ggPSAiPG5pbD4iX3M7CisgICAgICAgIFN0cmluZyBmcmFt ZURlc2NyaXB0aW9uID0gbWFrZVN0cmluZyhmcmFtZS5kaXNwbGF5TmFtZShtX3ZtKSwgJyMnLCBo YXNoLCAnOicsIGZyYW1lLnNvdXJjZUlEKCkpOwogICAgICAgICBmdW5jdGlvbkNvdW50cy5hZGQo ZnJhbWVEZXNjcmlwdGlvbiwgMCkuaXRlcmF0b3ItPnZhbHVlKys7CiAgICAgfQogCkBAIC0xMDUw LDcgKzEwNTcsNyBAQCB2b2lkIFNhbXBsaW5nUHJvZmlsZXI6OnJlcG9ydFRvcEZ1bmN0aW9uCiAK ICAgICBpZiAoT3B0aW9uczo6c2FtcGxpbmdQcm9maWxlclRvcEZ1bmN0aW9uc0NvdW50KCkpIHsK ICAgICAgICAgb3V0LnByaW50KCJcblxuU2FtcGxpbmcgcmF0ZTogIiwgbV90aW1pbmdJbnRlcnZh bC5taWNyb3NlY29uZHMoKSwgIiBtaWNyb3NlY29uZHNcbiIpOwotICAgICAgICBvdXQucHJpbnQo IlRvcCBmdW5jdGlvbnMgYXMgPG51bVNhbXBsZXMgICdmdW5jdGlvbk5hbWU6c291cmNlSUQnPlxu Iik7CisgICAgICAgIG91dC5wcmludCgiVG9wIGZ1bmN0aW9ucyBhcyA8bnVtU2FtcGxlcyAgJ2Z1 bmN0aW9uTmFtZSNoYXNoOnNvdXJjZUlEJz5cbiIpOwogICAgICAgICBmb3IgKHNpemVfdCBpID0g MDsgaSA8IE9wdGlvbnM6OnNhbXBsaW5nUHJvZmlsZXJUb3BGdW5jdGlvbnNDb3VudCgpOyBpKysp IHsKICAgICAgICAgICAgIGF1dG8gcGFpciA9IHRha2VNYXgoKTsKICAgICAgICAgICAgIGlmIChw YWlyLmZpcnN0LmlzRW1wdHkoKSkK