216085 2020-09-02 11:27:24 -0700 WebCore::DOMTimerFireState constructor fails to initialize m_initialDOMTreeVersion, m_previous on worker threads 2020-09-04 08:04:13 -0700 1 1 1 Unclassified WebKit DOM Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer cdumez darin rniwa webkit-bug-importer youennf oldest_to_newest 1684888 0 ddkilzer 2020-09-02 11:27:24 -0700 WebCore::DOMTimerFireState fails to initialize m_initialDOMTreeVersion, m_previous on worker threads. Found by clang static analyzer using the optin.cplusplus.UninitializedObject checker. 1684894 1 407780 ddkilzer 2020-09-02 11:32:14 -0700 Created attachment 407780 Patch v1 1685162 2 407780 darin 2020-09-02 21:34:01 -0700 Comment on attachment 407780 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=407780&action=review > Source/WebCore/page/DOMTimer.cpp:100 > bool m_contextIsDocument; Why not initialize this to false, too? I know it’s not necessary, but seems worth doing. Keep in mind that those other two are never used when m_contextIsDocument is false, so all of this is just "defensive programming". 1685164 3 darin 2020-09-02 21:35:37 -0700 Another way to do this is to write the constructor differently, like this: , m_initialDOMTreeVersion(m_contextIsDocument ? downcast<Document>(context).domTreeVersion() : 0) , m_previous(m_contextIsDocument ? std::exchange(current, this) : nullptr) And reorder the members so m_contextIsDocument comes first. 1685354 4 407894 ddkilzer 2020-09-03 11:12:44 -0700 Created attachment 407894 Patch for landing 1685645 5 407894 ddkilzer 2020-09-04 08:00:22 -0700 Comment on attachment 407894 Patch for landing Adding cq+ since all bubbles passed. 1685648 6 ews-feeder 2020-09-04 08:03:27 -0700 Committed r266608: <https://trac.webkit.org/changeset/266608> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407894. 1685649 7 webkit-bug-importer 2020-09-04 08:04:13 -0700 <rdar://problem/68346261> 407780 2020-09-02 11:32:14 -0700 2020-09-02 21:34:01 -0700 Patch v1 bug-216085-20200902113504.patch text/plain 1413 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDNmMzdmOGUzMDc0NjIx YjgwYzJkODA5MTNhZWM3NDhmNGNkMDZhNy4uMjcwOTIyOWEyZTg1ZGIzZjZlOWM4YjQ3ZTc0MDQ4 NTdiYjI3Nzc2MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA5LTAyICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViQ29yZTo6RE9NVGlt ZXJGaXJlU3RhdGUgY29uc3RydWN0b3IgZmFpbHMgdG8gaW5pdGlhbGl6ZSBtX2luaXRpYWxET01U cmVlVmVyc2lvbiwgbV9wcmV2aW91cyBvbiB3b3JrZXIgdGhyZWFkcworICAgICAgICA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMjE2MDg1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGFnZS9ET01UaW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpE T01UaW1lckZpcmVTdGF0ZSk6CisgICAgICAgIC0gQWRkIGRlZmF1bHQgaW5pdGlhbGl6ZXJzLgor CiAyMDIwLTA5LTAyICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgogCiAgICAgICAg IFJFR1JFU1NJT04gKHIyNjQ2NjEpOiBDcmFzaGVzIGluIFdlYkNvcmU6OndyYXA8V2ViQ29yZTo6 QmxvYj4gaW4gQ2xvbmVEZXNlcmlhbGl6ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRE9NVGltZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAKaW5kZXgg ODY1NDA4ZGJmYTUwMzYyMWZhYzQxZjIwZjZjZmZiZjQ0MzU4YTYwZi4uZjFlZjQyMmEzZmU4OWE1 YzFjZWZmZjc4M2M2ZGYxZTkwNzBjZjk4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFn ZS9ET01UaW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01UaW1lci5jcHAKQEAg LTk1LDggKzk1LDggQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIFNjcmlwdEV4ZWN1dGlvbkNv bnRleHQmIG1fY29udGV4dDsKLSAgICB1aW50NjRfdCBtX2luaXRpYWxET01UcmVlVmVyc2lvbjsK LSAgICBET01UaW1lckZpcmVTdGF0ZSogbV9wcmV2aW91czsKKyAgICB1aW50NjRfdCBtX2luaXRp YWxET01UcmVlVmVyc2lvbiB7IDAgfTsKKyAgICBET01UaW1lckZpcmVTdGF0ZSogbV9wcmV2aW91 cyB7IG51bGxwdHIgfTsKICAgICBib29sIG1fY29udGV4dElzRG9jdW1lbnQ7CiAgICAgYm9vbCBt X3NjcmlwdE1hZGVOb25Vc2VyT2JzZXJ2YWJsZUNoYW5nZXMgeyBmYWxzZSB9OwogICAgIGJvb2wg bV9zY3JpcHRNYWRlVXNlck9ic2VydmFibGVDaGFuZ2VzIHsgZmFsc2UgfTsK 407894 2020-09-03 11:12:44 -0700 2020-09-04 08:03:28 -0700 Patch for landing bug-216085-20200903111540.patch text/plain 2358 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2NTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTYwZWE4N2MwODI0N2Ix OTM1M2MzZGMxOTJjYWNjYzEyNjY5MzYyZC4uMDE5NTc5MjMyY2UzZDk3NWUzNzczNWY0ZDE4YWM5 N2YyMDRjZWVkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA5LTAzICBEYXZp ZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViQ29yZTo6RE9NVGlt ZXJGaXJlU3RhdGUgY29uc3RydWN0b3IgZmFpbHMgdG8gaW5pdGlhbGl6ZSBtX2luaXRpYWxET01U cmVlVmVyc2lvbiwgbV9wcmV2aW91cyBvbiB3b3JrZXIgdGhyZWFkcworICAgICAgICA8aHR0cHM6 Ly93ZWJraXQub3JnL2IvMjE2MDg1PgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVy LgorCisgICAgICAgICogcGFnZS9ET01UaW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01U aW1lckZpcmVTdGF0ZSk6CisgICAgICAgIC0gUmVvcmRlciBpbnN0YW5jZSB2YXJpYWJsZXMgc28g bW9yZSBsb2dpYyBjYW4gYmUgbW92ZWQgaW50byB0aGUKKyAgICAgICAgICBpbml0aWFsaXplciBs aXN0LgorCiAyMDIwLTA5LTAzICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVGV4dERlY29kZXIgc2hvdWxkIGlnbm9yZSBieXRlLW9yZGVyLW1h cmsgbGlrZSBvdGhlciBicm93c2VycyBhbmQgc3BlYwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9ET01UaW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVRpbWVyLmNwcApp bmRleCA4NjU0MDhkYmZhNTAzNjIxZmFjNDFmMjBmNmNmZmJmNDQzNThhNjBmLi43NWQ1ZjJlYzdl NDAyNDJiZTc5YjI5MDY5ZTZjODFjZGRiZWZiZDg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0RPTVRpbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVRpbWVyLmNw cApAQCAtNTYsMTUgKzU2LDExIEBAIHB1YmxpYzoKICAgICBET01UaW1lckZpcmVTdGF0ZShTY3Jp cHRFeGVjdXRpb25Db250ZXh0JiBjb250ZXh0LCBpbnQgbmVzdGluZ0xldmVsKQogICAgICAgICA6 IG1fY29udGV4dChjb250ZXh0KQogICAgICAgICAsIG1fY29udGV4dElzRG9jdW1lbnQoaXM8RG9j dW1lbnQ+KG1fY29udGV4dCkpCi0gICAgewogICAgICAgICAvLyBGb3Igd29ya2VyIHRocmVhZHMs IGRvbid0IHVwZGF0ZSB0aGUgY3VycmVudCBET01UaW1lckZpcmVTdGF0ZS4KICAgICAgICAgLy8g U2V0dGluZyB0aGlzIGZyb20gd29ya2VycyB3b3VsZCBub3QgYmUgdGhyZWFkLXNhZmUsIGFuZCBp dHMgbm90IHJlbGV2YW50IHRvIGN1cnJlbnQgdXNlcy4KLSAgICAgICAgaWYgKG1fY29udGV4dElz RG9jdW1lbnQpIHsKLSAgICAgICAgICAgIG1faW5pdGlhbERPTVRyZWVWZXJzaW9uID0gZG93bmNh c3Q8RG9jdW1lbnQ+KGNvbnRleHQpLmRvbVRyZWVWZXJzaW9uKCk7Ci0gICAgICAgICAgICBtX3By ZXZpb3VzID0gY3VycmVudDsKLSAgICAgICAgICAgIGN1cnJlbnQgPSB0aGlzOwotICAgICAgICB9 Ci0KKyAgICAgICAgLCBtX2luaXRpYWxET01UcmVlVmVyc2lvbihtX2NvbnRleHRJc0RvY3VtZW50 ID8gZG93bmNhc3Q8RG9jdW1lbnQ+KG1fY29udGV4dCkuZG9tVHJlZVZlcnNpb24oKSA6IDApCisg ICAgICAgICwgbV9wcmV2aW91cyhtX2NvbnRleHRJc0RvY3VtZW50ID8gc3RkOjpleGNoYW5nZShj dXJyZW50LCB0aGlzKSA6IG51bGxwdHIpCisgICAgewogICAgICAgICBtX2NvbnRleHQuc2V0VGlt ZXJOZXN0aW5nTGV2ZWwobmVzdGluZ0xldmVsKTsKICAgICB9CiAKQEAgLTk1LDExICs5MSwxMSBA QCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCYgbV9jb250 ZXh0OwotICAgIHVpbnQ2NF90IG1faW5pdGlhbERPTVRyZWVWZXJzaW9uOwotICAgIERPTVRpbWVy RmlyZVN0YXRlKiBtX3ByZXZpb3VzOwogICAgIGJvb2wgbV9jb250ZXh0SXNEb2N1bWVudDsKICAg ICBib29sIG1fc2NyaXB0TWFkZU5vblVzZXJPYnNlcnZhYmxlQ2hhbmdlcyB7IGZhbHNlIH07CiAg ICAgYm9vbCBtX3NjcmlwdE1hZGVVc2VyT2JzZXJ2YWJsZUNoYW5nZXMgeyBmYWxzZSB9OworICAg IHVpbnQ2NF90IG1faW5pdGlhbERPTVRyZWVWZXJzaW9uOworICAgIERPTVRpbWVyRmlyZVN0YXRl KiBtX3ByZXZpb3VzOwogfTsKIAogRE9NVGltZXJGaXJlU3RhdGUqIERPTVRpbWVyRmlyZVN0YXRl OjpjdXJyZW50ID0gbnVsbHB0cjsK