216060 2020-09-01 18:06:09 -0700 Web Inspector: Timelines: duplicate "Timeline Recording 1" on open 2020-09-02 11:45:16 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1684679 0 hi 2020-09-01 18:06:09 -0700 # STEPS TO REPRODUCE 1. inspect any page 2. go to the Timelines Tab 3. click the "Timeline Recording 1" breadcrumb # EXPECTED Nothing should happen as there should only be one timeline recording. # ACTUAL Two "Timeline Recording 1" are shown in a contextmenu. 1684681 1 407722 hi 2020-09-01 18:07:39 -0700 Created attachment 407722 Patch 1684889 2 407722 bburg 2020-09-02 11:27:29 -0700 Comment on attachment 407722 Patch r=me 1684900 3 ews-feeder 2020-09-02 11:44:36 -0700 Committed r266477: <https://trac.webkit.org/changeset/266477> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407722. 1684901 4 webkit-bug-importer 2020-09-02 11:45:16 -0700 <rdar://problem/68223298> 407722 2020-09-01 18:07:39 -0700 2020-09-02 11:44:37 -0700 Patch 216060.diff text/plain 3069 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDgzZmNhMTcwMDA0Li42MDczOWFmNzU3NyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDktMDEgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRp bWVsaW5lczogZHVwbGljYXRlICJUaW1lbGluZSBSZWNvcmRpbmcgMSIgb24gb3BlbgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2MDYwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qczoKKyAgICAgICAgKFdJLlRpbWVsaW5lTWFu YWdlcik6CisgICAgICAgIChXSS5UaW1lbGluZU1hbmFnZXIucHJvdG90eXBlLmdldCByZWNvcmRp bmdzKTogRGVsZXRlZC4KKyAgICAgICAgRG9uJ3QgYHJlc2V0YCBpbiB0aGUgYGNvbnN0cnVjdG9y YCBhcyB0aGlzIGlzIGFscmVhZHkgZG9uZSBpbiBgZW5hYmxlYCBhbmQgYGRpc2FibGVgLCB3aGlj aAorICAgICAgICBpcyBjYWxsZWQgd2hlbmV2ZXIgdGhlIFRpbWVsaW5lIFRhYiBpcyBhZGRlZC9y ZW1vdmVkLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRl bnRWaWV3LmpzOgorICAgICAgICAoV0kuVGltZWxpbmVUYWJDb250ZW50Vmlldyk6CisgICAgICAg IFRoZXJlIHNob3VsZCBuZXZlciBiZSBhbnkgZXhpc3RpbmcgcmVjb3JkaW5ncyB3aGVuIGFkZGlu ZyB0aGUgVGltZWxpbmVzIFRhYiwgYXMgdGhleSBzaG91bGQKKyAgICAgICAgaGF2ZSBiZWVuIHJl bW92ZWQgd2hlbiB0aGUgdGFiIHdhcyBsYXN0IHJlbW92ZWQgKHZpYSBgV0kuVGltZWxpbmVNYW5h Z2VyLnByb3RvdHlwZS5kaXNhYmxlYCkuCisKIDIwMjAtMDgtMjggIERldmluIFJvdXNzbyAgPGRy b3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF1ZGl0OiBzaG91bGQg YmUgYWJsZSB0byBjcmVhdGUvZWRpdCBpbXBvcnRlZCBhdWRpdHMKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdl ci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1Rp bWVsaW5lTWFuYWdlci5qcwppbmRleCBiZjA5NzhjZTg5Ni4uZjUwMjhiZTU2OTMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVs aW5lTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9D b250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKQEAgLTU5LDggKzU5LDYgQEAgV0kuVGltZWxp bmVNYW5hZ2VyID0gY2xhc3MgVGltZWxpbmVNYW5hZ2VyIGV4dGVuZHMgV0kuT2JqZWN0CiAgICAg ICAgIHRoaXMuX3N0b3BDYXB0dXJpbmdUaW1lb3V0ID0gdW5kZWZpbmVkOwogICAgICAgICB0aGlz Ll9kZWFkVGltZVRpbWVvdXQgPSB1bmRlZmluZWQ7CiAgICAgICAgIHRoaXMuX2xhc3REZWFkVGlt ZVRpY2tsZSA9IDA7Ci0KLSAgICAgICAgdGhpcy5yZXNldCgpOwogICAgIH0KIAogICAgIC8vIEFn ZW50CkBAIC0xODcsMTEgKzE4NSw2IEBAIFdJLlRpbWVsaW5lTWFuYWdlciA9IGNsYXNzIFRpbWVs aW5lTWFuYWdlciBleHRlbmRzIFdJLk9iamVjdAogICAgICAgICByZXR1cm4gdGhpcy5fYWN0aXZl UmVjb3JkaW5nOwogICAgIH0KIAotICAgIGdldCByZWNvcmRpbmdzKCkKLSAgICB7Ci0gICAgICAg IHJldHVybiB0aGlzLl9yZWNvcmRpbmdzLnNsaWNlKCk7Ci0gICAgfQotCiAgICAgZ2V0IGF1dG9D YXB0dXJlT25QYWdlTG9hZCgpCiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5fYXV0b0NhcHR1 cmVPblBhZ2VMb2FkOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVGFiQ29udGVudFZpZXcuanMKaW5kZXgg ZTA2M2Q1NzY4NzYuLjhmYWU4ZGY3ZTI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVGFiQ29udGVu dFZpZXcuanMKQEAgLTgzLDE0ICs4Myw2IEBAIFdJLlRpbWVsaW5lVGFiQ29udGVudFZpZXcgPSBj bGFzcyBUaW1lbGluZVRhYkNvbnRlbnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudEJyb3dzCiAgICAg ICAgIGNvbnN0IHNlbGVjdGVkQnlVc2VyID0gZmFsc2U7CiAgICAgICAgIHRoaXMuX2NoYW5nZVZp ZXdNb2RlKFdJLlRpbWVsaW5lT3ZlcnZpZXcuVmlld01vZGUuVGltZWxpbmVzLCBzZWxlY3RlZEJ5 VXNlcik7CiAKLSAgICAgICAgZm9yIChsZXQgcmVjb3JkaW5nIG9mIFdJLnRpbWVsaW5lTWFuYWdl ci5yZWNvcmRpbmdzKQotICAgICAgICAgICAgdGhpcy5fYWRkUmVjb3JkaW5nKHJlY29yZGluZyk7 Ci0KLSAgICAgICAgdGhpcy5fcmVjb3JkaW5nQ291bnRDaGFuZ2VkKCk7Ci0KLSAgICAgICAgLy8g RXhwbGljaXRseSB1cGRhdGUgdGhlIHBhdGggZm9yIHRoZSBuYXZpZ2F0aW9uIGJhciB0byBwcmV2 ZW50IGl0IGZyb20gc2hvd2luZyB1cCBhcyBibGFuay4KLSAgICAgICAgdGhpcy5jb250ZW50QnJv d3Nlci51cGRhdGVIaWVyYXJjaGljYWxQYXRoRm9yQ3VycmVudENvbnRlbnRWaWV3KCk7Ci0KICAg ICAgICAgV0kuaGVhcE1hbmFnZXIuZW5hYmxlKCk7CiAgICAgICAgIFdJLm1lbW9yeU1hbmFnZXIu ZW5hYmxlKCk7CiAgICAgICAgIFdJLnRpbWVsaW5lTWFuYWdlci5lbmFibGUoKTsK