216057 2020-09-01 16:07:02 -0700 Web Inspector: Timelines: re-enabling the JavaScript Allocations timeline doesn't show previously captured heap snapshots in the table 2020-09-02 08:48:32 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1684654 0 hi 2020-09-01 16:07:02 -0700 # STEPS TO REPRODUCE 1. inspect <https://webkit.org/> 2. go to the Timelines Tab 3. enable the JavaScript Allocations timeline instrument 4. reload the page to capture some heap snapshots (should have at least two) 5. enter Edit mode 6. disable the JavaScript Allocations timeline instrument 7. exit Edit mode 8. enter Edit mode 9. enable the JavaScript Allocations timeline instrument 10. exit Edit mode # EXPECTED The JavaScript Allocations timeline instrument should show either the previously captured heap snapshots or no heap snapshots (i.e. they were cleared when the JavaScript Allocations timeline instrument was disabled). # ACTUAL The overview graph shows records for each previously captured heap snapshot, but the JavaScript Allocations table has no rows and clicking on any of the heap snapshot records in the overview graph does nothing. 1684655 1 webkit-bug-importer 2020-09-01 16:07:15 -0700 <rdar://problem/68172848> 1684686 2 407727 hi 2020-09-01 18:18:56 -0700 Created attachment 407727 Patch 1684825 3 407727 bburg 2020-09-02 08:45:58 -0700 Comment on attachment 407727 Patch r=me 1684828 4 ews-feeder 2020-09-02 08:48:31 -0700 Committed r266463: <https://trac.webkit.org/changeset/266463> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407727. 407727 2020-09-01 18:18:56 -0700 2020-09-02 08:48:32 -0700 Patch 216057.diff text/plain 1940 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDgzZmNhMTcwMDA0OS4uMzZjMGE0YmE3YjIxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wOS0wMSAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog VGltZWxpbmVzOiByZS1lbmFibGluZyB0aGUgSmF2YVNjcmlwdCBBbGxvY2F0aW9ucyB0aW1lbGlu ZSBkb2Vzbid0IHNob3cgcHJldmlvdXNseSBjYXB0dXJlZCBoZWFwIHNuYXBzaG90cyBpbiB0aGUg dGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIx NjA1NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjgxNzI4NDg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0hl YXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldy5qczoKKyAgICAgICAgKFdJLkhlYXBBbGxvY2F0aW9u c1RpbWVsaW5lVmlldyk6CisgICAgICAgIEFkZCBhIGBXSS5IZWFwQWxsb2NhdGlvbnNUaW1lbGlu ZURhdGFHcmlkTm9kZWAgZm9yIGVhY2ggYFdJLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lUmVjb3Jk YAorICAgICAgICB0aGF0IGFscmVhZHkgZXhpc3RzIHdoZW4gdGhlIGBXSS5IZWFwQWxsb2NhdGlv bnNUaW1lbGluZVZpZXdgIGlzIGNyZWF0ZWQuCisKIDIwMjAtMDgtMjggIERldmluIFJvdXNzbyAg PGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF1ZGl0OiBzaG91 bGQgYmUgYWJsZSB0byBjcmVhdGUvZWRpdCBpbXBvcnRlZCBhdWRpdHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1Rp bWVsaW5lVmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldy5qcwppbmRleCBlYzUxNDVhZmIyNDAuLmM1MjAx MjExNmQ0YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvSGVhcEFsbG9jYXRpb25zVGltZWxpbmVWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldy5q cwpAQCAtMTAwLDcgKzEwMCw3IEBAIFdJLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldyA9IGNs YXNzIEhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldyBleHRlbmRzIFdJLlRpCiAgICAgICAgIHRo aXMuX2NvbnRlbnRWaWV3Q29udGFpbmVyLmFkZEV2ZW50TGlzdGVuZXIoV0kuQ29udGVudFZpZXdD b250YWluZXIuRXZlbnQuQ3VycmVudENvbnRlbnRWaWV3RGlkQ2hhbmdlLCB0aGlzLl9jdXJyZW50 Q29udGVudFZpZXdEaWRDaGFuZ2UsIHRoaXMpOwogICAgICAgICBXSS5Db250ZW50Vmlldy5hZGRF dmVudExpc3RlbmVyKFdJLkNvbnRlbnRWaWV3LkV2ZW50LlNlbGVjdGlvblBhdGhDb21wb25lbnRz RGlkQ2hhbmdlLCB0aGlzLl9jb250ZW50Vmlld1NlbGVjdGlvblBhdGhDb21wb25lbnREaWRDaGFu Z2UsIHRoaXMpOwogCi0gICAgICAgIHRoaXMuX3BlbmRpbmdSZWNvcmRzID0gW107CisgICAgICAg IHRoaXMuX3BlbmRpbmdSZWNvcmRzID0gQXJyYXkuZnJvbSh0aW1lbGluZS5yZWNvcmRzKTsKIAog ICAgICAgICB0aW1lbGluZS5hZGRFdmVudExpc3RlbmVyKFdJLlRpbWVsaW5lLkV2ZW50LlJlY29y ZEFkZGVkLCB0aGlzLl9oZWFwQWxsb2NhdGlvbnNUaW1lbGluZVJlY29yZEFkZGVkLCB0aGlzKTsK IAo=