216043 2020-09-01 10:15:32 -0700 Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled 2020-09-02 09:41:56 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist jbedard keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1684523 0 ysuzuki 2020-09-01 10:15:32 -0700 Skip fast/css-custom-paint/out-of-memory-while-adding-worklet-module.html if Gigacage is not enabled 1684526 1 407692 ysuzuki 2020-09-01 10:22:02 -0700 Created attachment 407692 Patch 1684527 2 ysuzuki 2020-09-01 10:22:05 -0700 <rdar://problem/66394369> 1684540 3 407692 mark.lam 2020-09-01 10:46:20 -0700 Comment on attachment 407692 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407692&action=review r=me with fix > Source/JavaScriptCore/tools/JSDollarVM.cpp:3124 > + return JSValue::encode(jsBoolean(Gigacage::isEnabled())); Can you add `DollarVMAssertScope assertScope;` before this line? 1684559 4 407692 ysuzuki 2020-09-01 11:30:37 -0700 Comment on attachment 407692 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407692&action=review Thanks! >> Source/JavaScriptCore/tools/JSDollarVM.cpp:3124 >> + return JSValue::encode(jsBoolean(Gigacage::isEnabled())); > > Can you add `DollarVMAssertScope assertScope;` before this line? Added. 1684700 5 ysuzuki 2020-09-01 19:18:10 -0700 Committed r266447: <https://trac.webkit.org/changeset/266447> 407692 2020-09-01 10:22:02 -0700 2020-09-01 10:46:20 -0700 Patch bug-216043-20200901102202.patch text/plain 7181 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2Mzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx OGNmYmQyYWMzZGU1OTFjNDc1Yzc5YTgyNmYxMjg4NzM2MzhlYmVkLi4zZWIxNTdkZTRjYjBhYmYw Y2Q5YTYzNDFmZmMzYzRkYjhhNGFmMjU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wOS0wMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFNraXAgZmFzdC9jc3MtY3VzdG9tLXBhaW50L291dC1vZi1tZW1vcnktd2hp bGUtYWRkaW5nLXdvcmtsZXQtbW9kdWxlLmh0bWwgaWYgR2lnYWNhZ2UgaXMgbm90IGVuYWJsZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjA0Mwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjYzOTQzNjk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB0b29scy9KU0RvbGxhclZNLmNwcDoKKyAgICAg ICAgKEpTQzo6ZnVuY3Rpb25Jc0dpZ2FjYWdlRW5hYmxlZCk6CisgICAgICAgIChKU0M6OkpTRG9s bGFyVk06OmZpbmlzaENyZWF0aW9uKToKKwogMjAyMC0wOS0wMSAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0xpbnV4XSBXZWIgSW5zcGVjdG9y OiBzaG93IHBlciB0aHJlYWQgY3B1IHVzYWdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvdG9vbHMvSlNEb2xsYXJWTS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMv SlNEb2xsYXJWTS5jcHAKaW5kZXggYmQ5MWI2NDViZTMyMWZmYjAwMTMxOTljMmNkN2Q5YTgyOGU0 Zjc2NC4uNjFiY2RlNjkzYTI2ZDAxMzYyYzVlZmUwM2E5NmVhNzc1YjE1ZTg1ZSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0pTRG9sbGFyVk0uY3BwCisrKyBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS90b29scy9KU0RvbGxhclZNLmNwcApAQCAtMzExOSw2ICszMTE5LDEx IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGZ1bmN0aW9uVXNlSklUKEpT R2xvYmFsT2JqZWN0KiwgQ2FsbEZyYW1lKikKICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpz Qm9vbGVhbihPcHRpb25zOjp1c2VKSVQoKSkpOwogfQogCitzdGF0aWMgRW5jb2RlZEpTVmFsdWUg SlNDX0hPU1RfQ0FMTCBmdW5jdGlvbklzR2lnYWNhZ2VFbmFibGVkKEpTR2xvYmFsT2JqZWN0Kiwg Q2FsbEZyYW1lKikKK3sKKyAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzQm9vbGVhbihHaWdh Y2FnZTo6aXNFbmFibGVkKCkpKTsKK30KKwogY29uc3RleHByIHVuc2lnbmVkIGpzRG9sbGFyVk1Q cm9wZXJ0eUF0dHJpYnV0ZXMgPSBQcm9wZXJ0eUF0dHJpYnV0ZTo6UmVhZE9ubHkgfCBQcm9wZXJ0 eUF0dHJpYnV0ZTo6RG9udEVudW0gfCBQcm9wZXJ0eUF0dHJpYnV0ZTo6RG9udERlbGV0ZTsKIAog dm9pZCBKU0RvbGxhclZNOjpmaW5pc2hDcmVhdGlvbihWTSYgdm0pCkBAIC0zMjY0LDYgKzMyNjks NyBAQCB2b2lkIEpTRG9sbGFyVk06OmZpbmlzaENyZWF0aW9uKFZNJiB2bSkKIAogICAgIGFkZEZ1 bmN0aW9uKHZtLCAiaXNNZW1vcnlMaW1pdGVkIiwgZnVuY3Rpb25Jc01lbW9yeUxpbWl0ZWQsIDAp OwogICAgIGFkZEZ1bmN0aW9uKHZtLCAidXNlSklUIiwgZnVuY3Rpb25Vc2VKSVQsIDApOworICAg IGFkZEZ1bmN0aW9uKHZtLCAiaXNHaWdhY2FnZUVuYWJsZWQiLCBmdW5jdGlvbklzR2lnYWNhZ2VF bmFibGVkLCAwKTsKIAogICAgIG1fb2JqZWN0RG9pbmdTaWRlRWZmZWN0UHV0V2l0aG91dENvcnJl Y3RTbG90U3RhdHVzU3RydWN0dXJlLnNldCh2bSwgdGhpcywgT2JqZWN0RG9pbmdTaWRlRWZmZWN0 UHV0V2l0aG91dENvcnJlY3RTbG90U3RhdHVzOjpjcmVhdGVTdHJ1Y3R1cmUodm0sIGdsb2JhbE9i amVjdCwganNOdWxsKCkpKTsKIH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBkNTRjYThkNGZjZDc4MTFjNDI5NmRkN2ZmNDZk YmEyMWQ5NzFiOWVjLi44MDQxNDEwZGUxOGE2ZGUxNWUyOTViNzZmYmFlNGM3MzYzMmE1MTZlIDEw MDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMjAtMDktMDEgIFl1c3VrZSBTdXp1a2kgIDx5c3V6dWtp QGFwcGxlLmNvbT4KKworICAgICAgICBTa2lwIGZhc3QvY3NzLWN1c3RvbS1wYWludC9vdXQtb2Yt bWVtb3J5LXdoaWxlLWFkZGluZy13b3JrbGV0LW1vZHVsZS5odG1sIGlmIEdpZ2FjYWdlIGlzIG5v dCBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTYwNDMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY2Mzk0MzY5PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0ZXN0IGlzIHN0cmVzc2lu ZyBHaWdhY2FnZSBFeGhhdXN0aW9uLiBTbyB3aXRob3V0IEdpZ2FjYWdlLCB0aGlzIHRlc3QgaXMg bWVhbmluZ2xlc3MuCisgICAgICAgIEd1YXJkTWFsbG9jIGJlaGF2ZXMgZGlmZmVyZW50bHkgZnJv bSB1c3VhbCBNYWxsb2MgLyBibWFsbG9jOiB3aGljaCBjcmFzaGVzIHdoZW4gZXhoYXVzdGluZyBt ZW1vcnkuCisgICAgICAgIEFzIGEgcmVzdWx0LCB3ZSBvYnNlcnZlIHRlc3QgY3Jhc2ggd2hlbiBH dWFyZE1hbGxvYyBpcyBlbmFibGVkLiBTaW5jZSBvdXIgdGVzdCBoYXJuZXNzIGRvZXMgbm90IHN1 cHBvcnQKKyAgICAgICAgR3VhcmRNYWxsb2MgYW5ub3RhdGlvbiBpbiBUZXN0RXhwZWN0YXRpb25z LCB3ZSBuZWVkZWQgYSB3b3JrYXJvdW5kIHRvIGF2b2lkIHRoaXMgY3Jhc2guCisKKyAgICAgICAg KiBUZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIGZhc3QvY3NzLWN1c3RvbS1wYWludC9vdXQt b2YtbWVtb3J5LXdoaWxlLWFkZGluZy13b3JrbGV0LW1vZHVsZS1leHBlY3RlZC50eHQ6CisgICAg ICAgICogZmFzdC9jc3MtY3VzdG9tLXBhaW50L3NjcmlwdC10ZXN0cy9vdXQtb2YtbWVtb3J5LXdo aWxlLWFkZGluZy13b3JrbGV0LW1vZHVsZS5qczoKKyAgICAgICAgKHZtLmlzR2lnYWNhZ2VFbmFi bGVkLnVzZUFsbE1lbW9yeS50cnkuZ2V0IE9iamVjdCk6CisgICAgICAgICh2bS5pc0dpZ2FjYWdl RW5hYmxlZC51c2VBbGxNZW1vcnkudHJ5LmZvbyk6CisgICAgICAgICh2bS5pc0dpZ2FjYWdlRW5h YmxlZCk6CisgICAgICAgICh1c2VBbGxNZW1vcnkudHJ5LmdldCBPYmplY3QpOiBEZWxldGVkLgor ICAgICAgICAodXNlQWxsTWVtb3J5LnRyeS5mb28pOiBEZWxldGVkLgorICAgICAgICAoKTogRGVs ZXRlZC4KKyAgICAgICAgKGNhdGNoKTogRGVsZXRlZC4KKwogMjAyMC0wOS0wMSAgQWRpdHlhIEtl ZXJ0aGkgIDxha2VlcnRoaUBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBIYW5kbGUgZXZl bnRzIGZvciBkYXRlIGlucHV0cyB3aXRoIGVkaXRhYmxlIGNvbXBvbmVudHMKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRp b25zCmluZGV4IGU4MWNmNzQ2MDUyODczYWZkYTQ0Y2Y4OTc1NWZkZTBiMTdhZTZlYmUuLmYwNGZi ZGRiOTYwZmMwOGI1YTViYzU4OTM2OTkwMTY5MGNkMTFmNTggMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwpA QCAtMTE3MCw4ICsxMTcwLDcgQEAgd2Via2l0Lm9yZy9iLzEzNjA3OCBmYXN0L2JvcmRlcnMvYm9y ZGVyLXBhaW50aW5nLWRhc2hlZC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZQogd2Via2l0Lm9yZy9i LzEzNjA3OCBmYXN0L2JvcmRlcnMvYm9yZGVyLXBhaW50aW5nLWRvdHRlZC5odG1sIFsgSW1hZ2VP bmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTM2MDc4IGZhc3QvYm9yZGVycy9ib3JkZXItcGFp bnRpbmctZG91YmxlLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIAotIyBTa2lwIHRoaXMgYmVj YXVzZSBpdCBpcyB0b28gc2xvdyBvbiBkZWJ1ZyBidWlsZHMuCi1bIERlYnVnIF0gZmFzdC9jc3Mt Y3VzdG9tLXBhaW50L291dC1vZi1tZW1vcnktd2hpbGUtYWRkaW5nLXdvcmtsZXQtbW9kdWxlLmh0 bWwgWyBTa2lwIF0KK2Zhc3QvY3NzLWN1c3RvbS1wYWludC9vdXQtb2YtbWVtb3J5LXdoaWxlLWFk ZGluZy13b3JrbGV0LW1vZHVsZS5odG1sIFsgRHVtcEpTQ29uc29sZUxvZ0luU3RkRXJyIF0KIAog IyBvZmZpY2lhbCBmbGV4Ym94IHRlc3RzCiB3ZWJraXQub3JnL2IvMTQzMjk0IGltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1mbGV4Ym94L2Nzcy1mbGV4Ym94LWhlaWdodC1h bmltYXRpb24tc3RyZXRjaC5odG1sIFsgUGFzcyBJbWFnZU9ubHlGYWlsdXJlIF0KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWN1c3RvbS1wYWludC9vdXQtb2YtbWVtb3J5LXdoaWxl LWFkZGluZy13b3JrbGV0LW1vZHVsZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2Nz cy1jdXN0b20tcGFpbnQvb3V0LW9mLW1lbW9yeS13aGlsZS1hZGRpbmctd29ya2xldC1tb2R1bGUt ZXhwZWN0ZWQudHh0CmluZGV4IDk4MDIyZjBjNDY0ZGJmMDE2MmQ1MzMzNzMyYzIwYmJjNmVkZWY0 NzEuLjhiMTM3ODkxNzkxZmU5NjkyN2FkNzhlNjRiMGFhZDdiZGVkMDhiZGMgMTAwNjQ0Ci0tLSBh L0xheW91dFRlc3RzL2Zhc3QvY3NzLWN1c3RvbS1wYWludC9vdXQtb2YtbWVtb3J5LXdoaWxlLWFk ZGluZy13b3JrbGV0LW1vZHVsZS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9j c3MtY3VzdG9tLXBhaW50L291dC1vZi1tZW1vcnktd2hpbGUtYWRkaW5nLXdvcmtsZXQtbW9kdWxl LWV4cGVjdGVkLnR4dApAQCAtMSwyICsxIEBACi1DT05TT0xFIE1FU1NBR0U6IFJhbmdlRXJyb3I6 IE91dCBvZiBtZW1vcnkKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtY3VzdG9t LXBhaW50L3NjcmlwdC10ZXN0cy9vdXQtb2YtbWVtb3J5LXdoaWxlLWFkZGluZy13b3JrbGV0LW1v ZHVsZS5qcyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWN1c3RvbS1wYWludC9zY3JpcHQtdGVzdHMv b3V0LW9mLW1lbW9yeS13aGlsZS1hZGRpbmctd29ya2xldC1tb2R1bGUuanMKaW5kZXggMDk1NWVk ZmM1ZDE1M2E3ZGFlNzA4ZWI0ODA2ZTMxZmY2OGJjNDcwYy4uMjBkYzgzYTJhNjNkYTcxNmY1MDg3 MmQ1NjY5NGIyYmRkNzZhOGUwNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtY3Vz dG9tLXBhaW50L3NjcmlwdC10ZXN0cy9vdXQtb2YtbWVtb3J5LXdoaWxlLWFkZGluZy13b3JrbGV0 LW1vZHVsZS5qcworKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1jdXN0b20tcGFpbnQvc2NyaXB0 LXRlc3RzL291dC1vZi1tZW1vcnktd2hpbGUtYWRkaW5nLXdvcmtsZXQtbW9kdWxlLmpzCkBAIC0x LDI5ICsxLDMxIEBACi13aW5kb3cuYWxsb2NhdGVkID0gW107Ci1mdW5jdGlvbiB1c2VBbGxNZW1v cnkoKSB7CitpZiAoJHZtLmlzR2lnYWNhZ2VFbmFibGVkKCkpIHsKKyAgICB3aW5kb3cuYWxsb2Nh dGVkID0gW107CisgICAgZnVuY3Rpb24gdXNlQWxsTWVtb3J5KCkgeworICAgICAgICB0cnkgewor ICAgICAgICAgICAgY29uc3QgYSA9IFtdOworICAgICAgICAgICAgYS5fX3Byb3RvX18gPSB7fTsK KyAgICAgICAgICAgIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShhLCAwLCB7IGdldDogZm9vIH0pOwor ICAgICAgICAgICAgT2JqZWN0LmRlZmluZVByb3BlcnR5KGEsIDgwMDAwMDAwLCB7fSk7CisgICAg ICAgICAgICBmdW5jdGlvbiBmb28oKSB7CisgICAgICAgICAgICAgICAgbmV3IFVpbnQ4QXJyYXko YSk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBuZXcgUHJvbWlzZShmb28pLmNhdGNoKCgp ID0+IHt9KTsKKyAgICAgICAgICAgIHdoaWxlKDEpIHsKKyAgICAgICAgICAgICAgICB3aW5kb3cu YWxsb2NhdGVkLnB1c2gobmV3IEFycmF5QnVmZmVyKDEwMDApKTsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgfSBjYXRjaCB7IH0KKyAgICB9CisKKyAgICB2YXIgZXhjZXB0aW9uOworICAgIHVzZUFs bE1lbW9yeSgpOwogICAgIHRyeSB7Ci0gICAgICAgIGNvbnN0IGEgPSBbXTsKLSAgICAgICAgYS5f X3Byb3RvX18gPSB7fTsKLSAgICAgICAgT2JqZWN0LmRlZmluZVByb3BlcnR5KGEsIDAsIHsgZ2V0 OiBmb28gfSk7Ci0gICAgICAgIE9iamVjdC5kZWZpbmVQcm9wZXJ0eShhLCA4MDAwMDAwMCwge30p OwotICAgICAgICBmdW5jdGlvbiBmb28oKSB7Ci0gICAgICAgICAgICBuZXcgVWludDhBcnJheShh KTsKKyAgICAgICAgZm9yIChsZXQgaSA9IDA7IGkgPCA1MDAwOyBpKyspIHsKKyAgICAgICAgICAg IENTUy5wYWludFdvcmtsZXQuYWRkTW9kdWxlKCcnKTsKICAgICAgICAgfQotICAgICAgICBuZXcg UHJvbWlzZShmb28pLmNhdGNoKCgpID0+IHt9KTsKLSAgICAgICAgd2hpbGUoMSkgewotICAgICAg ICAgICAgd2luZG93LmFsbG9jYXRlZC5wdXNoKG5ldyBBcnJheUJ1ZmZlcigxMDAwKSk7Ci0gICAg ICAgIH0KLSAgICB9IGNhdGNoIHsgfQotfQotCi12YXIgZXhjZXB0aW9uOwotdXNlQWxsTWVtb3J5 KCk7Ci10cnkgewotICAgIGZvciAobGV0IGkgPSAwOyBpIDwgNTAwMDsgaSsrKSB7Ci0gICAgICAg IENTUy5wYWludFdvcmtsZXQuYWRkTW9kdWxlKCcnKTsKKyAgICB9IGNhdGNoIChlKSB7CisgICAg ICAgIGV4Y2VwdGlvbiA9IGU7CiAgICAgfQotfSBjYXRjaCAoZSkgewotICAgIGV4Y2VwdGlvbiA9 IGU7Ci19CiAKLWlmIChleGNlcHRpb24gIT0gIlJhbmdlRXJyb3I6IE91dCBvZiBtZW1vcnkiKQot ICAgIHRocm93ICJGQUlMOiBleHBlY3Q6ICdSYW5nZUVycm9yOiBPdXQgb2YgbWVtb3J5JywgYWN0 dWFsOiAnIiArIGV4Y2VwdGlvbiArICInIjsKKyAgICBpZiAoZXhjZXB0aW9uICE9ICJSYW5nZUVy cm9yOiBPdXQgb2YgbWVtb3J5IikKKyAgICAgICAgdGhyb3cgIkZBSUw6IGV4cGVjdDogJ1Jhbmdl RXJyb3I6IE91dCBvZiBtZW1vcnknLCBhY3R1YWw6ICciICsgZXhjZXB0aW9uICsgIiciOworfQo=