216028 2020-08-31 21:06:44 -0700 Fix crash during WebPage constructor 2020-09-02 09:48:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen ap timothy webkit-bug-importer oldest_to_newest 1684375 0 achristensen 2020-08-31 21:06:44 -0700 Fix crash during WebPage constructor 1684376 1 407656 achristensen 2020-08-31 21:07:01 -0700 Created attachment 407656 Patch 1684377 2 achristensen 2020-08-31 21:07:03 -0700 <rdar://problem/67781279> 1684391 3 ews-feeder 2020-08-31 22:51:42 -0700 Found 16 new test failures: fast/css/continuationCrash.html, fast/css/text-overflow-input.html, fast/forms/button-positioned.html, fast/forms/button-sizes.html, fast/forms/input-button-sizes.html, fast/forms/input-disabled-color.html, fast/forms/input-readonly-dimmed.html, fast/forms/input-text-word-wrap.html, fast/forms/listbox-bidi-align.html, fast/forms/select-change-popup-to-listbox.html ... 1684472 4 ews-feeder 2020-09-01 08:42:34 -0700 Committed r266395: <https://trac.webkit.org/changeset/266395> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407656. 1684850 5 407656 ap 2020-09-02 09:48:33 -0700 Comment on attachment 407656 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407656&action=review > Source/WebKit/WebProcess/WebProcess.cpp:1149 > + // This can be called during a WebPage's constructor, so wait until after the constructor returns to touch the WebPage. > + RunLoop::main().dispatch([this] { I can see what issue you are fixing, but delaying on a timer is a super risky approach. What else can happen between now and when the timer fires? This leaves the page in an inconsistent state with no guarantee that it will remain dormant until the state is corrected. 407656 2020-08-31 21:07:01 -0700 2020-09-01 08:42:35 -0700 Patch bug-216028-20200831210700.patch text/plain 1606 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjYzODQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA4LTMxICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNyYXNoIGR1 cmluZyBXZWJQYWdlIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTYwMjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY3NzgxMjc5 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6ZW5z dXJlTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uKToKKwogMjAyMC0wOC0zMSAgU2lodWkgTGl1ICA8 c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWJwYWdlcyBmbGFzaCB3aGVuIHN3aXRj aGluZyBiZXR3ZWVuIHdpbmRvd3MKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ cm9jZXNzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUHJv Y2Vzcy5jcHAJKHJldmlzaW9uIDI2NjM1MykKKysrIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQcm9jZXNzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE0NCw4ICsxMTQ0LDEyIEBAIE5ldHdv cmtQcm9jZXNzQ29ubmVjdGlvbiYgV2ViUHJvY2Vzczo6ZW4KICAgICAgICAgaWYgKCFEb2N1bWVu dDo6YWxsRG9jdW1lbnRzKCkuaXNFbXB0eSgpKQogICAgICAgICAgICAgbV9uZXR3b3JrUHJvY2Vz c0Nvbm5lY3Rpb24tPnNlcnZpY2VXb3JrZXJDb25uZWN0aW9uKCkucmVnaXN0ZXJTZXJ2aWNlV29y a2VyQ2xpZW50cygpOwogI2VuZGlmCi0gICAgICAgIGZvciAoYXV0byYgd2ViUGFnZSA6IG1fcGFn ZU1hcC52YWx1ZXMoKSkKLSAgICAgICAgICAgIHdlYlBhZ2UtPnN5bmNocm9uaXplQ09SU0Rpc2Fi bGluZ1BhdHRlcm5zV2l0aE5ldHdvcmtQcm9jZXNzKCk7CisKKyAgICAgICAgLy8gVGhpcyBjYW4g YmUgY2FsbGVkIGR1cmluZyBhIFdlYlBhZ2UncyBjb25zdHJ1Y3Rvciwgc28gd2FpdCB1bnRpbCBh ZnRlciB0aGUgY29uc3RydWN0b3IgcmV0dXJucyB0byB0b3VjaCB0aGUgV2ViUGFnZS4KKyAgICAg ICAgUnVuTG9vcDo6bWFpbigpLmRpc3BhdGNoKFt0aGlzXSB7CisgICAgICAgICAgICBmb3IgKGF1 dG8mIHdlYlBhZ2UgOiBtX3BhZ2VNYXAudmFsdWVzKCkpCisgICAgICAgICAgICAgICAgd2ViUGFn ZS0+c3luY2hyb25pemVDT1JTRGlzYWJsaW5nUGF0dGVybnNXaXRoTmV0d29ya1Byb2Nlc3MoKTsK KyAgICAgICAgfSk7CiAgICAgfQogICAgIAogICAgIHJldHVybiAqbV9uZXR3b3JrUHJvY2Vzc0Nv bm5lY3Rpb247Cg==