216017 2020-08-31 16:20:56 -0700 <video> element prevents screen from sleeping even after playback finishes 2020-09-01 13:45:44 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez calvaris changseok darin eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1684293 0 cdumez 2020-08-31 16:20:56 -0700 <video> element prevents screen from sleeping even after playback finishes. 1684294 1 cdumez 2020-08-31 16:21:08 -0700 <rdar://problem/66665846> 1684297 2 407634 cdumez 2020-08-31 16:33:25 -0700 Created attachment 407634 Patch 1684304 3 407636 cdumez 2020-08-31 16:42:34 -0700 Created attachment 407636 Patch 1684321 4 407636 darin 2020-08-31 17:53:10 -0700 Comment on attachment 407636 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407636&action=review > Source/WebCore/ChangeLog:14 > + To address the problem, we now call updateSleepDisabling() when This says updateSleepDisabling, which makes logical sense. > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3171 > + rateChanged(); This says rateChanged, which makes less sense. 1684353 5 cdumez 2020-08-31 19:07:17 -0700 (In reply to Darin Adler from comment #4) > Comment on attachment 407636 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407636&action=review > > > Source/WebCore/ChangeLog:14 > > + To address the problem, we now call updateSleepDisabling() when > > This says updateSleepDisabling, which makes logical sense. > > > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:3171 > > + rateChanged(); > > This says rateChanged, which makes less sense. rateChanged() is what Jer recommended I call. This ends up calling HTMLMediaElement::mediaPlayerRateChanged() which calls updateSleepDisabling(). I initially introduced a new delegate just for this but Jer suggested I rely on the pre-existing rateChanged() instead. 1684510 6 jer.noble 2020-09-01 09:43:02 -0700 lgtm. The KVO property which AVFoundation changes does double duty, representing whether the underlying player is playing or paused, but also whether this is due to a network stall or a direct user action. So the confusion is understandable. But sending a "rateChanged()" notification is definitely the correct thing here. 1684533 7 darin 2020-09-01 10:36:42 -0700 (In reply to Jer Noble from comment #6) > The KVO property which AVFoundation changes does double duty, representing > whether the underlying player is playing or paused, but also whether this is > due to a network stall or a direct user action. So the confusion is > understandable. But sending a "rateChanged()" notification is definitely > the correct thing here. WebKit doesn’t have to follow the AVFoundation naming. We could come up with a name other than "rate" for this if we like. 1684575 8 cdumez 2020-09-01 12:27:08 -0700 (In reply to Darin Adler from comment #7) > (In reply to Jer Noble from comment #6) > > The KVO property which AVFoundation changes does double duty, representing > > whether the underlying player is playing or paused, but also whether this is > > due to a network stall or a direct user action. So the confusion is > > understandable. But sending a "rateChanged()" notification is definitely > > the correct thing here. > > WebKit doesn’t have to follow the AVFoundation naming. We could come up with > a name other than "rate" for this if we like. That was my original proposal, something like a new pausedStateChanged(). Jer still preferred we call the existing rateChanged() instead of introducing a new delegate so I will let him comment before landing. 1684591 9 darin 2020-09-01 13:08:13 -0700 We should land this change and debate the naming thing at our leisure separately. 1684594 10 jer.noble 2020-09-01 13:11:33 -0700 (In reply to Chris Dumez from comment #8) > (In reply to Darin Adler from comment #7) > > (In reply to Jer Noble from comment #6) > > > The KVO property which AVFoundation changes does double duty, representing > > > whether the underlying player is playing or paused, but also whether this is > > > due to a network stall or a direct user action. So the confusion is > > > understandable. But sending a "rateChanged()" notification is definitely > > > the correct thing here. > > > > WebKit doesn’t have to follow the AVFoundation naming. We could come up with > > a name other than "rate" for this if we like. > > That was my original proposal, something like a new pausedStateChanged(). > Jer still preferred we call the existing rateChanged() instead of > introducing a new delegate so I will let him comment before landing. We can't change the behavior here without involving all the other ports; the callbacks are part of an abstraction layer used by all the MediaPlayer subclasses, and just adding new behavior in HTMLMediaElement runs the risk of breaking those ports. Adding a new message only for one engine just because the name of one of our underlying framework's properties is inconsistent is risky, both for us with other MediaPlayer subclasses who would have to start calling that new callback, and for other ports. I'd be fine with renaming "rateChanged()" to "pausedChanged()" or "playingChanged()". But that's refactoring work that can happen later, coordinated with other ports, in unison. 1684595 11 jer.noble 2020-09-01 13:12:38 -0700 (In reply to Darin Adler from comment #9) > We should land this change and debate the naming thing at our leisure > separately. Totally. 1684606 12 ews-feeder 2020-09-01 13:45:43 -0700 Committed r266410: <https://trac.webkit.org/changeset/266410> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407636. 407634 2020-08-31 16:33:25 -0700 2020-08-31 16:41:29 -0700 Patch bug-216017-20200831163324.patch text/plain 5381 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ1NzRkZWZjZjAxZTU5 ZDUxNGRkNzYzYjk3M2Q5NjZiYTk0NzJkYy4uNDAyZDc4NjNjYzUxMmFiNzkxYjI0ZDhmODczYjc2 OTI2NDYyZTNkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDIwLTA4LTMxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgPHZpZGVvPiBlbGVtZW50IHBy ZXZlbnRzIHNjcmVlbiBmcm9tIHNsZWVwaW5nIGV2ZW4gYWZ0ZXIgcGxheWJhY2sgZmluaXNoZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjAxNwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjY2NjU4NDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB2aWRlbyBwbGF5YmFjayB3b3VsZCBmaW5p c2ggKGR1ZSB0byByZWFjaGluZyBlbmQgb2YgZmlsZSksIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlh UGxheWVyUmF0ZUNoYW5nZWQoKQorICAgICAgICB3b3VsZCBnZXQgY2FsbGVkLCB3aGljaCB3b3Vs ZCBjYWxsIHVwZGF0ZVNsZWVwRGlzYWJsaW5nKCkuIFRoZSBpZGVhIHdhcyB0aGF0IHVwZGF0ZVNs ZWVwRGlzYWJsaW5nKCkgd291bGQKKyAgICAgICAgZGVzdHJveSB0aGUgU2xlZXBEaXNhYmxlciB0 byBhbGxvdyB0aGUgZGlzcGxheSB0byBzbGVlcCBhZ2Fpbi4gSG93ZXZlciwgdXBkYXRlU2xlZXBE aXNhYmxpbmcoKSB3b3VsZCBub3QKKyAgICAgICAgZGVzdHJveSB0aGUgU2xlZXBEaXNhYmxlciBi ZWNhdXNlIGl0IGRvZXMgbm90IGtub3cgeWV0IHRoYXQgdGhlIG1lZGlhIGhhcyBiZWVuIHBhdXNl ZC4gV2Ugb25seSBsZWFybmVkCisgICAgICAgIGFib3V0IGl0IGxhdGVyIG9uLCB3aGVuIE1lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnRpbWVDb250cm9sU3RhdHVzRGlkQ2hhbmdl KCkgZ2V0cyBjYWxsZWQuCisgICAgICAgIFRvIGFkZHJlc3MgdGhlIHByb2JsZW0sIHdlIG5vdyBj YWxsIHVwZGF0ZVNsZWVwRGlzYWJsaW5nKCkgd2hlbgorICAgICAgICBNZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDOjp0aW1lQ29udHJvbFN0YXR1c0RpZENoYW5nZSgpIGlzIGNhbGxl ZCB0b28uCisKKyAgICAgICAgKiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJUaW1lQ29udHJvbFN0YXR1c0No YW5nZWQpOgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UGxheWVyOjp0aW1lQ29udHJvbFN0YXR1c0NoYW5nZWQpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL01lZGlhUGxheWVyLmg6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllckNsaWVu dDo6bWVkaWFQbGF5ZXJUaW1lQ29udHJvbFN0YXR1c0NoYW5nZWQpOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRh dGlvbk9iakMubW06CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5k YXRpb25PYmpDOjp0aW1lQ29udHJvbFN0YXR1c0RpZENoYW5nZSk6CisKIDIwMjAtMDgtMzEgIEph bWVzIERhcnBpbmlhbiAgPGpkYXJwaW5pYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEltcGxl bWVudCBXRUJHTF9jb21wcmVzc2VkX3RleHR1cmVfczN0Y19zcmdiIGV4dGVuc2lvbgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKaW5kZXggYzljYjE0ZThmNWYyMDdlOGUw NGFmMTE5MTQ3OTczMzgxMGRlZTA0Ni4uYzU1ZjVmNGUxNzJjOGM3NDhlNjZiZTViMTE2M2YyNjQy NzczMTUyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCkBAIC02 NzM3LDYgKzY3MzcsMTEgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50Ojp1cGRhdGVTbGVlcERpc2Fi bGluZygpCiAgICAgICAgIG1fcGxheWVyLT5zZXRTaG91bGREaXNhYmxlU2xlZXAoc2hvdWxkRGlz YWJsZVNsZWVwID09IFNsZWVwVHlwZTo6RGlzcGxheSk7CiB9CiAKK3ZvaWQgSFRNTE1lZGlhRWxl bWVudDo6bWVkaWFQbGF5ZXJUaW1lQ29udHJvbFN0YXR1c0NoYW5nZWQoKQoreworICAgIHVwZGF0 ZVNsZWVwRGlzYWJsaW5nKCk7Cit9CisKICNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQogc3RhdGlj IGlubGluZSBib29sIGlzUmVtb3RlTWVkaWFTdHJlYW1WaWRlb1RyYWNrKFJlZlB0cjxNZWRpYVN0 cmVhbVRyYWNrPiYgaXRlbSkKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TE1lZGlhRWxlbWVudC5oIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgK aW5kZXggNjk1ZWE3MGVlNzc2ZDRkNTg5Y2M0MDViOTk0NDM1OTRiNmNlNTRhOS4uNjE5NTBmY2M0 ZmE3NGIyYjliY2YwMzFmMGY0Yzk4NDIzODM1ODBlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1M TWVkaWFFbGVtZW50LmgKQEAgLTY2Myw2ICs2NjMsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgbWVk aWFQbGF5ZXJSZW5kZXJpbmdNb2RlQ2hhbmdlZCgpIGZpbmFsOwogICAgIGJvb2wgbWVkaWFQbGF5 ZXJBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxlZCgpIGZpbmFsOwogICAgIHZvaWQgbWVkaWFQ bGF5ZXJFbmdpbmVVcGRhdGVkKCkgZmluYWw7CisgICAgdm9pZCBtZWRpYVBsYXllclRpbWVDb250 cm9sU3RhdHVzQ2hhbmdlZCgpIGZpbmFsOwogCiAgICAgdm9pZCBzY2hlZHVsZU1lZGlhRW5naW5l V2FzVXBkYXRlZCgpOwogICAgIHZvaWQgbWVkaWFFbmdpbmVXYXNVcGRhdGVkKCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKaW5kZXggNTNj YTdjNzRhMjZiY2VhN2E5MjhiZTJiZTUxMjMxYTM3NDU5OGE1Mi4uNWY1NDRlNDdmMWY1ODFhODc0 YjQ4ZjMyZGY0NmU2NGVjZTlkYjdhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcApAQCAtMTI1Myw2ICsxMjUzLDExIEBAIHZvaWQgTWVk aWFQbGF5ZXI6OnNpemVDaGFuZ2VkKCkKICAgICBjbGllbnQoKS5tZWRpYVBsYXllclNpemVDaGFu Z2VkKCk7CiB9CiAKK3ZvaWQgTWVkaWFQbGF5ZXI6OnRpbWVDb250cm9sU3RhdHVzQ2hhbmdlZCgp Cit7CisgICAgY2xpZW50KCkubWVkaWFQbGF5ZXJUaW1lQ29udHJvbFN0YXR1c0NoYW5nZWQoKTsK K30KKwogdm9pZCBNZWRpYVBsYXllcjo6cmVwYWludCgpCiB7CiAgICAgY2xpZW50KCkubWVkaWFQ bGF5ZXJSZXBhaW50KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9NZWRpYVBsYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVk aWFQbGF5ZXIuaAppbmRleCBlYTI1N2YxMmFjZjA5ZTBiYmRmYjMyOWIxMTUzY2NlNTFhY2FmNGYz Li5jZGQ1NDYwNTMyZjNkOGVhNDg5MTIyN2NjMmU2N2JiNzI1NTJhMzY5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmgKQEAgLTE2Myw2ICsxNjMs OSBAQCBwdWJsaWM6CiAgICAgLy8gdGhlIHBsYXliYWNrIHJhdGUgaGFzIGNoYW5nZWQKICAgICB2 aXJ0dWFsIHZvaWQgbWVkaWFQbGF5ZXJSYXRlQ2hhbmdlZCgpIHsgfQogCisgICAgLy8gVGhlIHRp bWUgY29udHJvbCBzdGF0dXMgaGFzIGNoYW5nZWQuCisgICAgdmlydHVhbCB2b2lkIG1lZGlhUGxh eWVyVGltZUNvbnRyb2xTdGF0dXNDaGFuZ2VkKCkgeyB9CisKICAgICAvLyB0aGUgcGxheS9wYXVz ZSBzdGF0dXMgY2hhbmdlZAogICAgIHZpcnR1YWwgdm9pZCBtZWRpYVBsYXllclBsYXliYWNrU3Rh dGVDaGFuZ2VkKCkgeyB9CiAKQEAgLTQ1Nyw2ICs0NjAsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBk dXJhdGlvbkNoYW5nZWQoKTsKICAgICB2b2lkIGZpcnN0VmlkZW9GcmFtZUF2YWlsYWJsZSgpOwog ICAgIHZvaWQgY2hhcmFjdGVyaXN0aWNDaGFuZ2VkKCk7CisgICAgdm9pZCB0aW1lQ29udHJvbFN0 YXR1c0NoYW5nZWQoKTsKIAogICAgIHZvaWQgcmVwYWludCgpOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXll clByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2Jq Qy5tbQppbmRleCBjZGMxNWM3Njc0MzM2MmJlNGE4MTVlMzliOWYwNGNjZGVmY2U3ZTNhLi5jZjhk ZWQ3ZmRlYTcyMWYyMjRiNTc1NmRlOTA1ZTg3NzI0MjJmYmUxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclBy aXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9i akMubW0KQEAgLTMxNjgsNiArMzE2OCw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3Vu ZGF0aW9uT2JqQzo6dGltZUNvbnRyb2xTdGF0dXNEaWRDaGFuZ2UoaW50IHRpbWVDb250CiAgICAg ICAgIHJldHVybjsKIAogICAgIG1fY2FjaGVkVGltZUNvbnRyb2xTdGF0dXMgPSB0aW1lQ29udHJv bFN0YXR1czsKKyAgICBwbGF5ZXIoKS0+dGltZUNvbnRyb2xTdGF0dXNDaGFuZ2VkKCk7CiAKICNp ZiBFTkFCTEUoV0lSRUxFU1NfUExBWUJBQ0tfVEFSR0VUKQogICAgIGlmICghaXNDdXJyZW50UGxh eWJhY2tUYXJnZXRXaXJlbGVzcygpKQo= 407636 2020-08-31 16:42:34 -0700 2020-09-01 13:45:44 -0700 Patch bug-216017-20200831164233.patch text/plain 2315 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjQ1NzRkZWZjZjAxZTU5 ZDUxNGRkNzYzYjk3M2Q5NjZiYTk0NzJkYy4uY2YzMTNkYWZlOTk4ZjNjMzUwYTEwOGU2MTcyOTE3 YmUxN2NmNDlkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA4LTMxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgPHZpZGVvPiBlbGVtZW50IHBy ZXZlbnRzIHNjcmVlbiBmcm9tIHNsZWVwaW5nIGV2ZW4gYWZ0ZXIgcGxheWJhY2sgZmluaXNoZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjAxNwor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjY2NjU4NDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB2aWRlbyBwbGF5YmFjayB3b3VsZCBmaW5p c2ggKGR1ZSB0byByZWFjaGluZyBlbmQgb2YgZmlsZSksIEhUTUxNZWRpYUVsZW1lbnQ6Om1lZGlh UGxheWVyUmF0ZUNoYW5nZWQoKQorICAgICAgICB3b3VsZCBnZXQgY2FsbGVkLCB3aGljaCB3b3Vs ZCBjYWxsIHVwZGF0ZVNsZWVwRGlzYWJsaW5nKCkuIFRoZSBpZGVhIHdhcyB0aGF0IHVwZGF0ZVNs ZWVwRGlzYWJsaW5nKCkgd291bGQKKyAgICAgICAgZGVzdHJveSB0aGUgU2xlZXBEaXNhYmxlciB0 byBhbGxvdyB0aGUgZGlzcGxheSB0byBzbGVlcCBhZ2Fpbi4gSG93ZXZlciwgdXBkYXRlU2xlZXBE aXNhYmxpbmcoKSB3b3VsZCBub3QKKyAgICAgICAgZGVzdHJveSB0aGUgU2xlZXBEaXNhYmxlciBi ZWNhdXNlIGl0IGRvZXMgbm90IGtub3cgeWV0IHRoYXQgdGhlIG1lZGlhIGhhcyBiZWVuIHBhdXNl ZC4gV2Ugb25seSBsZWFybmVkCisgICAgICAgIGFib3V0IGl0IGxhdGVyIG9uLCB3aGVuIE1lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakM6OnRpbWVDb250cm9sU3RhdHVzRGlkQ2hhbmdl KCkgZ2V0cyBjYWxsZWQuCisgICAgICAgIFRvIGFkZHJlc3MgdGhlIHByb2JsZW0sIHdlIG5vdyBj YWxsIHVwZGF0ZVNsZWVwRGlzYWJsaW5nKCkgd2hlbgorICAgICAgICBNZWRpYVBsYXllclByaXZh dGVBVkZvdW5kYXRpb25PYmpDOjp0aW1lQ29udHJvbFN0YXR1c0RpZENoYW5nZSgpIGlzIGNhbGxl ZCB0b28uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9N ZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tOgorICAgICAgICAoV2ViQ29yZTo6 TWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQzo6dGltZUNvbnRyb2xTdGF0dXNEaWRD aGFuZ2UpOgorCiAyMDIwLTA4LTMxICBKYW1lcyBEYXJwaW5pYW4gIDxqZGFycGluaWFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBJbXBsZW1lbnQgV0VCR0xfY29tcHJlc3NlZF90ZXh0dXJlX3Mz dGNfc3JnYiBleHRlbnNpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9i akMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2Jq Yy9NZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDLm1tCmluZGV4IGNkYzE1Yzc2NzQz MzYyYmU0YTgxNWUzOWI5ZjA0Y2NkZWZjZTdlM2EuLmYxNjU4MjRiOGQxM2NiN2UxM2JkMWM3Nzk2 NmYxNTQzYzk2MjBiNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbk9iakMu bW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29i amMvTWVkaWFQbGF5ZXJQcml2YXRlQVZGb3VuZGF0aW9uT2JqQy5tbQpAQCAtMzE2OCw2ICszMTY4 LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb25PYmpDOjp0aW1lQ29udHJv bFN0YXR1c0RpZENoYW5nZShpbnQgdGltZUNvbnQKICAgICAgICAgcmV0dXJuOwogCiAgICAgbV9j YWNoZWRUaW1lQ29udHJvbFN0YXR1cyA9IHRpbWVDb250cm9sU3RhdHVzOworICAgIHJhdGVDaGFu Z2VkKCk7CiAKICNpZiBFTkFCTEUoV0lSRUxFU1NfUExBWUJBQ0tfVEFSR0VUKQogICAgIGlmICgh aXNDdXJyZW50UGxheWJhY2tUYXJnZXRXaXJlbGVzcygpKQo=