216015 2020-08-31 14:48:13 -0700 Missing exception check while handling the onbeforeunload event. 2020-08-31 19:46:46 -0700 1 1 1 Unclassified WebKit WebCore JavaScript WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam saam webkit-bug-importer oldest_to_newest 1684261 0 mark.lam 2020-08-31 14:48:13 -0700 <rdar://problem/66324934> 1684272 1 407629 mark.lam 2020-08-31 15:06:14 -0700 Created attachment 407629 proposed patch. 1684357 2 407629 mark.lam 2020-08-31 19:42:31 -0700 Comment on attachment 407629 proposed patch. Thanks for the review. Landing now. 1684358 3 ews-feeder 2020-08-31 19:45:13 -0700 Committed r266383: <https://trac.webkit.org/changeset/266383> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407629. 1684359 4 webkit-bug-importer 2020-08-31 19:46:03 -0700 <rdar://problem/68115033> 1684360 5 mark.lam 2020-08-31 19:46:46 -0700 <rdar://problem/66324934> 407629 2020-08-31 15:06:14 -0700 2020-08-31 19:45:13 -0700 proposed patch. bug-216015.patch text/plain 5319 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NjM2OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA4LTMxICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBNaXNzaW5nIGV4Y2VwdGlvbiBjaGVj ayB3aGlsZSBoYW5kbGluZyB0aGUgb25iZWZvcmV1bmxvYWQgZXZlbnQuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTYwMTUKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzY2MzI0OTM0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRlc3Q6IGpzL2RvbS9taXNzaW5nLWV4Y2VwdGlvbi1jaGVjay13aGlsZS1o YW5kbGluZy1vbmJlZm9yZXVubG9hZC5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0V2 ZW50TGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNFdmVudExpc3RlbmVyOjpoYW5k bGVFdmVudCk6CisKIDIwMjAtMDgtMzEgIEphbWVzIERhcnBpbmlhbiAgPGpkYXJwaW5pYW5AY2hy b21pdW0ub3JnPgogCiAgICAgICAgIEltcGxlbWVudCBXRUJHTF9jb21wcmVzc2VkX3RleHR1cmVf czN0Y19zcmdiIGV4dGVuc2lvbgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNF dmVudExpc3RlbmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9KU0V2ZW50TGlzdGVuZXIuY3BwCShyZXZpc2lvbiAyNjYzNTkpCisrKyBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0V2ZW50TGlzdGVuZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODIs MTggKzE4MiwyNCBAQCB2b2lkIEpTRXZlbnRMaXN0ZW5lcjo6aGFuZGxlRXZlbnQoU2NyaXB0CiAK ICAgICBnbG9iYWxPYmplY3QtPnNldEN1cnJlbnRFdmVudChzYXZlZEV2ZW50KTsKIAotICAgIGlm IChpczxXb3JrZXJHbG9iYWxTY29wZT4oc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkpIHsKLSAgICAg ICAgYXV0byYgc2NyaXB0Q29udHJvbGxlciA9ICpkb3duY2FzdDxXb3JrZXJHbG9iYWxTY29wZT4o c2NyaXB0RXhlY3V0aW9uQ29udGV4dCkuc2NyaXB0KCk7Ci0gICAgICAgIGJvb2wgdGVybWluYXRv ckNhdXNlZEV4Y2VwdGlvbiA9IChzY29wZS5leGNlcHRpb24oKSAmJiBpc1Rlcm1pbmF0ZWRFeGVj dXRpb25FeGNlcHRpb24odm0sIHNjb3BlLmV4Y2VwdGlvbigpKSk7Ci0gICAgICAgIGlmICh0ZXJt aW5hdG9yQ2F1c2VkRXhjZXB0aW9uIHx8IHNjcmlwdENvbnRyb2xsZXIuaXNUZXJtaW5hdGluZ0V4 ZWN1dGlvbigpKQotICAgICAgICAgICAgc2NyaXB0Q29udHJvbGxlci5mb3JiaWRFeGVjdXRpb24o KTsKLSAgICB9CisgICAgYXV0byBoYW5kbGVFeGNlcHRpb25JZk5lZWRlZCA9IFsmXSAoKSAtPiBi b29sIHsKKyAgICAgICAgaWYgKGlzPFdvcmtlckdsb2JhbFNjb3BlPihzY3JpcHRFeGVjdXRpb25D b250ZXh0KSkgeworICAgICAgICAgICAgYXV0byYgc2NyaXB0Q29udHJvbGxlciA9ICpkb3duY2Fz dDxXb3JrZXJHbG9iYWxTY29wZT4oc2NyaXB0RXhlY3V0aW9uQ29udGV4dCkuc2NyaXB0KCk7Cisg ICAgICAgICAgICBib29sIHRlcm1pbmF0b3JDYXVzZWRFeGNlcHRpb24gPSAoc2NvcGUuZXhjZXB0 aW9uKCkgJiYgaXNUZXJtaW5hdGVkRXhlY3V0aW9uRXhjZXB0aW9uKHZtLCBzY29wZS5leGNlcHRp b24oKSkpOworICAgICAgICAgICAgaWYgKHRlcm1pbmF0b3JDYXVzZWRFeGNlcHRpb24gfHwgc2Ny aXB0Q29udHJvbGxlci5pc1Rlcm1pbmF0aW5nRXhlY3V0aW9uKCkpCisgICAgICAgICAgICAgICAg c2NyaXB0Q29udHJvbGxlci5mb3JiaWRFeGVjdXRpb24oKTsKKyAgICAgICAgfQorCisgICAgICAg IGlmIChleGNlcHRpb24pIHsKKyAgICAgICAgICAgIGV2ZW50LnRhcmdldCgpLT51bmNhdWdodEV4 Y2VwdGlvbkluRXZlbnRIYW5kbGVyKCk7CisgICAgICAgICAgICByZXBvcnRFeGNlcHRpb24obGV4 aWNhbEdsb2JhbE9iamVjdCwgZXhjZXB0aW9uKTsKKyAgICAgICAgICAgIHJldHVybiB0cnVlOwor ICAgICAgICB9CisgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9OwogCi0gICAgaWYgKGV4Y2Vw dGlvbikgewotICAgICAgICBldmVudC50YXJnZXQoKS0+dW5jYXVnaHRFeGNlcHRpb25JbkV2ZW50 SGFuZGxlcigpOwotICAgICAgICByZXBvcnRFeGNlcHRpb24obGV4aWNhbEdsb2JhbE9iamVjdCwg ZXhjZXB0aW9uKTsKKyAgICBpZiAoaGFuZGxlRXhjZXB0aW9uSWZOZWVkZWQoKSkKICAgICAgICAg cmV0dXJuOwotICAgIH0KIAogICAgIGlmICghbV9pc0F0dHJpYnV0ZSkgewogICAgICAgICAvLyBU aGlzIGlzIGFuIEV2ZW50TGlzdGVuZXIgYW5kIHRoZXJlIGlzIHRoZXJlZm9yZSBubyBuZWVkIGZv ciBhbnkgcmV0dXJuIHZhbHVlIGhhbmRsaW5nLgpAQCAtMjA0LDggKzIxMCwxNSBAQCB2b2lkIEpT RXZlbnRMaXN0ZW5lcjo6aGFuZGxlRXZlbnQoU2NyaXB0CiAKICAgICBpZiAoZXZlbnQudHlwZSgp ID09IGV2ZW50TmFtZXMoKS5iZWZvcmV1bmxvYWRFdmVudCkgewogICAgICAgICAvLyBUaGlzIGlz IGEgT25CZWZvcmVVbmxvYWRFdmVudEhhbmRsZXIsIGFuZCB0aGVyZWZvcmUgdGhlIHJldHVybiB2 YWx1ZSBtdXN0IGJlIGNvZXJjZWQgaW50byBhIFN0cmluZy4KLSAgICAgICAgaWYgKGlzPEJlZm9y ZVVubG9hZEV2ZW50PihldmVudCkpCi0gICAgICAgICAgICBoYW5kbGVCZWZvcmVVbmxvYWRFdmVu dFJldHVyblZhbHVlKGRvd25jYXN0PEJlZm9yZVVubG9hZEV2ZW50PihldmVudCksIGNvbnZlcnQ8 SURMTnVsbGFibGU8SURMRE9NU3RyaW5nPj4oKmxleGljYWxHbG9iYWxPYmplY3QsIHJldHZhbCkp OworICAgICAgICBpZiAoaXM8QmVmb3JlVW5sb2FkRXZlbnQ+KGV2ZW50KSkgeworICAgICAgICAg ICAgU3RyaW5nIHJlc3VsdFN0ciA9IGNvbnZlcnQ8SURMTnVsbGFibGU8SURMRE9NU3RyaW5nPj4o KmxleGljYWxHbG9iYWxPYmplY3QsIHJldHZhbCk7CisgICAgICAgICAgICBpZiAoVU5MSUtFTFko c2NvcGUuZXhjZXB0aW9uKCkpKSB7CisgICAgICAgICAgICAgICAgZXhjZXB0aW9uID0gc2NvcGUu ZXhjZXB0aW9uKCk7CisgICAgICAgICAgICAgICAgaWYgKGhhbmRsZUV4Y2VwdGlvbklmTmVlZGVk KCkpCisgICAgICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKyAgICAgICAg ICAgIGhhbmRsZUJlZm9yZVVubG9hZEV2ZW50UmV0dXJuVmFsdWUoZG93bmNhc3Q8QmVmb3JlVW5s b2FkRXZlbnQ+KGV2ZW50KSwgcmVzdWx0U3RyKTsKKyAgICAgICAgfQogICAgICAgICByZXR1cm47 CiAgICAgfQogCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjYzNTkpCisrKyBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wOC0zMSAgTWFyayBM YW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgTWlzc2luZyBleGNlcHRpb24gY2hl Y2sgd2hpbGUgaGFuZGxpbmcgdGhlIG9uYmVmb3JldW5sb2FkIGV2ZW50LgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2MDE1CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS82NjMyNDkzND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGpzL2RvbS9taXNzaW5nLWV4Y2VwdGlvbi1jaGVjay13aGlsZS1oYW5k bGluZy1vbmJlZm9yZXVubG9hZC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGpzL2Rv bS9taXNzaW5nLWV4Y2VwdGlvbi1jaGVjay13aGlsZS1oYW5kbGluZy1vbmJlZm9yZXVubG9hZC5o dG1sOiBBZGRlZC4KKwogMjAyMC0wOC0zMSAgSGVjdG9yIExvcGV6ICA8aGVjdG9yX2lfbG9wZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjY2MzUwLgpJbmRl eDogTGF5b3V0VGVzdHMvanMvZG9tL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLXdoaWxlLWhhbmRs aW5nLW9uYmVmb3JldW5sb2FkLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9qcy9kb20vbWlzc2luZy1leGNlcHRpb24tY2hlY2std2hpbGUtaGFuZGxpbmctb25iZWZvcmV1 bmxvYWQtZXhwZWN0ZWQudHh0CShub25leGlzdGVudCkKKysrIExheW91dFRlc3RzL2pzL2RvbS9t aXNzaW5nLWV4Y2VwdGlvbi1jaGVjay13aGlsZS1oYW5kbGluZy1vbmJlZm9yZXVubG9hZC1leHBl Y3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw0IEBACitQQVNTIHN1Y2Nlc3NmdWxs eVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvanMv ZG9tL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLXdoaWxlLWhhbmRsaW5nLW9uYmVmb3JldW5sb2Fk Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvanMvZG9tL21pc3NpbmctZXhjZXB0aW9u LWNoZWNrLXdoaWxlLWhhbmRsaW5nLW9uYmVmb3JldW5sb2FkLmh0bWwJKG5vbmV4aXN0ZW50KQor KysgTGF5b3V0VGVzdHMvanMvZG9tL21pc3NpbmctZXhjZXB0aW9uLWNoZWNrLXdoaWxlLWhhbmRs aW5nLW9uYmVmb3JldW5sb2FkLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMiBAQAor PCFET0NUWVBFIGh0bWw+PCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBqc2NPcHRpb25zPS0tdmFs aWRhdGVFeGNlcHRpb25DaGVja3M9dHJ1ZSBdIC0tPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQg c3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgor PGJvZHk+Cis8c2NyaXB0PgorICAgIG9uYmVmb3JldW5sb2FkID0gaXNOYU47Cis8L3NjcmlwdD4K KzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4K KzwvYm9keT4KKzwvaHRtbD4K