216011 2020-08-31 13:28:41 -0700 Avoid computing metadata for idempotent text autosizing on macOS 2020-08-31 16:35:16 -0700 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh darin mmaxfield webkit-bug-importer oldest_to_newest 1684230 0 wenson_hsieh 2020-08-31 13:28:41 -0700 ...i.e., there’s no use in calling into Adjuster::adjustForTextAutosizing if idempotent text autosizing is not enabled. 1684255 1 407627 wenson_hsieh 2020-08-31 14:27:42 -0700 Created attachment 407627 Patch 1684292 2 407627 wenson_hsieh 2020-08-31 16:20:05 -0700 Comment on attachment 407627 Patch Thanks for the review! 1684299 3 ews-feeder 2020-08-31 16:34:13 -0700 Committed r266375: <https://trac.webkit.org/changeset/266375> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407627. 1684300 4 webkit-bug-importer 2020-08-31 16:35:16 -0700 <rdar://problem/68106041> 407627 2020-08-31 14:27:42 -0700 2020-08-31 16:34:14 -0700 Patch bug-216011-20200831142741.patch text/plain 2048 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhkZjUxNDhkZTg1OWI2 ZjAyNDhmN2M3NDc0NjE0ZmYxNjVlNjdmMS4uMDA1MTJhMDAxOWI0MmIxMTRlMDRmNWU3OGM5MjJm ODZiN2VlMTE1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA4LTMxICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGNvbXB1 dGluZyBtZXRhZGF0YSBmb3IgaWRlbXBvdGVudCB0ZXh0IGF1dG9zaXppbmcgb24gbWFjT1MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjAxMQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEF2b2lkcyBhbiB1 bm5lY2Vzc2FyeSBjYWxsIHRvIGBhZGp1c3RGb3JUZXh0QXV0b3NpemluZ2AgZHVyaW5nIHN0eWxl IHJlc29sdXRpb24gb24gbWFjT1MsIHdoZXJlIGlkZW1wb3RlbnQgdGV4dAorICAgICAgICBhdXRv c2l6aW5nIGlzIGRpc2FibGVkLiBUaGlzIGZ1bmN0aW9uIGNhbGwgcG9wdWxhdGVzIHRoZSBgQXV0 b3NpemVTdGF0dXNgIGZpZWxkcyBvbiBgUmVuZGVyU3R5bGVgIHRoYXQgYXJlIHVzZWQKKyAgICAg ICAgYnkgdGhlIGlkZW1wb3RlbnQgdGV4dCBhdXRvc2l6aW5nIGhldXJpc3RpYy4gVGhpcyBmdW5j dGlvbiBjYWxsIGFwcGVhcnMgY29uc2lzdGVudGx5IGluIHRyYWNlcyB0YWtlbiB3aGlsZQorICAg ICAgICBydW5uaW5nIHRoZSBNdWx0aXBseSBzdWJ0ZXN0IG9mIE1vdGlvbk1hcmssIGlmIG9ubHkg Zm9yIGEgcmVsYXRpdmVseSBzbWFsbCBudW1iZXIgb2Ygc2FtcGxlcy4gV2hpbGUKKyAgICAgICAg YEF1dG9zaXplU3RhdHVzOjpjb21wdXRlU3RhdHVzYCBpcyBkZXNpZ25lZCB0byBiZSB2ZXJ5IGNo ZWFwLCBpdCBlbmRzIHVwIGJlaW5nIGNhbGxlZCBhcm91bmQgMS42IG1pbGxpb24gdGltZXMKKyAg ICAgICAgb3ZlciB0aGUgY291cnNlIG9mIHRoZSBzdWJ0ZXN0LgorCisgICAgICAgICogc3R5bGUv U3R5bGVBZGp1c3Rlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZTo6QWRqdXN0ZXI6OmFk anVzdCBjb25zdCk6CisKIDIwMjAtMDgtMzEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBh cHBsZS5jb20+CiAKICAgICAgICAgT3B0aW1pemUgdGhlIGltcGxlbWVudGF0aW9uIG9mIFRyYW5z Zm9ybWF0aW9uTWF0cml4Ojpyb3RhdGUoZG91YmxlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvc3R5bGUvU3R5bGVBZGp1c3Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUFk anVzdGVyLmNwcAppbmRleCBkZWVhYmI1Yzc3OGQ5OTgwYjk2ODI4MGI1MGM4Zjg5Njk0NDZjMTIw Li41ZGFiYjRkMzUwY2NlMWM1NmRlYTY5YWQ4M2U3M2Y5NTc0NDQ2ZTk0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9zdHlsZS9TdHlsZUFkanVzdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9zdHlsZS9TdHlsZUFkanVzdGVyLmNwcApAQCAtNDkwLDcgKzQ5MCw3IEBAIHZvaWQgQWRqdXN0 ZXI6OmFkanVzdChSZW5kZXJTdHlsZSYgc3R5bGUsIGNvbnN0IFJlbmRlclN0eWxlKiB1c2VyQWdl bnRBcHBlYXJhbmNlCiAgICAgICAgIHN0eWxlLnNldEV2ZW50TGlzdGVuZXJSZWdpb25UeXBlcyhj b21wdXRlRXZlbnRMaXN0ZW5lclJlZ2lvblR5cGVzKCptX2VsZW1lbnQsIG1fcGFyZW50U3R5bGUu ZXZlbnRMaXN0ZW5lclJlZ2lvblR5cGVzKCkpKTsKIAogI2lmIEVOQUJMRShURVhUX0FVVE9TSVpJ TkcpCi0gICAgaWYgKG1fZWxlbWVudCkKKyAgICBpZiAobV9lbGVtZW50ICYmIG1fZG9jdW1lbnQu c2V0dGluZ3MoKS50ZXh0QXV0b3NpemluZ1VzZXNJZGVtcG90ZW50TW9kZSgpKQogICAgICAgICBh ZGp1c3RGb3JUZXh0QXV0b3NpemluZyhzdHlsZSwgKm1fZWxlbWVudCk7CiAjZW5kaWYKIAo=