215994 2020-08-30 16:26:02 -0700 Optimize the implementation of TransformationMatrix::rotate(double) 2020-08-31 08:16:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh koivisto simon.fraser thorton webkit-bug-importer oldest_to_newest 1684051 0 wenson_hsieh 2020-08-30 16:26:02 -0700 TransformationMatrix::rotate(angle) currently just calls TransformationMatrix::rotate3d(0, 0, 1, angle), which has a fast path for the case where we're rotating about the z-axis. However, we should be able to make this *slightly* faster by omitting the hypotenuse computation, several floating point comparisons, and several assignments. 1684052 1 407580 wenson_hsieh 2020-08-30 16:37:21 -0700 Created attachment 407580 For EWS 1684069 2 407580 thorton 2020-08-30 18:44:12 -0700 Comment on attachment 407580 For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=407580&action=review > Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:905 > + multiply({ cosZ, sinZ, -sinZ, cosZ, 0, 0 }); I assume something extends this with the 1s in the diagonals to preserve the other columns? 1684077 3 407580 wenson_hsieh 2020-08-30 21:14:10 -0700 Comment on attachment 407580 For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=407580&action=review >> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:905 >> + multiply({ cosZ, sinZ, -sinZ, cosZ, 0, 0 }); > > I assume something extends this with the 1s in the diagonals to preserve the other columns? Indeed — this uses the a, b, c, d, e, f constructor for TransformationMatrix, which ensures that the last two values along the diagonal are 1: constexpr TransformationMatrix(double a, double b, double c, double d, double e, double f) : m_matrix { { a, b, 0, 0 }, { c, d, 0, 0 }, { 0, 0, 1, 0 }, { e, f, 0, 1 }, } { } 1684129 4 ews-feeder 2020-08-31 08:15:04 -0700 Committed r266353: <https://trac.webkit.org/changeset/266353> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407580. 1684131 5 webkit-bug-importer 2020-08-31 08:16:19 -0700 <rdar://problem/68076663> 407580 2020-08-30 16:37:21 -0700 2020-08-31 08:15:06 -0700 For EWS bug-215994-20200830163720.patch text/plain 4437 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MzI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWY2NTQxYmJiMmQxZGU0 MzFkMDM4MjYwNzVmZWNmZjMxNzVhYWQ5Ny4uNjMyMTg3MjBjNTlkMmZlNzMyNWI2NDk4ODI2ODg5 MjA4MDk4YjljNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDIwLTA4LTMwICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIE9wdGltaXplIHRo ZSBpbXBsZW1lbnRhdGlvbiBvZiBUcmFuc2Zvcm1hdGlvbk1hdHJpeDo6cm90YXRlKGRvdWJsZSkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTk5NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRyYW5zZm9y bWF0aW9uTWF0cml4Ojpyb3RhdGUoYW5nbGUpIGN1cnJlbnRseSBqdXN0IGNhbGxzIFRyYW5zZm9y bWF0aW9uTWF0cml4Ojpyb3RhdGUzZCgwLCAwLCAxLCBhbmdsZSksIHdoaWNoCisgICAgICAgIGhh cyBhIGZhc3QgcGF0aCBmb3IgdGhlIGNhc2Ugd2hlcmUgd2UncmUgcm90YXRpbmcgYWJvdXQgdGhl IHotYXhpcy4gSG93ZXZlciwgd2UgY2FuIG1ha2UgdGhpcyAqc2xpZ2h0bHkqIGZhc3RlcgorICAg ICAgICBieSBvbWl0dGluZyB0aGUgaHlwb3RlbnVzZSBjb21wdXRhdGlvbiwgc2V2ZXJhbCBmbG9h dGluZyBwb2ludCBjb21wYXJpc29ucywgYW5kIHNldmVyYWwgYXNzaWdubWVudHMgaW4gdGhpcyBj YXNlCisgICAgICAgIGJlY2F1c2Ugd2UgYWxyZWFkeSBrbm93IHRoYXQgd2UncmUganVzdCByb3Rh dGluZyBhYm91dCB0aGUgei1heGlzLgorCisgICAgICAgIFRoaXMgaXMgYSBzbWFsbCAoYnV0IG1l YXN1cmFibGUpIGltcHJvdmVtZW50IG9uIHRoZSBNdWx0aXBseSBzdWJ0ZXN0IG9mIE1vdGlvbk1h cmssIHdoaWNoIGFwcGxpZXMgYSBsaXR0bGUgb3ZlcgorICAgICAgICAzIG1pbGxpb24gcm90YXRp b24gdHJhbnNmb3JtYXRpb25zIG92ZXIgdGhlIGNvdXJzZSBvZiAzMCBzZWNvbmRzLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9Sb3RhdGVUcmFuc2Zvcm1PcGVyYXRp b24uaDoKKworICAgICAgICBJbnN0ZWFkIG9mIGNhbGxpbmcgYHJvdGF0ZTNkYCwganVzdCBoYXZl IGByb3RhdGVgIGRpcmVjdGx5IGNhbGwgYG11bHRpcGx5YCB3aXRoIHRoZSBmb2xsb3dpbmcKKyAg ICAgICAgYFRyYW5zZm9ybWF0aW9uTWF0cml4YDoKKyAgICAgICAgYGBgCisgICAgICAgIFtbICBj b3MoeikgIHNpbih6KSAgMCAgIDAgXQorICAgICAgICAgWyAgLXNpbih6KSBjb3MoeikgIDAgICAw IF0KKyAgICAgICAgIFsgIDAgICAgICAgMCAgICAgICAxICAgMCBdCisgICAgICAgICBbICAwICAg ICAgIDAgICAgICAgMCAgIDEgXV0KKyAgICAgICAgYGBgCisgICAgICAgIC4uLndoZXJlIGB6YCBp cyB0aGUgYW5nbGUgb2Ygcm90YXRpb24sIGluIHJhZGlhbnMuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4LmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlRyYW5zZm9ybWF0aW9uTWF0cml4Ojpyb3RhdGUpOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRyaXguaDoKKyAgICAgICAg KFdlYkNvcmU6OlRyYW5zZm9ybWF0aW9uTWF0cml4Ojpyb3RhdGUpOiBEZWxldGVkLgorCiAyMDIw LTA4LTI4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRl IFBhbm5lck5vZGUgdG8gc3VwcG9ydCBrLXJhdGUgYXV0b21hdGlvbiBvZiBpdHMgQXVkaW9QYXJh bXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9y bXMvUm90YXRlVHJhbnNmb3JtT3BlcmF0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy90cmFuc2Zvcm1zL1JvdGF0ZVRyYW5zZm9ybU9wZXJhdGlvbi5oCmluZGV4IDc2M2Rh YTAzODc0ODJmN2U0NmI5ZmQwYmFlNjlmNTE4MmM2MmZiMjAuLjgzNGFhNWZjNjg1ZTk3Njg3MGM4 MTk0ZmYxZDIwZjU1ZGY3MzczYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3RyYW5zZm9ybXMvUm90YXRlVHJhbnNmb3JtT3BlcmF0aW9uLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9Sb3RhdGVUcmFuc2Zvcm1P cGVyYXRpb24uaApAQCAtNjAsNyArNjAsMTAgQEAgcHJpdmF0ZToKIAogICAgIGJvb2wgYXBwbHko VHJhbnNmb3JtYXRpb25NYXRyaXgmIHRyYW5zZm9ybSwgY29uc3QgRmxvYXRTaXplJiAvKmJvcmRl ckJveFNpemUqLykgY29uc3Qgb3ZlcnJpZGUKICAgICB7Ci0gICAgICAgIHRyYW5zZm9ybS5yb3Rh dGUzZChtX3gsIG1feSwgbV96LCBtX2FuZ2xlKTsKKyAgICAgICAgaWYgKHR5cGUoKSA9PSBUcmFu c2Zvcm1PcGVyYXRpb246OlJPVEFURSkKKyAgICAgICAgICAgIHRyYW5zZm9ybS5yb3RhdGUobV9h bmdsZSk7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHRyYW5zZm9ybS5yb3RhdGUzZChtX3gs IG1feSwgbV96LCBtX2FuZ2xlKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFu c2Zvcm1hdGlvbk1hdHJpeC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4LmNwcAppbmRleCBlZTMwYTIxYmVjNWFkMzQ3 YTcxMDc5ZTNhZWUwZWM0OTdiNTgzODg3Li5jMTQ3YTM5N2VlNzJkYTYwMzc4YjZjNTVkMzkwMjQ3 NjM3MGNhNzM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90 cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybWF0aW9uTWF0cml4LmNwcApAQCAt ODk3LDYgKzg5NywxNSBAQCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgVHJhbnNmb3JtYXRpb25NYXRy aXg6OnJvdGF0ZTNkKGRvdWJsZSB4LCBkb3VibGUgeSwgZG91YmxlCiAgICAgcmV0dXJuICp0aGlz OwogfQogCitUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgVHJhbnNmb3JtYXRpb25NYXRyaXg6OnJvdGF0 ZShkb3VibGUgYW5nbGUpCit7CisgICAgYW5nbGUgPSBkZWcycmFkKGFuZ2xlKTsKKyAgICBkb3Vi bGUgc2luWiA9IHNpbihhbmdsZSk7CisgICAgZG91YmxlIGNvc1ogPSBjb3MoYW5nbGUpOworICAg IG11bHRpcGx5KHsgY29zWiwgc2luWiwgLXNpblosIGNvc1osIDAsIDAgfSk7CisgICAgcmV0dXJu ICp0aGlzOworfQorCiBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgVHJhbnNmb3JtYXRpb25NYXRyaXg6 OnJvdGF0ZTNkKGRvdWJsZSByeCwgZG91YmxlIHJ5LCBkb3VibGUgcnopCiB7CiAgICAgLy8gQW5n bGVzIGFyZSBpbiBkZWdyZWVzLiBTd2l0Y2ggdG8gcmFkaWFucy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtYXRpb25NYXRy aXguaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNm b3JtYXRpb25NYXRyaXguaAppbmRleCBlN2VjYjI4ZTQ5Y2IxNjMxNzEyNDYxNTUwYmFmODlhNTFl ZjhjMWFmLi5jNzFmNDRhODliNDExM2MwN2Y5YzVjNTMxNWIyNzQxMTMyMzIzOGJhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9y bWF0aW9uTWF0cml4LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdHJh bnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5oCkBAIC0yNTMsNyArMjUzLDcgQEAgcHVibGlj OgogICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4JiBzY2FsZTNkKGRvdWJsZSBzeCwgZG91YmxlIHN5 LCBkb3VibGUgc3opOwogCiAgICAgLy8gQW5nbGUgaXMgaW4gZGVncmVlcy4KLSAgICBUcmFuc2Zv cm1hdGlvbk1hdHJpeCYgcm90YXRlKGRvdWJsZSBkKSB7IHJldHVybiByb3RhdGUzZCgwLCAwLCBk KTsgfQorICAgIFdFQkNPUkVfRVhQT1JUIFRyYW5zZm9ybWF0aW9uTWF0cml4JiByb3RhdGUoZG91 YmxlKTsKICAgICBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYgcm90YXRlRnJvbVZlY3Rvcihkb3VibGUg eCwgZG91YmxlIHkpOwogICAgIFdFQkNPUkVfRVhQT1JUIFRyYW5zZm9ybWF0aW9uTWF0cml4JiBy b3RhdGUzZChkb3VibGUgcngsIGRvdWJsZSByeSwgZG91YmxlIHJ6KTsKICAgICAK