215962 2020-08-28 17:56:10 -0700 Delete DeprecatedGlobalSettings 2025-07-29 19:31:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=216182 InRadar P2 Normal --- 250192 1 sam sam ahmad.saleem792 graouts ntim webkit-bug-importer oldest_to_newest 1683845 0 sam 2020-08-28 17:56:10 -0700 DeprecatedGlobalSettings has been named deprecated for many years. Let's finish it off, and find new homes for its members. 1684921 1 sam 2020-09-02 12:36:07 -0700 Most of the very straightforward ones out of the way, now onto the more complicated ones (only listing the getter half of each): static bool shouldUseHighResolutionTimers() { return gShouldUseHighResolutionTimers; } Windows only, used in platform/win/MainThreadSharedTimerWin.cpp (layering violation). static bool isAVFoundationEnabled() { return gAVFoundationEnabled; } Used in platform/graphics/MediaPlayer.cpp (layering violation). static bool isAVFoundationNSURLSessionEnabled() { return gAVFoundationNSURLSessionEnabled; } Used in platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (layering violation). static bool isGStreamerEnabled() { return gGStreamerEnabled; } Used in platform/graphics/MediaPlayer.cpp (layering violation). WEBCORE_EXPORT static bool mockScrollbarsEnabled(); Used in platform/ScrollbarTheme.cpp (layering violation) and testing/InternalSettings.cpp. static bool usesOverlayScrollbars(); Used in platform/adwaita/ScrollbarThemeAdwaita.cpp (layering violation), platform/mock/ScrollbarThemeMock.cpp (layering violation), platform/Mac/NSScrollerImpDetails.mm (layering violation) and platform/Mac/ScrollbarThemeMac.mm (layering violation). static bool usesMockScrollAnimator(); Used in page/FrameView.cpp, rendering/RenderLayer.cpp, rendering/RenderListBox.cpp. (this one it seems like we could move to Settings.yaml). static bool shouldRespectPriorityInCSSAttributeSetters(); Used in css/CSSStyleDeclaration.cpp. static bool lowPowerVideoAudioBufferSizeEnabled() { return gLowPowerVideoAudioBufferSizeEnabled; } Used in platform/audio/cocoa/MediaSessionManagerCocoa.mm (layering violation). static bool resourceLoadStatisticsEnabled() { return gResourceLoadStatisticsEnabledEnabled; } Used in dom/Document.cpp, WebKit/WebProcess/WebProcess.cpp and WebKit/WebProcess/WebPage/WebCookieJar.cpp. static unsigned audioSessionCategoryOverride(); Not used anywhere, though setter is, and calls down to AudioSession::sharedSession().setCategoryOverride(...). static bool networkDataUsageTrackingEnabled(); Not used anywhere. static const String& networkInterfaceName(); Used in WebCore/html/HTMLMediaElement.cpp (this one it seems like we could move to Settings.yaml, probably needs a clearer names, since it is only used for some media related purposes). static bool disableScreenSizeOverride() { return gDisableScreenSizeOverride; } Not used anywhere. static bool avKitEnabled() { return gAVKitEnabled; } Used in WebKit/WebProcess/cocoa/VideoFullscreenManager.mm, WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm and WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp (layering violation). static bool shouldOptOutOfNetworkStateObservation() { return gShouldOptOutOfNetworkStateObservation; } Used in WebCore/platform/network/iOS/NetworkStateNotifierIOS.mm (layering violation). static bool shouldManageAudioSessionCategory() { return gManageAudioSession; } Used in WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm (layering violation), WebCore/platform/mediastream/Mac/BaseAudioSharedUnit.cpp (layering violation), and WebCore/testing/InternalSettings.cpp. static bool allowsAnySSLCertificate(); Used in WebCore/platform/network/cf/SocketStreamHandleImplCFNet.cpp (layering violation), WebCore/platform/network/curl/SocketStreamHandleImplCurl.cpp (layering violation) and WebKit/NetworkProcess/soup/NetworkSessionSoup.cpp. 1685028 2 sam 2020-09-02 15:35:27 -0700 (In reply to Sam Weinig from comment #1) > > > static bool disableScreenSizeOverride() { return > gDisableScreenSizeOverride; } > > Not used anywhere. Actually, this one is indeed still used. 1685966 3 webkit-bug-importer 2020-09-04 17:57:14 -0700 <rdar://problem/68375087> 1990120 4 ntim 2023-11-06 01:58:15 -0800 *** This bug has been marked as a duplicate of bug 250192 *** 1990122 5 ntim 2023-11-06 02:00:33 -0800 Actually we can use this bug to remove the file itself. 2133287 6 ahmad.saleem792 2025-07-29 19:31:45 -0700 We still has this - https://searchfox.org/wubkat/search?q=DeprecatedGlobalSettings&path=&case=false&regexp=false