<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>215948</bug_id>
          
          <creation_ts>2020-08-28 13:33:59 -0700</creation_ts>
          <short_desc>[ews] Notify bot watchers about pre-existing and flaky test failures for JSC tests</short_desc>
          <delta_ts>2020-09-23 11:17:17 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=215949</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=207475</see_also>
    
    <see_also>https://bugs.webkit.org/show_bug.cgi?id=216889</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1683755</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-08-28 13:33:59 -0700</bug_when>
    <thetext>Notify bot watchers about pre-existing and flaky test failures for JSC tests.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685603</commentid>
    <comment_count>1</comment_count>
      <attachid>407958</attachid>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-09-04 04:41:10 -0700</bug_when>
    <thetext>Created attachment 407958
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685778</commentid>
    <comment_count>2</comment_count>
      <attachid>407958</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2020-09-04 11:27:05 -0700</bug_when>
    <thetext>Comment on attachment 407958
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=407958&amp;action=review

&gt; Tools/BuildSlaveSupport/ews-build/steps.py:1781
&gt; +    def send_email_for_flaky_failure(self, test_name):

Same deal as https://bugs.webkit.org/show_bug.cgi?id=215949, the only variability here seems to be the suite, should we consider basing all of these analysis steps on the same base class?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685789</commentid>
    <comment_count>3</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-09-04 11:42:16 -0700</bug_when>
    <thetext>(In reply to Jonathan Bedard from comment #2)
&gt; Same deal as https://bugs.webkit.org/show_bug.cgi?id=215949, the only variability here seems to be the suite, should we consider basing all of these analysis steps on the same base class?
Yeah, will do that in a separate patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685796</commentid>
    <comment_count>4</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-09-04 11:51:05 -0700</bug_when>
    <thetext>commit-queue failed to commit attachment 407958 to WebKit repository.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685812</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-09-04 12:19:48 -0700</bug_when>
    <thetext>Committed r266629: &lt;https://trac.webkit.org/changeset/266629&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 407958.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1685813</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-09-04 12:20:16 -0700</bug_when>
    <thetext>&lt;rdar://problem/68359434&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>407958</attachid>
            <date>2020-09-04 04:41:10 -0700</date>
            <delta_ts>2020-09-04 12:19:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-215948-20200904074109.patch</filename>
            <type>text/plain</type>
            <size>3943</size>
            <attacher name="Aakash Jain">aakash_jain</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDI2NjU5NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDE2IEBACisyMDIwLTA5LTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv
bT4KKworICAgICAgICBbZXdzXSBOb3RpZnkgYm90IHdhdGNoZXJzIGFib3V0IHByZS1leGlzdGlu
ZyBhbmQgZmxha3kgdGVzdCBmYWlsdXJlcyBmb3IgSlNDIHRlc3RzCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU5NDgKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1i
dWlsZC9zdGVwcy5weToKKyAgICAgICAgKEFuYWx5emVKU0NUZXN0c1Jlc3VsdHMuc3RhcnQpOgor
ICAgICAgICAoQW5hbHl6ZUpTQ1Rlc3RzUmVzdWx0cy5zZW5kX2VtYWlsX2Zvcl9mbGFreV9mYWls
dXJlKToKKyAgICAgICAgKEFuYWx5emVKU0NUZXN0c1Jlc3VsdHMpOgorICAgICAgICAoQW5hbHl6
ZUpTQ1Rlc3RzUmVzdWx0cy5zZW5kX2VtYWlsX2Zvcl9wcmVfZXhpc3RpbmdfZmFpbHVyZSk6CisK
IDIwMjAtMDktMDQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog
CiAgICAgICAgIFtHTElCXSBTdG9wIHVzaW5nIGZpcmVmb3ggdXNlciBhZ2VudCBxdWlyayBmb3Ig
Z29vZ2xlIGRvY3MKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw
cy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3Rl
cHMucHkJKHJldmlzaW9uIDI2NjU5NikKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i
dWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMTc1OSwxMCArMTc1OSwxNCBAQCBjbGFz
cyBBbmFseXplSlNDVGVzdHNSZXN1bHRzKGJ1aWxkc3RlcC5CCiAgICAgICAgICAgICBtZXNzYWdl
ID0gJycKICAgICAgICAgICAgIGlmIGNsZWFuX3RyZWVfZmFpbHVyZXM6CiAgICAgICAgICAgICAg
ICAgbWVzc2FnZSA9ICdGb3VuZCB7fSBwcmUtZXhpc3RpbmcgSlNDIHRlc3QgZmFpbHVyZXt9OiB7
fScuZm9ybWF0KGxlbihjbGVhbl90cmVlX2ZhaWx1cmVzKSwgcGx1cmFsU3VmZml4LCBjbGVhbl90
cmVlX2ZhaWx1cmVzX3N0cmluZykKKyAgICAgICAgICAgICAgICBmb3IgY2xlYW5fdHJlZV9mYWls
dXJlIGluIGNsZWFuX3RyZWVfZmFpbHVyZXM6CisgICAgICAgICAgICAgICAgICAgIHNlbGYuc2Vu
ZF9lbWFpbF9mb3JfcHJlX2V4aXN0aW5nX2ZhaWx1cmUoY2xlYW5fdHJlZV9mYWlsdXJlKQogICAg
ICAgICAgICAgaWYgbGVuKGNsZWFuX3RyZWVfZmFpbHVyZXMpID4gc2VsZi5OVU1fRkFJTFVSRVNf
VE9fRElTUExBWToKICAgICAgICAgICAgICAgICBtZXNzYWdlICs9ICcgLi4uJwogICAgICAgICAg
ICAgaWYgZmxha3lfZmFpbHVyZXM6CiAgICAgICAgICAgICAgICAgbWVzc2FnZSArPSAnIEZvdW5k
IGZsYWt5IHRlc3RzOiB7fScuZm9ybWF0KGZsYWt5X2ZhaWx1cmVzX3N0cmluZykKKyAgICAgICAg
ICAgICAgICBmb3IgZmxha3lfZmFpbHVyZSBpbiBmbGFreV9mYWlsdXJlczoKKyAgICAgICAgICAg
ICAgICAgICAgc2VsZi5zZW5kX2VtYWlsX2Zvcl9mbGFreV9mYWlsdXJlKGZsYWt5X2ZhaWx1cmUp
CiAgICAgICAgICAgICBzZWxmLmJ1aWxkLmJ1aWxkRmluaXNoZWQoW21lc3NhZ2VdLCBTVUNDRVNT
KQogICAgICAgICByZXR1cm4gZGVmZXIuc3VjY2VlZChOb25lKQogCkBAIC0xNzc0LDYgKzE3Nzgs
MzMgQEAgY2xhc3MgQW5hbHl6ZUpTQ1Rlc3RzUmVzdWx0cyhidWlsZHN0ZXAuQgogICAgICAgICAg
ICAgbG9nID0geWllbGQgc2VsZi5hZGRMb2cobG9nTmFtZSkKICAgICAgICAgbG9nLmFkZFN0ZG91
dChtZXNzYWdlKQogCisgICAgZGVmIHNlbmRfZW1haWxfZm9yX2ZsYWt5X2ZhaWx1cmUoc2VsZiwg
dGVzdF9uYW1lKToKKyAgICAgICAgdHJ5OgorICAgICAgICAgICAgYnVpbGRlcl9uYW1lID0gc2Vs
Zi5nZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnJykKKyAgICAgICAgICAgIHdvcmtlcl9uYW1l
ID0gc2VsZi5nZXRQcm9wZXJ0eSgnd29ya2VybmFtZScsICcnKQorICAgICAgICAgICAgYnVpbGRf
dXJsID0gJ3t9Iy9idWlsZGVycy97fS9idWlsZHMve30nLmZvcm1hdChzZWxmLm1hc3Rlci5jb25m
aWcuYnVpbGRib3RVUkwsIHNlbGYuYnVpbGQuX2J1aWxkZXJpZCwgc2VsZi5idWlsZC5udW1iZXIp
CisgICAgICAgICAgICBoaXN0b3J5X3VybCA9ICd7fT9zdWl0ZT1qYXZhc2NyaXB0Y29yZS10ZXN0
cyZ0ZXN0PXt9Jy5mb3JtYXQoUkVTVUxUU19EQl9VUkwsIHRlc3RfbmFtZSkKKworICAgICAgICAg
ICAgZW1haWxfc3ViamVjdCA9IHUnRmxha3kgdGVzdDoge30nLmZvcm1hdCh0ZXN0X25hbWUpCisg
ICAgICAgICAgICBlbWFpbF90ZXh0ID0gJ0ZsYWt5IHRlc3Q6IHt9XG5cbkJ1aWxkOiB7fVxuXG5C
dWlsZGVyOiB7fVxuXG5Xb3JrZXI6IHt9XG5cbkhpc3Rvcnk6IHt9Jy5mb3JtYXQodGVzdF9uYW1l
LCBidWlsZF91cmwsIGJ1aWxkZXJfbmFtZSwgd29ya2VyX25hbWUsIGhpc3RvcnlfdXJsKQorICAg
ICAgICAgICAgc2VuZF9lbWFpbF90b19ib3Rfd2F0Y2hlcnMoZW1haWxfc3ViamVjdCwgZW1haWxf
dGV4dCwgJ2ZsYWt5LXt9Jy5mb3JtYXQodGVzdF9uYW1lKSkKKyAgICAgICAgZXhjZXB0IEV4Y2Vw
dGlvbiBhcyBlOgorICAgICAgICAgICAgcHJpbnQoJ0Vycm9yIGluIHNlbmRpbmcgZW1haWwgZm9y
IGZsYWt5IGZhaWx1cmU6IHt9Jy5mb3JtYXQoZSkpCisKKyAgICBkZWYgc2VuZF9lbWFpbF9mb3Jf
cHJlX2V4aXN0aW5nX2ZhaWx1cmUoc2VsZiwgdGVzdF9uYW1lKToKKyAgICAgICAgdHJ5OgorICAg
ICAgICAgICAgYnVpbGRlcl9uYW1lID0gc2VsZi5nZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAn
JykKKyAgICAgICAgICAgIHdvcmtlcl9uYW1lID0gc2VsZi5nZXRQcm9wZXJ0eSgnd29ya2VybmFt
ZScsICcnKQorICAgICAgICAgICAgYnVpbGRfdXJsID0gJ3t9Iy9idWlsZGVycy97fS9idWlsZHMv
e30nLmZvcm1hdChzZWxmLm1hc3Rlci5jb25maWcuYnVpbGRib3RVUkwsIHNlbGYuYnVpbGQuX2J1
aWxkZXJpZCwgc2VsZi5idWlsZC5udW1iZXIpCisgICAgICAgICAgICBoaXN0b3J5X3VybCA9ICd7
fT9zdWl0ZT1qYXZhc2NyaXB0Y29yZS10ZXN0cyZ0ZXN0PXt9Jy5mb3JtYXQoUkVTVUxUU19EQl9V
UkwsIHRlc3RfbmFtZSkKKworICAgICAgICAgICAgZW1haWxfc3ViamVjdCA9IHUnUHJlLWV4aXN0
aW5nIHRlc3QgZmFpbHVyZToge30nLmZvcm1hdCh0ZXN0X25hbWUpCisgICAgICAgICAgICBlbWFp
bF90ZXh0ID0gJ1Rlc3Qge30gZmFpbGVkIG9uIGNsZWFuIHRyZWUgcnVuIGluIHt9LlxuXG5CdWls
ZGVyOiB7fVxuXG5Xb3JrZXI6IHt9XG5cbkhpc3Rvcnk6IHt9Jy5mb3JtYXQodGVzdF9uYW1lLCBi
dWlsZF91cmwsIGJ1aWxkZXJfbmFtZSwgd29ya2VyX25hbWUsIGhpc3RvcnlfdXJsKQorICAgICAg
ICAgICAgc2VuZF9lbWFpbF90b19ib3Rfd2F0Y2hlcnMoZW1haWxfc3ViamVjdCwgZW1haWxfdGV4
dCwgJ3ByZWV4aXN0aW5nLXt9Jy5mb3JtYXQodGVzdF9uYW1lKSkKKyAgICAgICAgZXhjZXB0IEV4
Y2VwdGlvbiBhcyBlOgorICAgICAgICAgICAgcHJpbnQoJ0Vycm9yIGluIHNlbmRpbmcgZW1haWwg
Zm9yIHByZS1leGlzdGluZyBmYWlsdXJlOiB7fScuZm9ybWF0KGUpKQorCisKIAogY2xhc3MgQ2xl
YW5CdWlsZChzaGVsbC5Db21waWxlKToKICAgICBuYW1lID0gJ2RlbGV0ZS1XZWJLaXRCdWlsZC1k
aXJlY3RvcnknCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>