215940 2020-08-28 11:32:38 -0700 Web Inspector: Graphics: remove unnecessary main page check when iterating existing animations 2020-08-28 13:28:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED WONTFIX P2 Normal --- 208493 1 hi hi bburg hi inspector-bugzilla-changes joepeck pangle timothy oldest_to_newest 1683720 0 hi 2020-08-28 11:32:38 -0700 . 1683726 1 407491 hi 2020-08-28 11:38:46 -0700 Created attachment 407491 Patch 1683736 2 407491 bburg 2020-08-28 12:12:02 -0700 Comment on attachment 407491 Patch LGTM, but it doesn't build. Is there a behavior change? Does this mean iframe animations will show in the main page? or that WebAnimation::instances() only returns such animations? 1683751 3 hi 2020-08-28 13:19:43 -0700 (In reply to Brian Burg from comment #2) > Comment on attachment 407491 [details] > Patch > > LGTM, but it doesn't build. grumble mumble `-Wunused-private-field` grumble grumble > Is there a behavior change? Does this mean iframe animations will show in the main page? or that WebAnimation::instances() only returns such animations? AFAIU this is not a behavior change as subframes share the same `Page` as the main frame. It's already possible to see `WebAnimation` inside `<iframe>`. I'll adjust the ChangeLog comment to further clarify that this code indeed basically did nothing. In fact, it's possible to see `WebSocket` and `<canvas>` too, so I think we can remove those checks as well :) 1683754 4 hi 2020-08-28 13:28:42 -0700 I totally forgot that there can be more than one `Page` per WebProcess, so we actually still do need this code. 407491 2020-08-28 11:38:46 -0700 2020-08-28 12:12:02 -0700 Patch bug-215940-20200828113845.patch text/plain 5081 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhZGRlNGQ2MWNjZjM2MzFiMzBiYTA1OTNjYzRmZDYyY2ZlMTFiYTIwLi43 YzM4ZTA1YzVhNDNkYmNkMTQ1MmE0YmNkNTIwNDI5NGUyNjk3MjI1IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjIgQEAKKzIwMjAtMDgtMjggIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEdyYXBoaWNzOiByZW1vdmUgdW5uZWNlc3Nhcnkg bWFpbiBwYWdlIGNoZWNrIHdoZW4gaXRlcmF0aW5nIGV4aXN0aW5nIGFuaW1hdGlvbnMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTk0MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIyNTc3NTYgcmVtb3Zl ZCB0aGUgdW5uZWNlc3NhcnkgbG9jayB0aGF0IGd1YXJkZWQgYWNjZXNzIHRvIGBXZWJBbmltYXRp b246Omluc3RhbmNlc2AgYXMKKyAgICAgICAgYFdlYkFuaW1hdGlvbmAgb25seSBleGlzdCBpbiB0 aGUgbWFpbiB0aHJlYWQuIHIyNTc3NTYgZGlkIG5vdCByZW1vdmUgdGhlIGFkZGl0aW9uYWwgY2hl Y2sKKyAgICAgICAgdGhhdCBmdXJ0aGVyIHJlc3RyaWN0ZWQgaW5zdHJ1bWVudGF0aW9uIHRvIG9u bHkgYFdlYkFuaW1hdGlvbmAgdGhhdCBleGlzdCBpbiB0aGUgbWFpbiBwYWdlLgorCisgICAgICAg ICogaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JBbmltYXRpb25BZ2VudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpJbnNwZWN0b3JBbmltYXRpb25BZ2VudDo6ZW5hYmxlKToKKworICAgICAgICAq IGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ2FudmFzQWdlbnQuY3BwOgorICAgICAgICAqIGlu c3BlY3Rvci9hZ2VudHMvcGFnZS9QYWdlTmV0d29ya0FnZW50LmNwcDoKKyAgICAgICAgKiBpbnNw ZWN0b3IvYWdlbnRzL3dvcmtlci9Xb3JrZXJOZXR3b3JrQWdlbnQuY3BwOgorICAgICAgICBEcml2 ZS1ieTogYWRqdXN0IEZJWE1FIGNvbW1lbnRzIHRvIHBvaW50IHRvIHRoZSByaWdodCBidWcuCisK IDIwMjAtMDgtMjcgIEZyYW5rIFlhbmcgIDxndW93ZWlfeWFuZ0BhcHBsZS5jb20+CiAKICAgICAg ICAgQ1NTIEZpbHRlciBpbnZlcnQoKSBhbmQgb3BhY2l0eSgpIEltcGxlbWVudGF0aW9uIFNob3Vs ZCBVc2UgTGluZWFyIFRyYW5zZmVyIEZ1bmN0aW9uIGZvciBDbGFyaXR5IGFuZCBTaW1wbGljaXR5 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckFu aW1hdGlvbkFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVj dG9yQW5pbWF0aW9uQWdlbnQuY3BwCmluZGV4IDcxMzI1ZjUyMmQzYTEyM2E1MzRmYzdmZjNhNTg0 YjU4YmM5NGY5MzYuLjVmYzRhMTJiMTNiODA1ZGYyOTI2ODIzYzFiYTYyM2U3OTMyN2FhNTQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQW5pbWF0 aW9uQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVj dG9yQW5pbWF0aW9uQWdlbnQuY3BwCkBAIC0yNTUsMjAgKzI1NSw4IEBAIHZvaWQgSW5zcGVjdG9y QW5pbWF0aW9uQWdlbnQ6OmVuYWJsZShFcnJvclN0cmluZyYgZXJyb3JTdHJpbmcpCiAKICAgICBt X2luc3RydW1lbnRpbmdBZ2VudHMuc2V0RW5hYmxlZEFuaW1hdGlvbkFnZW50KHRoaXMpOwogCi0g ICAgY29uc3QgYXV0byBleGlzdHNJbkN1cnJlbnRQYWdlID0gWyZdIChTY3JpcHRFeGVjdXRpb25D b250ZXh0KiBzY3JpcHRFeGVjdXRpb25Db250ZXh0KSB7Ci0gICAgICAgIGlmICghaXM8RG9jdW1l bnQ+KHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQpKQotICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwot Ci0gICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTY4NDc1PiBXZWIgSW5z cGVjdG9yOiBDb3JyZWN0bHkgZGlzcGxheSBpZnJhbWUncyBXZWJTb2NrZXRzCi0gICAgICAgIGF1 dG8qIGRvY3VtZW50ID0gZG93bmNhc3Q8RG9jdW1lbnQ+KHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQp OwotICAgICAgICByZXR1cm4gZG9jdW1lbnQtPnBhZ2UoKSA9PSAmbV9pbnNwZWN0ZWRQYWdlOwot ICAgIH07Ci0KLSAgICB7Ci0gICAgICAgIGZvciAoYXV0byogYW5pbWF0aW9uIDogV2ViQW5pbWF0 aW9uOjppbnN0YW5jZXMoKSkgewotICAgICAgICAgICAgaWYgKGV4aXN0c0luQ3VycmVudFBhZ2Uo YW5pbWF0aW9uLT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpKQotICAgICAgICAgICAgICAgIGJp bmRBbmltYXRpb24oKmFuaW1hdGlvbiwgZmFsc2UpOwotICAgICAgICB9CisgICAgZm9yIChhdXRv KiBhbmltYXRpb24gOiBXZWJBbmltYXRpb246Omluc3RhbmNlcygpKSB7CisgICAgICAgIGJpbmRB bmltYXRpb24oKmFuaW1hdGlvbiwgZmFsc2UpOwogICAgIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JDYW52YXNBZ2VudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNhbnZhc0FnZW50LmNwcApp bmRleCBkMDkxNjgyOTQwMGY5NDZmMDg2MDA5NThhYTQ0M2U1NzA3M2ZlOGFhLi4xZTQ3YTg3ZjEy ODY1YzhmNTM5NmFiZGU2OTY5YzBkMzJhYWFkMTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNhbnZhc0FnZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvckNhbnZhc0FnZW50LmNwcApAQCAtMTIy LDcgKzEyMiw3IEBAIHZvaWQgSW5zcGVjdG9yQ2FudmFzQWdlbnQ6OmVuYWJsZShFcnJvclN0cmlu ZyYpCiAgICAgICAgIGlmICghaXM8RG9jdW1lbnQ+KHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQpKQog ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6Ly93 ZWJraXQub3JnL2IvMTY4NDc1PiBXZWIgSW5zcGVjdG9yOiBDb3JyZWN0bHkgZGlzcGxheSBpZnJh bWUncyBXZWJTb2NrZXRzCisgICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2Iv MjE1OTM5PiBXZWIgSW5zcGVjdG9yOiBHcmFwaGljczogY29ycmVjdGx5IHNob3cgPGNhbnZhcz4g Y3JlYXRlZCBpbnNpZGUgPGlmcmFtZT4KICAgICAgICAgYXV0byogZG9jdW1lbnQgPSBkb3duY2Fz dDxEb2N1bWVudD4oc2NyaXB0RXhlY3V0aW9uQ29udGV4dCk7CiAgICAgICAgIHJldHVybiBkb2N1 bWVudC0+cGFnZSgpID09ICZtX2luc3BlY3RlZFBhZ2U7CiAgICAgfTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvcGFnZS9QYWdlTmV0d29ya0FnZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvcGFnZS9QYWdlTmV0d29ya0FnZW50LmNw cAppbmRleCAzNDhhNDQ4MGQ1YmMyNDM1OWQzOTI5OGE0NGU4YTk2ZjJlMTZlZjNkLi42OGVjNGYw OTNmNWNhZmRmMDZkMDEyNGE1YzcxNzZjNjQ3ZjAyM2NiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvYWdlbnRzL3BhZ2UvUGFnZU5ldHdvcmtBZ2VudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9wYWdlL1BhZ2VOZXR3b3JrQWdlbnQuY3BwCkBA IC04Myw3ICs4Myw3IEBAIFZlY3RvcjxXZWJTb2NrZXQqPiBQYWdlTmV0d29ya0FnZW50OjphY3Rp dmVXZWJTb2NrZXRzKGNvbnN0IExvY2tIb2xkZXImIGxvY2spCiAgICAgICAgIGlmICghaXM8RG9j dW1lbnQ+KHdlYlNvY2tldC0+c2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKSkKICAgICAgICAgICAg IGNvbnRpbnVlOwogCi0gICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTY4 NDc1PiBXZWIgSW5zcGVjdG9yOiBDb3JyZWN0bHkgZGlzcGxheSBpZnJhbWUncyBXZWJTb2NrZXRz CisgICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTY4NDc1PiBXZWIgSW5z cGVjdG9yOiBDb3JyZWN0bHkgZGlzcGxheSBpZnJhbWUncyBhbmQgd29ya2VyJ3MgV2ViU29ja2V0 cwogICAgICAgICBhdXRvKiBkb2N1bWVudCA9IGRvd25jYXN0PERvY3VtZW50Pih3ZWJTb2NrZXQt PnNjcmlwdEV4ZWN1dGlvbkNvbnRleHQoKSk7CiAgICAgICAgIGlmIChkb2N1bWVudC0+cGFnZSgp ICE9ICZtX2luc3BlY3RlZFBhZ2UpCiAgICAgICAgICAgICBjb250aW51ZTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvd29ya2VyL1dvcmtlck5ldHdvcmtBZ2Vu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL3dvcmtlci9Xb3JrZXJOZXR3 b3JrQWdlbnQuY3BwCmluZGV4IDUzZmE4ODNhZDk3MTg4Njg0Y2I5NGMwOTBlNzk2MTY5MDgxYjZi NGQuLjIxYjJhZTQyOGYyNDc1ODYzMDNiOWI1OWU4Y2E4OGNhMTlhNTczYWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvd29ya2VyL1dvcmtlck5ldHdvcmtBZ2Vu dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy93b3JrZXIvV29ya2Vy TmV0d29ya0FnZW50LmNwcApAQCAtNTUsNyArNTUsNyBAQCBTdHJpbmcgV29ya2VyTmV0d29ya0Fn ZW50OjpmcmFtZUlkZW50aWZpZXIoRG9jdW1lbnRMb2FkZXIqKQogCiBWZWN0b3I8V2ViU29ja2V0 Kj4gV29ya2VyTmV0d29ya0FnZW50OjphY3RpdmVXZWJTb2NrZXRzKGNvbnN0IExvY2tIb2xkZXIm KQogewotICAgIC8vIEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTY4NDc1PiBXZWIgSW5z cGVjdG9yOiBDb3JyZWN0bHkgZGlzcGxheSB3b3JrZXIncyBXZWJTb2NrZXRzCisgICAgLy8gRklY TUU6IDxodHRwczovL3dlYmtpdC5vcmcvYi8xNjg0NzU+IFdlYiBJbnNwZWN0b3I6IENvcnJlY3Rs eSBkaXNwbGF5IGlmcmFtZSdzIGFuZCB3b3JrZXIncyBXZWJTb2NrZXRzCiAgICAgcmV0dXJuIHsg fTsKIH0KIAo=