215937 2020-08-28 11:15:34 -0700 No need to run full can-use-for (fast inline layout codepath) check on every style change. 2020-08-28 13:21:45 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan mmaxfield pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1683708 0 zalan 2020-08-28 11:15:34 -0700 e.g. when the style change diff is RepaintOnly we know that the content has not changed, so no need to re-check each glyphs. 1683709 1 webkit-bug-importer 2020-08-28 11:15:56 -0700 <rdar://problem/67951360> 1683715 2 407488 zalan 2020-08-28 11:29:47 -0700 Created attachment 407488 Patch 1683753 3 ews-feeder 2020-08-28 13:21:44 -0700 Committed r266291: <https://trac.webkit.org/changeset/266291> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407488. 407488 2020-08-28 11:29:47 -0700 2020-08-28 13:21:44 -0700 Patch bug-215937-20200828112947.patch text/plain 6324 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MTY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWNhNGJhNTU0M2IwMDQy ZjVkNDFhNmE3YmNjN2Y5Y2Q0Njk5YTE4NC4uYmI5ZWE3NzAzZjY5YzI1ZjlkZTI3ODQ5MzJhYTdh YzA3NDViOGNlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTA4LTI4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgTm8gbmVlZCB0byBydW4gZnVs bCBjYW4tdXNlLWZvciAoZmFzdCBpbmxpbmUgbGF5b3V0IGNvZGVwYXRoKSBjaGVjayBvbiBldmVy eSBzdHlsZSBjaGFuZ2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTU5MzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY3OTUxMzYwPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExldCdzIHVzZSB0aGUg U3R5bGVEaWZmZXJlbmNlIHRvIGZpZ3VyZSBvdXQgaG93IGV4dGVuc2l2ZSB0aGUgY2FuLXVzZS1m b3IgY2hlY2sgc2hvdWxkIGJlLgorICAgICAgICBXZSBjYW4gY2VydGFpbmx5IHNraXAgc29tZSBy ZWxhdGl2ZWx5IGV4cGVuc2l2ZSBjb250ZW50IGNoZWNrcyB3aGVuIHdlIGtub3cgdGhhdCB0aGUg c3R5bGUgY2hhbmdlIG9ubHkgdHJpZ2dlcnMgcmVwYWludCBvciBwb3NpdGlvbmVkLW1vdmVtZW50 LW9ubHkgY2hhbmdlcy4KKworICAgICAgICAqIGxheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRl Z3JhdGlvbkxpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRp b246OkxpbmVMYXlvdXQ6OmNhblVzZUZvckFmdGVyU3R5bGVDaGFuZ2UpOgorICAgICAgICAqIGxh eW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuaDoKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJsb2NrRmxvdzo6c3R5bGVEaWRDaGFuZ2UpOgorICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVM aW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNpbXBsZUxpbmVMYXlvdXQ6OmNhblVz ZUZvckFmdGVyU3R5bGVDaGFuZ2UpOgorICAgICAgICAqIHJlbmRlcmluZy9TaW1wbGVMaW5lTGF5 b3V0Lmg6CisKIDIwMjAtMDgtMjYgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUu Y29tPgogCiAgICAgICAgIFdoZW4gY2FjaGluZyB0aGUgQWNjZXNzaWJpbGl0eVRleHQgcHJvcGVy dHkgaW4gQVhJc29sYXRlZE9iamVjdCwgdGhlIFN0cmluZ3MgbmVlZCB0byBiZSBpc29sYXRlZENv cGllZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlv dXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVn cmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKaW5kZXggMWU3ZjY0OWJlYWM3 OTY1Y2MwMGYyYjdjNGFjNjI5MzJkMWViYTVlNy4uMWQxNWQ1ZDYxZGVlYzZhM2FiMTdmODEyNGNj MjZjODA1OTk4MDBlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0 aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv bGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5jcHAKQEAgLTgz LDYgKzgzLDEyIEBAIGJvb2wgTGluZUxheW91dDo6Y2FuVXNlRm9yKGNvbnN0IFJlbmRlckJsb2Nr RmxvdyYgZmxvdywgT3B0aW9uYWw8Ym9vbD4gY291bGRVc2VTCiAgICAgcmV0dXJuIHRydWU7CiB9 CiAKK2Jvb2wgTGluZUxheW91dDo6Y2FuVXNlRm9yQWZ0ZXJTdHlsZUNoYW5nZShjb25zdCBSZW5k ZXJCbG9ja0Zsb3cmIGZsb3csIFN0eWxlRGlmZmVyZW5jZSBkaWZmKQoreworICAgIEFTU0VSVChS dW50aW1lRW5hYmxlZEZlYXR1cmVzOjpzaGFyZWRGZWF0dXJlcygpLmxheW91dEZvcm1hdHRpbmdD b250ZXh0SW50ZWdyYXRpb25FbmFibGVkKCkpOworICAgIHJldHVybiBTaW1wbGVMaW5lTGF5b3V0 OjpjYW5Vc2VGb3JBZnRlclN0eWxlQ2hhbmdlKGZsb3csIGRpZmYpOworfQorCiB2b2lkIExpbmVM YXlvdXQ6OnVwZGF0ZVN0eWxlKCkKIHsKICAgICBhdXRvJiByb290ID0gcm9vdExheW91dEJveCgp OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dElu dGVncmF0aW9uTGluZUxheW91dC5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9u L0xheW91dEludGVncmF0aW9uTGluZUxheW91dC5oCmluZGV4IDAyMmZhNDE2ODgxZTc1ZjFhY2I4 YmI4MDVkNDJkYWNlOGJiOTJjZWYuLjlhMDU0ZmViNDcwMmRlN2VhYzkxODkzYmVhMWE3MmQwZDI0 Njg4OWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlv dXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50 ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25MaW5lTGF5b3V0LmgKQEAgLTYwLDYgKzYwLDcgQEAg cHVibGljOgogICAgIH5MaW5lTGF5b3V0KCk7CiAKICAgICBzdGF0aWMgYm9vbCBjYW5Vc2VGb3Io Y29uc3QgUmVuZGVyQmxvY2tGbG93JiwgT3B0aW9uYWw8Ym9vbD4gY291bGRVc2VTaW1wbGVMaW5l TGF5b3V0ID0geyB9KTsKKyAgICBzdGF0aWMgYm9vbCBjYW5Vc2VGb3JBZnRlclN0eWxlQ2hhbmdl KGNvbnN0IFJlbmRlckJsb2NrRmxvdyYsIFN0eWxlRGlmZmVyZW5jZSk7CiAKICAgICB2b2lkIHVw ZGF0ZVN0eWxlKCk7CiAgICAgdm9pZCBsYXlvdXQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXggZTIxM2FhYzcxYTk0NDU4NzNlMjE2MDQxNjRl NDE0NDU4YjA2Y2E5MC4uYmIwNjJjODRkMjdlYTNiNWFiOTAwZDM3MmNjZjc3NjY4NDE5NTE3OSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKQEAgLTIx MDcsMTEgKzIxMDcsMTAgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OnN0eWxlRGlkQ2hhbmdlKFN0 eWxlRGlmZmVyZW5jZSBkaWZmLCBjb25zdCBSZW5kZXJTdHlsZSogb2wKICAgICAgICAgYXV0byBz aG91bGRJbnZhbGlkYXRlTGluZUxheW91dFBhdGggPSBbJl0gewogICAgICAgICAgICAgaWYgKHNl bGZOZWVkc0xheW91dCgpIHx8IGNvbXBsZXhMaW5lTGF5b3V0KCkpCiAgICAgICAgICAgICAgICAg cmV0dXJuIHRydWU7Ci0gICAgICAgICAgICAvLyBGSVhNRTogVGhpcyBjb3VsZCB1c2UgYSBjaGVh cGVyIHN0eWxlLW9ubHkgdGVzdCBpbnN0ZWFkIG9mIFNpbXBsZUxpbmVMYXlvdXQ6OmNhblVzZUZv ci4KLSAgICAgICAgICAgIGlmIChzaW1wbGVMaW5lTGF5b3V0KCkgJiYgIVNpbXBsZUxpbmVMYXlv dXQ6OmNhblVzZUZvcigqdGhpcykpCisgICAgICAgICAgICBpZiAoc2ltcGxlTGluZUxheW91dCgp ICYmICFTaW1wbGVMaW5lTGF5b3V0OjpjYW5Vc2VGb3JBZnRlclN0eWxlQ2hhbmdlKCp0aGlzLCBk aWZmKSkKICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICNpZiBFTkFCTEUoTEFZT1VUX0ZP Uk1BVFRJTkdfQ09OVEVYVCkKLSAgICAgICAgICAgIGlmIChsYXlvdXRGb3JtYXR0aW5nQ29udGV4 dExpbmVMYXlvdXQoKSAmJiAhTGF5b3V0SW50ZWdyYXRpb246OkxpbmVMYXlvdXQ6OmNhblVzZUZv cigqdGhpcykpCisgICAgICAgICAgICBpZiAobGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5 b3V0KCkgJiYgIUxheW91dEludGVncmF0aW9uOjpMaW5lTGF5b3V0OjpjYW5Vc2VGb3JBZnRlclN0 eWxlQ2hhbmdlKCp0aGlzLCBkaWZmKSkKICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICNl bmRpZgogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCmluZGV4IDZmMTljODViMDkzMzJjMDJjMzRkN2E1Zjcy MTk2ODIzN2VhMGFkMGEuLjEwOTJmZDFmMTA0YWRmOWI4ZjU4ODU1NDZmYThhYWUyZDAwZWYzODMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5jcHAKQEAg LTM1OSw2ICszNTksMzAgQEAgYm9vbCBjYW5Vc2VGb3IoY29uc3QgUmVuZGVyQmxvY2tGbG93JiBm bG93KQogICAgIHJldHVybiBjYW5Vc2VGb3JXaXRoUmVhc29uKGZsb3csIEluY2x1ZGVSZWFzb25z OjpGaXJzdCkgPT0gTm9SZWFzb247CiB9CiAKK2Jvb2wgY2FuVXNlRm9yQWZ0ZXJTdHlsZUNoYW5n ZShjb25zdCBSZW5kZXJCbG9ja0Zsb3cmIGJsb2NrQ29udGFpbmVyLCBTdHlsZURpZmZlcmVuY2Ug ZGlmZikKK3sKKyAgICBzd2l0Y2ggKGRpZmYpIHsKKyAgICBjYXNlIFN0eWxlRGlmZmVyZW5jZTo6 RXF1YWw6CisgICAgY2FzZSBTdHlsZURpZmZlcmVuY2U6OlJlY29tcG9zaXRlTGF5ZXI6CisgICAg ICAgIHJldHVybiB0cnVlOworICAgIGNhc2UgU3R5bGVEaWZmZXJlbmNlOjpSZXBhaW50OgorICAg IGNhc2UgU3R5bGVEaWZmZXJlbmNlOjpSZXBhaW50SWZUZXh0T3JCb3JkZXJPck91dGxpbmU6Cisg ICAgY2FzZSBTdHlsZURpZmZlcmVuY2U6OlJlcGFpbnRMYXllcjoKKyAgICAgICAgLy8gRklYTUU6 IFdlIGNvdWxkIGRvIGEgbW9yZSBmb2N1c2VkIHN0eWxlIGNoZWNrIGJ5IG1hdGNoaW5nIFJlbmRl cmVyU3R5bGU6OmNoYW5nZVJlcXVpcmVzUmVwYWludCZjby4KKyAgICAgICAgcmV0dXJuIGNhblVz ZUZvclN0eWxlKGJsb2NrQ29udGFpbmVyLnN0eWxlKCksIEluY2x1ZGVSZWFzb25zOjpGaXJzdCkg PT0gTm9SZWFzb247CisgICAgY2FzZSBTdHlsZURpZmZlcmVuY2U6OkxheW91dFBvc2l0aW9uZWRN b3ZlbWVudE9ubHk6CisgICAgICAgIHJldHVybiB0cnVlOworICAgIGNhc2UgU3R5bGVEaWZmZXJl bmNlOjpTaW1wbGlmaWVkTGF5b3V0OgorICAgIGNhc2UgU3R5bGVEaWZmZXJlbmNlOjpTaW1wbGlm aWVkTGF5b3V0QW5kUG9zaXRpb25lZE1vdmVtZW50OgorICAgICAgICByZXR1cm4gY2FuVXNlRm9y U3R5bGUoYmxvY2tDb250YWluZXIuc3R5bGUoKSwgSW5jbHVkZVJlYXNvbnM6OkZpcnN0KSA9PSBO b1JlYXNvbjsKKyAgICBjYXNlIFN0eWxlRGlmZmVyZW5jZTo6TGF5b3V0OgorICAgIGNhc2UgU3R5 bGVEaWZmZXJlbmNlOjpOZXdTdHlsZToKKyAgICAgICAgcmV0dXJuIGNhblVzZUZvcihibG9ja0Nv bnRhaW5lcik7CisgICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBj YW5Vc2VGb3IoYmxvY2tDb250YWluZXIpOworfQorCiBzdGF0aWMgdm9pZCByZXZlcnRBbGxSdW5z T25DdXJyZW50TGluZShMYXlvdXQ6OlJ1blZlY3RvciYgcnVucykKIHsKICAgICB3aGlsZSAoIXJ1 bnMuaXNFbXB0eSgpICYmICFydW5zLmxhc3QoKS5pc0VuZE9mTGluZSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmggYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvU2ltcGxlTGluZUxheW91dC5oCmluZGV4IGVjNGE3YTBmYTRiOTBmMjU2ODMz NGI4NTliZDhlMTcwODQzYzA2OGMuLmMyMDBlYjc1YjVlNmE3NDM3ZWQ1NWFlZGRlOGYzMmVkZTdk ZmZiYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5 b3V0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuaApA QCAtNDUsNiArNDUsNyBAQCBuYW1lc3BhY2UgU2ltcGxlTGluZUxheW91dCB7CiBjbGFzcyBSdW5S ZXNvbHZlcjsKIAogYm9vbCBjYW5Vc2VGb3IoY29uc3QgUmVuZGVyQmxvY2tGbG93Jik7Citib29s IGNhblVzZUZvckFmdGVyU3R5bGVDaGFuZ2UoY29uc3QgUmVuZGVyQmxvY2tGbG93JiwgU3R5bGVE aWZmZXJlbmNlKTsKIEF2b2lkYW5jZVJlYXNvbkZsYWdzIGNhblVzZUZvcldpdGhSZWFzb24oY29u c3QgUmVuZGVyQmxvY2tGbG93JiwgSW5jbHVkZVJlYXNvbnMpOwogCiBzdHJ1Y3QgUnVuIHsK