215933 2020-08-28 10:18:48 -0700 Remove the system tracing from DisplayList::Replayer::replay() 2020-08-28 11:03:17 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa benjamin bfulgham cdumez cmarcelo ews-watchlist simon.fraser webkit-bug-importer zalan oldest_to_newest 1683679 0 sabouhallawa 2020-08-28 10:18:48 -0700 It turned out this tracing point can be expensive when drawing many text lines in a page. It can affect the tracing of the MotionMark Design test for example. 1683682 1 407479 sabouhallawa 2020-08-28 10:24:08 -0700 Created attachment 407479 Patch 1683685 2 407479 simon.fraser 2020-08-28 10:27:56 -0700 Comment on attachment 407479 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407479&action=review > Source/WTF/wtf/SystemTracing.h:-92 > - DisplayListReplayStart, > - DisplayListReplayEnd, Don't remove these, because the rest of the values will move and break viewing older traces. 1683691 3 407482 sabouhallawa 2020-08-28 10:37:21 -0700 Created attachment 407482 Patch 1683702 4 ews-feeder 2020-08-28 11:02:40 -0700 Committed r266286: <https://trac.webkit.org/changeset/266286> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407482. 1683703 5 webkit-bug-importer 2020-08-28 11:03:17 -0700 <rdar://problem/67950678> 407479 2020-08-28 10:24:08 -0700 2020-08-28 10:37:19 -0700 Patch bug-215933-20200828102407.patch text/plain 2738 sabouhallawa SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjYyODEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDIwLTA4LTI4ICBTYWlkIEFib3UtSGFsbGF3YSAg PHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHRoZSBzeXN0ZW0gdHJh Y2luZyBmcm9tIERpc3BsYXlMaXN0OjpSZXBsYXllcjo6cmVwbGF5KCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTkzMworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1N5c3RlbVRyYWNpbmcuaDoK KwogMjAyMC0wOC0yNyAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5jb20+CiAK ICAgICAgICAgW1BsYXlTdGF0aW9uXSBCdWlsZCBmaXggZHVlIHRvIG1lbW1lbSBub3QgYWx3YXlz IGJlaW5nIGF2YWlsYWJsZS4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL1N5c3RlbVRyYWNpbmcuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9TeXN0ZW1UcmFjaW5nLmgJKHJldmlzaW9uIDI2 NjI3OCkKKysrIFNvdXJjZS9XVEYvd3RmL1N5c3RlbVRyYWNpbmcuaAkod29ya2luZyBjb3B5KQpA QCAtODgsOCArODgsNiBAQCBlbnVtIFRyYWNlUG9pbnRDb2RlIHsKICAgICBEaXNwYXRjaFRvdWNo RXZlbnRzRW5kLAogICAgIFBhcnNlSFRNTFN0YXJ0LAogICAgIFBhcnNlSFRNTEVuZCwKLSAgICBE aXNwbGF5TGlzdFJlcGxheVN0YXJ0LAotICAgIERpc3BsYXlMaXN0UmVwbGF5RW5kLAogICAgIFNj cm9sbGluZ1RocmVhZFJlbmRlclVwZGF0ZVN5bmNTdGFydCwKICAgICBTY3JvbGxpbmdUaHJlYWRS ZW5kZXJVcGRhdGVTeW5jRW5kLAogICAgIFNjcm9sbGluZ1RocmVhZERpc3BsYXlEaWRSZWZyZXNo U3RhcnQsCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjYyNzgpCisrKyBTb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wOC0yOCAg U2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgorCisgICAgICAgIFJl bW92ZSB0aGUgc3lzdGVtIHRyYWNpbmcgZnJvbSBEaXNwbGF5TGlzdDo6UmVwbGF5ZXI6OnJlcGxh eSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU5 MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1v dmUgdGhpcyBleHBlbnNpdmUgdHJhY2luZyBwb2ludCBzaW5jZSBpdCBjYW4gYWZmZWN0IHRoZSB0 cmFjaW5nIG9mCisgICAgICAgIHRoZSBNb3Rpb25NYXJrIERlc2lnbiB0ZXN0LgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0UmVwbGF5ZXIuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheUxpc3Q6OlJlcGxheWVyOjpyZXBsYXkpOgorCiAy MDIwLTA4LTI4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xG Q11bSUZDXSBNb3ZlIGlubGluZSBhbGlnbm1lbnQgY29kZSB0byBMaW5lQm94CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RSZXBs YXllci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv ZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0UmVwbGF5ZXIuY3BwCShyZXZpc2lvbiAyNjYyNzgpCisr KyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxp c3RSZXBsYXllci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5LDcgKzI5LDYgQEAKICNpbmNsdWRl ICJEaXNwbGF5TGlzdEl0ZW1zLmgiCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5j bHVkZSAiTG9nZ2luZy5oIgotI2luY2x1ZGUgPHd0Zi9TeXN0ZW1UcmFjaW5nLmg+CiAjaW5jbHVk ZSA8d3RmL3RleHQvVGV4dFN0cmVhbS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC00Niw3 ICs0NSw2IEBAIFJlcGxheWVyOjp+UmVwbGF5ZXIoKSA9IGRlZmF1bHQ7CiAKIHN0ZDo6dW5pcXVl X3B0cjxEaXNwbGF5TGlzdD4gUmVwbGF5ZXI6OnJlcGxheShjb25zdCBGbG9hdFJlY3QmIGluaXRp YWxDbGlwLCBib29sIHRyYWNrUmVwbGF5TGlzdCkKIHsKLSAgICBUcmFjZVNjb3BlIHRyYWNpbmdT Y29wZShEaXNwbGF5TGlzdFJlcGxheVN0YXJ0LCBEaXNwbGF5TGlzdFJlcGxheUVuZCk7CiAgICAg TE9HX1dJVEhfU1RSRUFNKERpc3BsYXlMaXN0cywgc3RyZWFtIDw8ICJcblJlcGxheWluZyB3aXRo IGNsaXAgIiA8PCBpbml0aWFsQ2xpcCk7CiAgICAgVU5VU0VEX1BBUkFNKGluaXRpYWxDbGlwKTsK IAo= 407482 2020-08-28 10:37:21 -0700 2020-08-28 11:02:41 -0700 Patch bug-215933-20200828103720.patch text/plain 1646 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2NjI3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA4LTI4ICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHRo ZSBzeXN0ZW0gdHJhY2luZyBmcm9tIERpc3BsYXlMaXN0OjpSZXBsYXllcjo6cmVwbGF5KCkKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTkzMworCisg ICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAgICAgICBSZW1vdmUgdGhpcyBl eHBlbnNpdmUgdHJhY2luZyBwb2ludCBzaW5jZSBpdCBjYW4gYWZmZWN0IHRoZSB0cmFjaW5nIG9m CisgICAgICAgIHRoZSBNb3Rpb25NYXJrIERlc2lnbiB0ZXN0LgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0UmVwbGF5ZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RGlzcGxheUxpc3Q6OlJlcGxheWVyOjpyZXBsYXkpOgorCiAyMDIwLTA4LTI4 ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBN b3ZlIGlubGluZSBhbGlnbm1lbnQgY29kZSB0byBMaW5lQm94CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RSZXBsYXllci5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxp c3RzL0Rpc3BsYXlMaXN0UmVwbGF5ZXIuY3BwCShyZXZpc2lvbiAyNjYyNzgpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RSZXBsYXll ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5LDcgKzI5LDYgQEAKICNpbmNsdWRlICJEaXNwbGF5 TGlzdEl0ZW1zLmgiCiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiTG9n Z2luZy5oIgotI2luY2x1ZGUgPHd0Zi9TeXN0ZW1UcmFjaW5nLmg+CiAjaW5jbHVkZSA8d3RmL3Rl eHQvVGV4dFN0cmVhbS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC00Niw3ICs0NSw2IEBA IFJlcGxheWVyOjp+UmVwbGF5ZXIoKSA9IGRlZmF1bHQ7CiAKIHN0ZDo6dW5pcXVlX3B0cjxEaXNw bGF5TGlzdD4gUmVwbGF5ZXI6OnJlcGxheShjb25zdCBGbG9hdFJlY3QmIGluaXRpYWxDbGlwLCBi b29sIHRyYWNrUmVwbGF5TGlzdCkKIHsKLSAgICBUcmFjZVNjb3BlIHRyYWNpbmdTY29wZShEaXNw bGF5TGlzdFJlcGxheVN0YXJ0LCBEaXNwbGF5TGlzdFJlcGxheUVuZCk7CiAgICAgTE9HX1dJVEhf U1RSRUFNKERpc3BsYXlMaXN0cywgc3RyZWFtIDw8ICJcblJlcGxheWluZyB3aXRoIGNsaXAgIiA8 PCBpbml0aWFsQ2xpcCk7CiAgICAgVU5VU0VEX1BBUkFNKGluaXRpYWxDbGlwKTsKIAo=