215932 2020-08-28 09:48:26 -0700 [Cocoa] Disable sniffing for WebSocket handshakes 2020-08-31 01:59:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen darin webkit-bug-importer oldest_to_newest 1683671 0 youennf 2020-08-28 09:48:26 -0700 [Cocoa] Disable sniffing for WebSocket handshakes 1683672 1 407477 youennf 2020-08-28 09:51:21 -0700 Created attachment 407477 Patch 1683674 2 407477 darin 2020-08-28 10:08:09 -0700 Comment on attachment 407477 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407477&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1607 > + // FIXME: CFNetwork should probably disable sniffing by default for WebSocket handshakes. I don’t think a suggested change to CFNetwork should be covered by a FIXME in WebKit source code. 1684089 3 407591 youennf 2020-08-31 00:22:37 -0700 Created attachment 407591 Patch for landing 1684095 4 ews-feeder 2020-08-31 01:58:38 -0700 Committed r266347: <https://trac.webkit.org/changeset/266347> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407591. 1684096 5 webkit-bug-importer 2020-08-31 01:59:13 -0700 <rdar://problem/68060631> 407477 2020-08-28 09:51:21 -0700 2020-08-31 00:22:32 -0700 Patch bug-215932-20200828185120.patch text/plain 1891 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFhYWVjODNjZjJiYzU0YWZk ZmY2ZTM4Nzg4NDI3ZjY1NjJmYjA1MmYuLjQzMjA1MDdiYmE4MWExZTdhMDQ4YTFkOWEyYTRlY2U1 NmUzNTIwODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDgtMjggIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gRGlzYWJsZSBzbmlm ZmluZyBmb3IgV2ViU29ja2V0IGhhbmRzaGFrZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTkzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQgYnkgaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVz dHMvaHliaS9oYW5kc2hha2UtZXJyb3IuaHRtbCBubyBsb25nZXIgdGltaW5nIG91dCB3aXRoIE5T VVJMU2Vzc2lvbiBXZWJTb2NrZXQgY29kZSBwYXRoLgorCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0d29y a1Nlc3Npb25Db2NvYTo6Y3JlYXRlV2ViU29ja2V0VGFzayk6CisKIDIwMjAtMDgtMjggIFlvdWVu biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIEVuYWJsZSBpbnNwZWN0aW9u IG9mIFdlYlNvY2tldCB3aGVuIG9wZW5pbmcgV2ViIEluc3BlY3RvciBpbiB0aGUgbWlkZGxlIG9m IHRoZSBjb25uZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNz L2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KaW5kZXggODdjNmE3MGRmOTliYzc2ODJl MDczMzM2ZjRkNzlmMmI4ZjllYzA0Yi4uMzg3OTYwZWM1YWFmMmE2ZDAyMTg1NDk1MGJiNjQzZTgy Zjk2MDZiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9O ZXR3b3JrU2Vzc2lvbkNvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv Y29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQpAQCAtMTYwNCw2ICsxNjA0LDkgQEAgc3RkOjp1 bmlxdWVfcHRyPFdlYlNvY2tldFRhc2s+IE5ldHdvcmtTZXNzaW9uQ29jb2E6OmNyZWF0ZVdlYlNv Y2tldFRhc2soTmV0d29ya1MKICAgICAgICAgW3JlcXVlc3RXaXRoUHJvdG9jb2xzIGFkZFZhbHVl OiBTdHJpbmdWaWV3KHByb3RvY29sKS5jcmVhdGVOU1N0cmluZygpLmdldCgpIGZvckhUVFBIZWFk ZXJGaWVsZDpAIlNlYy1XZWJTb2NrZXQtUHJvdG9jb2wiXTsKICAgICAgICAgbnNSZXF1ZXN0ID0g cmVxdWVzdFdpdGhQcm90b2NvbHM7CiAgICAgfQorICAgIC8vIEZJWE1FOiBDRk5ldHdvcmsgc2hv dWxkIHByb2JhYmx5IGRpc2FibGUgc25pZmZpbmcgYnkgZGVmYXVsdCBmb3IgV2ViU29ja2V0IGhh bmRzaGFrZXMuCisgICAgW25zUmVxdWVzdCBfc2V0UHJvcGVydHk6QE5PIGZvcktleTooTlNTdHJp bmcgKilfa0NGVVJMQ29ubmVjdGlvblByb3BlcnR5U2hvdWxkU25pZmZdOworCiAgICAgUmV0YWlu UHRyPE5TVVJMU2Vzc2lvbldlYlNvY2tldFRhc2s+IHRhc2sgPSBbbV9zZXNzaW9uV2l0aENyZWRl bnRpYWxTdG9yYWdlLnNlc3Npb24gd2ViU29ja2V0VGFza1dpdGhSZXF1ZXN0Om5zUmVxdWVzdF07 CiAgICAgcmV0dXJuIG1ha2VVbmlxdWU8V2ViU29ja2V0VGFzaz4oY2hhbm5lbCwgV1RGTW92ZSh0 YXNrKSk7CiB9Cg== 407591 2020-08-31 00:22:37 -0700 2020-08-31 01:58:38 -0700 Patch for landing bug-215932-20200831092235.patch text/plain 1855 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDVlMjU3Zjg2Y2JmNjM1MTU0 MzVhNTZhYTg2OGI3NDkzOTE3ZjI0YWQuLjE0ZjA4NDJkMTA1OTMxNjVmZDE5M2FlNDU0MmIwNWQ3 NjQ1MjlhMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDgtMzEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFtDb2NvYV0gRGlzYWJsZSBzbmlm ZmluZyBmb3IgV2ViU29ja2V0IGhhbmRzaGFrZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTkzMgorCisgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgorCisgICAgICAgIENvdmVyZWQgYnkgaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMv aHliaS9oYW5kc2hha2UtZXJyb3IuaHRtbCBubyBsb25nZXIgdGltaW5nIG91dCB3aXRoIE5TVVJM U2Vzc2lvbiBXZWJTb2NrZXQgY29kZSBwYXRoLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mv Y29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Nl c3Npb25Db2NvYTo6Y3JlYXRlV2ViU29ja2V0VGFzayk6CisKIDIwMjAtMDgtMjggIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgU2l0ZXMgYnVpbHQgd2l0 aCBmbGFtYmUuanMgZG9uJ3Qgd29yayB3aXRoIHRyYWNrcGFkIG9uIGlQYWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5t bSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2Nv YS5tbQppbmRleCA4N2M2YTcwZGY5OWJjNzY4MmUwNzMzMzZmNGQ3OWYyYjhmOWVjMDRiLi45MDQz NmE0MDkyZGI4ZmJkYzYwNjRkMmVmZGIxZmE5NzdmOGZiNTQwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1t CkBAIC0xNjA0LDYgKzE2MDQsOSBAQCBzdGQ6OnVuaXF1ZV9wdHI8V2ViU29ja2V0VGFzaz4gTmV0 d29ya1Nlc3Npb25Db2NvYTo6Y3JlYXRlV2ViU29ja2V0VGFzayhOZXR3b3JrUwogICAgICAgICBb cmVxdWVzdFdpdGhQcm90b2NvbHMgYWRkVmFsdWU6IFN0cmluZ1ZpZXcocHJvdG9jb2wpLmNyZWF0 ZU5TU3RyaW5nKCkuZ2V0KCkgZm9ySFRUUEhlYWRlckZpZWxkOkAiU2VjLVdlYlNvY2tldC1Qcm90 b2NvbCJdOwogICAgICAgICBuc1JlcXVlc3QgPSByZXF1ZXN0V2l0aFByb3RvY29sczsKICAgICB9 CisgICAgLy8gcmRhcjovL3Byb2JsZW0vNjgwNTcwMzE6IGV4cGxpY2l0bHkgZGlzYWJsZSBzbmlm ZmluZyBmb3IgV2ViU29ja2V0IGhhbmRzaGFrZXMuCisgICAgW25zUmVxdWVzdCBfc2V0UHJvcGVy dHk6QE5PIGZvcktleTooTlNTdHJpbmcgKilfa0NGVVJMQ29ubmVjdGlvblByb3BlcnR5U2hvdWxk U25pZmZdOworCiAgICAgUmV0YWluUHRyPE5TVVJMU2Vzc2lvbldlYlNvY2tldFRhc2s+IHRhc2sg PSBbbV9zZXNzaW9uV2l0aENyZWRlbnRpYWxTdG9yYWdlLnNlc3Npb24gd2ViU29ja2V0VGFza1dp dGhSZXF1ZXN0Om5zUmVxdWVzdF07CiAgICAgcmV0dXJuIG1ha2VVbmlxdWU8V2ViU29ja2V0VGFz az4oY2hhbm5lbCwgV1RGTW92ZSh0YXNrKSk7CiB9Cg==