215931 2020-08-28 09:46:00 -0700 REGRESSION(r266187): ARGUMENT BAD: WebIconUtilities.mm(138) : RetainPtr<UIImage> WebKit::iconForFile(NSURL *) file, [file isFileURL] 2020-08-28 11:33:58 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hector_i_lopez achristensen achristensen webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1683668 0 hector_i_lopez 2020-08-28 09:46:00 -0700 7 Tests are constantly crashing after revision r266187 on iOS wk2 Debug. imported/w3c/web-platform-tests/FileAPI/file/send-file-form-iso-2022-jp.tentative.html https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2FFileAPI%2Ffile%2Fsend-file-form-iso-2022-jp.tentative.html&platform=ios&style=debug imported/w3c/web-platform-tests/FileAPI/file/send-file-form-utf-8.html https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2FFileAPI%2Ffile%2Fsend-file-form-utf-8.html&platform=ios&style=debug imported/w3c/web-platform-tests/FileAPI/file/send-file-form-windows-1252.tentative.html https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2FFileAPI%2Ffile%2Fsend-file-form-windows-1252.tentative.html&platform=ios&style=debug imported/w3c/web-platform-tests/FileAPI/file/send-file-form-x-user-defined.tentative.html https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2FFileAPI%2Ffile%2Fsend-file-form-x-user-defined.tentative.html&platform=ios&style=debug imported/w3c/web-platform-tests/FileAPI/file/send-file-form.html https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2FFileAPI%2Ffile%2Fsend-file-form.html&style=debug&platform=ios imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/submit-file.sub.html https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fhtml%2Fsemantics%2Fforms%2Fform-submission-0%2Fsubmit-file.sub.html&platform=ios&style=debug imported/w3c/web-platform-tests/service-workers/service-worker/data-transfer-files.https.html https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Fdata-transfer-files.https.html&platform=ios&style=debug Crash log: Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.JavaScriptCore 0x0000000235beea0e WTFCrash + 14 (Assertions.cpp:295) 1 com.apple.WebKit 0x00000002209d27ee WebKit::iconForFile(NSURL*) + 94 (WebIconUtilities.mm:138) 2 com.apple.WebKit 0x0000000221258a2e WebKit::WebChromeClient::createIconForFiles(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) + 158 (WebChromeClientIOS.mm:157) 3 com.apple.WebKit 0x00000002216a0240 WebKit::WebChromeClient::loadIconForFiles(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FileIconLoader&) + 48 (WebChromeClient.cpp:807) 4 com.apple.WebCore 0x0000000240bc8fa0 WebCore::Chrome::loadIconForFiles(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FileIconLoader&) + 48 (Chrome.cpp:478) 5 com.apple.WebCore 0x000000024025c18f WebCore::FileInputType::requestIcon(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) + 319 (FileInputType.cpp:331) Stderr: ARGUMENT BAD: file, [file isFileURL] /Volumes/Data/slave/ios-simulator-13-debug/build/Source/WebKit/Shared/ios/WebIconUtilities.mm(138) : RetainPtr<UIImage> WebKit::iconForFile(NSURL *) 1 0x3b5beea09 WTFCrash 2 0x3a09d27ee WebKit::iconForFile(NSURL*) 3 0x3a1258a2e WebKit::WebChromeClient::createIconForFiles(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) 4 0x3a16a0240 WebKit::WebChromeClient::loadIconForFiles(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FileIconLoader&) 5 0x3c0bc8fa0 WebCore::Chrome::loadIconForFiles(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&, WebCore::FileIconLoader&) 6 0x3c025c18f WebCore::FileInputType::requestIcon(WTF::Vector<WTF::String, 0ul, WTF::CrashOnOverflow, 16ul, WTF::FastMalloc> const&) 7 0x3c025c97e WebCore::FileInputType::setFiles(WTF::RefPtr<WebCore::FileList, WTF::DumbPtrTraits<WebCore::FileList> >&&, WebCore::FileInputType::RequestIcon) 8 0x3c025c6d2 WebCore::FileInputType::setFiles(WTF::RefPtr<WebCore::FileList, WTF::DumbPtrTraits<WebCore::FileList> >&&) 9 0x3c0323ba2 WebCore::HTMLInputElement::setFiles(WTF::RefPtr<WebCore::FileList, WTF::DumbPtrTraits<WebCore::FileList> >&&) 10 0x3be158d9c WebCore::setJSHTMLInputElementFilesSetter(JSC::JSGlobalObject&, WebCore::JSHTMLInputElement&, JSC::JSValue)::'lambda'()::operator()() const 11 0x3be158b2d std::__1::enable_if<std::is_same<void, decltype(fp1())>::value, void>::type WebCore::AttributeSetter::call<WebCore::setJSHTMLInputElementFilesSetter(JSC::JSGlobalObject&, WebCore::JSHTMLInputElement&, JSC::JSValue)::'lambda'()>(JSC::JSGlobalObject&, JSC::ThrowScope&, WebCore::setJSHTMLInputElementFilesSetter(JSC::JSGlobalObject&, WebCore::JSHTMLInputElement&, JSC::JSValue)::'lambda'()&&) 12 0x3be158a93 WebCore::setJSHTMLInputElementFilesSetter(JSC::JSGlobalObject&, WebCore::JSHTMLInputElement&, JSC::JSValue) 13 0x3be07975e bool WebCore::IDLAttribute<WebCore::JSHTMLInputElement>::set<&(WebCore::setJSHTMLInputElementFilesSetter(JSC::JSGlobalObject&, WebCore::JSHTMLInputElement&, JSC::JSValue)), (WebCore::CastedThisErrorBehavior)0>(JSC::JSGlobalObject&, long long, long long, char const*) 14 0x3be0795fc WebCore::setJSHTMLInputElementFiles(JSC::JSGlobalObject*, long long, long long) 15 0x3b73c704e JSC::callCustomSetter(JSC::JSGlobalObject*, bool (*)(JSC::JSGlobalObject*, long long, long long), bool, JSC::JSValue, JSC::JSValue) 16 0x3b73c7122 JSC::callCustomSetter(JSC::JSGlobalObject*, JSC::JSValue, bool, JSC::JSObject*, JSC::JSValue, JSC::JSValue) 17 0x3b75bf30e JSC::JSObject::putInlineSlow(JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) 18 0x3b7310d31 JSC::JSObject::putInlineForJSObject(JSC::JSCell*, JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) 19 0x3b6c75338 JSC::JSCell::putInline(JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) 20 0x3b6c76a33 JSC::JSValue::putInline(JSC::JSGlobalObject*, JSC::PropertyName, JSC::JSValue, JSC::PutPropertySlot&) 21 0x3b71219cb llint_slow_path_put_by_id 22 0x3b6164c31 llint_entry 23 0x3b6179f85 llint_entry 24 0x3b6179f85 llint_entry 25 0x3b617a028 llint_entry 26 0x3b6179f85 llint_entry 27 0x3b6159943 vmEntryToJavaScript 28 0x3b6feaa9b JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 29 0x3b6feb257 JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 30 0x3b737e8dd JSC::call(JSC::JSGlobalObject*, JSC::JSValue, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) 31 0x3b737ebb3 JSC::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) LEAK: 2 WebPageProxy 1683669 1 webkit-bug-importer 2020-08-28 09:46:22 -0700 <rdar://problem/67945906> 1683696 2 407483 achristensen 2020-08-28 10:47:27 -0700 Created attachment 407483 Patch 1683723 3 ews-feeder 2020-08-28 11:33:57 -0700 Committed r266287: <https://trac.webkit.org/changeset/266287> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407483. 407483 2020-08-28 10:47:27 -0700 2020-08-28 11:33:58 -0700 Patch bug-215931-20200828104726.patch text/plain 2040 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjYyODQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA4LTI4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjY2MTg3KTogQVJHVU1FTlQgQkFEOiBXZWJJY29uVXRpbGl0aWVzLm1tKDEzOCkgOiBSZXRhaW5Q dHI8VUlJbWFnZT4gV2ViS2l0OjppY29uRm9yRmlsZShOU1VSTCAqKSBmaWxlLCBbZmlsZSBpc0Zp bGVVUkxdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MTU5MzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJ dCdzIHBvc3NpYmxlIGZvciBKYXZhU2NyaXB0IHRvIG1ha2UgYSBmaWxlbmFtZSB0aGF0IGRvZXNu J3QgY29udmVydCB0byBhIGZpbGUgVVJMLCBzdWNoIGFzIHRoZSBlbXB0eSBzdHJpbmcuCisgICAg ICAgIFdoZW4gdGhpcyBoYXBwZW5zLCB3ZSB3b3VsZCd2ZSByZXR1cm5lZCBudWxsIGZvciB0aGUg aWNvbiBsYXRlciBhbnl3YXlzLCBidXQgYWRkaW5nIGEgbnVsbCBjaGVjayBwcmV2ZW50cyBhbiBh c3NlcnRpb24uCisgICAgICAgIENvdmVyZWQgYnkgNyBleGlzdGluZyB0ZXN0cyB3aGljaCB3b3Vs ZCBoYXZlIGhpdCB0aGF0IGFzc2VydGlvbi4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViQ29y ZVN1cHBvcnQvaW9zL1dlYkNocm9tZUNsaWVudElPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2Vi Q2hyb21lQ2xpZW50OjpjcmVhdGVJY29uRm9yRmlsZXMpOgorCiAyMDIwLTA4LTI4ICBZb3Vlbm4g RmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgVHJhbnNmb3JtU3Ry ZWFtIGJ5IGRlZmF1bHQKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3Vw cG9ydC9pb3MvV2ViQ2hyb21lQ2xpZW50SU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9pb3MvV2ViQ2hyb21lQ2xpZW50SU9TLm1tCShy ZXZpc2lvbiAyNjYyNzkpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBv cnQvaW9zL1dlYkNocm9tZUNsaWVudElPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTU0LDcgKzE1 NCwxMSBAQCBSZWZQdHI8SWNvbj4gV2ViQ2hyb21lQ2xpZW50OjpjcmVhdGVJY29uCiAKICAgICAv LyBGSVhNRTogV2Ugc2hvdWxkIGdlbmVyYXRlIGFuIGljb24gc2hvd2luZyBtdWx0aXBsZSBmaWxl cyBoZXJlLCBpZiBhcHBsaWNhYmxlLiBDdXJyZW50bHksIGlmIHRoZXJlIGFyZSBtdWx0aXBsZQog ICAgIC8vIGZpbGVzLCB3ZSBvbmx5IHVzZSB0aGUgZmlyc3QgVVJMIHRvIGdlbmVyYXRlIGFuIGlj b24uCi0gICAgcmV0dXJuIEljb246OmNyZWF0ZUljb25Gb3JJbWFnZShpY29uRm9yRmlsZShbTlNV UkwgZmlsZVVSTFdpdGhQYXRoOmZpbGVuYW1lc1swXSBpc0RpcmVjdG9yeTpOT10pLmdldCgpLkNH SW1hZ2UpOworICAgIE5TVVJMICp1cmwgPSBbTlNVUkwgZmlsZVVSTFdpdGhQYXRoOmZpbGVuYW1l c1swXSBpc0RpcmVjdG9yeTpOT107CisgICAgaWYgKCF1cmwpCisgICAgICAgIHJldHVybiBudWxs cHRyOworCisgICAgcmV0dXJuIEljb246OmNyZWF0ZUljb25Gb3JJbWFnZShpY29uRm9yRmlsZSh1 cmwpLmdldCgpLkNHSW1hZ2UpOwogfQogCiB2b2lkIFdlYkNocm9tZUNsaWVudDo6YXNzb2NpYXRl RWRpdGFibGVJbWFnZVdpdGhBdHRhY2htZW50KEdyYXBoaWNzTGF5ZXI6OkVtYmVkZGVkVmlld0lE IGVtYmVkZGVkVmlld0lELCBjb25zdCBTdHJpbmcmIGF0dGFjaG1lbnRJRCkK