215924 2020-08-28 07:18:03 -0700 [WPE] Enable Notifications support 2020-08-28 15:10:02 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215950 P2 Normal --- 1 pnormand aperez annulen aperez bugs-noreply cgarcia clopez ews-watchlist gyuyoung.kim pnormand ryuan.choi sergio oldest_to_newest 1683631 0 pnormand 2020-08-28 07:18:03 -0700 Why is this disabled? It doesn't seem to pull additional build-time dependencies here. 1683638 1 aperez 2020-08-28 07:58:30 -0700 I think we should enable this by default. For the WPE port I think it is fine to let the default implementation be a stub that does nothing (so not even libnotify is needed at build time) so embedders can decide how to show notifications connecting to the WebKitWebView::show-notification signal. 1683650 2 407471 aperez 2020-08-28 08:46:33 -0700 Created attachment 407471 Patch 1683652 3 407471 pnormand 2020-08-28 08:56:58 -0700 Comment on attachment 407471 Patch Maybe this could allow us to unskip some of http/tests/notifications ? 1683653 4 pnormand 2020-08-28 08:57:32 -0700 and imported/w3c/web-platform-tests/notifications 1683656 5 aperez 2020-08-28 09:00:22 -0700 (In reply to Philippe Normand from comment #3) > Comment on attachment 407471 [details] > Patch > > Maybe this could allow us to unskip some of http/tests/notifications ? Probably, I'll give it a try before landing. 1683761 6 aperez 2020-08-28 14:23:17 -0700 Regarding layout tests: - All the tests under http/tests/notifications/ pass. - All but one under imported/w3c/web-platform-tests/notifications/ pass, too. - imported/w3c/web-platform-tests/notifications/shownotification-resolve-manual.https.html gives a timeout, I'll mark it “[ Timeout Pass ]” for now. 1683770 7 407501 aperez 2020-08-28 14:35:33 -0700 Created attachment 407501 Patch for landing 1683784 8 ews-feeder 2020-08-28 15:10:00 -0700 Committed r266297: <https://trac.webkit.org/changeset/266297> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407501. 407471 2020-08-28 08:46:33 -0700 2020-08-28 14:35:27 -0700 Patch bug-215924-20200828184632.patch text/plain 1982 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2Mjc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IGI0ZDNl M2EyZDMwMDQ5YzIxYTQ0MTZjNTFjZjFlNzQ3ZTg1YWY5YjQuLmNjM2E0MjkwZWIyNGZkMDk5MjE5 MDVhMDFjMzdlMmZhM2M2ZDljOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BF LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC02Nyw3ICs2Nyw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9MQVlPVVRfRk9STUFU VElOR19DT05URVhUIFBSSVZBVEUgJHtFTkFCCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfTUVESUFfU1RSRUFNIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZF QVRVUkVTfSkKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NSFRNTCBQ UklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX05FVFND QVBFX1BMVUdJTl9BUEkgUFJJVkFURSBPRkYpCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfTk9USUZJQ0FUSU9OUyBQUklWQVRFIE9GRikKK1dFQktJVF9PUFRJT05fREVG QVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9OT1RJRklDQVRJT05TIFBSSVZBVEUgT04pCiBXRUJLSVRf T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTkVUV09SS19DQUNIRV9TVEFMRV9XSElM RV9SRVZBTElEQVRFIFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShFTkFCTEVfT0ZGU0NSRUVOX0NBTlZBUyBQUklWQVRFICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9G RUFUVVJFU30pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfUEVSSU9E SUNfTUVNT1JZX01PTklUT1IgUFJJVkFURSBPTikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0No YW5nZUxvZwppbmRleCAyOWNmZDM3M2I1YWU4OWIyMzJhMjIyMzllOWQ3Yjk1OTViM2FlZjkzLi5k OWQ3M2YzYTBkNDljNWQyNTFhZDAwM2I5MmI0NjExZGUxYTM3ZTUxIDEwMDY0NAotLS0gYS9DaGFu Z2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDgtMjggIEFkcmlh biBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBF bmFibGUgTm90aWZpY2F0aW9ucyBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU5MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBFbmFibGUgd2ViIG5vdGlmaWNhdGlvbnMgc3VwcG9ydCBmb3Ig dGhlIFdQRSBwb3J0LiBUaGUgY29kZSBpcyBzaGFyZWQgd2l0aCB0aGUgR1RLCisgICAgICAgIHBv cnQsIGJ1dCBhcyB3ZSBkbyBub3QgdHJ5IHRvIGZpbmQgYW5kIGVuYWJsZSBsaWJub3RpZnkgdGhl IGRlZmF1bHQgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaXMgYSBzdHViOiBlbWJlZGRlcnMgY2Fu IGN1c3RvbWl6ZSBob3cgdG8gZGlzcGxheSBub3RpZmljYXRpb25zIGJ5IGNvbm5lY3RpbmcgdG8K KyAgICAgICAgdGhlIFdlYktpdFdlYlZpZXc6c2hvdy1ub3RpZmljYXRpb24gc2lnbmFsLiBUaGlz IHdheSB3ZSBkbyBub3QgYWRkIGFueSBhZGRpdGlvbmFsCisgICAgICAgIGJ1aWxkIGRlcGVuZGVu Y2llcy4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOiBGbGlwIEVO QUJMRV9OT1RJRklDQVRJT05TIHRvIE9OLgorCiAyMDIwLTA4LTI3ICBTdGVwaGFuIFN6YWJvICA8 c3RlcGhhbi5zemFib0Bzb255LmNvbT4KIAogICAgICAgICBbUGxheVN0YXRpb25dIEJ1aWxkIGZp eCBkdWUgdG8gbWVtbWVtIG5vdCBhbHdheXMgYmVpbmcgYXZhaWxhYmxlLgo= 407501 2020-08-28 14:35:33 -0700 2020-08-28 15:10:01 -0700 Patch for landing bug-215924-20200829003532.patch text/plain 4238 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MjkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IGI0ZDNl M2EyZDMwMDQ5YzIxYTQ0MTZjNTFjZjFlNzQ3ZTg1YWY5YjQuLmNjM2E0MjkwZWIyNGZkMDk5MjE5 MDVhMDFjMzdlMmZhM2M2ZDljOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BF LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC02Nyw3ICs2Nyw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9MQVlPVVRfRk9STUFU VElOR19DT05URVhUIFBSSVZBVEUgJHtFTkFCCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfTUVESUFfU1RSRUFNIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVOVEFMX0ZF QVRVUkVTfSkKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9NSFRNTCBQ UklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX05FVFND QVBFX1BMVUdJTl9BUEkgUFJJVkFURSBPRkYpCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfTk9USUZJQ0FUSU9OUyBQUklWQVRFIE9GRikKK1dFQktJVF9PUFRJT05fREVG QVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9OT1RJRklDQVRJT05TIFBSSVZBVEUgT04pCiBXRUJLSVRf T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTkVUV09SS19DQUNIRV9TVEFMRV9XSElM RV9SRVZBTElEQVRFIFBSSVZBVEUgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxV RShFTkFCTEVfT0ZGU0NSRUVOX0NBTlZBUyBQUklWQVRFICR7RU5BQkxFX0VYUEVSSU1FTlRBTF9G RUFUVVJFU30pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfUEVSSU9E SUNfTUVNT1JZX01PTklUT1IgUFJJVkFURSBPTikKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAyMmUzMThhYTc0Njc2YzkwNjJj MDAyYjE5ODhjNjMzMzhkYWRiZTc4Li5iZjk3Y2UzNzhlMmEyMTU2ZTcyMGRmOTRkYzUzY2Y3NDhh MjZhYWU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDgtMjggIEFkcmlhbiBQZXJleiBk ZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBFbmFibGUgTm90 aWZpY2F0aW9ucyBzdXBwb3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTU5MjQKKworICAgICAgICBSZXZpZXdlZCBieSBQaGlsaXBwZSBOb3JtYW5k LgorCisgICAgICAgICogcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnM6IFVwZGF0ZSB0ZXN0 IGV4cGVjdGF0aW9ucy4KKwogMjAyMC0wOC0yNyAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBWZXJ0aWNhbCBzY3JvbGxpbmcgZ2V0cyBzdHVjayB3aGVu IGEgaG9yaXpvbnRhbCBzY3JvbGxlciBpcyB1bmRlciB0aGUgbW91c2UgKGdvb2dsZSBzZWFyY2gg cmVzdWx0cykKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dwZS9UZXN0RXhwZWN0 YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXgg NjAyMTYyYjJhMTExNTY0ZTRkZTE4OWMzMjBiNzc1NzVkNzBiOGFlNC4uM2JmMTRhMGU1YzRkYTEw MDgwOTAxN2FlZmJiNjg5OTZmMzBiYWUxMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vd3BlL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd3BlL1Rl c3RFeHBlY3RhdGlvbnMKQEAgLTY5NCw3ICs2OTQsNiBAQCBodHRwL3Rlc3RzL2luc3BlY3RvciBb IFNraXAgXQogaHR0cC90ZXN0cy9sb2NhbCBbIFNraXAgXQogaHR0cC90ZXN0cy9tZWRpYSBbIFNr aXAgXQogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3BpbmctYXR0cmlidXRlLyBbIFNraXAgXQotaHR0 cC90ZXN0cy9ub3RpZmljYXRpb25zIFsgU2tpcCBdCiBodHRwL3Rlc3RzL3BvaW50ZXItbG9jayBb IFNraXAgXQogaHR0cC90ZXN0cy9zZWN1cml0eSBbIFNraXAgXQogCkBAIC03MTIsNyArNzExLDYg QEAgd2Via2l0Lm9yZy9iLzE3NTQxOSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3Nl cnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmsKIEJ1ZyhXUEUpIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvbWVkaWFjYXB0dXJlLWZyb21lbGVtZW50IFsgU2tpcCBdCiBCdWcoV1BFKSBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlhY2FwdHVyZS1zdHJlYW1zIFsgU2tp cCBdCiBCdWcoV1BFKSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL21lZGlhLXNvdXJj ZSBbIFNraXAgXQotQnVnKFdQRSkgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9ub3Rp ZmljYXRpb25zIFsgU2tpcCBdCiBCdWcoV1BFKSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL3dlYnJ0YyBbIFNraXAgXQogCiBCdWcoV1BFKSBmYXN0L2RvbS9EZXZpY2VNb3Rpb24gWyBT a2lwIF0KQEAgLTk4Miw2ICs5ODAsOCBAQCB3ZWJraXQub3JnL2IvMTgxNTM0IHBlcmYvc2hvdy1o aWRlLXRhYmxlLXJvd3MuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAKIHdlYmtpdC5vcmcvYi8xODc1 OTMgaHR0cC90ZXN0cy9jYWNoZS9kaXNrLWNhY2hlL2Rpc2stY2FjaGUtY2FuY2VsLmh0bWwgWyBG YWlsdXJlIFBhc3MgXQogCit3ZWJraXQub3JnL2IvMjE1OTUwIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvbm90aWZpY2F0aW9ucy9zaG93bm90aWZpY2F0aW9uLXJlc29sdmUtbWFudWFs Lmh0dHBzLmh0bWwgWyBUaW1lb3V0IFBhc3MgXQorCiB3ZWJraXQub3JnL2IvMTg3NTk0IGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvSW5kZXhlZERCL2lkYm9iamVjdHN0b3JlX2NyZWF0 ZUluZGV4Ny1ldmVudF9vcmRlci5odG0gWyBGYWlsdXJlIFBhc3MgXQogCiB3ZWJraXQub3JnL2Iv MTg3NTkwIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViLWFuaW1hdGlvbnMvdGlt aW5nLW1vZGVsL3RpbWVsaW5lcy9kb2N1bWVudC10aW1lbGluZXMuaHRtbCBbIEZhaWx1cmUgUGFz cyBdCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjljZmQzNzNiNWFl ODliMjMyYTIyMjM5ZTlkN2I5NTk1YjNhZWY5My4uZWY1ZTQ3YTc3NjE5ZjhlYWNjZWQ4MDI2MTc1 YTkyNDliNjcwODA0ZSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIwLTA4LTI4ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6 QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gRW5hYmxlIE5vdGlmaWNhdGlvbnMgc3VwcG9y dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1OTI0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUGhpbGlwcGUgTm9ybWFuZC4KKworICAgICAgICBFbmFi bGUgd2ViIG5vdGlmaWNhdGlvbnMgc3VwcG9ydCBmb3IgdGhlIFdQRSBwb3J0LiBUaGUgY29kZSBp cyBzaGFyZWQgd2l0aCB0aGUgR1RLCisgICAgICAgIHBvcnQsIGJ1dCBhcyB3ZSBkbyBub3QgdHJ5 IHRvIGZpbmQgYW5kIGVuYWJsZSBsaWJub3RpZnkgdGhlIGRlZmF1bHQgaW1wbGVtZW50YXRpb24K KyAgICAgICAgaXMgYSBzdHViOiBlbWJlZGRlcnMgY2FuIGN1c3RvbWl6ZSBob3cgdG8gZGlzcGxh eSBub3RpZmljYXRpb25zIGJ5IGNvbm5lY3RpbmcgdG8KKyAgICAgICAgdGhlIFdlYktpdFdlYlZp ZXc6c2hvdy1ub3RpZmljYXRpb24gc2lnbmFsLiBUaGlzIHdheSB3ZSBkbyBub3QgYWRkIGFueSBh ZGRpdGlvbmFsCisgICAgICAgIGJ1aWxkIGRlcGVuZGVuY2llcy4KKworICAgICAgICAqIFNvdXJj ZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOiBGbGlwIEVOQUJMRV9OT1RJRklDQVRJT05TIHRvIE9O LgorCiAyMDIwLTA4LTI3ICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4K IAogICAgICAgICBbUGxheVN0YXRpb25dIEJ1aWxkIGZpeCBkdWUgdG8gbWVtbWVtIG5vdCBhbHdh eXMgYmVpbmcgYXZhaWxhYmxlLgo=