215896 2020-08-27 11:32:07 -0700 CSS invert() and opacity() filter implementations should use linear transfer functions for clarity and simplicity 2020-08-27 18:24:22 -0700 1 1 1 Unclassified WebKit CSS Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 frankhome61 frankhome61 changseok darin dino esprehn+autocc ews-watchlist glenn kondapallykalyan mmaxfield pdr webkit-bug-importer oldest_to_newest 1683440 0 frankhome61 2020-08-27 11:32:07 -0700 In WebKit's implementation of CSS filters invert() and opacity(), FEComponentTransfer is used and the transfer function is surprisingly to table, instead of linear. Looking at the CSS spec, https://drafts.fxtf.org/filter-effects/#invertEquivalent invert() and opacity() is implemented using "table" with just 2 values, which is equivalent to using a linear function. I propose to change the implementation of invert() and opacity() to use linear transfer function as well for simplicity and clarity. 1683441 1 webkit-bug-importer 2020-08-27 11:32:37 -0700 <rdar://problem/67887069> 1683443 2 407421 frankhome61 2020-08-27 11:45:35 -0700 Created attachment 407421 Patch 1683542 3 407421 darin 2020-08-27 17:50:28 -0700 Comment on attachment 407421 Patch Does this have any effect on performance? 1683544 4 frankhome61 2020-08-27 18:06:35 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 407421 [details] > Patch > > Does this have any effect on performance? No, not that I know of. By looking at the code, FEComponentTransfer eventually converts linear, discrete table transfer functions to a hash map that maps each R,G,B values to a new value by applying the transfer function. So I don't expect this patch to cause any performance hit at all 1683547 5 ews-feeder 2020-08-27 18:24:21 -0700 Committed r266266: <https://trac.webkit.org/changeset/266266> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407421. 407421 2020-08-27 11:45:35 -0700 2020-08-27 18:24:21 -0700 Patch bug-215896-20200827114534.patch text/plain 4112 frankhome61 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1OTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZiY2MxZTA3ZGFkZDBm NDdkNmRjOGVkZjAxMDRkYTI0MWQyNTQyMC4uYWExMGRhYTcxMTExNDBhODI3YTdhZWI1NmM2YWEw NjE5OTFkZGY5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA4LTI3ICBGcmFu ayBZYW5nICA8Z3Vvd2VpX3lhbmdAYXBwbGUuY29tPgorCisgICAgICAgIENTUyBGaWx0ZXIgaW52 ZXJ0KCkgYW5kIG9wYWNpdHkoKSBJbXBsZW1lbnRhdGlvbiBTaG91bGQgVXNlIExpbmVhciBUcmFu c2ZlciBGdW5jdGlvbiBmb3IgQ2xhcml0eSBhbmQgU2ltcGxpY2l0eQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1ODk2CisKKyAgICAgICAgU2ltcGxp ZnkgQ1NTIGZpbHRlcnMsIGludmVydCgpIGFuZCBvcGFjaXR5KCkgaW1wbGVtZW50YXRpb24gYnkg dXNpbmcgImxpbmVhciIgdHJhbnNmZXIgZnVuY3Rpb24sIAorICAgICAgICBpbnN0ZWFkIG9mIHVz aW5nIGEgbW9yZSBjb25mdXNpbmcgdHJhbnNmZXIgZnVuY3Rpb24sICJ0YWJsZSIuIEZvciBpbnZl cnQoKSwgdGhlIHRyYW5zZmVyIGZ1bmN0aW9uIAorICAgICAgICBpcyB0eXBlPSJ0YWJsZSIgdGFi bGVWYWx1ZXM9IlthbW91bnRdICgxIC0gW2Ftb3VudF0pIiwgd2hpY2ggaXMgZXF1aXZhbGVudCB0 byBhIGxpbmVhciBmdW5jdGlvbgorICAgICAgICBvZiBzbG9wZSAxIC0gMiAqIFthbW91bnRdIGFu ZCBpbnRlcmNlcHQgW2Ftb3VudF07IGZvciBvcGFjaXR5IHRoZSB0cmFuc2ZlciBmdW5jdGlvbiBp cyB0eXBlPSJ0YWJsZSIgdGFibGVWYWx1ZXM9IjAgW2Ftb3VudF0iCisgICAgICAgIHdoaWNoIGlz IGVxdWl2YWxlbnQgdG8gYSBsaW5lYXIgdHJhbnNmZXIgZnVuY3Rpb24gb2Ygc2xvcGUgW2Ftb3Vu dF0gYW5kIGludGVyY2VwdCAwLiBUaGlzIGNoYW5nZSB3aWxsIG1ha2UgdGhlIGltcGxlbWVudGF0 aW9uIAorICAgICAgICBjbGVhcmVyIGFuZCBzaW1wbGVyLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQsIHVzaW5nIGV4 aXN0aW5nIHRlc3RzIGluIGNzcy9maWx0ZXItZWZmZWN0cworCisgICAgICAgICogcmVuZGVyaW5n L0NTU0ZpbHRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDU1NGaWx0ZXI6OmJ1aWxkKTogTW9k aWZpZWQgdGhlIGltcGxlbWVudGF0aW9uIG9mIGludmVydCgpIGFuZCBvcGFjaXR5KCkgc28gdGhh dCB0aGV5IGJvdGggdXNlIAorICAgICAgICAgICAgIGEgbGluZWFyIGNvbXBvbmVudCB0cmFuc2Zl ciBmdW5jdGlvbiBpbnN0ZWFkIG9mIGEgbW9yZSBjb25mdXNpbmcgdGFibGUgdHJhbnNmZXIgZnVu Y3Rpb24uCisKKwogMjAyMC0wOC0yMCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIEF1ZGlvQnVmZmVyU291cmNlTm9kZSBzaG91bGQgdXNlICJmaW5hbCIgdmFsdWVz IGZvciBwbGF5YmFja1JhdGUgYW5kIGRldHVuZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL0NTU0ZpbHRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQ1NTRmls dGVyLmNwcAppbmRleCA1M2U5Mjk1NDRhM2E4MGY5Yjc5NWY4NDhlMjkwMDQyYmViZDA5NDMxLi5h ZmViOTI5NTUzNTM0Mjc4MDJjZTI5MDYwN2RhMWE4OTdjZjhjYTIwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvQ1NTRmlsdGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvQ1NTRmlsdGVyLmNwcApAQCAtMjIxLDExICsyMjEsMTAgQEAgYm9vbCBDU1NGaWx0 ZXI6OmJ1aWxkKFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyLCBjb25zdCBGaWx0ZXJPcGVyYXRpb25z JiBvcGVyYXRpb24KICAgICAgICAgY2FzZSBGaWx0ZXJPcGVyYXRpb246OklOVkVSVDogewogICAg ICAgICAgICAgYXV0byYgY29tcG9uZW50VHJhbnNmZXJPcGVyYXRpb24gPSBkb3duY2FzdDxCYXNp Y0NvbXBvbmVudFRyYW5zZmVyRmlsdGVyT3BlcmF0aW9uPihmaWx0ZXJPcGVyYXRpb24pOwogICAg ICAgICAgICAgQ29tcG9uZW50VHJhbnNmZXJGdW5jdGlvbiB0cmFuc2ZlckZ1bmN0aW9uOwotICAg ICAgICAgICAgdHJhbnNmZXJGdW5jdGlvbi50eXBlID0gRkVDT01QT05FTlRUUkFOU0ZFUl9UWVBF X1RBQkxFOwotICAgICAgICAgICAgVmVjdG9yPGZsb2F0PiB0cmFuc2ZlclBhcmFtZXRlcnM7Ci0g ICAgICAgICAgICB0cmFuc2ZlclBhcmFtZXRlcnMuYXBwZW5kKG5hcnJvd1ByZWNpc2lvblRvRmxv YXQoY29tcG9uZW50VHJhbnNmZXJPcGVyYXRpb24uYW1vdW50KCkpKTsKLSAgICAgICAgICAgIHRy YW5zZmVyUGFyYW1ldGVycy5hcHBlbmQobmFycm93UHJlY2lzaW9uVG9GbG9hdCgxIC0gY29tcG9u ZW50VHJhbnNmZXJPcGVyYXRpb24uYW1vdW50KCkpKTsKLSAgICAgICAgICAgIHRyYW5zZmVyRnVu Y3Rpb24udGFibGVWYWx1ZXMgPSB0cmFuc2ZlclBhcmFtZXRlcnM7CisgICAgICAgICAgICB0cmFu c2ZlckZ1bmN0aW9uLnR5cGUgPSBGRUNPTVBPTkVOVFRSQU5TRkVSX1RZUEVfTElORUFSOworICAg ICAgICAgICAgZmxvYXQgYW1vdW50ID0gbmFycm93UHJlY2lzaW9uVG9GbG9hdChjb21wb25lbnRU cmFuc2Zlck9wZXJhdGlvbi5hbW91bnQoKSk7CisgICAgICAgICAgICB0cmFuc2ZlckZ1bmN0aW9u LnNsb3BlID0gMSAtIDIgKiBhbW91bnQ7CisgICAgICAgICAgICB0cmFuc2ZlckZ1bmN0aW9uLmlu dGVyY2VwdCA9IGFtb3VudDsKIAogICAgICAgICAgICAgQ29tcG9uZW50VHJhbnNmZXJGdW5jdGlv biBudWxsRnVuY3Rpb247CiAgICAgICAgICAgICBlZmZlY3QgPSBGRUNvbXBvbmVudFRyYW5zZmVy OjpjcmVhdGUoKnRoaXMsIHRyYW5zZmVyRnVuY3Rpb24sIHRyYW5zZmVyRnVuY3Rpb24sIHRyYW5z ZmVyRnVuY3Rpb24sIG51bGxGdW5jdGlvbik7CkBAIC0yMzcsMTEgKzIzNiwxMCBAQCBib29sIENT U0ZpbHRlcjo6YnVpbGQoUmVuZGVyRWxlbWVudCYgcmVuZGVyZXIsIGNvbnN0IEZpbHRlck9wZXJh dGlvbnMmIG9wZXJhdGlvbgogICAgICAgICBjYXNlIEZpbHRlck9wZXJhdGlvbjo6T1BBQ0lUWTog ewogICAgICAgICAgICAgYXV0byYgY29tcG9uZW50VHJhbnNmZXJPcGVyYXRpb24gPSBkb3duY2Fz dDxCYXNpY0NvbXBvbmVudFRyYW5zZmVyRmlsdGVyT3BlcmF0aW9uPihmaWx0ZXJPcGVyYXRpb24p OwogICAgICAgICAgICAgQ29tcG9uZW50VHJhbnNmZXJGdW5jdGlvbiB0cmFuc2ZlckZ1bmN0aW9u OwotICAgICAgICAgICAgdHJhbnNmZXJGdW5jdGlvbi50eXBlID0gRkVDT01QT05FTlRUUkFOU0ZF Ul9UWVBFX1RBQkxFOwotICAgICAgICAgICAgVmVjdG9yPGZsb2F0PiB0cmFuc2ZlclBhcmFtZXRl cnM7Ci0gICAgICAgICAgICB0cmFuc2ZlclBhcmFtZXRlcnMuYXBwZW5kKDApOwotICAgICAgICAg ICAgdHJhbnNmZXJQYXJhbWV0ZXJzLmFwcGVuZChuYXJyb3dQcmVjaXNpb25Ub0Zsb2F0KGNvbXBv bmVudFRyYW5zZmVyT3BlcmF0aW9uLmFtb3VudCgpKSk7Ci0gICAgICAgICAgICB0cmFuc2ZlckZ1 bmN0aW9uLnRhYmxlVmFsdWVzID0gdHJhbnNmZXJQYXJhbWV0ZXJzOworICAgICAgICAgICAgdHJh bnNmZXJGdW5jdGlvbi50eXBlID0gRkVDT01QT05FTlRUUkFOU0ZFUl9UWVBFX0xJTkVBUjsKKyAg ICAgICAgICAgIGZsb2F0IGFtb3VudCA9IG5hcnJvd1ByZWNpc2lvblRvRmxvYXQoY29tcG9uZW50 VHJhbnNmZXJPcGVyYXRpb24uYW1vdW50KCkpOworICAgICAgICAgICAgdHJhbnNmZXJGdW5jdGlv bi5zbG9wZSA9IGFtb3VudDsKKyAgICAgICAgICAgIHRyYW5zZmVyRnVuY3Rpb24uaW50ZXJjZXB0 ID0gMDsKIAogICAgICAgICAgICAgQ29tcG9uZW50VHJhbnNmZXJGdW5jdGlvbiBudWxsRnVuY3Rp b247CiAgICAgICAgICAgICBlZmZlY3QgPSBGRUNvbXBvbmVudFRyYW5zZmVyOjpjcmVhdGUoKnRo aXMsIG51bGxGdW5jdGlvbiwgbnVsbEZ1bmN0aW9uLCBudWxsRnVuY3Rpb24sIHRyYW5zZmVyRnVu Y3Rpb24pOwo=