215867 2020-08-26 13:57:13 -0700 Ensure that email notifications are not sent for obsolete and r- patches 2020-08-28 05:58:27 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1683121 0 aakash_jain 2020-08-26 13:57:13 -0700 We should ensure that email notifications are not sent for obsolete and r- patches. EWS does check occasionally if the patch is obsolete/r- and stops processing the build if so. However, there aren't checks at the end of the build. If the patch becomes obsolete/r- after EWS checks the patch state, it is possible that EWS might send email notification for the failure. We should add another check just before sending the email, to ensure that EWS doesn't send email for obsolete/r- patches. Note that it should be fine to send email for bugs which are closed, since it might indicate that there was a failure on the patch which was landed. 1683126 1 407337 aakash_jain 2020-08-26 14:00:36 -0700 Created attachment 407337 Patch 1683490 2 407337 jbedard 2020-08-27 14:36:41 -0700 Comment on attachment 407337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407337&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:549 > + self._addToLog('stdio', 'Skipping email since patch {} is marked r-'.format(patch_id)) Do we have a request somewhere to make this the behavior when a patch is marked r-? It's not obviously that an r- ed patch shouldn't generate notification emails. 1683491 3 aakash_jain 2020-08-27 15:03:54 -0700 (In reply to Jonathan Bedard from comment #2) > Do we have a request somewhere to make this the behavior when a patch is marked r-? It's not obviously that an r- ed patch shouldn't generate notification emails. Not an explicit request. Although marking r- itself generate an email notification from bugzilla. 1683496 4 ews-feeder 2020-08-27 15:18:18 -0700 Committed r266260: <https://trac.webkit.org/changeset/266260> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407337. 1683497 5 webkit-bug-importer 2020-08-27 15:19:15 -0700 <rdar://problem/67900641> 1683621 6 aakash_jain 2020-08-28 05:58:27 -0700 Restarted buildbot to pick up this change. 407337 2020-08-26 14:00:36 -0700 2020-08-27 15:18:18 -0700 Patch bug-215867-20200826170034.patch text/plain 6066 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NjE4OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDIwLTA4LTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFbnN1cmUgdGhhdCBlbWFpbCBub3RpZmljYXRpb25zIGFyZSBub3Qgc2Vu dCBmb3Igb2Jzb2xldGUgYW5kIHItIHBhdGNoZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTg2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz LnB5OgorICAgICAgICAoQnVnemlsbGFNaXhpbi5zaG91bGRfc2VuZF9lbWFpbCk6IE1ldGhvZCB0 byBjaGVjayBpZiBwYXRjaCBpcyBvYnNvbGV0ZS9yLS4KKyAgICAgICAgKEFuYWx5emVDb21waWxl V2ViS2l0UmVzdWx0cyk6IEluaGVyaXQgZnJvbSBCdWd6aWxsYU1peGluLgorICAgICAgICAoQW5h bHl6ZUNvbXBpbGVXZWJLaXRSZXN1bHRzLnNlbmRfZW1haWxfZm9yX25ld19idWlsZF9mYWlsdXJl KTogQ2hlY2sgZm9yIHBhdGNoIHN0YXRlIGJlZm9yZSBzZW5kaW5nIGVtYWlsLgorICAgICAgICAo QW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cyk6IERpdHRvLgorICAgICAgICAoQW5hbHl6ZUxheW91 dFRlc3RzUmVzdWx0cy5zZW5kX2VtYWlsX2Zvcl9uZXdfdGVzdF9mYWlsdXJlcyk6IERpdHRvLgor CiAyMDIwLTA4LTI2ICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgogCiAg ICAgICAgIFRlc3RXZWJLaXRBUEkuQXVkaW9Sb3V0aW5nQXJiaXRyYXRpb24uRGVsZXRpb24gaXMg YSBjb25zdGFudCBmYWlsdXJlCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNjYxODkpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTUyOSw2ICs1MjksMjcgQEAg Y2xhc3MgQnVnemlsbGFNaXhpbihvYmplY3QpOgogICAgICAgICAgICAgcmV0dXJuIDEKICAgICAg ICAgcmV0dXJuIDAKIAorICAgIGRlZiBzaG91bGRfc2VuZF9lbWFpbChzZWxmLCBwYXRjaF9pZCk6 CisgICAgICAgIHBhdGNoX2pzb24gPSBzZWxmLmdldF9wYXRjaF9qc29uKHBhdGNoX2lkKQorICAg ICAgICBpZiBub3QgcGF0Y2hfanNvbjoKKyAgICAgICAgICAgIHNlbGYuX2FkZFRvTG9nKCdzdGRp bycsICdVbmFibGUgdG8gZmV0Y2ggcGF0Y2gge30nLmZvcm1hdChwYXRjaF9pZCkpCisgICAgICAg ICAgICByZXR1cm4gVHJ1ZQorCisgICAgICAgIG9ic29sZXRlID0gcGF0Y2hfanNvbi5nZXQoJ2lz X29ic29sZXRlJykKKyAgICAgICAgaWYgb2Jzb2xldGUgPT0gMToKKyAgICAgICAgICAgIHNlbGYu X2FkZFRvTG9nKCdzdGRpbycsICdTa2lwcGluZyBlbWFpbCBzaW5jZSBwYXRjaCB7fSBpcyBvYnNv bGV0ZScuZm9ybWF0KHBhdGNoX2lkKSkKKyAgICAgICAgICAgIHJldHVybiBGYWxzZQorCisgICAg ICAgIHJldmlld19kZW5pZWQgPSBGYWxzZQorICAgICAgICBmb3IgZmxhZyBpbiBwYXRjaF9qc29u LmdldCgnZmxhZ3MnLCBbXSk6CisgICAgICAgICAgICBpZiBmbGFnLmdldCgnbmFtZScpID09ICdy ZXZpZXcnIGFuZCBmbGFnLmdldCgnc3RhdHVzJykgPT0gJy0nOgorICAgICAgICAgICAgICAgIHJl dmlld19kZW5pZWQgPSBUcnVlCisKKyAgICAgICAgaWYgcmV2aWV3X2RlbmllZDoKKyAgICAgICAg ICAgIHNlbGYuX2FkZFRvTG9nKCdzdGRpbycsICdTa2lwcGluZyBlbWFpbCBzaW5jZSBwYXRjaCB7 fSBpcyBtYXJrZWQgci0nLmZvcm1hdChwYXRjaF9pZCkpCisgICAgICAgICAgICByZXR1cm4gRmFs c2UKKyAgICAgICAgcmV0dXJuIFRydWUKKwogICAgIGRlZiBnZXRfYnVnemlsbGFfYXBpX2tleShz ZWxmKToKICAgICAgICAgdHJ5OgogICAgICAgICAgICAgcGFzc3dvcmRzID0ganNvbi5sb2FkKG9w ZW4oJ3Bhc3N3b3Jkcy5qc29uJykpCkBAIC0xMzg3LDcgKzE0MDgsNyBAQCBjbGFzcyBDb21waWxl V2ViS2l0V2l0aG91dFBhdGNoKENvbXBpbGVXCiAgICAgICAgIHJldHVybiBzaGVsbC5Db21waWxl LmV2YWx1YXRlQ29tbWFuZChzZWxmLCBjbWQpCiAKIAotY2xhc3MgQW5hbHl6ZUNvbXBpbGVXZWJL aXRSZXN1bHRzKGJ1aWxkc3RlcC5CdWlsZFN0ZXApOgorY2xhc3MgQW5hbHl6ZUNvbXBpbGVXZWJL aXRSZXN1bHRzKGJ1aWxkc3RlcC5CdWlsZFN0ZXAsIEJ1Z3ppbGxhTWl4aW4pOgogICAgIG5hbWUg PSAnYW5hbHl6ZS1jb21waWxlLXdlYmtpdC1yZXN1bHRzJwogICAgIGRlc2NyaXB0aW9uID0gWydh bmFseXplLWNvbXBpbGUtd2Via2l0LXJlc3VsdHMnXQogICAgIGRlc2NyaXB0aW9uRG9uZSA9IFsn YW5hbHl6ZS1jb21waWxlLXdlYmtpdC1yZXN1bHRzJ10KQEAgLTE0NjksMTEgKzE0OTAsMTMgQEAg Y2xhc3MgQW5hbHl6ZUNvbXBpbGVXZWJLaXRSZXN1bHRzKGJ1aWxkcwogCiAgICAgZGVmIHNlbmRf ZW1haWxfZm9yX25ld19idWlsZF9mYWlsdXJlKHNlbGYpOgogICAgICAgICB0cnk6CisgICAgICAg ICAgICBwYXRjaF9pZCA9IHNlbGYuZ2V0UHJvcGVydHkoJ3BhdGNoX2lkJywgJycpCisgICAgICAg ICAgICBpZiBub3Qgc2VsZi5zaG91bGRfc2VuZF9lbWFpbChwYXRjaF9pZCk6CisgICAgICAgICAg ICAgICAgcmV0dXJuCiAgICAgICAgICAgICBidWlsZGVyX25hbWUgPSBzZWxmLmdldFByb3BlcnR5 KCdidWlsZGVybmFtZScsICcnKQogICAgICAgICAgICAgYnVnX2lkID0gc2VsZi5nZXRQcm9wZXJ0 eSgnYnVnX2lkJywgJycpCiAgICAgICAgICAgICBidWdfdGl0bGUgPSBzZWxmLmdldFByb3BlcnR5 KCdidWdfdGl0bGUnLCAnJykKICAgICAgICAgICAgIHdvcmtlcl9uYW1lID0gc2VsZi5nZXRQcm9w ZXJ0eSgnd29ya2VybmFtZScsICcnKQotICAgICAgICAgICAgcGF0Y2hfaWQgPSBzZWxmLmdldFBy b3BlcnR5KCdwYXRjaF9pZCcsICcnKQogICAgICAgICAgICAgcGF0Y2hfYXV0aG9yID0gc2VsZi5n ZXRQcm9wZXJ0eSgncGF0Y2hfYXV0aG9yJywgJycpCiAgICAgICAgICAgICBwbGF0Zm9ybSA9IHNl bGYuZ2V0UHJvcGVydHkoJ3BsYXRmb3JtJywgJycpCiAgICAgICAgICAgICBidWlsZF91cmwgPSAn e30jL2J1aWxkZXJzL3t9L2J1aWxkcy97fScuZm9ybWF0KHNlbGYubWFzdGVyLmNvbmZpZy5idWls ZGJvdFVSTCwgc2VsZi5idWlsZC5fYnVpbGRlcmlkLCBzZWxmLmJ1aWxkLm51bWJlcikKQEAgLTE0 OTIsNiArMTUxNSw3IEBAIGNsYXNzIEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0cyhidWlsZHMK ICAgICAgICAgICAgICAgICBsb2dzID0gbG9ncy5yZXBsYWNlKCcmJywgJyZhbXA7JykucmVwbGFj ZSgnPCcsICcmbHQ7JykucmVwbGFjZSgnPicsICcmZ3Q7JykKICAgICAgICAgICAgICAgICBlbWFp bF90ZXh0ICs9IHUnXG5cbkVycm9yIGxpbmVzOlxuXG48Y29kZT57fTwvY29kZT4nLmZvcm1hdChs b2dzKQogICAgICAgICAgICAgZW1haWxfdGV4dCArPSAnXG5cblRvIHVuc3Vic2NyaWJsZSBmcm9t IHRoZXNlIG5vdGlmaWNhdGlvbnMgb3IgdG8gcHJvdmlkZSBhbnkgZmVlZGJhY2sgcGxlYXNlIGVt YWlsIGFha2FzaF9qYWluQGFwcGxlLmNvbScKKyAgICAgICAgICAgIHNlbGYuX2FkZFRvTG9nKCdz dGRpbycsICdTZW5kaW5nIGVtYWlsIG5vdGlmaWNhdGlvbiB0byB7fScuZm9ybWF0KHBhdGNoX2F1 dGhvcikpCiAgICAgICAgICAgICBzZW5kX2VtYWlsX3RvX3BhdGNoX2F1dGhvcihwYXRjaF9hdXRo b3IsIGVtYWlsX3N1YmplY3QsIGVtYWlsX3RleHQsIHBhdGNoX2lkKQogICAgICAgICBleGNlcHQg RXhjZXB0aW9uIGFzIGU6CiAgICAgICAgICAgICBwcmludCgnRXJyb3IgaW4gc2VuZGluZyBlbWFp bCBmb3IgbmV3IGJ1aWxkIGZhaWx1cmU6IHt9Jy5mb3JtYXQoZSkpCkBAIC0yMDU4LDcgKzIwODIs NyBAQCBjbGFzcyBSdW5XZWJLaXRUZXN0c1dpdGhvdXRQYXRjaChSdW5XZWJLCiAgICAgICAgIHNl bGYuX3BhcnNlUnVuV2ViS2l0VGVzdHNPdXRwdXQobG9nVGV4dCkKIAogCi1jbGFzcyBBbmFseXpl TGF5b3V0VGVzdHNSZXN1bHRzKGJ1aWxkc3RlcC5CdWlsZFN0ZXApOgorY2xhc3MgQW5hbHl6ZUxh eW91dFRlc3RzUmVzdWx0cyhidWlsZHN0ZXAuQnVpbGRTdGVwLCBCdWd6aWxsYU1peGluKToKICAg ICBuYW1lID0gJ2FuYWx5emUtbGF5b3V0LXRlc3RzLXJlc3VsdHMnCiAgICAgZGVzY3JpcHRpb24g PSBbJ2FuYWx5emUtbGF5b3V0LXRlc3QtcmVzdWx0cyddCiAgICAgZGVzY3JpcHRpb25Eb25lID0g WydhbmFseXplLWxheW91dC10ZXN0cy1yZXN1bHRzJ10KQEAgLTIxNDcsMTEgKzIxNzEsMTMgQEAg Y2xhc3MgQW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cyhidWlsZHN0ZQogCiAgICAgZGVmIHNlbmRf ZW1haWxfZm9yX25ld190ZXN0X2ZhaWx1cmVzKHNlbGYsIHRlc3RfbmFtZXMpOgogICAgICAgICB0 cnk6CisgICAgICAgICAgICBwYXRjaF9pZCA9IHNlbGYuZ2V0UHJvcGVydHkoJ3BhdGNoX2lkJywg JycpCisgICAgICAgICAgICBpZiBub3Qgc2VsZi5zaG91bGRfc2VuZF9lbWFpbChwYXRjaF9pZCk6 CisgICAgICAgICAgICAgICAgcmV0dXJuCiAgICAgICAgICAgICBidWlsZGVyX25hbWUgPSBzZWxm LmdldFByb3BlcnR5KCdidWlsZGVybmFtZScsICcnKQogICAgICAgICAgICAgYnVnX2lkID0gc2Vs Zi5nZXRQcm9wZXJ0eSgnYnVnX2lkJywgJycpCiAgICAgICAgICAgICBidWdfdGl0bGUgPSBzZWxm LmdldFByb3BlcnR5KCdidWdfdGl0bGUnLCAnJykKICAgICAgICAgICAgIHdvcmtlcl9uYW1lID0g c2VsZi5nZXRQcm9wZXJ0eSgnd29ya2VybmFtZScsICcnKQotICAgICAgICAgICAgcGF0Y2hfaWQg PSBzZWxmLmdldFByb3BlcnR5KCdwYXRjaF9pZCcsICcnKQogICAgICAgICAgICAgcGF0Y2hfYXV0 aG9yID0gc2VsZi5nZXRQcm9wZXJ0eSgncGF0Y2hfYXV0aG9yJywgJycpCiAgICAgICAgICAgICBi dWlsZF91cmwgPSAne30jL2J1aWxkZXJzL3t9L2J1aWxkcy97fScuZm9ybWF0KHNlbGYubWFzdGVy LmNvbmZpZy5idWlsZGJvdFVSTCwgc2VsZi5idWlsZC5fYnVpbGRlcmlkLCBzZWxmLmJ1aWxkLm51 bWJlcikKICAgICAgICAgICAgIHRlc3RfbmFtZXNfc3RyaW5nID0gJycKQEAgLTIxNjcsNiArMjE5 Myw3IEBAIGNsYXNzIEFuYWx5emVMYXlvdXRUZXN0c1Jlc3VsdHMoYnVpbGRzdGUKICAgICAgICAg ICAgIGVtYWlsX3RleHQgKz0gJ1xuXG5GdWxsIGRldGFpbHMgYXJlIGF2YWlsYWJsZSBhdDoge31c blxuUGF0Y2ggYXV0aG9yOiB7fScuZm9ybWF0KGJ1aWxkX3VybCwgcGF0Y2hfYXV0aG9yKQogICAg ICAgICAgICAgZW1haWxfdGV4dCArPSAnXG5cbkxheW91dCB0ZXN0IGZhaWx1cmV7fTpcbnt9Jy5m b3JtYXQocGx1cmFsU3VmZml4LCB0ZXN0X25hbWVzX3N0cmluZykKICAgICAgICAgICAgIGVtYWls X3RleHQgKz0gJ1xuXG5UbyB1bnN1YnNjcmlibGUgZnJvbSB0aGVzZSBub3RpZmljYXRpb25zIG9y IHRvIHByb3ZpZGUgYW55IGZlZWRiYWNrIHBsZWFzZSBlbWFpbCBhYWthc2hfamFpbkBhcHBsZS5j b20nCisgICAgICAgICAgICBzZWxmLl9hZGRUb0xvZygnc3RkaW8nLCAnU2VuZGluZyBlbWFpbCBu b3RpZmljYXRpb24gdG8ge30nLmZvcm1hdChwYXRjaF9hdXRob3IpKQogICAgICAgICAgICAgc2Vu ZF9lbWFpbF90b19wYXRjaF9hdXRob3IocGF0Y2hfYXV0aG9yLCBlbWFpbF9zdWJqZWN0LCBlbWFp bF90ZXh0LCBwYXRjaF9pZCkKICAgICAgICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBlOgogICAgICAg ICAgICAgcHJpbnQoJ0Vycm9yIGluIHNlbmRpbmcgZW1haWwgZm9yIG5ldyBsYXlvdXQgdGVzdCBm YWlsdXJlczoge30nLmZvcm1hdChlKSkK