215861 2020-08-26 13:26:37 -0700 REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests 2020-08-27 10:01:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble darin eric.carlson peng.liu6 webkit-bug-importer oldest_to_newest 1683098 0 jer.noble 2020-08-26 13:26:37 -0700 REGRESSION(r264710): Initializing the AVPlayer Obj-C class at process start up causes a regression in power-use tests 1683100 1 jer.noble 2020-08-26 13:30:00 -0700 <rdar://problem/67755363> 1683102 2 407330 jer.noble 2020-08-26 13:31:46 -0700 Created attachment 407330 Patch 1683112 3 407330 peng.liu6 2020-08-26 13:43:38 -0700 Comment on attachment 407330 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407330&action=review > Source/WebKit/ChangeLog:8 > + Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialize, which in the case of Nit. s/initialize/initialized. > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1048 > // and process global. Nit. Maybe update the comment here as well? 1683117 4 jer.noble 2020-08-26 13:47:50 -0700 (In reply to Peng Liu from comment #3) > Comment on attachment 407330 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407330&action=review > > > Source/WebKit/ChangeLog:8 > > + Calling +instancesRespondToSelector: will cause the underyling Obj-C class to be initialize, which in the case of > > Nit. s/initialize/initialized. Fixed. > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1048 > > // and process global. > > Nit. Maybe update the comment here as well? I think the comment still holds. We just assume that the property is there at runtime, rather than explicitly check. 1683119 5 407334 jer.noble 2020-08-26 13:50:06 -0700 Created attachment 407334 Patch for landing 1683141 6 407330 darin 2020-08-26 14:42:13 -0700 Comment on attachment 407330 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407330&action=review > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1049 > + return; Given that this is now a compile time switch, I suggest wrapping the entire function body in: #if !HAVE(AVPLAYER_VIDEORANGEOVERRIDE) Rather than compiling a function with a return at the start of it. 1683148 7 jer.noble 2020-08-26 14:45:49 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 407330 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407330&action=review > > > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1049 > > + return; > > Given that this is now a compile time switch, I suggest wrapping the entire > function body in: > > #if !HAVE(AVPLAYER_VIDEORANGEOVERRIDE) > > Rather than compiling a function with a return at the start of it. I considered that (or doing a #if/#else/#endif, but thought it might be confusing for previous OSs, especially given the existing comment. But sure, I'll re-write the comment to be more explicit that the wrapped behavior is for when this API is not available. 1683157 8 407341 jer.noble 2020-08-26 14:57:41 -0700 Created attachment 407341 Patch for landing 1683416 9 ews-feeder 2020-08-27 10:01:45 -0700 Committed r266240: <https://trac.webkit.org/changeset/266240> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407341. 407330 2020-08-26 13:31:46 -0700 2020-08-26 13:42:06 -0700 Patch bug-215861-20200826133145.patch text/plain 2119 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5N2IwN2QzOTE1MzlkM2Iy ZGU5N2E2ODNhYmUzYWM3Nzk5YzdjNzIuLjIyOTQzN2ZjNWM5ZjFhMWY4N2E3ZmM5YjFiYzkzZmY5 MThkMTU0ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDgtMjYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY0NzEwKTog SW5pdGlhbGl6aW5nIHRoZSBBVlBsYXllciBPYmotQyBjbGFzcyBhdCBwcm9jZXNzIHN0YXJ0IHVw IGNhdXNlcyBhIHJlZ3Jlc3Npb24gaW4gcG93ZXItdXNlIHRlc3RzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU4NjEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxsaW5nICtpbnN0YW5jZXNSZXNwb25k VG9TZWxlY3Rvcjogd2lsbCBjYXVzZSB0aGUgdW5kZXJ5bGluZyBPYmotQyBjbGFzcyB0byBiZSBp bml0aWFsaXplLCB3aGljaCBpbiB0aGUgY2FzZSBvZgorICAgICAgICBBVlBsYXllciBkb2VzIGEg YnVuY2ggb2Ygd29yayB3aGljaCBzaG93cyB1cCBvbiBwb3dlci11c2UgdGVzdHMuIEJlY2F1c2Ug dGhlIEFQSSBiZWluZyBjaGVja2VkIGZvciB3aWxsIGFsd2F5cyBleGlzdAorICAgICAgICBpbiBt YWNPUyAxMSwgYW5kIHRoYXQgY29kZSBpcyBhbHJlYWR5IHByb3RlY3RlZCBieSBhIEhBVkUoQVZQ TEFZRVJfVklERU9SQU5HRU9WRVJSSURFKSBwcmFnbWEsIGp1c3QgcmV0dXJuIGVhcmx5CisgICAg ICAgIGhlcmUgd2l0aG91dCBydW5uaW5nIHRoZSAraW5zdGFuY2VzUmVzcG9uZFRvU2VsZWN0b3I6 IGNoZWNrLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06 CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6OnVwZGF0ZVBhZ2VTY3JlZW5Qcm9wZXJ0aWVz KToKKwogMjAyMC0wOC0xOSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAg ICAgICBbTWFjXSBSRUdSRVNTSU9OKHIyNjIzMjIpOiBGb2N1c2FibGUgZWxlbWVudHMgYXJlIGZv Y3VzZWQgd2hlbiBleGl0aW5nIGZyb20gdmlkZW8gZnVsbHNjcmVlbiBtb2RlLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbSBiL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KaW5kZXggM2I4 YmRlYTNhNmFiNWI0MzY2YTYwNmRhYTdkYThjY2ZiZjU2MmYzNy4uOTUyNTAwMDY5ZDRiNGE4MmRl OGVhYzY4YmIwZDIxMTU5OTZmY2E1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCkBAIC0xMDQ2LDggKzEwNDYsNyBAQCB2b2lkIFdl YlByb2Nlc3M6OnVwZGF0ZVBhZ2VTY3JlZW5Qcm9wZXJ0aWVzKCkKICAgICAvLyBJZiBBVlBsYXll ci52aWRlb1JhbmdlT3ZlcnJpZGUgc3VwcG9ydCBpcyBwcmVzZW50LCB0aGVyZSdzIG5vIG5lZWQg dG8gb3ZlcnJpZGUgSERSIG1vZGUKICAgICAvLyBhdCB0aGUgTWVkaWFUb29sYm94IGxldmVsLCBh cyB0aGUgTWVkaWFUb29sYm94IG92ZXJyaWRlIGZ1bmN0aW9uYWxpdHkgaXMgYm90aCBkdXBsaWNh dGl2ZQogICAgIC8vIGFuZCBwcm9jZXNzIGdsb2JhbC4KLSAgICBpZiAoUEFMOjppc0FWRm91bmRh dGlvbkZyYW1ld29ya0F2YWlsYWJsZSgpICYmIFtQQUw6OmdldEFWUGxheWVyQ2xhc3MoKSBpbnN0 YW5jZXNSZXNwb25kVG9TZWxlY3RvcjpAc2VsZWN0b3Ioc2V0VmlkZW9SYW5nZU92ZXJyaWRlOild KQotICAgICAgICByZXR1cm47CisgICAgcmV0dXJuOwogI2VuZGlmCiAKICAgICBpZiAoaGFzUHJv Y2Vzc1ByaXZpbGVnZShQcm9jZXNzUHJpdmlsZWdlOjpDYW5Db21tdW5pY2F0ZVdpdGhXaW5kb3dT ZXJ2ZXIpKSB7Cg== 407334 2020-08-26 13:50:06 -0700 2020-08-26 14:48:22 -0700 Patch for landing bug-215861-20200826135005.patch text/plain 2118 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5N2IwN2QzOTE1MzlkM2Iy ZGU5N2E2ODNhYmUzYWM3Nzk5YzdjNzIuLjlkOTZmYTQ2NGI1MjM0NjIzMDdlZmNjYjY5NjhiZjIx YjY2ZTY2NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDgtMjYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY0NzEwKTog SW5pdGlhbGl6aW5nIHRoZSBBVlBsYXllciBPYmotQyBjbGFzcyBhdCBwcm9jZXNzIHN0YXJ0IHVw IGNhdXNlcyBhIHJlZ3Jlc3Npb24gaW4gcG93ZXItdXNlIHRlc3RzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU4NjEKKworICAgICAgICBSZXZpZXdl ZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgQ2FsbGluZyAraW5zdGFuY2VzUmVzcG9uZFRv U2VsZWN0b3I6IHdpbGwgY2F1c2UgdGhlIHVuZGVyeWxpbmcgT2JqLUMgY2xhc3MgdG8gYmUgaW5p dGlhbGl6ZWQsIHdoaWNoIGluIHRoZSBjYXNlIG9mCisgICAgICAgIEFWUGxheWVyIGRvZXMgYSBi dW5jaCBvZiB3b3JrIHdoaWNoIHNob3dzIHVwIG9uIHBvd2VyLXVzZSB0ZXN0cy4gQmVjYXVzZSB0 aGUgQVBJIGJlaW5nIGNoZWNrZWQgZm9yIHdpbGwgYWx3YXlzIGV4aXN0CisgICAgICAgIGluIG1h Y09TIDExLCBhbmQgdGhhdCBjb2RlIGlzIGFscmVhZHkgcHJvdGVjdGVkIGJ5IGEgSEFWRShBVlBM QVlFUl9WSURFT1JBTkdFT1ZFUlJJREUpIHByYWdtYSwganVzdCByZXR1cm4gZWFybHkKKyAgICAg ICAgaGVyZSB3aXRob3V0IHJ1bm5pbmcgdGhlICtpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3Rvcjog Y2hlY2suCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbToK KyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6dXBkYXRlUGFnZVNjcmVlblByb3BlcnRpZXMp OgorCiAyMDIwLTA4LTE5ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFtNYWNdIFJFR1JFU1NJT04ocjI2MjMyMik6IEZvY3VzYWJsZSBlbGVtZW50cyBhcmUgZm9j dXNlZCB3aGVuIGV4aXRpbmcgZnJvbSB2aWRlbyBmdWxsc2NyZWVuIG1vZGUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQppbmRleCAzYjhi ZGVhM2E2YWI1YjQzNjZhNjA2ZGFhN2RhOGNjZmJmNTYyZjM3Li45NTI1MDAwNjlkNGI0YTgyZGU4 ZWFjNjhiYjBkMjExNTk5NmZjYTVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KQEAgLTEwNDYsOCArMTA0Niw3IEBAIHZvaWQgV2Vi UHJvY2Vzczo6dXBkYXRlUGFnZVNjcmVlblByb3BlcnRpZXMoKQogICAgIC8vIElmIEFWUGxheWVy LnZpZGVvUmFuZ2VPdmVycmlkZSBzdXBwb3J0IGlzIHByZXNlbnQsIHRoZXJlJ3Mgbm8gbmVlZCB0 byBvdmVycmlkZSBIRFIgbW9kZQogICAgIC8vIGF0IHRoZSBNZWRpYVRvb2xib3ggbGV2ZWwsIGFz IHRoZSBNZWRpYVRvb2xib3ggb3ZlcnJpZGUgZnVuY3Rpb25hbGl0eSBpcyBib3RoIGR1cGxpY2F0 aXZlCiAgICAgLy8gYW5kIHByb2Nlc3MgZ2xvYmFsLgotICAgIGlmIChQQUw6OmlzQVZGb3VuZGF0 aW9uRnJhbWV3b3JrQXZhaWxhYmxlKCkgJiYgW1BBTDo6Z2V0QVZQbGF5ZXJDbGFzcygpIGluc3Rh bmNlc1Jlc3BvbmRUb1NlbGVjdG9yOkBzZWxlY3RvcihzZXRWaWRlb1JhbmdlT3ZlcnJpZGU6KV0p Ci0gICAgICAgIHJldHVybjsKKyAgICByZXR1cm47CiAjZW5kaWYKIAogICAgIGlmIChoYXNQcm9j ZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6OkNhbkNvbW11bmljYXRlV2l0aFdpbmRvd1Nl cnZlcikpIHsK 407341 2020-08-26 14:57:41 -0700 2020-08-27 10:01:46 -0700 Patch for landing bug-215861-20200826145740.patch text/plain 2830 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ5N2IwN2QzOTE1MzlkM2Iy ZGU5N2E2ODNhYmUzYWM3Nzk5YzdjNzIuLjlkOTZmYTQ2NGI1MjM0NjIzMDdlZmNjYjY5NjhiZjIx YjY2ZTY2NWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDgtMjYgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY0NzEwKTog SW5pdGlhbGl6aW5nIHRoZSBBVlBsYXllciBPYmotQyBjbGFzcyBhdCBwcm9jZXNzIHN0YXJ0IHVw IGNhdXNlcyBhIHJlZ3Jlc3Npb24gaW4gcG93ZXItdXNlIHRlc3RzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU4NjEKKworICAgICAgICBSZXZpZXdl ZCBieSBFcmljIENhcmxzb24uCisKKyAgICAgICAgQ2FsbGluZyAraW5zdGFuY2VzUmVzcG9uZFRv U2VsZWN0b3I6IHdpbGwgY2F1c2UgdGhlIHVuZGVyeWxpbmcgT2JqLUMgY2xhc3MgdG8gYmUgaW5p dGlhbGl6ZWQsIHdoaWNoIGluIHRoZSBjYXNlIG9mCisgICAgICAgIEFWUGxheWVyIGRvZXMgYSBi dW5jaCBvZiB3b3JrIHdoaWNoIHNob3dzIHVwIG9uIHBvd2VyLXVzZSB0ZXN0cy4gQmVjYXVzZSB0 aGUgQVBJIGJlaW5nIGNoZWNrZWQgZm9yIHdpbGwgYWx3YXlzIGV4aXN0CisgICAgICAgIGluIG1h Y09TIDExLCBhbmQgdGhhdCBjb2RlIGlzIGFscmVhZHkgcHJvdGVjdGVkIGJ5IGEgSEFWRShBVlBM QVlFUl9WSURFT1JBTkdFT1ZFUlJJREUpIHByYWdtYSwganVzdCByZXR1cm4gZWFybHkKKyAgICAg ICAgaGVyZSB3aXRob3V0IHJ1bm5pbmcgdGhlICtpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3Rvcjog Y2hlY2suCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbToK KyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6dXBkYXRlUGFnZVNjcmVlblByb3BlcnRpZXMp OgorCiAyMDIwLTA4LTE5ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAg ICAgIFtNYWNdIFJFR1JFU1NJT04ocjI2MjMyMik6IEZvY3VzYWJsZSBlbGVtZW50cyBhcmUgZm9j dXNlZCB3aGVuIGV4aXRpbmcgZnJvbSB2aWRlbyBmdWxsc2NyZWVuIG1vZGUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQppbmRleCAzYjhi ZGVhM2E2YWI1YjQzNjZhNjA2ZGFhN2RhOGNjZmJmNTYyZjM3Li5mMjQ1YjU5NTdmYjEwYzMzNWQ5 Zjk5OWQ1NzE4ZjU5NDgyYmE1YjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KQEAgLTEwNDIsMTQgKzEwNDIsOSBAQCB2b2lkIFdl YlByb2Nlc3M6OnNldFNjcmVlblByb3BlcnRpZXMoY29uc3QgU2NyZWVuUHJvcGVydGllcyYgcHJv cGVydGllcykKICNpZiBQTEFURk9STShNQUMpCiB2b2lkIFdlYlByb2Nlc3M6OnVwZGF0ZVBhZ2VT Y3JlZW5Qcm9wZXJ0aWVzKCkKIHsKLSNpZiBIQVZFKEFWUExBWUVSX1ZJREVPUkFOR0VPVkVSUklE RSkKLSAgICAvLyBJZiBBVlBsYXllci52aWRlb1JhbmdlT3ZlcnJpZGUgc3VwcG9ydCBpcyBwcmVz ZW50LCB0aGVyZSdzIG5vIG5lZWQgdG8gb3ZlcnJpZGUgSERSIG1vZGUKLSAgICAvLyBhdCB0aGUg TWVkaWFUb29sYm94IGxldmVsLCBhcyB0aGUgTWVkaWFUb29sYm94IG92ZXJyaWRlIGZ1bmN0aW9u YWxpdHkgaXMgYm90aCBkdXBsaWNhdGl2ZQotICAgIC8vIGFuZCBwcm9jZXNzIGdsb2JhbC4KLSAg ICBpZiAoUEFMOjppc0FWRm91bmRhdGlvbkZyYW1ld29ya0F2YWlsYWJsZSgpICYmIFtQQUw6Omdl dEFWUGxheWVyQ2xhc3MoKSBpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3RvcjpAc2VsZWN0b3Ioc2V0 VmlkZW9SYW5nZU92ZXJyaWRlOildKQotICAgICAgICByZXR1cm47Ci0jZW5kaWYKLQorI2lmICFI QVZFKEFWUExBWUVSX1ZJREVPUkFOR0VPVkVSUklERSkKKyAgICAvLyBPbmx5IG92ZXJyaWRlIEhE UiBzdXBwb3J0IGF0IHRoZSBNZWRpYVRvb2xib3ggbGV2ZWwgaWYgQVZQbGF5ZXIudmlkZW9SYW5n ZU92ZXJyaWRlIHN1cHBvcnQgaXMKKyAgICAvLyBub3QgcHJlc2VudCwgYXMgdGhlIE1lZGlhVG9v bGJveCBvdmVycmlkZSBmdW5jdGlvbmFsaXR5IGlzIGJvdGggZHVwbGljYXRpdmUgYW5kIHByb2Nl c3MgZ2xvYmFsLgogICAgIGlmIChoYXNQcm9jZXNzUHJpdmlsZWdlKFByb2Nlc3NQcml2aWxlZ2U6 OkNhbkNvbW11bmljYXRlV2l0aFdpbmRvd1NlcnZlcikpIHsKICAgICAgICAgc2V0U2hvdWxkT3Zl cnJpZGVTY3JlZW5TdXBwb3J0c0hpZ2hEeW5hbWljUmFuZ2UoZmFsc2UsIGZhbHNlKTsKICAgICAg ICAgcmV0dXJuOwpAQCAtMTA1OSw2ICsxMDU0LDcgQEAgdm9pZCBXZWJQcm9jZXNzOjp1cGRhdGVQ YWdlU2NyZWVuUHJvcGVydGllcygpCiAgICAgICAgIHJldHVybiBzY3JlZW5TdXBwb3J0c0hpZ2hE eW5hbWljUmFuZ2UocGFnZS0+bWFpbkZyYW1lVmlldygpKTsKICAgICB9KTsKICAgICBzZXRTaG91 bGRPdmVycmlkZVNjcmVlblN1cHBvcnRzSGlnaER5bmFtaWNSYW5nZSh0cnVlLCBhbGxQYWdlc0Fy ZU9uSERSU2NyZWVucyk7CisjZW5kaWYKIH0KICNlbmRpZgogCg==