215828 2020-08-25 16:39:12 -0700 Web Inspector: button for Inspector^2 doesn't work without setting default for DeveloperExtrasEnabled 2020-08-26 23:47:14 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1682844 0 bburg 2020-08-25 16:39:12 -0700 This should be automatically set up and require no extra config. 1683030 1 407310 bburg 2020-08-26 10:37:41 -0700 Created attachment 407310 Patch 1683036 2 407310 hi 2020-08-26 10:43:24 -0700 Comment on attachment 407310 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407310&action=review r=me, nice solution :) > Source/WebInspectorUI/ChangeLog:11 > + Drive-by: because the Inspector^2 button is text-only and has no > + .name element, the '2' button does not become dimmed when the > + window is inactive, unlike every other item in the tab bar. > + Fix this by coloring the text-only button similar to tab labels. IMO, since this is an engineering only feature I don't think we need to care about this 😅 at the very least please put the styles in Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css so it isn't shipped (and maybe include a comment in UserInterface/Views/ButtonNavigationItem.css so that we know there's some related styles elsewhere) 1683206 3 bburg 2020-08-26 17:01:42 -0700 (In reply to Devin Rousso from comment #2) > Comment on attachment 407310 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=407310&action=review > > r=me, nice solution :) > > > Source/WebInspectorUI/ChangeLog:11 > > + Drive-by: because the Inspector^2 button is text-only and has no > > + .name element, the '2' button does not become dimmed when the > > + window is inactive, unlike every other item in the tab bar. > > + Fix this by coloring the text-only button similar to tab labels. > > IMO, since this is an engineering only feature I don't think we need to care > about this 😅 > > at the very least please put the styles in > Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css so it isn't shipped > (and maybe include a comment in UserInterface/Views/ButtonNavigationItem.css > so that we know there's some related styles elsewhere) OK 1683281 4 407375 bburg 2020-08-26 22:10:49 -0700 Created attachment 407375 Patch 1683287 5 ews-feeder 2020-08-26 22:46:34 -0700 /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 1683294 6 407377 bburg 2020-08-26 23:08:54 -0700 Created attachment 407377 Patch 1683301 7 ews-feeder 2020-08-26 23:46:59 -0700 Committed r266225: <https://trac.webkit.org/changeset/266225> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407377. 1683302 8 webkit-bug-importer 2020-08-26 23:47:14 -0700 <rdar://problem/67855023> 407310 2020-08-26 10:37:41 -0700 2020-08-26 22:10:48 -0700 Patch bug-215828-20200826103740.patch text/plain 4314 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRlMzRkMWMyMmQzZDcz ZjIyMTI0ZGVhYzVlNjIxOTFlYTI2MThlZC4uMDA3YjQzNjE4NzE0NDVmYmVhNzQ4MzUxNTlmYjFm NWQ3NDQ4ZDNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA4LTI2ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGJ1dHRv biBmb3IgSW5zcGVjdG9yXjIgZG9lc24ndCB3b3JrIHdpdGhvdXQgc2V0dGluZyBkZWZhdWx0IGZv ciBEZXZlbG9wZXJFeHRyYXNFbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTU4MjgKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JG cm9udGVuZEhvc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRnJvbnRlbmRIb3N0 OjppbnNwZWN0SW5zcGVjdG9yKToKKyAgICAgICAgRXhwbGljaXRseSBzZXQgRGV2ZWxvcGVyRXh0 cmFzRW5hYmxlZCBmb3IgdGhlIEluc3BlY3RvcgorICAgICAgICB3ZWIgdmlldyBzbyB0aGF0IHRo ZSBJbnNwZWN0IGNvbnRleHQgbWVudSBhcHBlYXJzIGFuZAorICAgICAgICBzbyB0aGUgWzJdIGJ1 dHRvbiB3b3JrcyBhcyBleHBlY3RlZC4KKwogMjAyMC0wOC0yNCAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYWxsb3cgZXZlbnQgYnJl YWtwb2ludHMgdG8gYmUgY29uZmlndXJlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKaW5kZXggYjhm MzZkNTA1ZmVjZGQwZWI1OGJhZWI4ZmEwYjIxMmNjODFmZjg0OS4uMTA5MzZkZjhiNzIwYmU5Yjcx MjA2YTVkZmJmZDQxYWM4YmE5ZjkxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjIgQEAKKzIwMjAtMDgtMjYgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAg ICAgICAgV2ViIEluc3BlY3RvcjogYnV0dG9uIGZvciBJbnNwZWN0b3JeMiBkb2Vzbid0IHdvcmsg d2l0aG91dCBzZXR0aW5nIGRlZmF1bHQgZm9yIERldmVsb3BlckV4dHJhc0VuYWJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTgyOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERyaXZlLWJ5OiBiZWNh dXNlIHRoZSBJbnNwZWN0b3JeMiBidXR0b24gaXMgdGV4dC1vbmx5IGFuZCBoYXMgbm8KKyAgICAg ICAgLm5hbWUgZWxlbWVudCwgdGhlICcyJyBidXR0b24gZG9lcyBub3QgYmVjb21lIGRpbW1lZCB3 aGVuIHRoZQorICAgICAgICB3aW5kb3cgaXMgaW5hY3RpdmUsIHVubGlrZSBldmVyeSBvdGhlciBp dGVtIGluIHRoZSB0YWIgYmFyLgorICAgICAgICBGaXggdGhpcyBieSBjb2xvcmluZyB0aGUgdGV4 dC1vbmx5IGJ1dHRvbiBzaW1pbGFyIHRvIHRhYiBsYWJlbHMuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL0J1dHRvbk5hdmlnYXRpb25JdGVtLmNzczoKKyAgICAgICAgKGJvZHkud2lu ZG93LWluYWN0aXZlIC50YWItYmFyID4gLm5hdmlnYXRpb24tYmFyIC5pdGVtLmJ1dHRvbi50ZXh0 LW9ubHkpOgorICAgICAgICAoLnRhYi1iYXIgPiAubmF2aWdhdGlvbi1iYXIgLml0ZW0uYnV0dG9u LnRleHQtb25seSk6CisgICAgICAgICgudGFiLWJhciA+IC5uYXZpZ2F0aW9uLWJhciAuaXRlbS5i dXR0b24udGV4dC1vbmx5Om5vdCguc2VsZWN0ZWQpOmhvdmVyKToKKyAgICAgICAgKC50YWItYmFy ID4gLm5hdmlnYXRpb24tYmFyIC5pdGVtLmJ1dHRvbi50ZXh0LW9ubHk6bm90KC5kaXNhYmxlZCku c2VsZWN0ZWQpOgorICAgICAgICAoYm9keS53aW5kb3ctaW5hY3RpdmUgLnRhYi1iYXIgPiAubmF2 aWdhdGlvbi1iYXIgLml0ZW0uYnV0dG9uLnRleHQtb25seTpub3QoLmRpc2FibGVkKS5zZWxlY3Rl ZCA+KToKKwogMjAyMC0wOC0yNCAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogYWxsb3cgZXZlbnQgYnJlYWtwb2ludHMgdG8gYmUgY29u ZmlndXJlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZy b250ZW5kSG9zdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRl bmRIb3N0LmNwcAppbmRleCBmMWE3MmFkYjUwNTFiNmIyOTM2M2UwMDQwYTYzNWYzOWE5YzY0NTdj Li41MGUwYzgzYmM5MjA2NjJlNzY4MDI1NTc3NTJiMzZmMjM3NWIwMzljIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcApAQCAtNTQ2 LDggKzU0NiwxMCBAQCB2b2lkIEluc3BlY3RvckZyb250ZW5kSG9zdDo6YmVlcCgpCiAKIHZvaWQg SW5zcGVjdG9yRnJvbnRlbmRIb3N0OjppbnNwZWN0SW5zcGVjdG9yKCkKIHsKLSAgICBpZiAobV9m cm9udGVuZFBhZ2UpCisgICAgaWYgKG1fZnJvbnRlbmRQYWdlKSB7CisgICAgICAgIG1fZnJvbnRl bmRQYWdlLT5zZXR0aW5ncygpLnNldERldmVsb3BlckV4dHJhc0VuYWJsZWQodHJ1ZSk7CiAgICAg ICAgIG1fZnJvbnRlbmRQYWdlLT5pbnNwZWN0b3JDb250cm9sbGVyKCkuc2hvdygpOworICAgIH0K IH0KIAogYm9vbCBJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OmlzQmVpbmdJbnNwZWN0ZWQoKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQnV0dG9u TmF2aWdhdGlvbkl0ZW0uY3NzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvQnV0dG9uTmF2aWdhdGlvbkl0ZW0uY3NzCmluZGV4IDBiMDkzNTkxMGE1ZjU0NjU2NmY2 MjhhZmFiMmFkYWFmZmU5MmViYzguLjUzYmRlNWE5ZWRiMjkzNjllMjg5MDRjOGJmOTIzM2Y2OGU0 MWFhNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0J1dHRvbk5hdmlnYXRpb25JdGVtLmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9CdXR0b25OYXZpZ2F0aW9uSXRlbS5jc3MKQEAgLTU0LDYgKzU0 LDI2IEBACiAgICAgcGFkZGluZy1ib3R0b206IDA7CiB9CiAKKy8qIFRoZXNlIHJ1bGVzIGFyZSBh ZGFwdGVkIGZyb20gVGFiQmFyLmNzcyBhbmQgYXJlIGV4cGVjdGVkIHRvIG1hdGNoLiAqLworYm9k eS53aW5kb3ctaW5hY3RpdmUgLnRhYi1iYXIgPiAubmF2aWdhdGlvbi1iYXIgLml0ZW0uYnV0dG9u LnRleHQtb25seSB7CisgICAgY29sb3I6IGhzbGEoMCwgMCUsIHZhcigtLWZvcmVncm91bmQtbGln aHRuZXNzKSwgMC40KTsKK30KKy50YWItYmFyID4gLm5hdmlnYXRpb24tYmFyIC5pdGVtLmJ1dHRv bi50ZXh0LW9ubHkgeworICAgIGNvbG9yOiBoc2xhKDAsIDAlLCB2YXIoLS1mb3JlZ3JvdW5kLWxp Z2h0bmVzcyksIDAuNik7Cit9CisKKy50YWItYmFyID4gLm5hdmlnYXRpb24tYmFyIC5pdGVtLmJ1 dHRvbi50ZXh0LW9ubHk6bm90KC5zZWxlY3RlZCk6aG92ZXIgeworICAgIGNvbG9yOiBoc2xhKDAs IDAlLCB2YXIoLS1mb3JlZ3JvdW5kLWxpZ2h0bmVzcyksIDAuNyk7Cit9CisKKy50YWItYmFyID4g Lm5hdmlnYXRpb24tYmFyIC5pdGVtLmJ1dHRvbi50ZXh0LW9ubHk6bm90KC5kaXNhYmxlZCkuc2Vs ZWN0ZWQgeworICAgIGNvbG9yOiBoc2xhKDAsIDAlLCB2YXIoLS1mb3JlZ3JvdW5kLWxpZ2h0bmVz cyksIDAuOCk7Cit9CisKK2JvZHkud2luZG93LWluYWN0aXZlIC50YWItYmFyID4gLm5hdmlnYXRp b24tYmFyIC5pdGVtLmJ1dHRvbi50ZXh0LW9ubHk6bm90KC5kaXNhYmxlZCkuc2VsZWN0ZWQgPiB7 CisgICAgY29sb3I6IGhzbGEoMCwgMCUsIHZhcigtLWZvcmVncm91bmQtbGlnaHRuZXNzKSwgMC41 KTsKK30KKwogLm5hdmlnYXRpb24tYmFyIC5pdGVtLmJ1dHRvbi50ZXh0LW9ubHkgewogICAgIHBh ZGRpbmc6IDFweCA4cHggM3B4OwogICAgIG1hcmdpbjogMCAycHg7IC8qIFdJLkJ1dHRvbk5hdmln YXRpb25JdGVtLnByb3RvdHlwZS5nZXQgdG90YWxNYXJnaW4gKi8K 407375 2020-08-26 22:10:49 -0700 2020-08-26 23:08:53 -0700 Patch bug-215828-20200826221048.patch text/plain 4190 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRlMzRkMWMyMmQzZDcz ZjIyMTI0ZGVhYzVlNjIxOTFlYTI2MThlZC4uMDA3YjQzNjE4NzE0NDVmYmVhNzQ4MzUxNTlmYjFm NWQ3NDQ4ZDNjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA4LTI2ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGJ1dHRv biBmb3IgSW5zcGVjdG9yXjIgZG9lc24ndCB3b3JrIHdpdGhvdXQgc2V0dGluZyBkZWZhdWx0IGZv ciBEZXZlbG9wZXJFeHRyYXNFbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTU4MjgKKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JG cm9udGVuZEhvc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRnJvbnRlbmRIb3N0 OjppbnNwZWN0SW5zcGVjdG9yKToKKyAgICAgICAgRXhwbGljaXRseSBzZXQgRGV2ZWxvcGVyRXh0 cmFzRW5hYmxlZCBmb3IgdGhlIEluc3BlY3RvcgorICAgICAgICB3ZWIgdmlldyBzbyB0aGF0IHRo ZSBJbnNwZWN0IGNvbnRleHQgbWVudSBhcHBlYXJzIGFuZAorICAgICAgICBzbyB0aGUgWzJdIGJ1 dHRvbiB3b3JrcyBhcyBleHBlY3RlZC4KKwogMjAyMC0wOC0yNCAgRGV2aW4gUm91c3NvICA8ZHJv dXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogYWxsb3cgZXZlbnQgYnJl YWtwb2ludHMgdG8gYmUgY29uZmlndXJlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKaW5kZXggYjhm MzZkNTA1ZmVjZGQwZWI1OGJhZWI4ZmEwYjIxMmNjODFmZjg0OS4uZTM0OTllNjYzNTM5NDE1MTdm NWFiMGI2MDY2NzNlYTViMTE0MjMwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjIgQEAKKzIwMjAtMDgtMjYgIEJyaWFuIEJ1cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAg ICAgICAgV2ViIEluc3BlY3RvcjogYnV0dG9uIGZvciBJbnNwZWN0b3JeMiBkb2Vzbid0IHdvcmsg d2l0aG91dCBzZXR0aW5nIGRlZmF1bHQgZm9yIERldmVsb3BlckV4dHJhc0VuYWJsZWQKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTgyOAorCisgICAg ICAgIFJldmlld2VkIGJ5IERldmluIFJvdXNzby4KKworICAgICAgICBEcml2ZS1ieTogYmVjYXVz ZSB0aGUgSW5zcGVjdG9yXjIgYnV0dG9uIGlzIHRleHQtb25seSBhbmQgaGFzIG5vCisgICAgICAg IC5uYW1lIGVsZW1lbnQsIHRoZSAnMicgYnV0dG9uIGRvZXMgbm90IGJlY29tZSBkaW1tZWQgd2hl biB0aGUKKyAgICAgICAgd2luZG93IGlzIGluYWN0aXZlLCB1bmxpa2UgZXZlcnkgb3RoZXIgaXRl bSBpbiB0aGUgdGFiIGJhci4KKyAgICAgICAgRml4IHRoaXMgYnkgY29sb3JpbmcgdGhlIHRleHQt b25seSBidXR0b24gc2ltaWxhciB0byB0YWIgbGFiZWxzLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9EZWJ1Zy9Cb290c3RyYXAuY3NzOgorICAgICAgICAoYm9keS53aW5kb3ctaW5hY3RpdmUg LnRhYi1iYXIgPiAubmF2aWdhdGlvbi1iYXIgLml0ZW0uYnV0dG9uLnRleHQtb25seSk6CisgICAg ICAgICgudGFiLWJhciA+IC5uYXZpZ2F0aW9uLWJhciAuaXRlbS5idXR0b24udGV4dC1vbmx5KToK KyAgICAgICAgKC50YWItYmFyID4gLm5hdmlnYXRpb24tYmFyIC5pdGVtLmJ1dHRvbi50ZXh0LW9u bHk6bm90KC5zZWxlY3RlZCk6aG92ZXIpOgorICAgICAgICAoLnRhYi1iYXIgPiAubmF2aWdhdGlv bi1iYXIgLml0ZW0uYnV0dG9uLnRleHQtb25seTpub3QoLmRpc2FibGVkKS5zZWxlY3RlZCk6Cisg ICAgICAgIChib2R5LndpbmRvdy1pbmFjdGl2ZSAudGFiLWJhciA+IC5uYXZpZ2F0aW9uLWJhciAu aXRlbS5idXR0b24udGV4dC1vbmx5Om5vdCguZGlzYWJsZWQpLnNlbGVjdGVkID4pOgorCiAyMDIw LTA4LTI0ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBhbGxvdyBldmVudCBicmVha3BvaW50cyB0byBiZSBjb25maWd1cmVkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwCmlu ZGV4IGYxYTcyYWRiNTA1MWI2YjI5MzYzZTAwNDBhNjM1ZjM5YTljNjQ1N2MuLjUwZTBjODNiYzky MDY2MmU3NjgwMjU1Nzc1MmIzNmYyMzc1YjAzOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwCkBAIC01NDYsOCArNTQ2LDEwIEBA IHZvaWQgSW5zcGVjdG9yRnJvbnRlbmRIb3N0OjpiZWVwKCkKIAogdm9pZCBJbnNwZWN0b3JGcm9u dGVuZEhvc3Q6Omluc3BlY3RJbnNwZWN0b3IoKQogewotICAgIGlmIChtX2Zyb250ZW5kUGFnZSkK KyAgICBpZiAobV9mcm9udGVuZFBhZ2UpIHsKKyAgICAgICAgbV9mcm9udGVuZFBhZ2UtPnNldHRp bmdzKCkuc2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCh0cnVlKTsKICAgICAgICAgbV9mcm9udGVu ZFBhZ2UtPmluc3BlY3RvckNvbnRyb2xsZXIoKS5zaG93KCk7CisgICAgfQogfQogCiBib29sIElu c3BlY3RvckZyb250ZW5kSG9zdDo6aXNCZWluZ0luc3BlY3RlZCgpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9EZWJ1Zy9Cb290c3RyYXAuY3NzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvRGVidWcvQm9vdHN0cmFwLmNzcwppbmRl eCA1NmE1OTk2Y2U0MDc5ZDA5ZDk5ZDIwZDg2YjFlZDI5ZDdjNWMzZDNjLi41ODU1NThhMjliMWMw MDYzYjljZDkzNjk0ZDMxYTAyOTVkYmU1MzA4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9EZWJ1Zy9Cb290c3RyYXAuY3NzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0RlYnVnL0Jvb3RzdHJhcC5jc3MKQEAgLTM2LDMgKzM2 LDIzIEBAIGJvZHkuZm9jdXMtZGVidWcgKjpmb2N1cyB7CiAudGFiLWJhciA+IC5uYXZpZ2F0aW9u LWJhciAuaW5zcGVjdC1pbnNwZWN0b3IgewogICAgIHdpZHRoOiAxZW0gIWltcG9ydGFudDsKIH0K KworLyogVGhlc2UgcnVsZXMgYXJlIGFkYXB0ZWQgZnJvbSBUYWJCYXIuY3NzIGFuZCBhcmUgZXhw ZWN0ZWQgdG8gbWF0Y2guICovCitib2R5LndpbmRvdy1pbmFjdGl2ZSAudGFiLWJhciA+IC5uYXZp Z2F0aW9uLWJhciAuaXRlbS5idXR0b24udGV4dC1vbmx5IHsKKyAgICBjb2xvcjogaHNsYSgwLCAw JSwgdmFyKC0tZm9yZWdyb3VuZC1saWdodG5lc3MpLCAwLjQpOworfQorLnRhYi1iYXIgPiAubmF2 aWdhdGlvbi1iYXIgLml0ZW0uYnV0dG9uLnRleHQtb25seSB7CisgICAgY29sb3I6IGhzbGEoMCwg MCUsIHZhcigtLWZvcmVncm91bmQtbGlnaHRuZXNzKSwgMC42KTsKK30KKworLnRhYi1iYXIgPiAu bmF2aWdhdGlvbi1iYXIgLml0ZW0uYnV0dG9uLnRleHQtb25seTpub3QoLnNlbGVjdGVkKTpob3Zl ciB7CisgICAgY29sb3I6IGhzbGEoMCwgMCUsIHZhcigtLWZvcmVncm91bmQtbGlnaHRuZXNzKSwg MC43KTsKK30KKworLnRhYi1iYXIgPiAubmF2aWdhdGlvbi1iYXIgLml0ZW0uYnV0dG9uLnRleHQt b25seTpub3QoLmRpc2FibGVkKS5zZWxlY3RlZCB7CisgICAgY29sb3I6IGhzbGEoMCwgMCUsIHZh cigtLWZvcmVncm91bmQtbGlnaHRuZXNzKSwgMC44KTsKK30KKworYm9keS53aW5kb3ctaW5hY3Rp dmUgLnRhYi1iYXIgPiAubmF2aWdhdGlvbi1iYXIgLml0ZW0uYnV0dG9uLnRleHQtb25seTpub3Qo LmRpc2FibGVkKS5zZWxlY3RlZCA+IHsKKyAgICBjb2xvcjogaHNsYSgwLCAwJSwgdmFyKC0tZm9y ZWdyb3VuZC1saWdodG5lc3MpLCAwLjUpOworfQo= 407377 2020-08-26 23:08:54 -0700 2020-08-26 23:46:59 -0700 Patch bug-215828-20200826230853.patch text/plain 4225 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWRlMzRkMWMyMmQzZDcz ZjIyMTI0ZGVhYzVlNjIxOTFlYTI2MThlZC4uNmFiYWQwNjZkMTdlMzYyYjVhNzRhZGFiMTM3NmNj MDc5YzYwYTc4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA4LTI2ICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorICAgICAgICBXZWIgSW5zcGVjdG9yOiBidXR0b24g Zm9yIEluc3BlY3Rvcl4yIGRvZXNuJ3Qgd29yayB3aXRob3V0IHNldHRpbmcgZGVmYXVsdCBmb3Ig RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjE1ODI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGV2aW4gUm91c3Nv LgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JGcm9udGVuZEhvc3Q6Omluc3BlY3RJbnNwZWN0b3IpOgor ICAgICAgICBFeHBsaWNpdGx5IHNldCBEZXZlbG9wZXJFeHRyYXNFbmFibGVkIGZvciB0aGUgSW5z cGVjdG9yCisgICAgICAgIHdlYiB2aWV3IHNvIHRoYXQgdGhlIEluc3BlY3QgY29udGV4dCBtZW51 IGFwcGVhcnMgYW5kCisgICAgICAgIHNvIHRoZSBbMl0gYnV0dG9uIHdvcmtzIGFzIGV4cGVjdGVk LgorCiAyMDIwLTA4LTI0ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBhbGxvdyBldmVudCBicmVha3BvaW50cyB0byBiZSBjb25maWd1 cmVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBiOGYzNmQ1MDVmZWNkZDBlYjU4YmFlYjhm YTBiMjEyY2M4MWZmODQ5Li5lMzQ5OWU2NjM1Mzk0MTUxN2Y1YWIwYjYwNjY3M2VhNWIxMTQyMzA1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAyMC0wOC0yNiAg QnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBi dXR0b24gZm9yIEluc3BlY3Rvcl4yIGRvZXNuJ3Qgd29yayB3aXRob3V0IHNldHRpbmcgZGVmYXVs dCBmb3IgRGV2ZWxvcGVyRXh0cmFzRW5hYmxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1ODI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGV2aW4g Um91c3NvLgorCisgICAgICAgIERyaXZlLWJ5OiBiZWNhdXNlIHRoZSBJbnNwZWN0b3JeMiBidXR0 b24gaXMgdGV4dC1vbmx5IGFuZCBoYXMgbm8KKyAgICAgICAgLm5hbWUgZWxlbWVudCwgdGhlICcy JyBidXR0b24gZG9lcyBub3QgYmVjb21lIGRpbW1lZCB3aGVuIHRoZQorICAgICAgICB3aW5kb3cg aXMgaW5hY3RpdmUsIHVubGlrZSBldmVyeSBvdGhlciBpdGVtIGluIHRoZSB0YWIgYmFyLgorICAg ICAgICBGaXggdGhpcyBieSBjb2xvcmluZyB0aGUgdGV4dC1vbmx5IGJ1dHRvbiBzaW1pbGFyIHRv IHRhYiBsYWJlbHMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0RlYnVnL0Jvb3RzdHJhcC5j c3M6CisgICAgICAgIChib2R5LndpbmRvdy1pbmFjdGl2ZSAudGFiLWJhciA+IC5uYXZpZ2F0aW9u LWJhciAuaXRlbS5idXR0b24udGV4dC1vbmx5KToKKyAgICAgICAgKC50YWItYmFyID4gLm5hdmln YXRpb24tYmFyIC5pdGVtLmJ1dHRvbi50ZXh0LW9ubHkpOgorICAgICAgICAoLnRhYi1iYXIgPiAu bmF2aWdhdGlvbi1iYXIgLml0ZW0uYnV0dG9uLnRleHQtb25seTpub3QoLnNlbGVjdGVkKTpob3Zl cik6CisgICAgICAgICgudGFiLWJhciA+IC5uYXZpZ2F0aW9uLWJhciAuaXRlbS5idXR0b24udGV4 dC1vbmx5Om5vdCguZGlzYWJsZWQpLnNlbGVjdGVkKToKKyAgICAgICAgKGJvZHkud2luZG93LWlu YWN0aXZlIC50YWItYmFyID4gLm5hdmlnYXRpb24tYmFyIC5pdGVtLmJ1dHRvbi50ZXh0LW9ubHk6 bm90KC5kaXNhYmxlZCkuc2VsZWN0ZWQgPik6CisKIDIwMjAtMDgtMjQgIERldmluIFJvdXNzbyAg PGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFsbG93IGV2ZW50 IGJyZWFrcG9pbnRzIHRvIGJlIGNvbmZpZ3VyZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAKaW5kZXggZjFhNzJhZGI1MDUxYjZiMjkz NjNlMDA0MGE2MzVmMzlhOWM2NDU3Yy4uNTBlMGM4M2JjOTIwNjYyZTc2ODAyNTU3NzUyYjM2ZjIz NzViMDM5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZy b250ZW5kSG9zdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZy b250ZW5kSG9zdC5jcHAKQEAgLTU0Niw4ICs1NDYsMTAgQEAgdm9pZCBJbnNwZWN0b3JGcm9udGVu ZEhvc3Q6OmJlZXAoKQogCiB2b2lkIEluc3BlY3RvckZyb250ZW5kSG9zdDo6aW5zcGVjdEluc3Bl Y3RvcigpCiB7Ci0gICAgaWYgKG1fZnJvbnRlbmRQYWdlKQorICAgIGlmIChtX2Zyb250ZW5kUGFn ZSkgeworICAgICAgICBtX2Zyb250ZW5kUGFnZS0+c2V0dGluZ3MoKS5zZXREZXZlbG9wZXJFeHRy YXNFbmFibGVkKHRydWUpOwogICAgICAgICBtX2Zyb250ZW5kUGFnZS0+aW5zcGVjdG9yQ29udHJv bGxlcigpLnNob3coKTsKKyAgICB9CiB9CiAKIGJvb2wgSW5zcGVjdG9yRnJvbnRlbmRIb3N0Ojpp c0JlaW5nSW5zcGVjdGVkKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL0RlYnVnL0Jvb3RzdHJhcC5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9EZWJ1Zy9Cb290c3RyYXAuY3NzCmluZGV4IDU2YTU5OTZjZTQwNzlkMDlkOTlk MjBkODZiMWVkMjlkN2M1YzNkM2MuLjU4NTU1OGEyOWIxYzAwNjNiOWNkOTM2OTRkMzFhMDI5NWRi ZTUzMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Rl YnVnL0Jvb3RzdHJhcC5jc3MKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvRGVidWcvQm9vdHN0cmFwLmNzcwpAQCAtMzYsMyArMzYsMjMgQEAgYm9keS5mb2N1cy1kZWJ1 ZyAqOmZvY3VzIHsKIC50YWItYmFyID4gLm5hdmlnYXRpb24tYmFyIC5pbnNwZWN0LWluc3BlY3Rv ciB7CiAgICAgd2lkdGg6IDFlbSAhaW1wb3J0YW50OwogfQorCisvKiBUaGVzZSBydWxlcyBhcmUg YWRhcHRlZCBmcm9tIFRhYkJhci5jc3MgYW5kIGFyZSBleHBlY3RlZCB0byBtYXRjaC4gKi8KK2Jv ZHkud2luZG93LWluYWN0aXZlIC50YWItYmFyID4gLm5hdmlnYXRpb24tYmFyIC5pdGVtLmJ1dHRv bi50ZXh0LW9ubHkgeworICAgIGNvbG9yOiBoc2xhKDAsIDAlLCB2YXIoLS1mb3JlZ3JvdW5kLWxp Z2h0bmVzcyksIDAuNCk7Cit9CisudGFiLWJhciA+IC5uYXZpZ2F0aW9uLWJhciAuaXRlbS5idXR0 b24udGV4dC1vbmx5IHsKKyAgICBjb2xvcjogaHNsYSgwLCAwJSwgdmFyKC0tZm9yZWdyb3VuZC1s aWdodG5lc3MpLCAwLjYpOworfQorCisudGFiLWJhciA+IC5uYXZpZ2F0aW9uLWJhciAuaXRlbS5i dXR0b24udGV4dC1vbmx5Om5vdCguc2VsZWN0ZWQpOmhvdmVyIHsKKyAgICBjb2xvcjogaHNsYSgw LCAwJSwgdmFyKC0tZm9yZWdyb3VuZC1saWdodG5lc3MpLCAwLjcpOworfQorCisudGFiLWJhciA+ IC5uYXZpZ2F0aW9uLWJhciAuaXRlbS5idXR0b24udGV4dC1vbmx5Om5vdCguZGlzYWJsZWQpLnNl bGVjdGVkIHsKKyAgICBjb2xvcjogaHNsYSgwLCAwJSwgdmFyKC0tZm9yZWdyb3VuZC1saWdodG5l c3MpLCAwLjgpOworfQorCitib2R5LndpbmRvdy1pbmFjdGl2ZSAudGFiLWJhciA+IC5uYXZpZ2F0 aW9uLWJhciAuaXRlbS5idXR0b24udGV4dC1vbmx5Om5vdCguZGlzYWJsZWQpLnNlbGVjdGVkID4g eworICAgIGNvbG9yOiBoc2xhKDAsIDAlLCB2YXIoLS1mb3JlZ3JvdW5kLWxpZ2h0bmVzcyksIDAu NSk7Cit9Cg==