21581 2008-10-13 16:14:25 -0700 http/tests/misc/frame-default-enc-same-domain.html should not depend on the presence of x-mac-cyrillic converter 2008-10-22 01:10:54 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Trivial --- 1 jshin abarth abarth ap oldest_to_newest 95227 0 jshin 2008-10-13 16:14:25 -0700 http/tests/misc/frame-default-enc-same-domain.html has meta charset declaration for x-mac-cyrillic. However, the test is for the inheritance of charset from the parent frame. Some projects using webkit (e.g. Chrome) use their own custom build of ICU without x-mac-cyrillic converter. It's not a good idea to make a single test depend on something other than what it intends to test. 95230 1 24333 jshin 2008-10-13 17:16:20 -0700 Created attachment 24333 patch This patch replaces x-mac-cyrillic with windows-1251 95238 2 24333 darin 2008-10-13 18:01:55 -0700 Comment on attachment 24333 patch r=me 95255 3 abarth 2008-10-14 01:19:22 -0700 Will land. 95277 4 abarth 2008-10-14 03:01:49 -0700 My Mac Mini died in the middle of testing this patch. I'm going to take it into the store tomorrow. 95281 5 24333 ap 2008-10-14 04:06:03 -0700 Comment on attachment 24333 patch Sorry, I specifically chose MacCyrillic to make this test work reasonably on my machine (where I have windows-1251 as a default encoding). I'd ask you to change this to some encoding that is unlikely to be user default for any WebKit developer. On another note, I'm surprised that you can get away without supporting MacCyrillic - this encoding is in wide use on the Web. Many Russian sites re-encode their text to MacCyrillic on the fly if they see "Mac" in UA string (a practice that makes no sense in this age, but anyway). Maybe you don't get bug reports about this because you only have a Windows beta now? 95336 6 abarth 2008-10-14 12:29:28 -0700 Reassigning to Jungshik based on comment above. 95340 7 jshin 2008-10-14 12:45:30 -0700 (In reply to comment #5) > (From update of attachment 24333 [edit]) > Sorry, I specifically chose MacCyrillic to make this test work reasonably on my > machine (where I have windows-1251 as a default encoding). I'd ask you to > change this to some encoding that is unlikely to be user default for any WebKit > developer. Sure, I can change (to what encoding? I'll try to get the most unlikely one), but does it really matter in layout test? > On another note, I'm surprised that you can get away without supporting > MacCyrillic - this encoding is in wide use on the Web. Many Russian sites > re-encode their text to MacCyrillic on the fly if they see "Mac" in UA string > (a practice that makes no sense in this age, but anyway). Maybe you don't get > bug reports about this because you only have a Windows beta now? I'm aware of the practice. I have little idea how widespread the practice is. mail.ru was one of them, but it does not do that any more, does it? Anyway, if the practice is still widespread, I'll add it back (before we release Mac version) paying the price for one more item in the encoding list and a few more kBs in the ICU data file :-) 95345 8 ap 2008-10-14 13:04:38 -0700 (In reply to comment #7) > Sure, I can change (to what encoding? I'll try to get the most unlikely one), > but does it really matter in layout test? Yes, we try to make layout tests work in the browser if possible. This reduces confusion and simplifies debugging in case the test breaks. ISO-8859-5 is another example of a Cyrillic encoding that is unlikely to be default for many people. > I'm aware of the practice. I have little idea how widespread the practice is. > mail.ru was one of them, but it does not do that any more, does it? Anyway, if > the practice is still widespread, I'll add it back (before we release Mac > version) paying the price for one more item in the encoding list and a few > more kBs in the ICU data file :-) I don't have any current examples. Besides mail.ru, anekdot.ru used to do the same until very recently, and these are some of the largest resources out there. Also, this was the default configuration of Russian Apache distribution, so I expect that sites doing this will be around for a long time. 95355 9 24346 jshin 2008-10-14 14:30:26 -0700 Created attachment 24346 patch with windows-1256 I replaced windows-1251 with windows-1256 (Arabic) 95372 10 jshin 2008-10-14 17:14:58 -0700 (In reply to comment #9) > Created an attachment (id=24346) [edit] > patch with windows-1256 > > I replaced windows-1251 with windows-1256 (Arabic) My patch and Alexey's reply 'crossed in mail'. Anyway, I guess windows-1256 should be as good as ISO-8859-5. ISO-8859-15 would have been better :-) As for Russian Apache (mod_charset), does the current version still do that? If so, at least we should ask them to not to do it any more. 95385 11 24346 ap 2008-10-15 00:05:09 -0700 Comment on attachment 24346 patch with windows-1256 r=me > As for Russian Apache (mod_charset), does the current version still do that? If > so, at least we should ask them to not to do it any more. I used to think that it was no longer maintained, but it turns out to be not quite so. Anyway, according to documentation, the default for CharsetAgent is empty now. 96099 12 jshin 2008-10-21 13:46:16 -0700 Adam or Alexey, can you land the latest patch? 96119 13 abarth 2008-10-21 15:49:30 -0700 Yep. Assigned. 96151 14 abarth 2008-10-22 01:10:54 -0700 Fixed in http://trac.webkit.org/changeset/37775 24333 2008-10-13 17:16:20 -0700 2008-10-14 14:30:26 -0700 patch 21581.patch.1 text/plain 1471 jshin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM3NTY3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDgtMTAtMTMgIEp1bmdzaGlrIFNoaW4gIDxq c2hpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21pc2MvZnJhbWUtZGVmYXVsdC1lbmMtc2FtZS1kb21h aW4tZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbWlzYy9mcmFtZS1kZWZhdWx0 LWVuYy1zYW1lLWRvbWFpbi5odG1sOgorCiAyMDA4LTEwLTEzICBDaHJpcyBGbGVpemFjaCAgPGNm bGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4KSW5k ZXg6IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9mcmFtZS1kZWZhdWx0LWVuYy1zYW1lLWRv bWFpbi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9t aXNjL2ZyYW1lLWRlZmF1bHQtZW5jLXNhbWUtZG9tYWluLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g Mzc1NjcpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZnJhbWUtZGVmYXVsdC1lbmMt c2FtZS1kb21haW4tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDIgKzEsMiBAQAot QUxFUlQ6IHgtbWFjLWN5cmlsbGljCitBTEVSVDogd2luZG93cy0xMjUxCiAKSW5kZXg6IExheW91 dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9mcmFtZS1kZWZhdWx0LWVuYy1zYW1lLWRvbWFpbi5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9mcmFtZS1kZWZhdWx0 LWVuYy1zYW1lLWRvbWFpbi5odG1sCShyZXZpc2lvbiAzNzU2NykKKysrIExheW91dFRlc3RzL2h0 dHAvdGVzdHMvbWlzYy9mcmFtZS1kZWZhdWx0LWVuYy1zYW1lLWRvbWFpbi5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0xLDYgKzEsNiBAQAogPGh0bWw+CiA8aGVhZD4KLTxtZXRhIGh0dHAtZXF1aXY9 ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXgtbWFjLWN5cmlsbGlj Ij4KKzxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4dC9odG1sOyBj aGFyc2V0PXdpbmRvd3MtMTI1MSI+CiA8dGl0bGU+RnJhbWVzIGFuZCBlbmNvZGluZ3M8L3RpdGxl PgogPHNjcmlwdD4KIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCg== 24346 2008-10-14 14:30:26 -0700 2008-10-15 00:05:09 -0700 patch with windows-1256 21581.patch.2 text/plain 1633 jshin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM3NTkxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTAtMTQgIEp1bmdzaGlrIFNoaW4gIDxq c2hpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgLSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1 ODEKKworICAgICAgICBSZXBsYWNlIHgtbWFjLWN5cmlsbGljIGJ5IHdpbmRvd3MtMTI1Ni4gCisK KyAgICAgICAgKiBodHRwL3Rlc3RzL21pc2MvZnJhbWUtZGVmYXVsdC1lbmMtc2FtZS1kb21haW4t ZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGh0dHAvdGVzdHMvbWlzYy9mcmFtZS1kZWZhdWx0LWVu Yy1zYW1lLWRvbWFpbi5odG1sOgorCiAyMDA4LTEwLTE0ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgbGF5b3V0IHRlc3RzIGZvciBib2R5IHByb3BhZ2F0aW9u IG9mIG92ZXJmbG93IGFuZCBiYWNrZ3JvdW5kIHRvIHRoZSB2aWV3cG9ydC4KSW5kZXg6IExheW91 dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9mcmFtZS1kZWZhdWx0LWVuYy1zYW1lLWRvbWFpbi1leHBl Y3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL2ZyYW1l LWRlZmF1bHQtZW5jLXNhbWUtZG9tYWluLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMzc1OTEpCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZnJhbWUtZGVmYXVsdC1lbmMtc2FtZS1kb21h aW4tZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDIgKzEsMiBAQAotQUxFUlQ6IHgt bWFjLWN5cmlsbGljCitBTEVSVDogd2luZG93cy0xMjU2CiAKSW5kZXg6IExheW91dFRlc3RzL2h0 dHAvdGVzdHMvbWlzYy9mcmFtZS1kZWZhdWx0LWVuYy1zYW1lLWRvbWFpbi5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9mcmFtZS1kZWZhdWx0LWVuYy1zYW1l LWRvbWFpbi5odG1sCShyZXZpc2lvbiAzNzU5MSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMv bWlzYy9mcmFtZS1kZWZhdWx0LWVuYy1zYW1lLWRvbWFpbi5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0xLDYgKzEsNiBAQAogPGh0bWw+CiA8aGVhZD4KLTxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQt dHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXgtbWFjLWN5cmlsbGljIj4KKzxtZXRh IGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXdp bmRvd3MtMTI1NiI+CiA8dGl0bGU+RnJhbWVzIGFuZCBlbmNvZGluZ3M8L3RpdGxlPgogPHNjcmlw dD4KIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCg==