215777 2020-08-24 12:21:40 -0700 [ews] set references header in email so as to group similar emails together 2020-08-24 15:46:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 215220 1 aakash_jain aakash_jain aakash_jain ap jbedard kocsen_chung ryanhaddad webkit-bug-importer oldest_to_newest 1682427 0 aakash_jain 2020-08-24 12:21:40 -0700 We should set 'references' header in ews email notifications, so as the mail client can group similar emails together. We should set same 'references' header for all the emails we want to be grouped together. 1682433 1 407123 aakash_jain 2020-08-24 12:32:14 -0700 Created attachment 407123 Patch 1682465 2 407123 jbedard 2020-08-24 15:02:10 -0700 Comment on attachment 407123 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407123&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1493 > + send_email_to_patch_author(patch_author, email_subject, email_text, patch_id) Looks good, although for https://bugs.webkit.org/show_bug.cgi?id=215776, don't we need to do this for test failure emails too? And should test failures and build failures be in the same thread? 1682466 3 407123 jbedard 2020-08-24 15:08:58 -0700 Comment on attachment 407123 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=407123&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:1493 >> + send_email_to_patch_author(patch_author, email_subject, email_text, patch_id) > > Looks good, although for https://bugs.webkit.org/show_bug.cgi?id=215776, don't we need to do this for test failure emails too? And should test failures and build failures be in the same thread? Nevermind, just noticed that on line 2167 1682484 4 aakash_jain 2020-08-24 15:45:12 -0700 Committed r266088: <https://trac.webkit.org/changeset/266088> 1682485 5 webkit-bug-importer 2020-08-24 15:46:19 -0700 <rdar://problem/67703820> 407123 2020-08-24 12:32:14 -0700 2020-08-24 15:02:54 -0700 Patch bug-215777-20200824153213.patch text/plain 6342 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NjA4MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIxIEBACisyMDIwLTA4LTI0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBzZXQgcmVmZXJlbmNlcyBoZWFkZXIgaW4gZW1haWwgc28gYXMg dG8gZ3JvdXAgc2ltaWxhciBlbWFpbHMgdG9nZXRoZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTc3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3Nl bmRfZW1haWwucHk6CisgICAgICAgIChzZW5kX2VtYWlsKTogQWRkIHN1cHBvcnQgZm9yIHNldHRp bmcgcmVmZXJlbmNlcyBoZWFkZXIuCisgICAgICAgIChzZW5kX2VtYWlsX3RvX3BhdGNoX2F1dGhv cik6CisgICAgICAgIChzZW5kX2VtYWlsX3RvX2JvdF93YXRjaGVycyk6CisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQW5hbHl6ZUNvbXBp bGVXZWJLaXRSZXN1bHRzLnNlbmRfZW1haWxfZm9yX25ld19idWlsZF9mYWlsdXJlKTogU2V0IHJl ZmVyZW5jZXMgaGVhZGVyIGFwcHJvcHJpYXRlbHkuCisgICAgICAgIChSZVJ1bldlYktpdFRlc3Rz LnNlbmRfZW1haWxfZm9yX2ZsYWt5X2ZhaWx1cmUpOiBEaXR0by4KKyAgICAgICAgKEFuYWx5emVM YXlvdXRUZXN0c1Jlc3VsdHMuc2VuZF9lbWFpbF9mb3JfZmxha3lfZmFpbHVyZSk6IERpdHRvLgor ICAgICAgICAoQW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cy5zZW5kX2VtYWlsX2Zvcl9wcmVfZXhp c3RpbmdfZmFpbHVyZSk6IERpdHRvLgorICAgICAgICAoQW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0 cy5zZW5kX2VtYWlsX2Zvcl9uZXdfdGVzdF9mYWlsdXJlcyk6IERpdHRvLgorCiAyMDIwLTA4LTI0 ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBbcmVzdWx0 c2RicHldIEZpeCBwaXAgcGFja2FnZQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL3NlbmRfZW1haWwucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvZXdzLWJ1aWxkL3NlbmRfZW1haWwucHkJKHJldmlzaW9uIDI2NjA4MykKKysrIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zZW5kX2VtYWlsLnB5CSh3b3JraW5nIGNvcHkpCkBA IC00Miw3ICs0Miw3IEBAIGRlZiBnZXRfZW1haWxfaWRzKGNhdGVnb3J5KToKICAgICAgICAgcmV0 dXJuIFtdCiAKIAotZGVmIHNlbmRfZW1haWwodG9fZW1haWxzLCBzdWJqZWN0LCB0ZXh0KToKK2Rl ZiBzZW5kX2VtYWlsKHRvX2VtYWlscywgc3ViamVjdCwgdGV4dCwgcmVmZXJlbmNlPScnKToKICAg ICBpZiBpc190ZXN0X21vZGVfZW5hYmxlZDoKICAgICAgICAgcmV0dXJuCiAgICAgaWYgbm90IHRv X2VtYWlsczoKQEAgLTU5LDIwICs1OSwyMiBAQCBkZWYgc2VuZF9lbWFpbCh0b19lbWFpbHMsIHN1 YmplY3QsIHRleHQpCiAgICAgbXNnWydGcm9tJ10gPSBGUk9NX0VNQUlMCiAgICAgbXNnWydUbydd ID0gJywgJy5qb2luKHRvX2VtYWlscykKICAgICBtc2dbJ1N1YmplY3QnXSA9IHN1YmplY3QKKyAg ICBpZiByZWZlcmVuY2U6CisgICAgICAgIG1zZy5hZGRfaGVhZGVyKCdyZWZlcmVuY2VzJywgJ3t9 QHdlYmtpdC5vcmcnLmZvcm1hdChyZWZlcmVuY2UpKQogCiAgICAgc2VydmVyID0gc210cGxpYi5T TVRQKFNFUlZFUikKICAgICBzZXJ2ZXIuc2VuZG1haWwoRlJPTV9FTUFJTCwgdG9fZW1haWxzLCBt c2cuYXNfc3RyaW5nKCkpCiAgICAgc2VydmVyLnF1aXQoKQogCiAKLWRlZiBzZW5kX2VtYWlsX3Rv X3BhdGNoX2F1dGhvcihhdXRob3JfZW1haWwsIHN1YmplY3QsIHRleHQpOgorZGVmIHNlbmRfZW1h aWxfdG9fcGF0Y2hfYXV0aG9yKGF1dGhvcl9lbWFpbCwgc3ViamVjdCwgdGV4dCwgcmVmZXJlbmNl PScnKToKICAgICBpZiBub3QgYXV0aG9yX2VtYWlsOgogICAgICAgICByZXR1cm4KICAgICBpZiBh dXRob3JfZW1haWwgaW4gZ2V0X2VtYWlsX2lkcygnRU1BSUxfSURTX1RPX1VOU1VCU0NSSUJFJyk6 CiAgICAgICAgIHByaW50KCdlbWFpbCB7fSBpcyBpbiB1bnN1YnNjcmliZSBsaXN0LCBza2lwcGlu ZyBlbWFpbCcuZm9ybWF0KGF1dGhvcl9lbWFpbCkpCiAgICAgICAgIHJldHVybgotICAgIHNlbmRf ZW1haWwoW2F1dGhvcl9lbWFpbF0sIHN1YmplY3QsIHRleHQpCisgICAgc2VuZF9lbWFpbChbYXV0 aG9yX2VtYWlsXSwgc3ViamVjdCwgdGV4dCwgcmVmZXJlbmNlKQogCiAKLWRlZiBzZW5kX2VtYWls X3RvX2JvdF93YXRjaGVycyhzdWJqZWN0LCB0ZXh0KToKLSAgICBzZW5kX2VtYWlsKGdldF9lbWFp bF9pZHMoJ0JPVF9XQVRDSEVSU19FTUFJTFMnKSwgc3ViamVjdCwgdGV4dCkKK2RlZiBzZW5kX2Vt YWlsX3RvX2JvdF93YXRjaGVycyhzdWJqZWN0LCB0ZXh0LCByZWZlcmVuY2U9JycpOgorICAgIHNl bmRfZW1haWwoZ2V0X2VtYWlsX2lkcygnQk9UX1dBVENIRVJTX0VNQUlMUycpLCBzdWJqZWN0LCB0 ZXh0LCByZWZlcmVuY2UpCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxk L3N0ZXBzLnB5CShyZXZpc2lvbiAyNjYwODMpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTE0OTAsNyArMTQ5MCw3IEBAIGNs YXNzIEFuYWx5emVDb21waWxlV2ViS2l0UmVzdWx0cyhidWlsZHMKICAgICAgICAgICAgICAgICBs b2dzID0gbG9ncy5yZXBsYWNlKCcmJywgJyZhbXA7JykucmVwbGFjZSgnPCcsICcmbHQ7JykucmVw bGFjZSgnPicsICcmZ3Q7JykKICAgICAgICAgICAgICAgICBlbWFpbF90ZXh0ICs9IHUnXG5cbkVy cm9yIGxpbmVzOlxuXG48Y29kZT57fTwvY29kZT4nLmZvcm1hdChsb2dzKQogICAgICAgICAgICAg ZW1haWxfdGV4dCArPSAnXG5cblRvIHVuc3Vic2NyaWJsZSBmcm9tIHRoZXNlIG5vdGlmaWNhdGlv bnMgb3IgdG8gcHJvdmlkZSBhbnkgZmVlZGJhY2sgcGxlYXNlIGVtYWlsIGFha2FzaF9qYWluQGFw cGxlLmNvbScKLSAgICAgICAgICAgIHNlbmRfZW1haWxfdG9fcGF0Y2hfYXV0aG9yKHBhdGNoX2F1 dGhvciwgZW1haWxfc3ViamVjdCwgZW1haWxfdGV4dCkKKyAgICAgICAgICAgIHNlbmRfZW1haWxf dG9fcGF0Y2hfYXV0aG9yKHBhdGNoX2F1dGhvciwgZW1haWxfc3ViamVjdCwgZW1haWxfdGV4dCwg cGF0Y2hfaWQpCiAgICAgICAgIGV4Y2VwdCBFeGNlcHRpb24gYXMgZToKICAgICAgICAgICAgIHBy aW50KCdFcnJvciBpbiBzZW5kaW5nIGVtYWlsIGZvciBuZXcgYnVpbGQgZmFpbHVyZToge30nLmZv cm1hdChlKSkKIApAQCAtMjAyNyw3ICsyMDI3LDcgQEAgY2xhc3MgUmVSdW5XZWJLaXRUZXN0cyhS dW5XZWJLaXRUZXN0cyk6CiAgICAgICAgICAgICBlbWFpbF9zdWJqZWN0ID0gdSdGbGFreSB0ZXN0 OiB7fScuZm9ybWF0KHRlc3RfbmFtZSkKICAgICAgICAgICAgIGVtYWlsX3RleHQgPSAnVGVzdCB7 fSBmbGFrZWQgaW4ge31cblxuQnVpbGRlcjoge30nLmZvcm1hdCh0ZXN0X25hbWUsIGJ1aWxkX3Vy bCwgYnVpbGRlcl9uYW1lKQogICAgICAgICAgICAgZW1haWxfdGV4dCA9ICdGbGFreSB0ZXN0OiB7 fVxuXG5CdWlsZDoge31cblxuQnVpbGRlcjoge31cblxuV29ya2VyOiB7fVxuXG5IaXN0b3J5OiB7 fScuZm9ybWF0KHRlc3RfbmFtZSwgYnVpbGRfdXJsLCBidWlsZGVyX25hbWUsIHdvcmtlcl9uYW1l LCBoaXN0b3J5X3VybCkKLSAgICAgICAgICAgIHNlbmRfZW1haWxfdG9fYm90X3dhdGNoZXJzKGVt YWlsX3N1YmplY3QsIGVtYWlsX3RleHQpCisgICAgICAgICAgICBzZW5kX2VtYWlsX3RvX2JvdF93 YXRjaGVycyhlbWFpbF9zdWJqZWN0LCBlbWFpbF90ZXh0LCAnZmxha3kte30nLmZvcm1hdCh0ZXN0 X25hbWUpKQogICAgICAgICBleGNlcHQgRXhjZXB0aW9uIGFzIGU6CiAgICAgICAgICAgICAjIENh dGNoaW5nIGFsbCBleGNlcHRpb25zIGhlcmUgdG8gZW5zdXJlIHRoYXQgZmFpbHVyZSB0byBzZW5k IGVtYWlsIGRvZXNuJ3QgaW1wYWN0IHRoZSBidWlsZAogICAgICAgICAgICAgcHJpbnQoJ0Vycm9y IGluIHNlbmRpbmcgZW1haWwgZm9yIGZsYWt5IGZhaWx1cmVzOiB7fScuZm9ybWF0KGUpKQpAQCAt MjEyNSw3ICsyMTI1LDcgQEAgY2xhc3MgQW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cyhidWlsZHN0 ZQogCiAgICAgICAgICAgICBlbWFpbF9zdWJqZWN0ID0gdSdGbGFreSB0ZXN0OiB7fScuZm9ybWF0 KHRlc3RfbmFtZSkKICAgICAgICAgICAgIGVtYWlsX3RleHQgPSAnRmxha3kgdGVzdDoge31cblxu QnVpbGQ6IHt9XG5cbkJ1aWxkZXI6IHt9XG5cbldvcmtlcjoge31cblxuSGlzdG9yeToge30nLmZv cm1hdCh0ZXN0X25hbWUsIGJ1aWxkX3VybCwgYnVpbGRlcl9uYW1lLCB3b3JrZXJfbmFtZSwgaGlz dG9yeV91cmwpCi0gICAgICAgICAgICBzZW5kX2VtYWlsX3RvX2JvdF93YXRjaGVycyhlbWFpbF9z dWJqZWN0LCBlbWFpbF90ZXh0KQorICAgICAgICAgICAgc2VuZF9lbWFpbF90b19ib3Rfd2F0Y2hl cnMoZW1haWxfc3ViamVjdCwgZW1haWxfdGV4dCwgJ2ZsYWt5LXt9Jy5mb3JtYXQodGVzdF9uYW1l KSkKICAgICAgICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBlOgogICAgICAgICAgICAgcHJpbnQoJ0Vy cm9yIGluIHNlbmRpbmcgZW1haWwgZm9yIGZsYWt5IGZhaWx1cmU6IHt9Jy5mb3JtYXQoZSkpCiAK QEAgLTIxMzgsNyArMjEzOCw3IEBAIGNsYXNzIEFuYWx5emVMYXlvdXRUZXN0c1Jlc3VsdHMoYnVp bGRzdGUKIAogICAgICAgICAgICAgZW1haWxfc3ViamVjdCA9IHUnUHJlLWV4aXN0aW5nIHRlc3Qg ZmFpbHVyZToge30nLmZvcm1hdCh0ZXN0X25hbWUpCiAgICAgICAgICAgICBlbWFpbF90ZXh0ID0g J1Rlc3Qge30gZmFpbGVkIG9uIGNsZWFuIHRyZWUgcnVuIGluIHt9LlxuXG5CdWlsZGVyOiB7fVxu XG5Xb3JrZXI6IHt9XG5cbkhpc3Rvcnk6IHt9Jy5mb3JtYXQodGVzdF9uYW1lLCBidWlsZF91cmws IGJ1aWxkZXJfbmFtZSwgd29ya2VyX25hbWUsIGhpc3RvcnlfdXJsKQotICAgICAgICAgICAgc2Vu ZF9lbWFpbF90b19ib3Rfd2F0Y2hlcnMoZW1haWxfc3ViamVjdCwgZW1haWxfdGV4dCkKKyAgICAg ICAgICAgIHNlbmRfZW1haWxfdG9fYm90X3dhdGNoZXJzKGVtYWlsX3N1YmplY3QsIGVtYWlsX3Rl eHQsICdwcmVleGlzdGluZy17fScuZm9ybWF0KHRlc3RfbmFtZSkpCiAgICAgICAgIGV4Y2VwdCBF eGNlcHRpb24gYXMgZToKICAgICAgICAgICAgIHByaW50KCdFcnJvciBpbiBzZW5kaW5nIGVtYWls IGZvciBwcmUtZXhpc3RpbmcgZmFpbHVyZToge30nLmZvcm1hdChlKSkKIApAQCAtMjE2NCw3ICsy MTY0LDcgQEAgY2xhc3MgQW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cyhidWlsZHN0ZQogICAgICAg ICAgICAgZW1haWxfdGV4dCArPSAnXG5cbkZ1bGwgZGV0YWlscyBhcmUgYXZhaWxhYmxlIGF0OiB7 fVxuXG5QYXRjaCBhdXRob3I6IHt9Jy5mb3JtYXQoYnVpbGRfdXJsLCBwYXRjaF9hdXRob3IpCiAg ICAgICAgICAgICBlbWFpbF90ZXh0ICs9ICdcblxuTGF5b3V0IHRlc3QgZmFpbHVyZXt9Olxue30n LmZvcm1hdChwbHVyYWxTdWZmaXgsIHRlc3RfbmFtZXNfc3RyaW5nKQogICAgICAgICAgICAgZW1h aWxfdGV4dCArPSAnXG5cblRvIHVuc3Vic2NyaWJsZSBmcm9tIHRoZXNlIG5vdGlmaWNhdGlvbnMg b3IgdG8gcHJvdmlkZSBhbnkgZmVlZGJhY2sgcGxlYXNlIGVtYWlsIGFha2FzaF9qYWluQGFwcGxl LmNvbScKLSAgICAgICAgICAgIHNlbmRfZW1haWxfdG9fcGF0Y2hfYXV0aG9yKHBhdGNoX2F1dGhv ciwgZW1haWxfc3ViamVjdCwgZW1haWxfdGV4dCkKKyAgICAgICAgICAgIHNlbmRfZW1haWxfdG9f cGF0Y2hfYXV0aG9yKHBhdGNoX2F1dGhvciwgZW1haWxfc3ViamVjdCwgZW1haWxfdGV4dCwgcGF0 Y2hfaWQpCiAgICAgICAgIGV4Y2VwdCBFeGNlcHRpb24gYXMgZToKICAgICAgICAgICAgIHByaW50 KCdFcnJvciBpbiBzZW5kaW5nIGVtYWlsIGZvciBuZXcgbGF5b3V0IHRlc3QgZmFpbHVyZXM6IHt9 Jy5mb3JtYXQoZSkpCiAK