215776 2020-08-24 12:07:15 -0700 [ews] enable email notifications to patch authors for build or layout test failures on their patch 2020-08-25 04:35:36 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215231 https://bugs.webkit.org/show_bug.cgi?id=215219 InRadar P2 Normal --- 215220 1 aakash_jain aakash_jain aakash_jain ap hi jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1682418 0 aakash_jain 2020-08-24 12:07:15 -0700 Enable EWS email notifications to patch authors for build or layout test failures on their patch. High level details are in Bug 215220. 1682420 1 407120 aakash_jain 2020-08-24 12:10:04 -0700 Created attachment 407120 Patch 1682468 2 407120 jbedard 2020-08-24 15:11:14 -0700 Comment on attachment 407120 Patch r+ing this. But we should note that this has the potential to be pretty controversial. The feedback on Slack has been somewhat mixed. I think a Monday is a good time to land, it gives us a whole week to revert if engineers find this annoying. 1682486 3 aakash_jain 2020-08-24 15:46:53 -0700 Committed r266089: <https://trac.webkit.org/changeset/266089> 1682487 4 webkit-bug-importer 2020-08-24 15:47:17 -0700 <rdar://problem/67703852> 1682620 5 aakash_jain 2020-08-25 04:35:36 -0700 Restarted buildbot to pick up this change. 407120 2020-08-24 12:10:04 -0700 2020-08-24 15:11:14 -0700 Patch bug-215776-20200824151003.patch text/plain 1922 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NjA4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTA4LTI0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBlbmFibGUgZW1haWwgbm90aWZpY2F0aW9ucyB0byBwYXRjaCBh dXRob3JzIGZvciBidWlsZCBvciBsYXlvdXQgdGVzdCBmYWlsdXJlcyBvbiB0aGVpciBwYXRjaAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1Nzc2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChBbmFseXplQ29tcGlsZVdl YktpdFJlc3VsdHMuYW5hbHl6ZVJlc3VsdHMpOiBTZW5kIGVtYWlsIG5vdGlmaWNhdGlvbiB0byBw YXRjaCBhdXRob3JzIGZvciBidWlsZCBmYWlsdXJlIGR1ZSB0byB0aGVpciBwYXRjaC4KKyAgICAg ICAgKEFuYWx5emVMYXlvdXRUZXN0c1Jlc3VsdHMucmVwb3J0X2ZhaWx1cmUpOiBTZW5kIGVtYWls IG5vdGlmaWNhdGlvbiB0byBwYXRjaCBhdXRob3JzIGZvciBsYXlvdXQgdGVzdCBmYWlsdXJlLgor CiAyMDIwLTA4LTI0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAg ICAgICBbcmVzdWx0c2RicHldIEZpeCBwaXAgcGFja2FnZQpJbmRleDogVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjY2MDgxKQorKysgVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0x NDE5LDYgKzE0MTksOCBAQCBjbGFzcyBBbmFseXplQ29tcGlsZVdlYktpdFJlc3VsdHMoYnVpbGRz CiAgICAgICAgIHNlbGYuYnVpbGQucmVzdWx0cyA9IEZBSUxVUkUKICAgICAgICAgcGF0Y2hfaWQg PSBzZWxmLmdldFByb3BlcnR5KCdwYXRjaF9pZCcsICcnKQogICAgICAgICBtZXNzYWdlID0gJ1Bh dGNoIHt9IGRvZXMgbm90IGJ1aWxkJy5mb3JtYXQocGF0Y2hfaWQpCisgICAgICAgIHNlbGYuc2Vu ZF9lbWFpbF9mb3JfbmV3X2J1aWxkX2ZhaWx1cmUoKQorCiAgICAgICAgIHNlbGYuZGVzY3JpcHRp b25Eb25lID0gbWVzc2FnZQogICAgICAgICBpZiBzZWxmLmdldFByb3BlcnR5KCdidWlsZGVybmFt ZScsICcnKS5sb3dlcigpID09ICdjb21taXQtcXVldWUnOgogICAgICAgICAgICAgc2VsZi5zZXRQ cm9wZXJ0eSgnYnVnemlsbGFfY29tbWVudF90ZXh0JywgbWVzc2FnZSkKQEAgLTIwNzEsNiArMjA3 Myw3IEBAIGNsYXNzIEFuYWx5emVMYXlvdXRUZXN0c1Jlc3VsdHMoYnVpbGRzdGUKICAgICAgICAg aWYgbGVuKG5ld19mYWlsdXJlcykgPiBzZWxmLk5VTV9GQUlMVVJFU19UT19ESVNQTEFZOgogICAg ICAgICAgICAgbWVzc2FnZSArPSAnIC4uLicKICAgICAgICAgc2VsZi5kZXNjcmlwdGlvbkRvbmUg PSBtZXNzYWdlCisgICAgICAgIHNlbGYuc2VuZF9lbWFpbF9mb3JfbmV3X3Rlc3RfZmFpbHVyZXMo bmV3X2ZhaWx1cmVzKQogCiAgICAgICAgIGlmIHNlbGYuZ2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1l JywgJycpLmxvd2VyKCkgPT0gJ2NvbW1pdC1xdWV1ZSc6CiAgICAgICAgICAgICBzZWxmLnNldFBy b3BlcnR5KCdidWd6aWxsYV9jb21tZW50X3RleHQnLCBtZXNzYWdlKQo=