21576 2008-10-13 12:34:49 -0700 Fix a race in fast/history/history_reload.html 2008-10-17 11:08:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pam pam oldest_to_newest 95196 0 pam 2008-10-13 12:34:49 -0700 The fast/history/history_reload.html test has a potential race condition caused by higher-resolution timers. I don't know exactly what threshold it takes to expose the problem, but it's worth removing anyway. Each time the subframe loads, the onclose handler calls layoutTestController.notifyDone via setTimeout(0). If that gets fired before the history.go() completes, the test appears to have failed. One solution is to always use two passes in the test, and not complete until the second one. 95198 1 24322 pam 2008-10-13 12:47:23 -0700 Created attachment 24322 Fixed test No change to expected results. 95757 2 pam 2008-10-17 11:08:06 -0700 Landed in r37657. 24322 2008-10-13 12:47:23 -0700 2008-10-17 04:12:15 -0700 Fixed test 21576a.txt text/plain 2021 pam SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3NTU5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMTAt MTMgIFBhbWVsYSBHcmVlbmUgIDxwYW1AY2hyb21pdW0ub3JnPgorCisJRml4IHBvdGVudGlhbCBy YWNlIGJ5IHJ1bm5pbmcgdHdvIHBhc3NlcyBvZiB0ZXN0IHRvIGRlZmVyIG5vdGlmeURvbmUuCisJ U2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU3NgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9oaXN0b3J5 L3Jlc291cmNlcy9oaXN0b3J5X3JlbG9hZF93aW5kb3cuaHRtbDoKKwogMjAwOC0xMC0xMiAgUGFt ZWxhIEdyZWVuZSAgPHBhbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFy aW4gQWRsZXIuCkluZGV4OiBmYXN0L2hpc3RvcnkvcmVzb3VyY2VzL2hpc3RvcnlfcmVsb2FkX3dp bmRvdy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIGZhc3QvaGlzdG9yeS9yZXNvdXJjZXMvaGlzdG9yeV9y ZWxvYWRfd2luZG93Lmh0bWwJKHJldmlzaW9uIDM3NTU5KQorKysgZmFzdC9oaXN0b3J5L3Jlc291 cmNlcy9oaXN0b3J5X3JlbG9hZF93aW5kb3cuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtNCwyMSAr NCwyNiBAQAogICAgICAgICBmdW5jdGlvbiB0ZXN0KCkgewogICAgICAgICAgICAgdmFyIHRlbXBD b25zb2xlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2NvbnNvbGUnKTsKICAgICAgICAgICAg IHZhciBjb25zb2xlID0gd2luZG93Lm9wZW5lci5kb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29u c29sZScpOworICAgICAgICAgICAgLy8gT24gdGhlIGZpcnN0IHBhc3MsIHdlJ2xsIHRlbXBvcmFy aWx5IHNldCB0aGUgb3V0cHV0IHRvCisgICAgICAgICAgICAvLyB0byBmYWlsdXJlLCBhbmQgdGhl biBnbygwKS4gIE9uIHRoZSBzZWNvbmQgcGFzcywKKyAgICAgICAgICAgIC8vIHdlIHNldCB0aGUg b3V0cHV0IGJhY2sgdG8gc3VjY2VzcyBhbmQgY2xvc2UgdGhlIHdpbmRvdy4KICAgICAgICAgICAg IGlmICh3aW5kb3cub3BlbmVyLmkgPT0gMCkgewogICAgICAgICAgICAgICAgIHRlbXBDb25zb2xl LmlubmVySFRNTCA9ICdUZXN0IEZhaWxlZCc7CiAgICAgICAgICAgICAgICAgY29uc29sZS5pbm5l ckhUTUwgPSB0ZW1wQ29uc29sZS5pbm5lckhUTUw7Ci0gICAgICAgICAgICAgICAgd2luZG93Lm9w ZW5lci5pID0gd2luZG93Lm9wZW5lci5pICsgMTsKKyAgICAgICAgICAgICAgICB3aW5kb3cub3Bl bmVyLmkgPSAxOwogICAgICAgICAgICAgICAgIGhpc3RvcnkuZ28oMCk7CiAgICAgICAgICAgICB9 IGVsc2UgewogICAgICAgICAgICAgICAgIGNvbnNvbGUuaW5uZXJIVE1MID0gdGVtcENvbnNvbGUu aW5uZXJIVE1MOworICAgICAgICAgICAgICAgIHdpbmRvdy5vcGVuZXIuaSA9IDI7CiAgICAgICAg ICAgICAgICAgd2luZG93LmNsb3NlKCk7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KIAogICAg ICAgICBmdW5jdGlvbiBjbG9zZWQoKQogICAgICAgICB7Ci0gICAgICAgICAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQotICAgICAgICAgICAgICAgIG9wZW5lci5zZXRUaW1lb3V0 KCJsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCkiLCAwKTsKKyAgICAgICAgICAgIGlm ICh3aW5kb3cub3BlbmVyLmkgPT0gMikKKyAgICAgICAgICAgICAgICBpZiAod2luZG93LmxheW91 dFRlc3RDb250cm9sbGVyKQorICAgICAgICAgICAgICAgICAgICBvcGVuZXIuc2V0VGltZW91dCgi bGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgpIiwgMCk7CiAgICAgICAgIH0KICAgICAg ICAgPC9zY3JpcHQ+CiAgICAgPC9oZWFkPgo=