215753 2020-08-22 10:12:48 -0700 Do not use undefined default param in CSSStyleDeclaration.idl 2020-08-23 06:41:14 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis cdumez darin esprehn+autocc ews-watchlist glenn gyuyoung.kim kondapallykalyan macpherson menard webkit-bug-importer oldest_to_newest 1682136 0 rbuis 2020-08-22 10:12:48 -0700 Do not use undefined default parameter value in CSSStyleDeclaration.idl, instead use no explicit default parameter at all. This means a zero length String will be used, which will be more efficient when using the cssPropertyID helper method, as well as less error-prone. 1682137 1 407054 rbuis 2020-08-22 10:13:58 -0700 Created attachment 407054 Patch 1682170 2 407054 darin 2020-08-22 14:11:43 -0700 Comment on attachment 407054 Patch Could we have added a tests? Or is there no way to detect that we are failing to look up "undefined" vs. failing to look up a null string? 1682231 3 rbuis 2020-08-23 06:38:50 -0700 (In reply to Darin Adler from comment #2) > Comment on attachment 407054 [details] > Patch > > Could we have added a tests? Or is there no way to detect that we are > failing to look up "undefined" vs. failing to look up a null string? I think the only way is through timing both lookups, and asserting that the null string lookup (early exit) will take less time than looking up "undefined". I personally thing this is a bit overkill but let me know if you want me to add such a test. 1682232 4 ews-feeder 2020-08-23 06:40:29 -0700 Committed r266046: <https://trac.webkit.org/changeset/266046> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407054. 1682233 5 webkit-bug-importer 2020-08-23 06:41:14 -0700 <rdar://problem/67640590> 407054 2020-08-22 10:13:58 -0700 2020-08-23 06:40:29 -0700 Patch bug-215753-20200822191356.patch text/plain 1905 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MDA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2U0OGQ1ZTEwODMxY2Jh NTVjZWFhZWE3MDE5NTQxNzJiYzVkMmVlMi4uN2NhYTAyNzFhNmVlYWUzMzYxMzc0NWNmMzU2MmQ5 N2Q3OTg3Yjg2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTA4LTIyICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgRG8gbm90IHVzZSB1bmRlZmluZWQg ZGVmYXVsdCBwYXJhbSBpbiBDU1NTdHlsZURlY2xhcmF0aW9uLmlkbAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1NzUzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IHVzZSB1bmRlZmluZWQgZGVm YXVsdCBwYXJhbWV0ZXIgdmFsdWUgaW4gQ1NTU3R5bGVEZWNsYXJhdGlvbi5pZGwsIGluc3RlYWQg dXNlIG5vIGV4cGxpY2l0IGRlZmF1bHQKKyAgICAgICAgcGFyYW1ldGVyIGF0IGFsbC4gVGhpcyBt ZWFucyBhIHplcm8gbGVuZ3RoIFN0cmluZyB3aWxsIGJlIHVzZWQsIHdoaWNoIHdpbGwgYmUgbW9y ZSBlZmZpY2llbnQgd2hlbiB1c2luZworICAgICAgICB0aGUgY3NzUHJvcGVydHlJRCBoZWxwZXIg bWV0aG9kLCBhcyB3ZWxsIGFzIGxlc3MgZXJyb3ItcHJvbmUuCisKKyAgICAgICAgKiBjc3MvQ1NT U3R5bGVEZWNsYXJhdGlvbi5pZGw6CisKIDIwMjAtMDgtMjEgIEFuZHJlcyBHb256YWxleiAgPGFu ZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAgICAgIFJhbmdlOjpjb250YWlucyBkb2VzIG5vdCB3 b3JrIGNvcnJlY3RseSB3aGVuIHRoZSBjb21tb24gYW5jZXN0b3Igbm9kZSBpcyBhIERvY3VtZW50 LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlRGVjbGFyYXRpb24uaWRs IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlRGVjbGFyYXRpb24uaWRsCmluZGV4IDAzNWNi NjI0NWQ5NmMyY2ZjZDRkODY3YmM1YmRjY2I4NDI1MzFjZGIuLmZmMDQzNzU0ODRjZmExM2IxODVk YWQ4ZTNjMWIzMjgwNGFiYTU1MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT dHlsZURlY2xhcmF0aW9uLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVEZWNs YXJhdGlvbi5pZGwKQEAgLTQxLDkgKzQxLDggQEAKIAogICAgIFtDRVJlYWN0aW9uc10gYXR0cmli dXRlIFtUcmVhdE51bGxBcz1FbXB0eVN0cmluZ10gRE9NU3RyaW5nIGNzc0Zsb2F0OwogCi0gICAg Ly8gRklYTUU6IFVzaW5nICJ1bmRlZmluZWQiIGFzIGRlZmF1bHQgcGFyYW1ldGVyIHZhbHVlIGlz IHdyb25nLgotICAgIERPTVN0cmluZz8gZ2V0UHJvcGVydHlTaG9ydGhhbmQob3B0aW9uYWwgRE9N U3RyaW5nIHByb3BlcnR5TmFtZSA9ICJ1bmRlZmluZWQiKTsKLSAgICBib29sZWFuIGlzUHJvcGVy dHlJbXBsaWNpdChvcHRpb25hbCBET01TdHJpbmcgcHJvcGVydHlOYW1lID0gInVuZGVmaW5lZCIp OworICAgIERPTVN0cmluZz8gZ2V0UHJvcGVydHlTaG9ydGhhbmQob3B0aW9uYWwgRE9NU3RyaW5n IHByb3BlcnR5TmFtZSk7CisgICAgYm9vbGVhbiBpc1Byb3BlcnR5SW1wbGljaXQob3B0aW9uYWwg RE9NU3RyaW5nIHByb3BlcnR5TmFtZSk7CiAKICAgICAvLyBVc2UgbmFtZWQgZ2V0dGVycy9zZXR0 ZXJzIGZvciBhbGwgc3VwcG9ydCBDU1MgcHJvcGVydHkgbmFtZXMuIFRoZSBzcGVjIHNheXMKICAg ICAvLyB0aGVzZSBzaG91bGQgYmUgbm9ybWFsIGF0dHJpYnV0ZXMsIGJ1dCB0aGVyZSBhcmUgdG9v IG1hbnkgY29tYmluYXRpb25zIHdpdGgK