215743 2020-08-21 15:45:48 -0700 StrictEq should not care about masqueradesAsUndefinedWatchpoint 2020-08-21 18:33:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Enhancement --- 1 ashvayka ashvayka ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1682046 0 ashvayka 2020-08-21 15:45:48 -0700 StrictEq should not care about masqueradesAsUndefinedWatchpoint 1682049 1 407029 ashvayka 2020-08-21 15:48:21 -0700 Created attachment 407029 Patch 1682054 2 407029 ysuzuki 2020-08-21 15:54:17 -0700 Comment on attachment 407029 Patch r=me 1682091 3 ews-feeder 2020-08-21 18:32:25 -0700 Committed r266022: <https://trac.webkit.org/changeset/266022> All reviewed patches have been landed. Closing bug and clearing flags on attachment 407029. 1682092 4 webkit-bug-importer 2020-08-21 18:33:16 -0700 <rdar://problem/67593934> 407029 2020-08-21 15:48:21 -0700 2020-08-21 18:32:26 -0700 Patch bug-215743-20200822014819.patch text/plain 3563 ashvayka U3VidmVyc2lvbiBSZXZpc2lvbjogMjY2MDEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZjU2ZTNjYjE1NzM0MTE4YTgzODQwMjRkYTk5NWI3MmFjNzAzZTAwLi4xMTFiZTI0YWM4NDI3YWE0 YzhjYjdiNTE3NzA0MWQxNDYyNTdhNTQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAyMC0wOC0yMSAgQWxleGV5IFNodmF5a2EgIDxzaHZhaWthbGVzaEBnbWFp bC5jb20+CisKKyAgICAgICAgU3RyaWN0RXEgc2hvdWxkIG5vdCBjYXJlIGFib3V0IG1hc3F1ZXJh ZGVzQXNVbmRlZmluZWRXYXRjaHBvaW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTU3NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIHJlbW92ZXMgbWFzcXVlcmFkZXNBc1VuZGVmaW5l ZFdhdGNocG9pbnQgaGFuZGxpbmcgZm9yIFN0cmljdEVxCisgICAgICAgIGZyb20gZml4dXBDb21w YXJlU3RyaWN0RXFBbmRTYW1lVmFsdWUoKSwgYWxpZ25pbmcgaXQgd2l0aCBTYW1lVmFsdWUuCisK KyAgICAgICAgQWNjb3JkaW5nIHRvIHRoZSBzcGVjIFsxXSwgb25seSBhIGZldyBsYW5ndWFnZSBj b25zdHJ1Y3RzIHNwZWNpYWwtY2FzZQorICAgICAgICBbW0lzSFRNTEREQV1dIG9iamVjdHM6IFRv Qm9vbGVhbiwgYWJzdHJhY3QgZXF1YWxpdHksIGFuZCBgdHlwZW9mYC4KKworICAgICAgICBObyBi ZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgWzFdOiBodHRwczovL3RjMzkuZXMvZWNtYTI2Mi8j c2VjLUlzSFRNTEREQS1pbnRlcm5hbC1zbG90CisKKyAgICAgICAgKiBkZmcvREZHRml4dXBQaGFz ZS5jcHA6CisgICAgICAgIChKU0M6OkRGRzo6Rml4dXBQaGFzZTo6Zml4dXBDb21wYXJlU3RyaWN0 RXFBbmRTYW1lVmFsdWUpOgorCiAyMDIwLTA4LTIxICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2Fs ZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBGdW5jdGlvbi5wcm90b3R5cGUuYmluZCBzaG91bGQg bm90IGNsYW1wICJsZW5ndGgiIHRvIGludDMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdGaXh1cFBoYXNlLmNwcAppbmRleCAzNTA2MzJkMTg1OGQzMzZlYzFiNDQ2YjNlZDJhZDNmYzky MmY0Mjc0Li5kOTE3YTcxMTYyOGMzNDFlMjljMjY5MWIzYmUyNTBiMDFhZTI2ODI0IDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0ZpeHVwUGhhc2UuY3BwCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAKQEAgLTQyMzEsMzcgKzQy MzEsMTYgQEAgcHJpdmF0ZToKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQogCi0gICAg ICAgIGlmIChub2RlLT5vcCgpID09IFNhbWVWYWx1ZSkgewotICAgICAgICAgICAgaWYgKG5vZGUt PmNoaWxkMSgpLT5zaG91bGRTcGVjdWxhdGVPYmplY3QoKSkgewotICAgICAgICAgICAgICAgIGZp eEVkZ2U8T2JqZWN0VXNlPihub2RlLT5jaGlsZDEoKSk7Ci0gICAgICAgICAgICAgICAgbm9kZS0+ c2V0T3BBbmREZWZhdWx0RmxhZ3MoQ29tcGFyZVN0cmljdEVxKTsKLSAgICAgICAgICAgICAgICBy ZXR1cm47Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAgICBpZiAobm9kZS0+Y2hpbGQyKCktPnNo b3VsZFNwZWN1bGF0ZU9iamVjdCgpKSB7Ci0gICAgICAgICAgICAgICAgZml4RWRnZTxPYmplY3RV c2U+KG5vZGUtPmNoaWxkMigpKTsKLSAgICAgICAgICAgICAgICBub2RlLT5zZXRPcEFuZERlZmF1 bHRGbGFncyhDb21wYXJlU3RyaWN0RXEpOwotICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAg ICAgICAgIH0KLSAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIFdhdGNocG9pbnRTZXQqIG1h c3F1ZXJhZGVzQXNVbmRlZmluZWRXYXRjaHBvaW50ID0gbV9ncmFwaC5nbG9iYWxPYmplY3RGb3Io bm9kZS0+b3JpZ2luLnNlbWFudGljKS0+bWFzcXVlcmFkZXNBc1VuZGVmaW5lZFdhdGNocG9pbnQo KTsKLSAgICAgICAgICAgIGlmIChtYXNxdWVyYWRlc0FzVW5kZWZpbmVkV2F0Y2hwb2ludC0+aXNT dGlsbFZhbGlkKCkpIHsKLSAgICAgICAgICAgICAgICBpZiAobm9kZS0+Y2hpbGQxKCktPnNob3Vs ZFNwZWN1bGF0ZU9iamVjdCgpKSB7Ci0gICAgICAgICAgICAgICAgICAgIG1fZ3JhcGgud2F0Y2hw b2ludHMoKS5hZGRMYXppbHkobWFzcXVlcmFkZXNBc1VuZGVmaW5lZFdhdGNocG9pbnQpOwotICAg ICAgICAgICAgICAgICAgICBmaXhFZGdlPE9iamVjdFVzZT4obm9kZS0+Y2hpbGQxKCkpOwotICAg ICAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAg ICAgIGlmIChub2RlLT5jaGlsZDIoKS0+c2hvdWxkU3BlY3VsYXRlT2JqZWN0KCkpIHsKLSAgICAg ICAgICAgICAgICAgICAgbV9ncmFwaC53YXRjaHBvaW50cygpLmFkZExhemlseShtYXNxdWVyYWRl c0FzVW5kZWZpbmVkV2F0Y2hwb2ludCk7Ci0gICAgICAgICAgICAgICAgICAgIGZpeEVkZ2U8T2Jq ZWN0VXNlPihub2RlLT5jaGlsZDIoKSk7Ci0gICAgICAgICAgICAgICAgICAgIHJldHVybjsKLSAg ICAgICAgICAgICAgICB9Ci0gICAgICAgICAgICB9IGVsc2UgaWYgKG5vZGUtPmNoaWxkMSgpLT5z aG91bGRTcGVjdWxhdGVPYmplY3QoKSAmJiBub2RlLT5jaGlsZDIoKS0+c2hvdWxkU3BlY3VsYXRl T2JqZWN0KCkpIHsKLSAgICAgICAgICAgICAgICBmaXhFZGdlPE9iamVjdFVzZT4obm9kZS0+Y2hp bGQxKCkpOwotICAgICAgICAgICAgICAgIGZpeEVkZ2U8T2JqZWN0VXNlPihub2RlLT5jaGlsZDIo KSk7Ci0gICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgfQorICAgICAgICBpZiAo bm9kZS0+Y2hpbGQxKCktPnNob3VsZFNwZWN1bGF0ZU9iamVjdCgpKSB7CisgICAgICAgICAgICBm aXhFZGdlPE9iamVjdFVzZT4obm9kZS0+Y2hpbGQxKCkpOworICAgICAgICAgICAgbm9kZS0+c2V0 T3BBbmREZWZhdWx0RmxhZ3MoQ29tcGFyZVN0cmljdEVxKTsKKyAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgfQorICAgICAgICBpZiAobm9kZS0+Y2hpbGQyKCktPnNob3VsZFNwZWN1bGF0ZU9i amVjdCgpKSB7CisgICAgICAgICAgICBmaXhFZGdlPE9iamVjdFVzZT4obm9kZS0+Y2hpbGQyKCkp OworICAgICAgICAgICAgbm9kZS0+c2V0T3BBbmREZWZhdWx0RmxhZ3MoQ29tcGFyZVN0cmljdEVx KTsKKyAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQotCiAgICAgICAgIGlmIChub2RlLT5j aGlsZDEoKS0+c2hvdWxkU3BlY3VsYXRlU3ltYm9sKCkpIHsKICAgICAgICAgICAgIGZpeEVkZ2U8 U3ltYm9sVXNlPihub2RlLT5jaGlsZDEoKSk7CiAgICAgICAgICAgICBub2RlLT5zZXRPcEFuZERl ZmF1bHRGbGFncyhDb21wYXJlU3RyaWN0RXEpOwo=