215741 2020-08-21 15:27:06 -0700 Add some FIXMEs in the EventHandler wheel event handling code for all the things that are wrong 2020-08-21 15:51:14 -0700 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser bfulgham cmarcelo ews-watchlist fred.wang jamesr luiz simon.fraser tonikitoo webkit-bug-importer wenson_hsieh oldest_to_newest 1682039 0 simon.fraser 2020-08-21 15:27:06 -0700 Add some FIXMEs in the EventHandler wheel event handling code for all the things that are wrong 1682040 1 407028 simon.fraser 2020-08-21 15:27:47 -0700 Created attachment 407028 Patch 1682041 2 407028 wenson_hsieh 2020-08-21 15:30:11 -0700 Comment on attachment 407028 Patch rs=me 1682050 3 simon.fraser 2020-08-21 15:50:22 -0700 https://trac.webkit.org/r266016 1682052 4 webkit-bug-importer 2020-08-21 15:51:14 -0700 <rdar://problem/67585572> 407028 2020-08-21 15:27:47 -0700 2020-08-21 15:30:11 -0700 Patch bug-215741-20200821152746.patch text/plain 6411 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThkNTU3MzE1ZDdkYmEw NDA3NDM2MDEzNDliYTU2NzVhYjY2NzI4NS4uYWI4NjEwYTBmNjUzODQ1MGY4NTMxZDY0YWY2ZGM4 ZDNmZDk1YTkxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA4LTIxICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzb21lIEZJ WE1FcyBpbiB0aGUgRXZlbnRIYW5kbGVyIHdoZWVsIGV2ZW50IGhhbmRsaW5nIGNvZGUgZm9yIGFs bCB0aGUgdGhpbmdzIHRoYXQgYXJlIHdyb25nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU3NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBtdWNoIGNvbmZ1c2luZyBjb2RlIGhlcmUuIFRy eWluZyB0byBkb2N1bWVudCB0aGUgaXNzdWVzIEkndmUgZm91bmQuCisKKyAgICAgICAgKiBwYWdl L0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRs ZVdoZWVsRXZlbnQpOgorICAgICAgICAqIHBhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbToKKyAg ICAgICAgKFdlYkNvcmU6OmZpbmRFbmNsb3NpbmdTY3JvbGxhYmxlQ29udGFpbmVyKToKKyAgICAg ICAgKFdlYkNvcmU6OkV2ZW50SGFuZGxlcjo6ZGV0ZXJtaW5lV2hlZWxFdmVudFRhcmdldCk6Cisg ICAgICAgIChXZWJDb3JlOjpFdmVudEhhbmRsZXI6OnByb2Nlc3NXaGVlbEV2ZW50Rm9yU2Nyb2xs aW5nKToKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nQ29vcmRpbmF0b3JN YWMubW06CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvck1hYzo6aGFuZGxl V2hlZWxFdmVudCk6CisKIDIwMjAtMDgtMTggIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgVHVybiBvZmYgd2hlZWwgZXZlbnQgcmVnaW9ucyB1bnRpbCB3 ZSBuZWVkIHRoZW0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCBhNmE2MmFj OWY2ZWVjYTQ1MDFjZDQ3YTVmMDBlMGU1MWZmNzYxMzkyLi5iOTQ0OTRkMzI4YzU2NGVhZmRkZTc5 MjkyZWViNWQ5YTI3MDAyOWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50 SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwCkBA IC0yOTE3LDEwICsyOTE3LDE1IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVXaGVlbEV2ZW50 KGNvbnN0IFBsYXRmb3JtV2hlZWxFdmVudCYgZXZlbnQpCiAgICAgSGl0VGVzdFJlc3VsdCByZXN1 bHQodmlldy0+d2luZG93VG9Db250ZW50cyhldmVudC5wb3NpdGlvbigpKSk7CiAgICAgZG9jdW1l bnQtPmhpdFRlc3QocmVxdWVzdCwgcmVzdWx0KTsKIAorICAgIC8vIEZJWE1FOiBXaHkgZG8gd2Ug aGF2ZSB0cmFjayBhbGwgdGhyZWUgb2YgdGFyZ2V0RWxlbWVudCwgc2Nyb2xsYWJsZUNvbnRhaW5l ciBhbmQgU2Nyb2xsYWJsZUFyZWE/CiAgICAgUmVmUHRyPEVsZW1lbnQ+IGVsZW1lbnQgPSByZXN1 bHQudGFyZ2V0RWxlbWVudCgpOwogICAgIFJlZlB0cjxDb250YWluZXJOb2RlPiBzY3JvbGxhYmxl Q29udGFpbmVyOwogICAgIFdlYWtQdHI8U2Nyb2xsYWJsZUFyZWE+IHNjcm9sbGFibGVBcmVhOwog ICAgIGJvb2wgaXNPdmVyV2lkZ2V0ID0gcmVzdWx0LmlzT3ZlcldpZGdldCgpOworICAgIAorICAg IC8vIEZJWE1FOiBVc2luZyB0aGUgdmFsdWUgb2YgaXNPdmVyV2lkZ2V0IGZyb20gdGhlIGxhdGNo aW5nIHN0YXRlIHRyaWdnZXJzIGRvdWJsZS1yZWN1cnNpb24gaW50byBzdWJmcmFtZXMuCisgICAg Ly8gRklYTUU6IERlc3BpdGUgZG9pbmcgdGhpcyB1cC1mcm9udCBzZWFyY2ggZm9yIHRoZSBjb3Jy ZWN0IHNjcm9sbGFibGUgYXJlYSwgd2UgZGlzcGF0Y2ggZXZlbnRzIHZpYSBlbGVtZW50cyB3aGlj aAorICAgIC8vIGl0c2VsZiBmaW5kcyBhbmQgdHJpZXMgdG8gc2Nyb2xsIG92ZXJmbG93IHNjcm9s bGVycy4KICAgICBkZXRlcm1pbmVXaGVlbEV2ZW50VGFyZ2V0KGV2ZW50LCByZXN1bHQsIGVsZW1l bnQsIHNjcm9sbGFibGVDb250YWluZXIsIHNjcm9sbGFibGVBcmVhLCBpc092ZXJXaWRnZXQpOwog CiAjaWYgRU5BQkxFKFdIRUVMX0VWRU5UX0xBVENISU5HKQpAQCAtMjk1NCw2ICsyOTU5LDcgQEAg Ym9vbCBFdmVudEhhbmRsZXI6OmhhbmRsZVdoZWVsRXZlbnQoY29uc3QgUGxhdGZvcm1XaGVlbEV2 ZW50JiBldmVudCkKICAgICBpZiAoc2Nyb2xsYWJsZUFyZWEpCiAgICAgICAgIHNjcm9sbGFibGVB cmVhLT5zZXRTY3JvbGxTaG91bGRDbGVhckxhdGNoZWRTdGF0ZShmYWxzZSk7CiAKKyAgICAvLyBG SVhNRTogcHJvY2Vzc1doZWVsRXZlbnRGb3JTY3JvbGxpbmcoKSBpcyBvbmx5IGNhbGxlZCBmb3Ig RnJhbWVWaWV3IHNjcm9sbGluZywgbm90IG92ZXJmbG93IHNjcm9sbGluZywgd2hpY2ggaXMgY29u ZnVzaW5nLgogICAgIGJvb2wgaGFuZGxlZEV2ZW50ID0gcHJvY2Vzc1doZWVsRXZlbnRGb3JTY3Jv bGxpbmcoZXZlbnQsIHNjcm9sbGFibGVDb250YWluZXIuZ2V0KCksIHNjcm9sbGFibGVBcmVhKTsK ICAgICBwcm9jZXNzV2hlZWxFdmVudEZvclNjcm9sbFNuYXAoZXZlbnQsIHNjcm9sbGFibGVBcmVh KTsKICAgICByZXR1cm4gaGFuZGxlZEV2ZW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9tYWMvRXZlbnRIYW5kbGVyTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGFnZS9tYWMvRXZl bnRIYW5kbGVyTWFjLm1tCmluZGV4IGMwOTMwYjYzNDk1ZTcxODE1OTkxYTQwNmE0ZDY2NWEyN2Jh NzcxNGIuLjM3YjVhMThiMmQwYWQwZjQ2YzY5OTE3MGNkNGU3MmRjY2JlZTA2YTYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvbWFjL0V2ZW50SGFuZGxlck1hYy5tbQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL21hYy9FdmVudEhhbmRsZXJNYWMubW0KQEAgLTgwNyw2ICs4MDcsNyBA QCBzdGF0aWMgQ29udGFpbmVyTm9kZSogZmluZEVuY2xvc2luZ1Njcm9sbGFibGVDb250YWluZXIo Q29udGFpbmVyTm9kZSogbm9kZSwgY29ucwogICAgICAgICBpZiAod2hlZWxFdmVudC5waGFzZSgp ID09IFBsYXRmb3JtV2hlZWxFdmVudFBoYXNlTWF5QmVnaW4gfHwgd2hlZWxFdmVudC5waGFzZSgp ID09IFBsYXRmb3JtV2hlZWxFdmVudFBoYXNlQ2FuY2VsbGVkKQogICAgICAgICAgICAgcmV0dXJu IGNhbmRpZGF0ZTsKIAorICAgICAgICAvLyBGSVhNRTogVGhpcyBuZWVkcyB0byBoYXZlIHRoZSBz YW1lIGF4aXMgYmlhcyB0aGF0IHdlIHVzZSBpbiBvdGhlciBsYXRjaGluZyBjb2RlLgogICAgICAg ICBhdXRvIGRlbHRhWCA9IHdoZWVsRXZlbnQuZGVsdGFYKCk7CiAgICAgICAgIGF1dG8gZGVsdGFZ ID0gd2hlZWxFdmVudC5kZWx0YVkoKTsKICAgICAgICAgaWYgKChkZWx0YVkgPiAwICYmICFzY3Jv bGxhYmxlQXJlYS0+c2Nyb2xsZWRUb1RvcCgpKSB8fCAoZGVsdGFZIDwgMCAmJiAhc2Nyb2xsYWJs ZUFyZWEtPnNjcm9sbGVkVG9Cb3R0b20oKSkKQEAgLTk3NCw2ICs5NzUsNyBAQCB2b2lkIEV2ZW50 SGFuZGxlcjo6ZGV0ZXJtaW5lV2hlZWxFdmVudFRhcmdldChjb25zdCBQbGF0Zm9ybVdoZWVsRXZl bnQmIHdoZWVsRXZlbgogICAgICAgICAgICAgaWYgKHNjcm9sbGFibGVDb250YWluZXIgJiYgIWlz PEhUTUxJRnJhbWVFbGVtZW50Pih3aGVlbEV2ZW50VGFyZ2V0KSkKICAgICAgICAgICAgICAgICBz Y3JvbGxhYmxlQXJlYSA9IHNjcm9sbGFibGVBcmVhRm9yQ29udGFpbmVyTm9kZSgqc2Nyb2xsYWJs ZUNvbnRhaW5lcik7CiAgICAgICAgICAgICBlbHNlIHsKKyAgICAgICAgICAgICAgICAvLyBGSVhN RTogV2h5IGRvZXMgdGhpcyBhc3N1bWUgdGhlIGJvZHk/IFdoYXQgaWYgd2UgaGl0IGFuIGlmcmFt ZSBpbnNpZGUgYW4gb3ZlcmZsb3c6c2Nyb2xsPwogICAgICAgICAgICAgICAgIHNjcm9sbGFibGVD b250YWluZXIgPSB2aWV3LT5mcmFtZSgpLmRvY3VtZW50KCktPmJvZHlPckZyYW1lc2V0KCk7CiAg ICAgICAgICAgICAgICAgc2Nyb2xsYWJsZUFyZWEgPSBtYWtlV2Vha1B0cihzdGF0aWNfY2FzdDxT Y3JvbGxhYmxlQXJlYSY+KCp2aWV3KSk7CiAgICAgICAgICAgICB9CkBAIC0xMDA5LDYgKzEwMTEs NyBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6ZGV0ZXJtaW5lV2hlZWxFdmVudFRhcmdldChjb25zdCBQ bGF0Zm9ybVdoZWVsRXZlbnQmIHdoZWVsRXZlbgogICAgICAgICBMT0dfV0lUSF9TVFJFQU0oU2Ny b2xsTGF0Y2hpbmcsIHN0cmVhbSA8PCAiRXZlbnRIYW5kbGVyOjpkZXRlcm1pbmVXaGVlbEV2ZW50 VGFyZ2V0KCkgLSByZXNldCBsYXRjaGluZyBmb3IgZXZlbnQgIiA8PCB3aGVlbEV2ZW50IDw8ICIg bGF0Y2hpbmcgc3RhdGUgIiA8PCBwYWdlLT5sYXRjaGluZ1N0YXRlU3RhY2soKSk7CiAgICAgfQog CisgICAgLy8gRklYTUU6IFRoaXMgY2FuIHVzZSBhIHN0YWxlIGxhY2hpbmcgc3RhdGUsIGJlZm9y ZSB3ZSBqdXN0IHB1c2hlZCBvciBjbGVhcmVkLgogICAgIGlmICghd2hlZWxFdmVudC5zaG91bGRS ZXNldExhdGNoaW5nKCkgJiYgbGF0Y2hpbmdTdGF0ZSAmJiBsYXRjaGluZ1N0YXRlLT53aGVlbEV2 ZW50RWxlbWVudCgpKSB7CiAgICAgICAgIGlmIChsYXRjaGluZ0lzTG9ja2VkVG9QbGF0Zm9ybUZy YW1lKG1fZnJhbWUpKQogICAgICAgICAgICAgcmV0dXJuOwpAQCAtMTA3OSw4ICsxMDgyLDEwIEBA IGJvb2wgRXZlbnRIYW5kbGVyOjpwcm9jZXNzV2hlZWxFdmVudEZvclNjcm9sbGluZyhjb25zdCBQ bGF0Zm9ybVdoZWVsRXZlbnQmIHdoZWVsCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAg ICAgfQogCi0gICAgICAgIGlmICghbGF0Y2hpbmdTdGF0ZS0+c3RhcnRlZEdlc3R1cmVBdFNjcm9s bExpbWl0KCkpCisgICAgICAgIGlmICghbGF0Y2hpbmdTdGF0ZS0+c3RhcnRlZEdlc3R1cmVBdFNj cm9sbExpbWl0KCkpIHsKKyAgICAgICAgICAgIC8vIEZJWE1FOiBUaGlzIHNldCAndmlldycgdG8g YSBGcmFtZVZpZXcgdGhhdCBpcyBub3QgdGhpcyBFdmVudEhhbmRsZXIncyBGcmFtZVZpZXcsIHdo aWNoIHRoZW4gZ2V0cyBzY3JvbGxlZCBmcm9tIGhlcmUsIHdoaWNoIGlzIHdyb25nLgogICAgICAg ICAgICAgdmlldyA9IGZyYW1lVmlld0ZvckxhdGNoaW5nU3RhdGUobV9mcmFtZSwgKmxhdGNoaW5n U3RhdGUpOworICAgICAgICB9CiAKICAgICAgICAgQVNTRVJUKHZpZXcpOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nQ29vcmRpbmF0b3JN YWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9tYWMvU2Nyb2xsaW5nQ29vcmRp bmF0b3JNYWMubW0KaW5kZXggMmI4YjkwYmI0ZmIwNWMxZDQzNGQ4NWE5NDMxZWI5MWFhMDg1OTZk MS4uMWY3NDUwZDFlNTcxYzE5NTJlNzY2NzdkN2Q2YWU0YzJjZTE4YTE3NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvbWFjL1Njcm9sbGluZ0Nvb3JkaW5hdG9yTWFj Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL21hYy9TY3JvbGxpbmdDb29y ZGluYXRvck1hYy5tbQpAQCAtODIsNiArODIsOSBAQCBib29sIFNjcm9sbGluZ0Nvb3JkaW5hdG9y TWFjOjpoYW5kbGVXaGVlbEV2ZW50KEZyYW1lVmlldyYsIGNvbnN0IFBsYXRmb3JtV2hlZWxFdgog ICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBMT0dfV0lUSF9TVFJFQU0oU2Nyb2xsaW5nLCBz dHJlYW0gPDwgIlNjcm9sbGluZ0Nvb3JkaW5hdG9yTWFjOjpoYW5kbGVXaGVlbEV2ZW50IC0gc2Vu ZGluZyBldmVudCB0byBzY3JvbGxpbmcgdGhyZWFkIik7CisgICAgCisgICAgLy8gRklYTUU6IE92 ZXIgb24gdGhlIHNjcm9sbGluZyB0aHJlYWQsIHdlJ2xsIGhpdC10ZXN0IHRoZSBsYXllcnMgYW5k IHBvc3NpYmx5IHNlbmQgdGhlIGV2ZW50IHRvIGEgbm9kZQorICAgIC8vIHdoaWNoIHdlJ3ZlIGFs cmVhZHkgZGlzY291bnRlZCBvbiB0aGUgbWFpbiB0aHJlYWQuIFRoaXMgbmVlZHMgdG8gdGFyZ2V0 IGEgc3BlY2lmaWMgbm9kZS4KIAogICAgIFJlZlB0cjxUaHJlYWRlZFNjcm9sbGluZ1RyZWU+IHRo cmVhZGVkU2Nyb2xsaW5nVHJlZSA9IGRvd25jYXN0PFRocmVhZGVkU2Nyb2xsaW5nVHJlZT4oc2Ny b2xsaW5nVHJlZSgpKTsKICAgICBTY3JvbGxpbmdUaHJlYWQ6OmRpc3BhdGNoKFt0aHJlYWRlZFNj cm9sbGluZ1RyZWUsIHdoZWVsRXZlbnRdIHsK