215682 2020-08-19 20:03:46 -0700 Web Inspector: Elements: Styles: don't show non-inherited properties 2020-08-24 10:21:12 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg hi inspector-bugzilla-changes nvasilyev webkit-bug-importer oldest_to_newest 1681589 0 hi 2020-08-19 20:03:46 -0700 IMO there's very little reason to show non-inherited properties in rules with other inherited properties, as that just adds confusion as to what's actually being used/applied 1681592 1 406904 hi 2020-08-19 20:05:39 -0700 Created attachment 406904 Patch 1681615 2 nvasilyev 2020-08-19 21:11:03 -0700 I'm expecting blowback about this. When we show a CSS rule, we always shows all CSS properties, unaltered. This is how it has been for over a decade. The proposed patch would break this paradigm. 1681764 3 hi 2020-08-20 12:20:37 -0700 (In reply to Nikita Vasilyev from comment #2) > When we show a CSS rule, we always shows all CSS properties, unaltered. This is how it has been for over a decade. The proposed patch would break this paradigm. I appreciate that, but I personally don't think I'd really miss seeing the other properties. Showing only the properties that are inherited focuses on what actually matters and removes potential points of confusion (especially for beginners who may not know what properties inherit vs not). The section header just above each rule (those that are applicable) says "Inherited from ...", so having properties that are not in fact "Inherited from ..." is debatably a lie. btw I'm not "set in stone" on this or anything like that. I definitely think living on this is gonna tell the true story, but my gut is leaning towards this change. I put this up for people to give it a shot and see how it feels. We could try it as an experimental feature (or some sort of filter) to start. 1682355 4 bburg 2020-08-24 09:57:07 -0700 (In reply to Nikita Vasilyev from comment #2) > I'm expecting blowback about this. > > When we show a CSS rule, we always shows all CSS properties, unaltered. This > is how it has been for over a decade. The proposed patch would break this > paradigm. I think this was more a result of the old styles UI using original source text, and thus it was a messy proposition to omit lines that aren't helpful. Since we are no longer constrained to show the original source text as-is, I think this is a change in the right direction. The one scenario where I would want to see matched-but-overridden declarations is if the wrong declaration is taking precedence and I need to figure out how to fix the specificity. The Computed Styles panel shows conflicts on a per-property basis and seems strictly better at this task. 1682357 5 406904 bburg 2020-08-24 09:57:44 -0700 Comment on attachment 406904 Patch r=me Sad we can't test this. 1682370 6 webkit-bug-importer 2020-08-24 10:12:32 -0700 <rdar://problem/67685743> 1682377 7 ews-feeder 2020-08-24 10:21:11 -0700 Committed r266069: <https://trac.webkit.org/changeset/266069> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406904. 406904 2020-08-19 20:05:39 -0700 2020-08-24 10:21:12 -0700 Patch 215682.diff text/plain 1547 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQ1NTNiOTk0M2JkMi4uYzAwMWFhMjQwMTA5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wOC0xOSAgRGV2 aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog RWxlbWVudHM6IFN0eWxlczogZG9uJ3Qgc2hvdyBub24taW5oZXJpdGVkIHByb3BlcnRpZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTY4MgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25FZGl0b3IuanM6CisgICAg ICAgIChXSS5TcHJlYWRzaGVldENTU1N0eWxlRGVjbGFyYXRpb25FZGl0b3IucHJvdG90eXBlLmdl dCBwcm9wZXJ0aWVzVG9SZW5kZXIpOgorCiAyMDIwLTA4LTE0ICBEZXZpbiBSb3Vzc28gIDxkcm91 c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBc3NlcnRpb24gRmFpbGVk OiBBcHBlbmRlZCBhIHN0cmluZyB3aXRoIG5ld2xpbmVzLiBUaGlzIGJyZWFrcyB0aGUgc291cmNl IG1hcC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1NwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvbkVkaXRvci5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJh dGlvbkVkaXRvci5qcwppbmRleCBjZmIwMzY3MDg4NDUuLmYzZTg1NDlhZjI0MSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hlZXRD U1NTdHlsZURlY2xhcmF0aW9uRWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvbkVkaXRvci5q cwpAQCAtMjMwLDYgKzIzMCw5IEBAIFdJLlNwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvbkVk aXRvciA9IGNsYXNzIFNwcmVhZHNoZWV0Q1NTU3R5bGVEZWNsYXJhdGlvbkVkCiAgICAgICAgIGVs c2UKICAgICAgICAgICAgIHByb3BlcnRpZXMgPSB0aGlzLl9zdHlsZS5wcm9wZXJ0aWVzOwogCisg ICAgICAgIGlmICh0aGlzLl9zdHlsZS5pbmhlcml0ZWQpCisgICAgICAgICAgICBwcm9wZXJ0aWVz ID0gcHJvcGVydGllcy5maWx0ZXIoKHByb3BlcnR5KSA9PiBwcm9wZXJ0eS5pbmhlcml0ZWQpOwor CiAgICAgICAgIGlmICh0aGlzLl9zb3J0UHJvcGVydGllc0J5TmFtZSkKICAgICAgICAgICAgIHBy b3BlcnRpZXMuc29ydCgoYSwgYikgPT4gYS5uYW1lLmV4dGVuZGVkTG9jYWxlQ29tcGFyZShiLm5h bWUpKTsKIAo=