215674 2020-08-19 17:18:37 -0700 [Cocoa] Remove workaround in Font::platformWidthForGlyph() 2020-09-05 10:42:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 215670 https://bugs.webkit.org/show_bug.cgi?id=215670 InRadar P2 Normal --- 1 mmaxfield mmaxfield darin webkit-bug-importer oldest_to_newest 1681545 0 mmaxfield 2020-08-19 17:18:37 -0700 [Cocoa] Remove workaround in Font::platformWidthForGlyph() 1681547 1 406892 mmaxfield 2020-08-19 17:19:14 -0700 Created attachment 406892 Patch 1681593 2 mmaxfield 2020-08-19 20:06:57 -0700 This probably needs PLATFORM guards, as those radars aren't fixed on every OS. It's a little scary no tests failed.... 1681610 3 mmaxfield 2020-08-19 20:57:35 -0700 Also, this isn't for any particular bug, so I should probably hold off on committing it. 1683222 4 webkit-bug-importer 2020-08-26 17:19:12 -0700 <rdar://problem/67839262> 1686087 5 mmaxfield 2020-09-05 10:42:23 -0700 Solving this in https://bugs.webkit.org/show_bug.cgi?id=215670 instead. *** This bug has been marked as a duplicate of bug 215670 *** 406892 2020-08-19 17:19:14 -0700 2020-08-19 20:04:48 -0700 Patch bug-215674-20200819171913.patch text/plain 2749 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMwYmRlNzlmZTU5ODk4 M2M3MjczM2VmYjQ0OGQyZDc4NGMwNmUxYi4uZGIwYmRmNzUxZjY4NjAzMGRhNjE0MmNlMjNmNjcw MDA2MTFlMjYyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA4LTE5ICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0NvY29hXSBS ZW1vdmUgd29ya2Fyb3VuZCBpbiBGb250OjpwbGF0Zm9ybVdpZHRoRm9yR2x5cGgoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1Njc0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQm90aCA8cmRhcjovL3By b2JsZW0vMjgxOTcyOTE+IGFuZCA8cmRhcjovL3Byb2JsZW0vMjg2NjIwODY+IGFyZSBmaXhlZC4K KworICAgICAgICBObyBuZXcgdGVzdHMgYmVjYXVzZSB0aGVyZSBpcyBubyBiZWhhdmlvciBjaGFu Z2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250Q29jb2EubW06Cisg ICAgICAgIChXZWJDb3JlOjpGb250OjpwbGF0Zm9ybVdpZHRoRm9yR2x5cGggY29uc3QpOgorCiAy MDIwLTA4LTE5ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAg ICAgIFtpT1NdIFJlc3RvcmUgYSAxMF8xNV8qIHVzZXItYWdlbnQgc3RyaW5nIHdoZW4gcmVxdWVz dGluZyBkZXNrdG9wIHNpdGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NvY29hL0ZvbnRDb2NvYS5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2NvY29hL0ZvbnRDb2NvYS5tbQppbmRleCA5M2ZiMDAwNGUyZDA0YWE3NTkzM2ExYmQxY2I3 YmM4YjgxN2Y1Y2M0Li5mOTkzZDI5MjVkYTY5Y2JhY2ZhYjVlMjY2MjAzYzY1ZGY1NDRjODk1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250Q29j b2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udENv Y29hLm1tCkBAIC02NzAsMTYgKzY3MCwxMiBAQCBGbG9hdFJlY3QgRm9udDo6cGxhdGZvcm1Cb3Vu ZHNGb3JHbHlwaChHbHlwaCBnbHlwaCkgY29uc3QKIGZsb2F0IEZvbnQ6OnBsYXRmb3JtV2lkdGhG b3JHbHlwaChHbHlwaCBnbHlwaCkgY29uc3QKIHsKICAgICBDR1NpemUgYWR2YW5jZSA9IENHU2l6 ZVplcm87Ci0gICAgYm9vbCBob3Jpem9udGFsID0gcGxhdGZvcm1EYXRhKCkub3JpZW50YXRpb24o KSA9PSBGb250T3JpZW50YXRpb246Okhvcml6b250YWw7Ci0gICAgQ0dGb250UmVuZGVyaW5nU3R5 bGUgc3R5bGUgPSBrQ0dGb250UmVuZGVyaW5nU3R5bGVBbnRpYWxpYXNpbmcgfCBrQ0dGb250UmVu ZGVyaW5nU3R5bGVTdWJwaXhlbFBvc2l0aW9uaW5nIHwga0NHRm9udFJlbmRlcmluZ1N0eWxlU3Vi cGl4ZWxRdWFudGl6YXRpb24gfCBrQ0dGb250QW50aWFsaWFzaW5nU3R5bGVVbmZpbHRlcmVkOwog CiAgICAgaWYgKHBsYXRmb3JtRGF0YSgpLnNpemUoKSkgeworICAgICAgICBib29sIGhvcml6b250 YWwgPSBwbGF0Zm9ybURhdGEoKS5vcmllbnRhdGlvbigpID09IEZvbnRPcmllbnRhdGlvbjo6SG9y aXpvbnRhbDsKICAgICAgICAgQ1RGb250T3JpZW50YXRpb24gb3JpZW50YXRpb24gPSBob3Jpem9u dGFsIHx8IG1faXNCcm9rZW5JZGVvZ3JhcGhGYWxsYmFjayA/IGtDVEZvbnRPcmllbnRhdGlvbkhv cml6b250YWwgOiBrQ1RGb250T3JpZW50YXRpb25WZXJ0aWNhbDsKLSAgICAgICAgLy8gRklYTUU6 IFJlbW92ZSB0aGlzIHNwZWNpYWwtY2FzaW5nIHdoZW4gPHJkYXI6Ly9wcm9ibGVtLzI4MTk3Mjkx PiBhbmQgPHJkYXI6Ly9wcm9ibGVtLzI4NjYyMDg2PiBhcmUgZml4ZWQuCi0gICAgICAgIGlmIChD VEZvbnRJc0FwcGxlQ29sb3JFbW9qaShtX3BsYXRmb3JtRGF0YS5jdEZvbnQoKSkgfHwgbV9wbGF0 Zm9ybURhdGEuaGFzVmFyaWF0aW9ucygpKQotICAgICAgICAgICAgQ1RGb250R2V0QWR2YW5jZXNG b3JHbHlwaHMobV9wbGF0Zm9ybURhdGEuY3RGb250KCksIG9yaWVudGF0aW9uLCAmZ2x5cGgsICZh ZHZhbmNlLCAxKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgQ1RGb250R2V0VW5zdW1tZWRB ZHZhbmNlc0ZvckdseXBoc0FuZFN0eWxlKG1fcGxhdGZvcm1EYXRhLmN0Rm9udCgpLCBvcmllbnRh dGlvbiwgc3R5bGUsICZnbHlwaCwgJmFkdmFuY2UsIDEpOworICAgICAgICBDR0ZvbnRSZW5kZXJp bmdTdHlsZSBzdHlsZSA9IGtDR0ZvbnRSZW5kZXJpbmdTdHlsZUFudGlhbGlhc2luZyB8IGtDR0Zv bnRSZW5kZXJpbmdTdHlsZVN1YnBpeGVsUG9zaXRpb25pbmcgfCBrQ0dGb250UmVuZGVyaW5nU3R5 bGVTdWJwaXhlbFF1YW50aXphdGlvbiB8IGtDR0ZvbnRBbnRpYWxpYXNpbmdTdHlsZVVuZmlsdGVy ZWQ7CisgICAgICAgIENURm9udEdldFVuc3VtbWVkQWR2YW5jZXNGb3JHbHlwaHNBbmRTdHlsZSht X3BsYXRmb3JtRGF0YS5jdEZvbnQoKSwgb3JpZW50YXRpb24sIHN0eWxlLCAmZ2x5cGgsICZhZHZh bmNlLCAxKTsKICAgICB9CiAgICAgcmV0dXJuIGFkdmFuY2Uud2lkdGggKyBtX3N5bnRoZXRpY0Jv bGRPZmZzZXQ7CiB9Cg==