215668 2020-08-19 16:13:57 -0700 Fix possible crash when webAnimationsCSSIntegrationEnabled is false 2020-08-19 20:51:32 -0700 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser darin dino graouts simon.fraser webkit-bug-importer oldest_to_newest 1681515 0 simon.fraser 2020-08-19 16:13:57 -0700 Fix possible crash when webAnimationsCSSIntegrationEnabled is false 1681516 1 406885 simon.fraser 2020-08-19 16:16:13 -0700 Created attachment 406885 Patch 1681517 2 simon.fraser 2020-08-19 16:16:15 -0700 <rdar://problem/67402003> 1681520 3 406885 darin 2020-08-19 16:19:17 -0700 Comment on attachment 406885 Patch Too bad we have to do this manually. Encoding and decoding Optional<> handles this correctly automatically, but I guess with pointers it’s ambiguous whether they can be null or not. 1681525 4 simon.fraser 2020-08-19 16:32:32 -0700 Optional<> would have be easier if the timing-function encoding didn't need special-casing. 1681607 5 ews-feeder 2020-08-19 20:51:31 -0700 Committed r265932: <https://trac.webkit.org/changeset/265932> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406885. 406885 2020-08-19 16:16:13 -0700 2020-08-19 20:51:32 -0700 Patch bug-215668-20200819161612.patch text/plain 5366 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI1ZThkOTdlMjNhZDNjNjZl NWNlY2MwNTBmM2RiYTYzMGU0YjdkYWQuLmZlMjhmNTAzZjNhNjMxOWRmZTg5MzIwNDk1NDk0Mzc3 MGIwZDUzZmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDgtMTkgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHBvc3NpYmxlIGNy YXNoIHdoZW4gd2ViQW5pbWF0aW9uc0NTU0ludGVncmF0aW9uRW5hYmxlZCBpcyBmYWxzZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1NjY4CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82NzQwMjAwMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlYkFuaW1hdGlvbnNDU1NJbnRlZ3JhdGlvbkVu YWJsZWQgaXMgZmFsc2UsIEdyYXBoaWNzTGF5ZXJDQTo6c2V0dXBBbmltYXRpb24oKSBkb2Vzbid0 CisgICAgICAgIHNldCBhIHRpbWluZyBmdW5jdGlvbiBvbiB0aGUgYW5pbWF0aW9uLCBjYXVzaW5n IGEgbnVsbCBkZS1yZWYgd2hlbiB0aGUgYW5pbWF0aW9uIGlzIGJlaW5nIGVuY29kZWQuCisgICAg ICAgIEZpeCB0aGUgZW5jb2RlciB0byBoYW5kbGUgbnVsbCB0aW1pbmcgZnVuY3Rpb25zLgorCisg ICAgICAgIFRlc3Q6IGFuaW1hdGlvbnMvbGVnYWN5LWVuY29kaW5nLXRpbWluZy1mdW5jdGlvbi5o dG1sCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvUmVtb3RlTGF5ZXJUcmVlL1BsYXRm b3JtQ0FBbmltYXRpb25SZW1vdGUubW06CisgICAgICAgIChXZWJLaXQ6OlBsYXRmb3JtQ0FBbmlt YXRpb25SZW1vdGU6OlByb3BlcnRpZXM6OmVuY29kZSBjb25zdCk6CisgICAgICAgIChXZWJLaXQ6 OlBsYXRmb3JtQ0FBbmltYXRpb25SZW1vdGU6OlByb3BlcnRpZXM6OmRlY29kZSk6CisKIDIwMjAt MDgtMTggIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10g VW5oYW5kbGVkIGtleURvd246IGV2ZW50cyBjYXVzZSBhIHN5c3RlbSBiZWVwIGluIGZ1bGwgc2Ny ZWVuIG1vZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1Jl bW90ZUxheWVyVHJlZS9QbGF0Zm9ybUNBQW5pbWF0aW9uUmVtb3RlLm1tIGIvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1dlYlBhZ2UvUmVtb3RlTGF5ZXJUcmVlL1BsYXRmb3JtQ0FBbmltYXRpb25S ZW1vdGUubW0KaW5kZXggYzUzNGRlMDcyYjZmODBmYWJkMGJjZmQ2YzZkNDY3ZTUxY2M0YTE3NC4u ZGU3ZDcyODAyOTJkMDUwZDcyZDA2YWM5NGFiOTMxY2YyM2ZhNGU4ZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvUmVtb3RlTGF5ZXJUcmVlL1BsYXRmb3JtQ0FB bmltYXRpb25SZW1vdGUubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2Uv UmVtb3RlTGF5ZXJUcmVlL1BsYXRmb3JtQ0FBbmltYXRpb25SZW1vdGUubW0KQEAgLTIyMyw3ICsy MjMsMTEgQEAgdm9pZCBQbGF0Zm9ybUNBQW5pbWF0aW9uUmVtb3RlOjpQcm9wZXJ0aWVzOjplbmNv ZGUoSVBDOjpFbmNvZGVyJiBlbmNvZGVyKSBjb25zdAogCiAgICAgZW5jb2RlciA8PCBmaWxsTW9k ZTsKICAgICBlbmNvZGVyIDw8IHZhbHVlRnVuY3Rpb247Ci0gICAgZW5jb2RlVGltaW5nRnVuY3Rp b24oZW5jb2RlciwgdGltaW5nRnVuY3Rpb24uZ2V0KCkpOworICAgIAorICAgIGJvb2wgaGFzVGlt aW5nRnVuY3Rpb24gPSAhIXRpbWluZ0Z1bmN0aW9uOworICAgIGVuY29kZXIgPDwgaGFzVGltaW5n RnVuY3Rpb247CisgICAgaWYgKGhhc1RpbWluZ0Z1bmN0aW9uKQorICAgICAgICBlbmNvZGVUaW1p bmdGdW5jdGlvbihlbmNvZGVyLCB0aW1pbmdGdW5jdGlvbi5nZXQoKSk7CiAKICAgICBlbmNvZGVy IDw8IGF1dG9SZXZlcnNlczsKICAgICBlbmNvZGVyIDw8IHJlbW92ZWRPbkNvbXBsZXRpb247CkBA IC0yNjksMTEgKzI3MywxNyBAQCBPcHRpb25hbDxQbGF0Zm9ybUNBQW5pbWF0aW9uUmVtb3RlOjpQ cm9wZXJ0aWVzPiBQbGF0Zm9ybUNBQW5pbWF0aW9uUmVtb3RlOjpQcm9wZQogICAgIGlmICghZGVj b2Rlci5kZWNvZGUocHJvcGVydGllcy52YWx1ZUZ1bmN0aW9uKSkKICAgICAgICAgcmV0dXJuIFdU Rjo6bnVsbG9wdDsKIAotICAgIGlmIChhdXRvIHRpbWluZ0Z1bmN0aW9uID0gZGVjb2RlVGltaW5n RnVuY3Rpb24oZGVjb2RlcikpCi0gICAgICAgIHByb3BlcnRpZXMudGltaW5nRnVuY3Rpb24gPSBX VEZNb3ZlKCp0aW1pbmdGdW5jdGlvbik7Ci0gICAgZWxzZQorICAgIGJvb2wgaGFzVGltaW5nRnVu Y3Rpb247CisgICAgaWYgKCFkZWNvZGVyLmRlY29kZShoYXNUaW1pbmdGdW5jdGlvbikpCiAgICAg ICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiAKKyAgICBpZiAoaGFzVGltaW5nRnVuY3Rpb24pIHsK KyAgICAgICAgaWYgKGF1dG8gdGltaW5nRnVuY3Rpb24gPSBkZWNvZGVUaW1pbmdGdW5jdGlvbihk ZWNvZGVyKSkKKyAgICAgICAgICAgIHByb3BlcnRpZXMudGltaW5nRnVuY3Rpb24gPSBXVEZNb3Zl KCp0aW1pbmdGdW5jdGlvbik7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHJldHVybiBXVEY6 Om51bGxvcHQ7CisgICAgfQorCiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZShwcm9wZXJ0aWVzLmF1 dG9SZXZlcnNlcykpCiAgICAgICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxNjdi ODZmMGMyZmJiODFmOWY5YzYxN2MzYWVhZTJlNTdkNmY4MTI2Li5kYmQ4NjZhZGEyY2E5MGJjZTIz NzRkYWE3MzAxYmY3NzljZTk2Mzk1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDgtMTkg IFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IHBv c3NpYmxlIGNyYXNoIHdoZW4gd2ViQW5pbWF0aW9uc0NTU0ludGVncmF0aW9uRW5hYmxlZCBpcyBm YWxzZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1 NjY4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NzQwMjAwMz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGFuaW1hdGlvbnMvbGVnYWN5LWVuY29k aW5nLXRpbWluZy1mdW5jdGlvbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGFuaW1h dGlvbnMvbGVnYWN5LWVuY29kaW5nLXRpbWluZy1mdW5jdGlvbi5odG1sOiBBZGRlZC4KKwogMjAy MC0wOC0xOCAgS2FybCBSYWNrbGVyICA8cmFja2xlckBhcHBsZS5jb20+CiAKICAgICAgICAgRGlz YWJsZSBwbHVnLWluIHRlc3RzIG9uIEFwcGxlIFNpbGljb24KZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2FuaW1hdGlvbnMvbGVnYWN5LWVuY29kaW5nLXRpbWluZy1mdW5jdGlvbi1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2xlZ2FjeS1lbmNvZGluZy10aW1pbmctZnVuY3Rp b24tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQzMWY2ZWE2NTZjMjE2NzA1ZGNjOTI4Y2ZlZGJk MzNlZDc5ZTJjMmEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9hbmltYXRpb25zL2xl Z2FjeS1lbmNvZGluZy10aW1pbmctZnVuY3Rpb24tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBA QAorVGhpcyB0ZXN0IHNob3VsZCBub3QgY3Jhc2guCisKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvYW5pbWF0aW9ucy9sZWdhY3ktZW5jb2RpbmctdGltaW5nLWZ1bmN0aW9uLmh0bWwgYi9MYXlv dXRUZXN0cy9hbmltYXRpb25zL2xlZ2FjeS1lbmNvZGluZy10aW1pbmctZnVuY3Rpb24uaHRtbApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi40MDJmOThlYTMxMTVhYTFkNzc2ZmFmODhlZWRiOTFhMjg3NTFmOTczCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9sZWdhY3ktZW5jb2RpbmctdGlt aW5nLWZ1bmN0aW9uLmh0bWwKQEAgLTAsMCArMSwzNyBAQAorPCFET0NUWVBFIGh0bWw+IDwhLS0g d2Via2l0LXRlc3QtcnVubmVyIFsgZXhwZXJpbWVudGFsOldlYkFuaW1hdGlvbnNDU1NJbnRlZ3Jh dGlvbkVuYWJsZWQ9ZmFsc2UgXSAtLT4KKzxodG1sPgorPGhlYWQ+CisgICAgPHN0eWxlPgorICAg ICAgICAjYm94IHsKKyAgICAgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgICB3aWR0 aDogMTAwcHg7CisgICAgICAgICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOworICAgICAgICAg ICAgYW5pbWF0aW9uOiBtb3ZlIDEgMXMgbGluZWFyOworICAgICAgICB9CisgICAgICAgIAorICAg ICAgICBAa2V5ZnJhbWVzIG1vdmUgeworICAgICAgICAgICAgZnJvbSB7IHRyYW5zZm9ybTogdHJh bnNsYXRlKDAsIDApOyB9CisgICAgICAgICAgICA1MCUgIHsgdHJhbnNmb3JtOiB0cmFuc2xhdGUo MTAwcHgsIDApOyB9CisgICAgICAgICAgICB0byAgIHsgdHJhbnNmb3JtOiB0cmFuc2xhdGUoMzAw cHgsIDApOyB9CisgICAgICAgIH0KKyAgICA8L3N0eWxlPgorICAgIDxzY3JpcHQ+CisgICAgICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNU ZXh0KCk7CisgICAgICAgICAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICAgICAg fQorCisgICAgICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdsb2FkJywgKCkgPT4geworICAg ICAgICAgICAgbGV0IGJveCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdib3gnKTsKKyAgICAg ICAgICAgIGJveC5hZGRFdmVudExpc3RlbmVyKCdhbmltYXRpb25zdGFydCcsICgpID0+IHsKKyAg ICAgICAgICAgICAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgICAgICAgICAgICAg IHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICAgICAgfSk7CisgICAgICAgIH0sIGZh bHNlKTsKKyAgICA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorICAgIDxwPlRoaXMgdGVzdCBz aG91bGQgbm90IGNyYXNoLjwvcD4KKyAgICA8ZGl2IGlkPSJib3giPjwvZGl2PgorPC9ib2R5Pgor PC9odG1sPgo=