215656 2020-08-19 10:43:24 -0700 REGRESSION (r261407): Sharing rich links from Twitter/Netflix via Messages is unreliable 2020-08-19 11:33:52 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez darin thorton webkit-bug-importer oldest_to_newest 1681404 0 cdumez 2020-08-19 10:43:24 -0700 Sharing rick links from Twitter/Netflix via Messages is unreliable since r261407. The preview of the link is not always loaded. 1681405 1 cdumez 2020-08-19 10:43:36 -0700 <rdar://problem/67087352> 1681409 2 406856 cdumez 2020-08-19 10:58:21 -0700 Created attachment 406856 Patch 1681410 3 406856 thorton 2020-08-19 11:00:21 -0700 Comment on attachment 406856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406856&action=review > Source/WebKit/ChangeLog:3 > + REGRESSION (r261407): Sharing rick links from Twitter/Netflix via Messages is unreliable s/rick/rich/ 1681412 4 406857 cdumez 2020-08-19 11:04:21 -0700 Created attachment 406857 Patch 1681421 5 ews-feeder 2020-08-19 11:33:51 -0700 Committed r265882: <https://trac.webkit.org/changeset/265882> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406857. 406856 2020-08-19 10:58:21 -0700 2020-08-19 11:04:20 -0700 Patch bug-215656-20200819105820.patch text/plain 7549 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJjMmUyNzA0OGUxYTliNzhm MzlhZDhiMDBjYjU1ZGZmZGI3YjY1NzYuLjA0YjNmODA0MmYzZGIyOGVmOGRkNTgxNjIzY2MwZWE1 Y2ZjZjg4NzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzcgQEAKKzIwMjAtMDgtMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjYxNDA3KTog U2hhcmluZyByaWNrIGxpbmtzIGZyb20gVHdpdHRlci9OZXRmbGl4IHZpYSBNZXNzYWdlcyBpcyB1 bnJlbGlhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTU2NTYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY3MDg3MzUyPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBXS1dlYlZpZXcuX2NsaWVu dE5hdmlnYXRpb25zUnVuQXRGb3JlZ3JvdW5kUHJpb3JpdHkgU1BJIHdhcyBub3Qgd29ya2luZyBm b3IgdGhlCisgICAgICAgIE1lc3NhZ2VzVmlld1NlcnZpY2UgYmVjYXVzZSB0aGUgdmlldyBpcyB1 bnBhcmVudGVkIGFuZCBQYWdlQ2xpZW50Ojppc0FwcGxpY2F0aW9uVmlzaWJsZSgpCisgICAgICAg IHdvdWxkIG5vdCB3b3JrIHJldHVybiBhY2N1cmF0ZSByZXN1bHRzIHdoZW4gW3ZpZXcgd2luZG93 XSByZXR1cm5zIG5pbC4gSXQgaXMgdmVyeQorICAgICAgICB1bmZvcnR1bmF0ZSB0byBoYXZlIHRv IHJlbHkgb24gdGhlIHZpZXcgb3IgdGhlIHZpZXcncyB3aW5kb3cgdG8gZGV0ZXJtaW5lIGFwcGxp Y2F0aW9uCisgICAgICAgIHZpc2liaWxpdHkgc28gdGhpcyBwYXRjaCBmaXhlcyB0aGlzLiBXZSBu b3cgcmVseSBvbiBVSUtpdCdzIHZpc2liaWxpdHkgZW5kb3dtZW50IHRvCisgICAgICAgIGRldGVy bWluZSBpZiB0aGUgVUlQcm9jZXNzIGlzIHZpc2libGUsIHVzaW5nIFJ1bm5pbmdCb2FyZCBBUEku IEkgaGF2ZSB2ZXJpZmllZCB0aGF0IHRoZQorICAgICAgICB2aXNpYmlsaXR5IGVuZG93bWVudCBw cm9wZXJseSBnZXRzIHByb3BhZ2F0ZWQgZnJvbSB0aGUgaG9zdCBhcHBsaWNhdGlvbiB0byB0aGUg dmlldworICAgICAgICBzZXJ2aWNlIHdoZW4gdGhlIGFwcGxpY2F0aW9uIGlzIGEgdmlldyBzZXJ2 aWNlIGFuZCBJIGhhdmUgdmVyaWZpZWQgdGhhdCB0aGlzIGRldGVjdHMKKyAgICAgICAgdGhlIE1l c3NhZ2VzVmlld1NlcnZpY2UgYXMgdmlzaWJsZSBmb3IgdGhlIHVzZS1jYXNlIGF0IDxyZGFyOi8v cHJvYmxlbS82NzA4NzM1Mj4sIHdoaWNoCisgICAgICAgIGNhdXNlcyB0aGUgV0tXZWJWaWV3Ll9j bGllbnROYXZpZ2F0aW9uc1J1bkF0Rm9yZWdyb3VuZFByaW9yaXR5IFNQSSB0byB3b3JrIGFzIGlu dGVuZGVkLgorCisgICAgICAgIE5vdGUgdGhhdCB3aGVuIHRoZSBhcHBsaWNhdGlvbiBkb2VzIG5v dCBoYXZlIHRoZSB2aXNpYmlsaXR5IGVuZG93bWVudCwgd2Ugc3RpbGwgYWxsb3cKKyAgICAgICAg aXQgdG8gdGFrZSBhIGZvcmVncm91bmQgYXNzZXJ0aW9uIGZvciBjbGllbnQgbmF2aWdhdGlvbnMg aWYgdGhlIHByb2Nlc3MgaXMgYWxsb3dlZCB0bworICAgICAgICBydW4gaW4gdGhlIGJhY2tncm91 bmQgZm9yIGFuIGV4dGVuZGVkIHBlcmlvZCBvZiB0aW1lLCBhY2NvcmRpbmcgdG8gUnVubmluZ0Jv YXJkLiBUaGlzCisgICAgICAgIGFsbG93cyB0aGUgU1BJIHRvIHdvcmsgZm9yIGRhZW1vbnMgKGxp a2UgbWFpbGQpIHdoaWNoIHJlbHkgb24gaXQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvUGFnZUNs aWVudC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJQYWdlUHJveHk6OnJ1bkphdmFTY3JpcHRJbkZyYW1lSW5TY3JpcHRXb3JsZCk6 CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5oOgorICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW06CisgICAgICAgIChXZWJLaXQ6OlBh Z2VDbGllbnRJbXBsOjpjYW5UYWtlRm9yZWdyb3VuZEFzc2VydGlvbnMpOgorICAgICAgICAoV2Vi S2l0OjpQYWdlQ2xpZW50SW1wbDo6aXNBcHBsaWNhdGlvblZpc2libGUpOiBEZWxldGVkLgorICAg ICAgICAqIFVJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlUHJveHk6OnNob3VsZEZvcmNlRm9yZWdyb3VuZFByaW9yaXR5Rm9yQ2xpZW50TmF2 aWdhdGlvbiBjb25zdCk6CisKIDIwMjAtMDgtMTkgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBw bGUuY29tPgogCiAgICAgICAgIFdlYlNvY2tldENoYW5uZWw6OmRpZENsb3NlIHNob3VsZCBjb3Jy ZWN0bHkgY29tcHV0ZSB3aGV0aGVyIGEgY2xvc2luZyBoYW5kc2hha2Ugd2FzIHJlY2VpdmVkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmggYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmgKaW5kZXggOGM2YzU3M2NmZDczNDlkMGExMWFm YjRiMzhmOTY5MTczYWQ2MGJiNC4uMDYwNTZhNGYyODI3ZTQ4NWYyZGZiZWZkM2M2YWFjZjk5MWNj ZjgyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaApAQCAtMjA0LDggKzIwNCw3 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgaXNWaWV3VmlzaWJsZSgpID0gMDsKIAogI2lm IFBMQVRGT1JNKElPU19GQU1JTFkpCi0gICAgLy8gUmV0dXJuIHdoZXRoZXIgdGhlIGFwcGxpY2F0 aW9uIGlzIHZpc2libGUuCi0gICAgdmlydHVhbCBib29sIGlzQXBwbGljYXRpb25WaXNpYmxlKCkg PSAwOworICAgIHZpcnR1YWwgYm9vbCBjYW5UYWtlRm9yZWdyb3VuZEFzc2VydGlvbnMoKSA9IDA7 CiAjZW5kaWYKIAogICAgIC8vIFJldHVybiB3aGV0aGVyIHRoZSB2aWV3IGlzIHZpc2libGUsIG9y IG9jY2x1ZGVkIGJ5IGFub3RoZXIgd2luZG93LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHAKaW5kZXggM2FiYTUzN2VmNDZiNmEyNWFjY2JmOTYxZTFiMDU1OWY2MGMyY2Zj Mi4uMDkwOGRlYjMwZTNlY2UyOTBkOWExYzkzZGUzNzI5MzYyMDk2YmE5ZSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCkBAIC00MDk4LDcgKzQwOTgsNyBAQCB2b2lk IFdlYlBhZ2VQcm94eTo6cnVuSmF2YVNjcmlwdEluRnJhbWVJblNjcmlwdFdvcmxkKFJ1bkphdmFT Y3JpcHRQYXJhbWV0ZXJzJiYgcAogCiAgICAgUHJvY2Vzc1Rocm90dGxlcjo6QWN0aXZpdHlWYXJp YW50IGFjdGl2aXR5OwogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCi0gICAgaWYgKHBhZ2VDbGll bnQoKS5pc0FwcGxpY2F0aW9uVmlzaWJsZSgpKQorICAgIGlmIChwYWdlQ2xpZW50KCkuY2FuVGFr ZUZvcmVncm91bmRBc3NlcnRpb25zKCkpCiAgICAgICAgIGFjdGl2aXR5ID0gbV9wcm9jZXNzLT50 aHJvdHRsZXIoKS5mb3JlZ3JvdW5kQWN0aXZpdHkoIldlYlBhZ2VQcm94eTo6cnVuSmF2YVNjcmlw dEluRnJhbWVJblNjcmlwdFdvcmxkIl9zKTsKICAgICBlbHNlCiAjZW5kaWYKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5oIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLmgKaW5kZXggNTA2YWIzMDc3 MmU5ZTk4ZTExMWM4N2M4ZTdkYmVmMDAwNDUwZTNhMC4uMTMyOGJlYzNiMmExZjMwY2JmZTM5MWZl NTZjNzdjZDliNWI5ZWJmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9z L1BhZ2VDbGllbnRJbXBsSU9TLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1Bh Z2VDbGllbnRJbXBsSU9TLmgKQEAgLTY0LDcgKzY0LDcgQEAgcHJpdmF0ZToKICAgICBib29sIGlz Vmlld1dpbmRvd0FjdGl2ZSgpIG92ZXJyaWRlOwogICAgIGJvb2wgaXNWaWV3Rm9jdXNlZCgpIG92 ZXJyaWRlOwogICAgIGJvb2wgaXNWaWV3VmlzaWJsZSgpIG92ZXJyaWRlOwotICAgIGJvb2wgaXNB cHBsaWNhdGlvblZpc2libGUoKSBvdmVycmlkZTsKKyAgICBib29sIGNhblRha2VGb3JlZ3JvdW5k QXNzZXJ0aW9ucygpIG92ZXJyaWRlOwogICAgIGJvb2wgaXNWaWV3SW5XaW5kb3coKSBvdmVycmlk ZTsKICAgICBib29sIGlzVmlld1Zpc2libGVPck9jY2x1ZGVkKCkgb3ZlcnJpZGU7CiAgICAgYm9v bCBpc1Zpc3VhbGx5SWRsZSgpIG92ZXJyaWRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLm1tCmluZGV4IDBhNTU4NDA5ZDAyODY1NjYwNDI5MTEx ZjU2NGUzMjY5YzkyOGQyNzYuLmZmN2MwYmQyYTc5MDJkNjdlMTA2NmYxMzVkZDA5Y2IzZjc4NjFk N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1w bElPUy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJ T1MubW0KQEAgLTE0OCwyNyArMTQ4LDE4IEBAIGJvb2wgUGFnZUNsaWVudEltcGw6OmlzVmlld1Zp c2libGUoKQogICAgIHJldHVybiBmYWxzZTsKIH0KIAotYm9vbCBQYWdlQ2xpZW50SW1wbDo6aXNB cHBsaWNhdGlvblZpc2libGUoKQorYm9vbCBQYWdlQ2xpZW50SW1wbDo6Y2FuVGFrZUZvcmVncm91 bmRBc3NlcnRpb25zKCkKIHsKLSAgICBpZiAoYXBwbGljYXRpb25UeXBlKFttX3dlYlZpZXcgd2lu ZG93XSkgPT0gQXBwbGljYXRpb25UeXBlOjpBcHBsaWNhdGlvbikgewotICAgICAgICBBU1NFUlQo IV9VSUFwcGxpY2F0aW9uSXNFeHRlbnNpb24oKSk7Ci0gICAgICAgIHJldHVybiBbW1VJQXBwbGlj YXRpb24gc2hhcmVkQXBwbGljYXRpb25dIGFwcGxpY2F0aW9uU3RhdGVdICE9IFVJQXBwbGljYXRp b25TdGF0ZUJhY2tncm91bmQ7Ci0gICAgfQotCi0gICAgLy8gQ29tcGxleCBjb2RlIHBhdGggZm9y IGV4dGVuc2lvbnMgYW5kIHZpZXcgc2VydmljZXMuCi0gICAgVUlWaWV3Q29udHJvbGxlciAqc2Vy dmljZVZpZXdDb250cm9sbGVyID0gbmlsOwotICAgIGZvciAoVUlWaWV3ICp2aWV3ID0gbV93ZWJW aWV3LmdldCgpLmdldCgpOyB2aWV3OyB2aWV3ID0gdmlldy5zdXBlcnZpZXcpIHsKLSAgICAgICAg VUlWaWV3Q29udHJvbGxlciAqdmlld0NvbnRyb2xsZXIgPSBbVUlWaWV3Q29udHJvbGxlciB2aWV3 Q29udHJvbGxlckZvclZpZXc6dmlld107Ci0gICAgICAgIGlmICh2aWV3Q29udHJvbGxlci5faG9z dFByb2Nlc3NJZGVudGlmaWVyKSB7Ci0gICAgICAgICAgICBzZXJ2aWNlVmlld0NvbnRyb2xsZXIg PSB2aWV3Q29udHJvbGxlcjsKLSAgICAgICAgICAgIGJyZWFrOwotICAgICAgICB9CisgICAgaWYg KEVuZG93bWVudFN0YXRlVHJhY2tlcjo6c2luZ2xldG9uKCkuaXNWaXNpYmxlKCkpIHsKKyAgICAg ICAgLy8gSWYgdGhlIGFwcGxpY2F0aW9uIGlzIHZpc2libGUgYWNjb3JkaW5nIHRvIHRoZSBVSUtp dCB2aXNpYmlsaXR5IGVuZG93bWVudCB0aGVuIHdlIGNhbiB0YWtlCisgICAgICAgIC8vIGZvcmVn cm91bmQgYXNzZXJ0aW9ucy4gTm90ZSB0aGF0IGZvciB2aWV3IHNlcnZpY2VzLCB0aGUgdmlzaWJp bGl0eSBlbmRvd25tZW50IGZyb20gdGhlIGhvc3QKKyAgICAgICAgLy8gYXBwbGljYXRpb24gZ2V0 cyBwcm9wYWdhdGVkIHRvIHRoZSB2aWV3IHNlcnZpY2UuCisgICAgICAgIHJldHVybiB0cnVlOwog ICAgIH0KLSAgICBBU1NFUlQoc2VydmljZVZpZXdDb250cm9sbGVyKTsKLSAgICBwaWRfdCBhcHBs aWNhdGlvblBJRCA9IHNlcnZpY2VWaWV3Q29udHJvbGxlci5faG9zdFByb2Nlc3NJZGVudGlmaWVy OwotICAgIEFTU0VSVChhcHBsaWNhdGlvblBJRCk7CiAKLSAgICByZXR1cm4gRW5kb3dtZW50U3Rh dGVUcmFja2VyOjppc0FwcGxpY2F0aW9uRm9yZWdyb3VuZChhcHBsaWNhdGlvblBJRCk7CisgICAg Ly8gSWYgdGhlcmUgaXMgbm8gcnVuIHRpbWUgbGltaXRhdGlvbiwgdGhlbiBpdCBtZWFucyB0aGF0 IHRoZSBwcm9jZXNzIGlzIGFsbG93ZWQgdG8gcnVuIGZvciBhbiBleHRlbmRlZAorICAgIC8vIHBl cmlvZCBvZiB0aW1lIGluIHRoZSBiYWNrZ3JvdW5kIChlLmcuIGEgZGFlbW9uKSBhbmQgd2UgbGV0 IHN1Y2ggcHJvY2Vzc2VzIHRha2UgZm9yZWdyb3VuZCBhc3NlcnRpb25zLgorICAgIHJldHVybiBb UkJTUHJvY2Vzc0hhbmRsZSBjdXJyZW50UHJvY2Vzc10uYWN0aXZlTGltaXRhdGlvbnMucnVuVGlt ZSA9PSBSQlNQcm9jZXNzVGltZUxpbWl0YXRpb25Ob25lOwogfQogCiBib29sIFBhZ2VDbGllbnRJ bXBsOjppc1ZpZXdJbldpbmRvdygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dl YlBhZ2VQcm94eUlPUy5tbQppbmRleCBjMDQzYTA0N2U2NTI0MzYwZTQ1OWVjY2RkZTRkMmU3Mzky YmI0YmQwLi40NWMwYmQ0OTU3MGE1ZWUzYmUxYjg5M2VjYWVhY2I4MzVkZDliMjVlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV2ViUGFnZVByb3h5SU9TLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0KQEAgLTE1NTAs NyArMTU1MCw5IEBAIGJvb2wgV2ViUGFnZVByb3h5OjpzaG91bGRGb3JjZUZvcmVncm91bmRQcmlv cml0eUZvckNsaWVudE5hdmlnYXRpb24oKSBjb25zdAogICAgIGlmIChpc1ZpZXdWaXNpYmxlKCkp CiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIHJldHVybiBwYWdlQ2xpZW50KCkuaXNBcHBs aWNhdGlvblZpc2libGUoKTsKKyAgICBib29sIGNhblRha2VGb3JlZ3JvdW5kQXNzZXJ0aW9ucyA9 IHBhZ2VDbGllbnQoKS5jYW5UYWtlRm9yZWdyb3VuZEFzc2VydGlvbnMoKTsKKyAgICBSRUxFQVNF X0xPR19JRl9BTExPV0VEKFByb2Nlc3MsICJXZWJQYWdlUHJveHk6OnNob3VsZEZvcmNlRm9yZWdy b3VuZFByaW9yaXR5Rm9yQ2xpZW50TmF2aWdhdGlvbigpIHJldHVybnMgJWQgYmFzZWQgb24gUGFn ZUNsaWVudDo6Y2FuVGFrZUZvcmVncm91bmRBc3NlcnRpb25zKCkiLCBjYW5UYWtlRm9yZWdyb3Vu ZEFzc2VydGlvbnMpOworICAgIHJldHVybiBjYW5UYWtlRm9yZWdyb3VuZEFzc2VydGlvbnM7CiB9 CiAKIHZvaWQgV2ViUGFnZVByb3h5Ojp0ZXh0SW5wdXRDb250ZXh0c0luUmVjdChGbG9hdFJlY3Qg cmVjdCwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZChjb25zdCBWZWN0b3I8RWxlbWVudENvbnRleHQ+ Jik+JiYgY29tcGxldGlvbkhhbmRsZXIpCg== 406857 2020-08-19 11:04:21 -0700 2020-08-19 11:33:52 -0700 Patch bug-215656-20200819110420.patch text/plain 7545 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJjMmUyNzA0OGUxYTliNzhm MzlhZDhiMDBjYjU1ZGZmZGI3YjY1NzYuLmMxODA5NjViZTQ4NTBjMjUwZGNkYWY5MGJiYTJkOTZi NDZlZTNhMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzcgQEAKKzIwMjAtMDgtMTkgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjYxNDA3KTog U2hhcmluZyByaWNoIGxpbmtzIGZyb20gVHdpdHRlci9OZXRmbGl4IHZpYSBNZXNzYWdlcyBpcyB1 bnJlbGlhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTU2NTYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY3MDg3MzUyPgorCisgICAgICAgIFJl dmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAgICAgVGhlIFdLV2ViVmlldy5fY2xpZW50TmF2 aWdhdGlvbnNSdW5BdEZvcmVncm91bmRQcmlvcml0eSBTUEkgd2FzIG5vdCB3b3JraW5nIGZvciB0 aGUKKyAgICAgICAgTWVzc2FnZXNWaWV3U2VydmljZSBiZWNhdXNlIHRoZSB2aWV3IGlzIHVucGFy ZW50ZWQgYW5kIFBhZ2VDbGllbnQ6OmlzQXBwbGljYXRpb25WaXNpYmxlKCkKKyAgICAgICAgd291 bGQgbm90IHdvcmsgcmV0dXJuIGFjY3VyYXRlIHJlc3VsdHMgd2hlbiBbdmlldyB3aW5kb3ddIHJl dHVybnMgbmlsLiBJdCBpcyB2ZXJ5CisgICAgICAgIHVuZm9ydHVuYXRlIHRvIGhhdmUgdG8gcmVs eSBvbiB0aGUgdmlldyBvciB0aGUgdmlldydzIHdpbmRvdyB0byBkZXRlcm1pbmUgYXBwbGljYXRp b24KKyAgICAgICAgdmlzaWJpbGl0eSBzbyB0aGlzIHBhdGNoIGZpeGVzIHRoaXMuIFdlIG5vdyBy ZWx5IG9uIFVJS2l0J3MgdmlzaWJpbGl0eSBlbmRvd21lbnQgdG8KKyAgICAgICAgZGV0ZXJtaW5l IGlmIHRoZSBVSVByb2Nlc3MgaXMgdmlzaWJsZSwgdXNpbmcgUnVubmluZ0JvYXJkIEFQSS4gSSBo YXZlIHZlcmlmaWVkIHRoYXQgdGhlCisgICAgICAgIHZpc2liaWxpdHkgZW5kb3dtZW50IHByb3Bl cmx5IGdldHMgcHJvcGFnYXRlZCBmcm9tIHRoZSBob3N0IGFwcGxpY2F0aW9uIHRvIHRoZSB2aWV3 CisgICAgICAgIHNlcnZpY2Ugd2hlbiB0aGUgYXBwbGljYXRpb24gaXMgYSB2aWV3IHNlcnZpY2Ug YW5kIEkgaGF2ZSB2ZXJpZmllZCB0aGF0IHRoaXMgZGV0ZWN0cworICAgICAgICB0aGUgTWVzc2Fn ZXNWaWV3U2VydmljZSBhcyB2aXNpYmxlIGZvciB0aGUgdXNlLWNhc2UgYXQgPHJkYXI6Ly9wcm9i bGVtLzY3MDg3MzUyPiwgd2hpY2gKKyAgICAgICAgY2F1c2VzIHRoZSBXS1dlYlZpZXcuX2NsaWVu dE5hdmlnYXRpb25zUnVuQXRGb3JlZ3JvdW5kUHJpb3JpdHkgU1BJIHRvIHdvcmsgYXMgaW50ZW5k ZWQuCisKKyAgICAgICAgTm90ZSB0aGF0IHdoZW4gdGhlIGFwcGxpY2F0aW9uIGRvZXMgbm90IGhh dmUgdGhlIHZpc2liaWxpdHkgZW5kb3dtZW50LCB3ZSBzdGlsbCBhbGxvdworICAgICAgICBpdCB0 byB0YWtlIGEgZm9yZWdyb3VuZCBhc3NlcnRpb24gZm9yIGNsaWVudCBuYXZpZ2F0aW9ucyBpZiB0 aGUgcHJvY2VzcyBpcyBhbGxvd2VkIHRvCisgICAgICAgIHJ1biBpbiB0aGUgYmFja2dyb3VuZCBm b3IgYW4gZXh0ZW5kZWQgcGVyaW9kIG9mIHRpbWUsIGFjY29yZGluZyB0byBSdW5uaW5nQm9hcmQu IFRoaXMKKyAgICAgICAgYWxsb3dzIHRoZSBTUEkgdG8gd29yayBmb3IgZGFlbW9ucyAobGlrZSBt YWlsZCkgd2hpY2ggcmVseSBvbiBpdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9QYWdlQ2xpZW50 Lmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHA6CisgICAgICAgIChXZWJL aXQ6OldlYlBhZ2VQcm94eTo6cnVuSmF2YVNjcmlwdEluRnJhbWVJblNjcmlwdFdvcmxkKToKKyAg ICAgICAgKiBVSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLmg6CisgICAgICAgICogVUlQ cm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbToKKyAgICAgICAgKFdlYktpdDo6UGFnZUNs aWVudEltcGw6OmNhblRha2VGb3JlZ3JvdW5kQXNzZXJ0aW9ucyk6CisgICAgICAgIChXZWJLaXQ6 OlBhZ2VDbGllbnRJbXBsOjppc0FwcGxpY2F0aW9uVmlzaWJsZSk6IERlbGV0ZWQuCisgICAgICAg ICogVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW06CisgICAgICAgIChXZWJLaXQ6Oldl YlBhZ2VQcm94eTo6c2hvdWxkRm9yY2VGb3JlZ3JvdW5kUHJpb3JpdHlGb3JDbGllbnROYXZpZ2F0 aW9uIGNvbnN0KToKKwogMjAyMC0wOC0xOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgV2ViU29ja2V0Q2hhbm5lbDo6ZGlkQ2xvc2Ugc2hvdWxkIGNvcnJlY3Rs eSBjb21wdXRlIHdoZXRoZXIgYSBjbG9zaW5nIGhhbmRzaGFrZSB3YXMgcmVjZWl2ZWQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaAppbmRleCA4YzZjNTczY2ZkNzM0OWQwYTExYWZiNGIz OGY5NjkxNzNhZDYwYmI0Li4wNjA1NmE0ZjI4MjdlNDg1ZjJkZmJlZmQzYzZhYWNmOTkxY2NmODIx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmgKKysrIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCkBAIC0yMDQsOCArMjA0LDcgQEAg cHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBpc1ZpZXdWaXNpYmxlKCkgPSAwOwogCiAjaWYgUExB VEZPUk0oSU9TX0ZBTUlMWSkKLSAgICAvLyBSZXR1cm4gd2hldGhlciB0aGUgYXBwbGljYXRpb24g aXMgdmlzaWJsZS4KLSAgICB2aXJ0dWFsIGJvb2wgaXNBcHBsaWNhdGlvblZpc2libGUoKSA9IDA7 CisgICAgdmlydHVhbCBib29sIGNhblRha2VGb3JlZ3JvdW5kQXNzZXJ0aW9ucygpID0gMDsKICNl bmRpZgogCiAgICAgLy8gUmV0dXJuIHdoZXRoZXIgdGhlIHZpZXcgaXMgdmlzaWJsZSwgb3Igb2Nj bHVkZWQgYnkgYW5vdGhlciB3aW5kb3cuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVBy b3h5LmNwcAppbmRleCAzYWJhNTM3ZWY0NmI2YTI1YWNjYmY5NjFlMWIwNTU5ZjYwYzJjZmMyLi4w OTA4ZGViMzBlM2VjZTI5MGQ5YTFjOTNkZTM3MjkzNjIwOTZiYTllIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTQwOTgsNyArNDA5OCw3IEBAIHZvaWQgV2Vi UGFnZVByb3h5OjpydW5KYXZhU2NyaXB0SW5GcmFtZUluU2NyaXB0V29ybGQoUnVuSmF2YVNjcmlw dFBhcmFtZXRlcnMmJiBwCiAKICAgICBQcm9jZXNzVGhyb3R0bGVyOjpBY3Rpdml0eVZhcmlhbnQg YWN0aXZpdHk7CiAjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKLSAgICBpZiAocGFnZUNsaWVudCgp LmlzQXBwbGljYXRpb25WaXNpYmxlKCkpCisgICAgaWYgKHBhZ2VDbGllbnQoKS5jYW5UYWtlRm9y ZWdyb3VuZEFzc2VydGlvbnMoKSkKICAgICAgICAgYWN0aXZpdHkgPSBtX3Byb2Nlc3MtPnRocm90 dGxlcigpLmZvcmVncm91bmRBY3Rpdml0eSgiV2ViUGFnZVByb3h5OjpydW5KYXZhU2NyaXB0SW5G cmFtZUluU2NyaXB0V29ybGQiX3MpOwogICAgIGVsc2UKICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLmggYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MuaAppbmRleCA1MDZhYjMwNzcyZTll OThlMTExYzg3YzhlN2RiZWYwMDA0NTBlM2EwLi4xMzI4YmVjM2IyYTFmMzBjYmZlMzkxZmU1NmM3 N2NkOWI1YjllYmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvUGFn ZUNsaWVudEltcGxJT1MuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvUGFnZUNs aWVudEltcGxJT1MuaApAQCAtNjQsNyArNjQsNyBAQCBwcml2YXRlOgogICAgIGJvb2wgaXNWaWV3 V2luZG93QWN0aXZlKCkgb3ZlcnJpZGU7CiAgICAgYm9vbCBpc1ZpZXdGb2N1c2VkKCkgb3ZlcnJp ZGU7CiAgICAgYm9vbCBpc1ZpZXdWaXNpYmxlKCkgb3ZlcnJpZGU7Ci0gICAgYm9vbCBpc0FwcGxp Y2F0aW9uVmlzaWJsZSgpIG92ZXJyaWRlOworICAgIGJvb2wgY2FuVGFrZUZvcmVncm91bmRBc3Nl cnRpb25zKCkgb3ZlcnJpZGU7CiAgICAgYm9vbCBpc1ZpZXdJbldpbmRvdygpIG92ZXJyaWRlOwog ICAgIGJvb2wgaXNWaWV3VmlzaWJsZU9yT2NjbHVkZWQoKSBvdmVycmlkZTsKICAgICBib29sIGlz VmlzdWFsbHlJZGxlKCkgb3ZlcnJpZGU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9p b3MvUGFnZUNsaWVudEltcGxJT1MubW0KaW5kZXggMGE1NTg0MDlkMDI4NjU2NjA0MjkxMTFmNTY0 ZTMyNjljOTI4ZDI3Ni4uZmY3YzBiZDJhNzkwMmQ2N2UxMDY2ZjEzNWRkMDljYjNmNzg2MWQ3YSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9T Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5t bQpAQCAtMTQ4LDI3ICsxNDgsMTggQEAgYm9vbCBQYWdlQ2xpZW50SW1wbDo6aXNWaWV3VmlzaWJs ZSgpCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi1ib29sIFBhZ2VDbGllbnRJbXBsOjppc0FwcGxp Y2F0aW9uVmlzaWJsZSgpCitib29sIFBhZ2VDbGllbnRJbXBsOjpjYW5UYWtlRm9yZWdyb3VuZEFz c2VydGlvbnMoKQogewotICAgIGlmIChhcHBsaWNhdGlvblR5cGUoW21fd2ViVmlldyB3aW5kb3dd KSA9PSBBcHBsaWNhdGlvblR5cGU6OkFwcGxpY2F0aW9uKSB7Ci0gICAgICAgIEFTU0VSVCghX1VJ QXBwbGljYXRpb25Jc0V4dGVuc2lvbigpKTsKLSAgICAgICAgcmV0dXJuIFtbVUlBcHBsaWNhdGlv biBzaGFyZWRBcHBsaWNhdGlvbl0gYXBwbGljYXRpb25TdGF0ZV0gIT0gVUlBcHBsaWNhdGlvblN0 YXRlQmFja2dyb3VuZDsKLSAgICB9Ci0KLSAgICAvLyBDb21wbGV4IGNvZGUgcGF0aCBmb3IgZXh0 ZW5zaW9ucyBhbmQgdmlldyBzZXJ2aWNlcy4KLSAgICBVSVZpZXdDb250cm9sbGVyICpzZXJ2aWNl Vmlld0NvbnRyb2xsZXIgPSBuaWw7Ci0gICAgZm9yIChVSVZpZXcgKnZpZXcgPSBtX3dlYlZpZXcu Z2V0KCkuZ2V0KCk7IHZpZXc7IHZpZXcgPSB2aWV3LnN1cGVydmlldykgewotICAgICAgICBVSVZp ZXdDb250cm9sbGVyICp2aWV3Q29udHJvbGxlciA9IFtVSVZpZXdDb250cm9sbGVyIHZpZXdDb250 cm9sbGVyRm9yVmlldzp2aWV3XTsKLSAgICAgICAgaWYgKHZpZXdDb250cm9sbGVyLl9ob3N0UHJv Y2Vzc0lkZW50aWZpZXIpIHsKLSAgICAgICAgICAgIHNlcnZpY2VWaWV3Q29udHJvbGxlciA9IHZp ZXdDb250cm9sbGVyOwotICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIH0KKyAgICBpZiAoRW5k b3dtZW50U3RhdGVUcmFja2VyOjpzaW5nbGV0b24oKS5pc1Zpc2libGUoKSkgeworICAgICAgICAv LyBJZiB0aGUgYXBwbGljYXRpb24gaXMgdmlzaWJsZSBhY2NvcmRpbmcgdG8gdGhlIFVJS2l0IHZp c2liaWxpdHkgZW5kb3dtZW50IHRoZW4gd2UgY2FuIHRha2UKKyAgICAgICAgLy8gZm9yZWdyb3Vu ZCBhc3NlcnRpb25zLiBOb3RlIHRoYXQgZm9yIHZpZXcgc2VydmljZXMsIHRoZSB2aXNpYmlsaXR5 IGVuZG93bm1lbnQgZnJvbSB0aGUgaG9zdAorICAgICAgICAvLyBhcHBsaWNhdGlvbiBnZXRzIHBy b3BhZ2F0ZWQgdG8gdGhlIHZpZXcgc2VydmljZS4KKyAgICAgICAgcmV0dXJuIHRydWU7CiAgICAg fQotICAgIEFTU0VSVChzZXJ2aWNlVmlld0NvbnRyb2xsZXIpOwotICAgIHBpZF90IGFwcGxpY2F0 aW9uUElEID0gc2VydmljZVZpZXdDb250cm9sbGVyLl9ob3N0UHJvY2Vzc0lkZW50aWZpZXI7Ci0g ICAgQVNTRVJUKGFwcGxpY2F0aW9uUElEKTsKIAotICAgIHJldHVybiBFbmRvd21lbnRTdGF0ZVRy YWNrZXI6OmlzQXBwbGljYXRpb25Gb3JlZ3JvdW5kKGFwcGxpY2F0aW9uUElEKTsKKyAgICAvLyBJ ZiB0aGVyZSBpcyBubyBydW4gdGltZSBsaW1pdGF0aW9uLCB0aGVuIGl0IG1lYW5zIHRoYXQgdGhl IHByb2Nlc3MgaXMgYWxsb3dlZCB0byBydW4gZm9yIGFuIGV4dGVuZGVkCisgICAgLy8gcGVyaW9k IG9mIHRpbWUgaW4gdGhlIGJhY2tncm91bmQgKGUuZy4gYSBkYWVtb24pIGFuZCB3ZSBsZXQgc3Vj aCBwcm9jZXNzZXMgdGFrZSBmb3JlZ3JvdW5kIGFzc2VydGlvbnMuCisgICAgcmV0dXJuIFtSQlNQ cm9jZXNzSGFuZGxlIGN1cnJlbnRQcm9jZXNzXS5hY3RpdmVMaW1pdGF0aW9ucy5ydW5UaW1lID09 IFJCU1Byb2Nlc3NUaW1lTGltaXRhdGlvbk5vbmU7CiB9CiAKIGJvb2wgUGFnZUNsaWVudEltcGw6 OmlzVmlld0luV2luZG93KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lv cy9XZWJQYWdlUHJveHlJT1MubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV2ViUGFn ZVByb3h5SU9TLm1tCmluZGV4IGMwNDNhMDQ3ZTY1MjQzNjBlNDU5ZWNjZGRlNGQyZTczOTJiYjRi ZDAuLjQ1YzBiZDQ5NTcwYTVlZTNiZTFiODkzZWNhZWFjYjgzNWRkOWIyNWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XZWJQYWdlUHJveHlJT1MubW0KKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dlYlBhZ2VQcm94eUlPUy5tbQpAQCAtMTU1MCw3ICsx NTUwLDkgQEAgYm9vbCBXZWJQYWdlUHJveHk6OnNob3VsZEZvcmNlRm9yZWdyb3VuZFByaW9yaXR5 Rm9yQ2xpZW50TmF2aWdhdGlvbigpIGNvbnN0CiAgICAgaWYgKGlzVmlld1Zpc2libGUoKSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgcmV0dXJuIHBhZ2VDbGllbnQoKS5pc0FwcGxpY2F0 aW9uVmlzaWJsZSgpOworICAgIGJvb2wgY2FuVGFrZUZvcmVncm91bmRBc3NlcnRpb25zID0gcGFn ZUNsaWVudCgpLmNhblRha2VGb3JlZ3JvdW5kQXNzZXJ0aW9ucygpOworICAgIFJFTEVBU0VfTE9H X0lGX0FMTE9XRUQoUHJvY2VzcywgIldlYlBhZ2VQcm94eTo6c2hvdWxkRm9yY2VGb3JlZ3JvdW5k UHJpb3JpdHlGb3JDbGllbnROYXZpZ2F0aW9uKCkgcmV0dXJucyAlZCBiYXNlZCBvbiBQYWdlQ2xp ZW50OjpjYW5UYWtlRm9yZWdyb3VuZEFzc2VydGlvbnMoKSIsIGNhblRha2VGb3JlZ3JvdW5kQXNz ZXJ0aW9ucyk7CisgICAgcmV0dXJuIGNhblRha2VGb3JlZ3JvdW5kQXNzZXJ0aW9uczsKIH0KIAog dm9pZCBXZWJQYWdlUHJveHk6OnRleHRJbnB1dENvbnRleHRzSW5SZWN0KEZsb2F0UmVjdCByZWN0 LCBDb21wbGV0aW9uSGFuZGxlcjx2b2lkKGNvbnN0IFZlY3RvcjxFbGVtZW50Q29udGV4dD4mKT4m JiBjb21wbGV0aW9uSGFuZGxlcikK