215654 2020-08-19 10:34:12 -0700 [webkitcorepy] Don't overwrite foreign packages by default 2020-08-19 11:07:23 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214378 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain darin dewei_zhu frankhome61 slewis webkit-bug-importer oldest_to_newest 1681398 0 jbedard 2020-08-19 10:34:12 -0700 At the moment, packages which originate from a package index other than the requested one are overwritten. While not strictly wrong, this is often undesirable for the WebKit project, where packages from different indexes my share an install location. 1681399 1 webkit-bug-importer 2020-08-19 10:34:28 -0700 <rdar://problem/67411393> 1681402 2 406853 jbedard 2020-08-19 10:39:03 -0700 Created attachment 406853 Patch 1681403 3 jbedard 2020-08-19 10:41:53 -0700 Very willing to change the terminology here, "forgein" just felt like the right term for "something on disk that originates from a package index other than the index the program specified" 1681413 4 ews-feeder 2020-08-19 11:07:22 -0700 Committed r265880: <https://trac.webkit.org/changeset/265880> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406853. 406853 2020-08-19 10:39:03 -0700 2020-08-19 11:07:23 -0700 Patch bug-215654-20200819103902.patch text/plain 2664 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NTg3OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIwLTA4LTE5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0Y29yZXB5XSBEb24ndCBvdmVyd3JpdGUgZm9yZWlnbiBwYWNr YWdlcyBieSBkZWZhdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTU2NTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY3NDExMzkzPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9saWJy YXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS9fX2luaXRfXy5weTogQnVtcCB2ZXJzaW9u LgorICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkv YXV0b2luc3RhbGwucHk6CisgICAgICAgIChQYWNrYWdlLmlzX2NhY2hlZCk6IENvbnNpZGVyIGEg cGFja2FnZSBjYWNoZWQgaWYgaXQgaXMgZm9yZWlnbiBhbmQgb3ZlcndyaXRlX2ZvcmVpZ25fcGFj a2FnZXMgaXMgZmFsc2UuCisgICAgICAgIChBdXRvSW5zdGFsbCk6IEFkZCBvdmVyd3JpdGVfZm9y ZWlnbl9wYWNrYWdlcyBmbGFnLgorCiAyMDIwLTA4LTE5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVk YXJkQGFwcGxlLmNvbT4KIAogICAgICAgICBbd2Via2l0Y29yZXB5XSBDb3JyZWN0IGF1dG9pbnN0 YWxsZXIgbG9nZ2luZwpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5 L3dlYmtpdGNvcmVweS9fX2luaXRfXy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xp YnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L19faW5pdF9fLnB5CShyZXZpc2lvbiAy NjU4NzkpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29y ZXB5L19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMyw3ICszMyw3IEBAIGZyb20gd2Vi a2l0Y29yZXB5LnZlcnNpb24gaW1wb3J0IFZlcnNpb24KIGZyb20gd2Via2l0Y29yZXB5LnN0cmlu Z191dGlscyBpbXBvcnQgQnl0ZXNJTywgU3RyaW5nSU8sIFVuaWNvZGVJTywgdW5pY29kZQogZnJv bSB3ZWJraXRjb3JlcHkub3V0cHV0X2NhcHR1cmUgaW1wb3J0IExvZ2dlckNhcHR1cmUsIE91dHB1 dENhcHR1cmUsIE91dHB1dER1cGxpY2F0ZQogCi12ZXJzaW9uID0gVmVyc2lvbigwLCAyLCA3KQor dmVyc2lvbiA9IFZlcnNpb24oMCwgMiwgOCkKIAogZnJvbSB3ZWJraXRjb3JlcHkuYXV0b2luc3Rh bGwgaW1wb3J0IFBhY2thZ2UsIEF1dG9JbnN0YWxsCiBpZiBzeXMudmVyc2lvbl9pbmZvID4gKDMs IDApOgpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNv cmVweS9hdXRvaW5zdGFsbC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJhcmll cy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L2F1dG9pbnN0YWxsLnB5CShyZXZpc2lvbiAyNjU4 NzkpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5 L2F1dG9pbnN0YWxsLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xOTEsNyArMTkxLDcgQEAgY2xhc3Mg UGFja2FnZShvYmplY3QpOgogICAgICAgICBtYW5pZmVzdCA9IEF1dG9JbnN0YWxsLm1hbmlmZXN0 LmdldChzZWxmLm5hbWUpCiAgICAgICAgIGlmIG5vdCBtYW5pZmVzdDoKICAgICAgICAgICAgIHJl dHVybiBGYWxzZQotICAgICAgICBpZiBtYW5pZmVzdC5nZXQoJ2luZGV4JykgIT0gQXV0b0luc3Rh bGwuaW5kZXg6CisgICAgICAgIGlmIEF1dG9JbnN0YWxsLm92ZXJ3cml0ZV9mb3JlaWduX3BhY2th Z2VzIGFuZCBtYW5pZmVzdC5nZXQoJ2luZGV4JykgIT0gQXV0b0luc3RhbGwuaW5kZXg6CiAgICAg ICAgICAgICByZXR1cm4gRmFsc2UKICAgICAgICAgaWYgbm90IG1hbmlmZXN0LmdldCgndmVyc2lv bicpOgogICAgICAgICAgICAgcmV0dXJuIEZhbHNlCkBAIC0zMDUsNiArMzA1LDEwIEBAIGNsYXNz IEF1dG9JbnN0YWxsKG9iamVjdCk6CiAgICAgcGFja2FnZXMgPSB7fQogICAgIG1hbmlmZXN0ID0g e30KIAorICAgICMgV2hlbiBzaGFyaW5nIGFuIGluc3RhbGwgbG9jYXRpb24sIHByb2plY3RzIG1h eSB3aXNoIHRvIG92ZXJ3cml0ZSBwYWNrYWdlcyBvbiBkaXNrCisgICAgIyBvcmlnaW5hdGluZyBm cm9tIGEgZGlmZmVyZW50IGluZGV4LgorICAgIG92ZXJ3cml0ZV9mb3JlaWduX3BhY2thZ2VzID0g RmFsc2UKKwogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBfcmVxdWVzdChjbHMsIHVybCk6CiAg ICAgICAgICMgUmVseSBvbiBvdXIgb3duIGNlcnRpZmljYXRlcyBmb3IgUHlQaSwgc2luY2Ugd2Ug dXNlIFB5UGkgdG8gc3RhbmRhcmRpemUgcm9vdCBjZXJ0aWZpY2F0ZXMK