215644 2020-08-19 05:15:24 -0700 WebSocketChannel::didClose should correctly compute whether a closing handshake was received 2020-08-19 20:39:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215679 InRadar P2 Normal --- 1 youennf youennf darin webkit-bug-importer oldest_to_newest 1681319 0 youennf 2020-08-19 05:15:24 -0700 WebSocketChannel::didClose should correctly compute whether a closing handshake was received 1681320 1 406840 youennf 2020-08-19 05:19:22 -0700 Created attachment 406840 Patch 1681337 2 406840 darin 2020-08-19 08:25:04 -0700 Comment on attachment 406840 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review > Source/WebKit/ChangeLog:8 > + Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled. Where is that code path enabled? Why aren’t we seeing the failure in any bot? 1681338 3 406840 youennf 2020-08-19 08:31:19 -0700 Comment on attachment 406840 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406840&action=review >> Source/WebKit/ChangeLog:8 >> + Covered by LayoutTests/http/tests/websocket/tests/hybi/close-code-and-reason.html with NSURLSession code path enabled. > > Where is that code path enabled? Why aren’t we seeing the failure in any bot? This code path is off by default on all bots. It can be enabled in Safari as an experimental feature. We are working on reducing the test results between the two code paths before enabling this code path. 1681347 4 ews-feeder 2020-08-19 08:39:10 -0700 Committed r265856: <https://trac.webkit.org/changeset/265856> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406840. 1681349 5 webkit-bug-importer 2020-08-19 08:40:21 -0700 <rdar://problem/67405340> 406840 2020-08-19 05:19:22 -0700 2020-08-19 08:39:10 -0700 Patch bug-215644-20200819141920.patch text/plain 2398 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc0OTZmMDg1ZjYzZDViZjQx N2QwNzY2Y2EzN2RiMzA3YzZhZTgxODcuLmQzN2M3ZGZjZDIyMTMyN2IzZjRiNTRlODA0MDAxNDUx YzRkM2Q0ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDgtMTkgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYlNvY2tldENoYW5uZWw6OmRp ZENsb3NlIHNob3VsZCBjb3JyZWN0bHkgY29tcHV0ZSB3aGV0aGVyIGEgY2xvc2luZyBoYW5kc2hh a2Ugd2FzIHJlY2VpdmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMTU2NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDb3ZlcmVkIGJ5IExheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3Rz L2h5YmkvY2xvc2UtY29kZS1hbmQtcmVhc29uLmh0bWwgd2l0aCBOU1VSTFNlc3Npb24gY29kZSBw YXRoIGVuYWJsZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL05ldHdvcmsvV2ViU29ja2V0Q2hh bm5lbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlNvY2tldENoYW5uZWw6OmRpZENsb3NlKToK KyAgICAgICAgQXMgbm90ZWQgYnkgSml0ZW4gTWVodGEsIGFic2VuY2Ugb2YgY2xvc2luZyBoYW5k c2hha2UgZnJvbSB0aGUgc2VydmVyIGlzIG5vdGlmaWVkIGJ5IFdlYlNvY2tldENoYW5uZWw6OkNs b3NlRXZlbnRDb2RlQWJub3JtYWxDbG9zdXJlLgorICAgICAgICBVcGRhdGUgY2hlY2sgYWNjb3Jk aW5nbHkuCisKIDIwMjAtMDgtMTggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Vi a2l0Lm9yZz4KIAogICAgICAgICBXS1dlYlZpZXdzIHVzaW5nIGZhc3RTZXJ2ZXJUcnVzdEV2YWx1 YXRpb25FbmFibGVkIHNob3VsZCBvbmx5IGFsbG93IGxlZ2FjeSBUTFMgZm9yIG1haW4gcmVzb3Vy Y2UgbG9hZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL1dl YlNvY2tldENoYW5uZWwuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2Vi U29ja2V0Q2hhbm5lbC5jcHAKaW5kZXggN2Q5ZjAyMmVkZDkyMGY0MzkxZjUxOWNjZmEyYjg5ODVl YmM5YTllYi4uYTkxMTU0OWIwMWE0ZTQ3MGQ2YWRjOGFkMTNiNjVhY2RhYmNjNzE1ZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2ViU29ja2V0Q2hhbm5lbC5j cHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvV2ViU29ja2V0Q2hhbm5l bC5jcHAKQEAgLTMyMiwxMCArMzIyLDExIEBAIHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlkQ2xv c2UodW5zaWduZWQgc2hvcnQgY29kZSwgU3RyaW5nJiYgcmVhc29uKQogCiAgICAgbV9pbnNwZWN0 b3IuZGlkQ2xvc2VXZWJTb2NrZXQobV9kb2N1bWVudC5nZXQoKSk7CiAKLSAgICBpZiAoY29kZSA9 PSBXZWJDb3JlOjpXZWJTb2NrZXRDaGFubmVsOjpDbG9zZUV2ZW50Q29kZU5vcm1hbENsb3N1cmUp CisgICAgYm9vbCByZWNlaXZlZENsb3NpbmdIYW5kc2hha2UgPSBjb2RlICE9IFdlYkNvcmU6Oldl YlNvY2tldENoYW5uZWw6OkNsb3NlRXZlbnRDb2RlQWJub3JtYWxDbG9zdXJlOworICAgIGlmIChy ZWNlaXZlZENsb3NpbmdIYW5kc2hha2UpCiAgICAgICAgIG1fY2xpZW50LT5kaWRTdGFydENsb3Np bmdIYW5kc2hha2UoKTsKIAotICAgIG1fY2xpZW50LT5kaWRDbG9zZShtX2J1ZmZlcmVkQW1vdW50 LCAobV9pc0Nsb3NpbmcgfHwgY29kZSA9PSBXZWJDb3JlOjpXZWJTb2NrZXRDaGFubmVsOjpDbG9z ZUV2ZW50Q29kZU5vcm1hbENsb3N1cmUpID8gV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbENsaWVu dDo6Q2xvc2luZ0hhbmRzaGFrZUNvbXBsZXRlIDogV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbENs aWVudDo6Q2xvc2luZ0hhbmRzaGFrZUluY29tcGxldGUsIGNvZGUsIHJlYXNvbik7CisgICAgbV9j bGllbnQtPmRpZENsb3NlKG1fYnVmZmVyZWRBbW91bnQsIChtX2lzQ2xvc2luZyB8fCByZWNlaXZl ZENsb3NpbmdIYW5kc2hha2UpID8gV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbENsaWVudDo6Q2xv c2luZ0hhbmRzaGFrZUNvbXBsZXRlIDogV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbENsaWVudDo6 Q2xvc2luZ0hhbmRzaGFrZUluY29tcGxldGUsIGNvZGUsIHJlYXNvbik7CiB9CiAKIHZvaWQgV2Vi U29ja2V0Q2hhbm5lbDo6ZGlkUmVjZWl2ZU1lc3NhZ2VFcnJvcihTdHJpbmcmJiBlcnJvck1lc3Nh Z2UpCg==