215617 2020-08-18 11:47:26 -0700 Make some small improvements involving sorting 2020-08-22 09:14:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=214883 InRadar P2 Normal --- 1 darin darin andersca esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard webkit-bug-importer oldest_to_newest 1681136 0 darin 2020-08-18 11:47:26 -0700 Make some small improvements involving sorting 1681138 1 406797 darin 2020-08-18 11:51:20 -0700 Created attachment 406797 Patch 1681156 2 406797 darin 2020-08-18 13:02:35 -0700 Comment on attachment 406797 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406797&action=review > Source/WebCore/page/PerformanceObserver.cpp:94 > + if (oldEnd != end) { Just realized I don’t think this if statement is needed. I think both algorithms below are super-efficient when the ranges are empty. 1682129 3 darin 2020-08-22 09:13:17 -0700 Committed r266027: <https://trac.webkit.org/changeset/266027> 1682131 4 webkit-bug-importer 2020-08-22 09:14:13 -0700 <rdar://problem/67617539> 406797 2020-08-18 11:51:20 -0700 2020-08-18 16:12:01 -0700 Patch bug-215617-20200818115119.patch text/plain 6944 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1ODI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThkNTU3MzE1ZDdkYmEw NDA3NDM2MDEzNDliYTU2NzVhYjY2NzI4NS4uMTljYzFmMjJlMWJiZTk2NTIwMzIyNWRkNDI1MjJj ZjkwYTgzMTk1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIwLTA4LTE4ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBNYWtlIHNvbWUgc21hbGwgaW1w cm92ZW1lbnRzIGludm9sdmluZyBzb3J0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU2MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGNvbnRlbnRleHRlbnNpb25zL0RGQS5jcHA6CisgICAgICAg IChXZWJDb3JlOjpDb250ZW50RXh0ZW5zaW9uczo6cHJpbnRUcmFuc2l0aW9ucyk6IEZpeGVkICJp bmNvbW1pbmciIHNwZWxsaW5nIGVycm9yLgorCisgICAgICAgICogY3NzL0NTU0ltYWdlU2V0VmFs dWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTSW1hZ2VTZXRWYWx1ZTo6ZmlsbEltYWdlU2V0 KTogVXNlIHN0ZDo6c3RhYmxlX3NvcnQgaW5zdGVhZCBvZiBzdGQ6OnNvcnQKKyAgICAgICAgYmVj YXVzZSB0aGVyZSBpcyBubyBndWFyYW50ZWUgdGhhdCBlYWNoIGltYWdlIGhhcyBkaWZmZXJlbnQg cmVzb2x1dGlvbiBhbmQgd2Ugd2FudAorICAgICAgICByZXBlYXRhYmxlIGJlaGF2aW9yIHdoZW4g dGhleSBhcmUgdGhlIHNhbWUuCisKKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBlcmZvcm1hbmNlOjphcHBlbmRCdWZmZXJlZEVudHJpZXNCeVR5cGUg Y29uc3QpOiBSZW1vdmVkIHRoZSByZXR1cm4KKyAgICAgICAgdmFsdWUgc2luY2Ugd2UgZG9uJ3Qg bmVlZCBpdCBhbnkgbW9yZS4KKyAgICAgICAgKiBwYWdlL1BlcmZvcm1hbmNlLmg6IFVwZGF0ZWQg Zm9yIGFib3ZlLgorCisgICAgICAgICogcGFnZS9QZXJmb3JtYW5jZU9ic2VydmVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlBlcmZvcm1hbmNlT2JzZXJ2ZXI6Om9ic2VydmUpOiBVc2Ugc3RkOjpz dGFibGVfc29ydCBvbmx5IG9uIHRoZSBuZXcKKyAgICAgICAgZW50cmllcyBhbmQgdGhlbiB1c2Ug c3RkOjppbnBsYWNlX21lcmdlLiBJdCdzIHdhc3RlZnVsIHRvIHJlLXNvcnQgdGhlIGVudGlyZQor ICAgICAgICBhcnJheSB3aGVuIGFkZGluZyBlbnRyaWVzLiBBIGxpdHRsZSBsZXNzIGVsZWdhbnQs IGJ1dCBtb3JlIGVmZmljaWVudC4KKwogMjAyMC0wOC0xOCAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBUdXJuIG9mZiB3aGVlbCBldmVudCByZWdpb25z IHVudGlsIHdlIG5lZWQgdGhlbQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY29udGVudGV4 dGVuc2lvbnMvREZBLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2NvbnRlbnRleHRlbnNpb25zL0RGQS5j cHAKaW5kZXggMDQ3NWZhYWMyZTI0YzIwNjg1MzRjMjkzODFkZjRhNTE2MWQ1YWI2MS4uNDVlNWFm MDVmNTYwYjI0NDhhOTUyZmJlYzVhNTkwZjAxMTA5YTE4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvY29udGVudGV4dGVuc2lvbnMvREZBLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jb250 ZW50ZXh0ZW5zaW9ucy9ERkEuY3BwCkBAIC0xMTMsMTQgKzExMywxNCBAQCBzdGF0aWMgdm9pZCBw cmludFRyYW5zaXRpb25zKGNvbnN0IERGQSYgZGZhLCB1bnNpZ25lZCBzb3VyY2VOb2RlSWQpCiAg ICAgZm9yIChjb25zdCBhdXRvJiB0cmFuc2l0aW9uUGVyVGFyZ2V0IDogdHJhbnNpdGlvbnNQZXJU YXJnZXQpIHsKICAgICAgICAgZGF0YUxvZ0YoIiAgICAgICAgJWQgLT4gJWQgW2xhYmVsPVwiIiwg c291cmNlTm9kZUlkLCB0cmFuc2l0aW9uUGVyVGFyZ2V0LmtleSk7CiAKLSAgICAgICAgVmVjdG9y PHVpbnQxNl90PiBpbmNvbW1pbmdDaGFyYWN0ZXJzID0gdHJhbnNpdGlvblBlclRhcmdldC52YWx1 ZTsKLSAgICAgICAgc3RkOjpzb3J0KGluY29tbWluZ0NoYXJhY3RlcnMuYmVnaW4oKSwgaW5jb21t aW5nQ2hhcmFjdGVycy5lbmQoKSk7CisgICAgICAgIFZlY3Rvcjx1aW50MTZfdD4gaW5jb21pbmdD aGFyYWN0ZXJzID0gdHJhbnNpdGlvblBlclRhcmdldC52YWx1ZTsKKyAgICAgICAgc3RkOjpzb3J0 KGluY29taW5nQ2hhcmFjdGVycy5iZWdpbigpLCBpbmNvbWluZ0NoYXJhY3RlcnMuZW5kKCkpOwog Ci0gICAgICAgIGNoYXIgcmFuZ2VTdGFydCA9IGluY29tbWluZ0NoYXJhY3RlcnMuZmlyc3QoKTsK KyAgICAgICAgY2hhciByYW5nZVN0YXJ0ID0gaW5jb21pbmdDaGFyYWN0ZXJzLmZpcnN0KCk7CiAg ICAgICAgIGNoYXIgcmFuZ2VFbmQgPSByYW5nZVN0YXJ0OwogICAgICAgICBib29sIGZpcnN0ID0g dHJ1ZTsKLSAgICAgICAgZm9yICh1bnNpZ25lZCBzb3J0ZWRUcmFuc2l0aW9uSW5kZXggPSAxOyBz b3J0ZWRUcmFuc2l0aW9uSW5kZXggPCBpbmNvbW1pbmdDaGFyYWN0ZXJzLnNpemUoKTsgKytzb3J0 ZWRUcmFuc2l0aW9uSW5kZXgpIHsKLSAgICAgICAgICAgIGNoYXIgbmV4dENoYXIgPSBpbmNvbW1p bmdDaGFyYWN0ZXJzW3NvcnRlZFRyYW5zaXRpb25JbmRleF07CisgICAgICAgIGZvciAodW5zaWdu ZWQgc29ydGVkVHJhbnNpdGlvbkluZGV4ID0gMTsgc29ydGVkVHJhbnNpdGlvbkluZGV4IDwgaW5j b21pbmdDaGFyYWN0ZXJzLnNpemUoKTsgKytzb3J0ZWRUcmFuc2l0aW9uSW5kZXgpIHsKKyAgICAg ICAgICAgIGNoYXIgbmV4dENoYXIgPSBpbmNvbWluZ0NoYXJhY3RlcnNbc29ydGVkVHJhbnNpdGlv bkluZGV4XTsKICAgICAgICAgICAgIGlmIChuZXh0Q2hhciA9PSByYW5nZUVuZCsxKSB7CiAgICAg ICAgICAgICAgICAgcmFuZ2VFbmQgPSBuZXh0Q2hhcjsKICAgICAgICAgICAgICAgICBjb250aW51 ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NJbWFnZVNldFZhbHVlLmNwcCBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NJbWFnZVNldFZhbHVlLmNwcAppbmRleCA2YWZiY2YzMTA5 YzE4M2E1MTNlMDBkNTk1NTliZjFkMTI0OGYzNWU4Li4yZjdiMmI1OWQ5YzQ0ODljMjM1ZDRjNjVm YTRhYmQzNmY5NGEzNGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTSW1hZ2VT ZXRWYWx1ZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU0ltYWdlU2V0VmFsdWUuY3Bw CkBAIC02Myw3ICs2Myw3IEBAIHZvaWQgQ1NTSW1hZ2VTZXRWYWx1ZTo6ZmlsbEltYWdlU2V0KCkK ICAgICB9CiAKICAgICAvLyBTb3J0IHRoZSBpbWFnZXMgc28gdGhhdCB0aGV5IGFyZSBzdG9yZWQg aW4gb3JkZXIgZnJvbSBsb3dlc3QgcmVzb2x1dGlvbiB0byBoaWdoZXN0LgotICAgIHN0ZDo6c29y dChtX2ltYWdlc0luU2V0LmJlZ2luKCksIG1faW1hZ2VzSW5TZXQuZW5kKCksIENTU0ltYWdlU2V0 VmFsdWU6OmNvbXBhcmVCeVNjYWxlRmFjdG9yKTsKKyAgICBzdGQ6OnN0YWJsZV9zb3J0KG1faW1h Z2VzSW5TZXQuYmVnaW4oKSwgbV9pbWFnZXNJblNldC5lbmQoKSwgQ1NTSW1hZ2VTZXRWYWx1ZTo6 Y29tcGFyZUJ5U2NhbGVGYWN0b3IpOwogfQogCiBJbWFnZVdpdGhTY2FsZSBDU1NJbWFnZVNldFZh bHVlOjpiZXN0SW1hZ2VGb3JTY2FsZUZhY3RvcigpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1BlcmZvcm1hbmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2Uu Y3BwCmluZGV4IGM3NTc3OGIxZTE1YTE3OTdhMDQ4NmFhOWY1NDAyMjI3NWQ3M2JhOWYuLmJkMjY1 NjgzMzEwY2UxZTgyOGI5ZGNlNmZkYWVlM2FmNjc0MDYwYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVy Zm9ybWFuY2UuY3BwCkBAIC0xODIsOSArMTgyLDggQEAgVmVjdG9yPFJlZlB0cjxQZXJmb3JtYW5j ZUVudHJ5Pj4gUGVyZm9ybWFuY2U6OmdldEVudHJpZXNCeU5hbWUoY29uc3QgU3RyaW5nJiBuYW0K ICAgICByZXR1cm4gZW50cmllczsKIH0KIAotYm9vbCBQZXJmb3JtYW5jZTo6YXBwZW5kQnVmZmVy ZWRFbnRyaWVzQnlUeXBlKGNvbnN0IFN0cmluZyYgZW50cnlUeXBlLCBWZWN0b3I8UmVmUHRyPFBl cmZvcm1hbmNlRW50cnk+PiYgZW50cmllcykgY29uc3QKK3ZvaWQgUGVyZm9ybWFuY2U6OmFwcGVu ZEJ1ZmZlcmVkRW50cmllc0J5VHlwZShjb25zdCBTdHJpbmcmIGVudHJ5VHlwZSwgVmVjdG9yPFJl ZlB0cjxQZXJmb3JtYW5jZUVudHJ5Pj4mIGVudHJpZXMpIGNvbnN0CiB7Ci0gICAgYXV0byBvbGRF bnRyaWVzU2l6ZSA9IGVudHJpZXMuc2l6ZSgpOwogICAgIGlmIChlbnRyeVR5cGUgPT0gInJlc291 cmNlIikKICAgICAgICAgZW50cmllcy5hcHBlbmRWZWN0b3IobV9yZXNvdXJjZVRpbWluZ0J1ZmZl cik7CiAKQEAgLTE5NCw4ICsxOTMsNiBAQCBib29sIFBlcmZvcm1hbmNlOjphcHBlbmRCdWZmZXJl ZEVudHJpZXNCeVR5cGUoY29uc3QgU3RyaW5nJiBlbnRyeVR5cGUsIFZlY3RvcjxSZQogICAgICAg ICBpZiAoZW50cnlUeXBlLmlzTnVsbCgpIHx8IGVudHJ5VHlwZSA9PSAibWVhc3VyZSIpCiAgICAg ICAgICAgICBlbnRyaWVzLmFwcGVuZFZlY3RvcihtX3VzZXJUaW1pbmctPmdldE1lYXN1cmVzKCkp OwogICAgIH0KLQotICAgIHJldHVybiBlbnRyaWVzLnNpemUoKSA+IG9sZEVudHJpZXNTaXplOwog fQogCiB2b2lkIFBlcmZvcm1hbmNlOjpjbGVhclJlc291cmNlVGltaW5ncygpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L1BlcmZvcm1hbmNlLmgKaW5kZXggYjdiZTBhY2Q1OWM1ZjMzMjA5YmFiZWZkMTM0NjQ4Y2VhNWE3 YWJjMy4uZTM5YjczMDVjYjQ3OTAwOTA2YjU4Y2IxZGFlMDY2MDQ2ZmYwNDUyYSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvUGVyZm9ybWFuY2UuaApAQCAtNjgsNyArNjgsNyBAQCBwdWJsaWM6CiAgICAgVmVjdG9y PFJlZlB0cjxQZXJmb3JtYW5jZUVudHJ5Pj4gZ2V0RW50cmllcygpIGNvbnN0OwogICAgIFZlY3Rv cjxSZWZQdHI8UGVyZm9ybWFuY2VFbnRyeT4+IGdldEVudHJpZXNCeVR5cGUoY29uc3QgU3RyaW5n JiBlbnRyeVR5cGUpIGNvbnN0OwogICAgIFZlY3RvcjxSZWZQdHI8UGVyZm9ybWFuY2VFbnRyeT4+ IGdldEVudHJpZXNCeU5hbWUoY29uc3QgU3RyaW5nJiBuYW1lLCBjb25zdCBTdHJpbmcmIGVudHJ5 VHlwZSkgY29uc3Q7Ci0gICAgYm9vbCBhcHBlbmRCdWZmZXJlZEVudHJpZXNCeVR5cGUoY29uc3Qg U3RyaW5nJiBlbnRyeVR5cGUsIFZlY3RvcjxSZWZQdHI8UGVyZm9ybWFuY2VFbnRyeT4+JikgY29u c3Q7CisgICAgdm9pZCBhcHBlbmRCdWZmZXJlZEVudHJpZXNCeVR5cGUoY29uc3QgU3RyaW5nJiBl bnRyeVR5cGUsIFZlY3RvcjxSZWZQdHI8UGVyZm9ybWFuY2VFbnRyeT4+JikgY29uc3Q7CiAKICAg ICB2b2lkIGNsZWFyUmVzb3VyY2VUaW1pbmdzKCk7CiAgICAgdm9pZCBzZXRSZXNvdXJjZVRpbWlu Z0J1ZmZlclNpemUodW5zaWduZWQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9Q ZXJmb3JtYW5jZU9ic2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGVyZm9ybWFuY2VP YnNlcnZlci5jcHAKaW5kZXggYzZmOWExYmNlODU1MTZlNDA1ZTQxY2E5NjllNmUwMzUwZDRmZTdj OC4uMDJmZGE1NTIxZGRjNTY2MDI3Y2RjZWFiMThjNzdiMTAyZjdmNjRlNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGFnZS9QZXJmb3JtYW5jZU9ic2VydmVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1BlcmZvcm1hbmNlT2JzZXJ2ZXIuY3BwCkBAIC04Niw4ICs4NiwxNSBAQCBF eGNlcHRpb25Pcjx2b2lkPiBQZXJmb3JtYW5jZU9ic2VydmVyOjpvYnNlcnZlKEluaXQmJiBpbml0 KQogICAgICAgICAgICAgcmV0dXJuIHsgfTsKICAgICAgICAgaWYgKGluaXQuYnVmZmVyZWQpIHsK ICAgICAgICAgICAgIGlzQnVmZmVyZWQgPSB0cnVlOwotICAgICAgICAgICAgaWYgKG1fcGVyZm9y bWFuY2UtPmFwcGVuZEJ1ZmZlcmVkRW50cmllc0J5VHlwZSgqaW5pdC50eXBlLCBtX2VudHJpZXNU b0RlbGl2ZXIpKQotICAgICAgICAgICAgICAgIHN0ZDo6c3RhYmxlX3NvcnQobV9lbnRyaWVzVG9E ZWxpdmVyLmJlZ2luKCksIG1fZW50cmllc1RvRGVsaXZlci5lbmQoKSwgUGVyZm9ybWFuY2VFbnRy eTo6c3RhcnRUaW1lQ29tcGFyZUxlc3NUaGFuKTsKKyAgICAgICAgICAgIGF1dG8gb2xkU2l6ZSA9 IG1fZW50cmllc1RvRGVsaXZlci5zaXplKCk7CisgICAgICAgICAgICBtX3BlcmZvcm1hbmNlLT5h cHBlbmRCdWZmZXJlZEVudHJpZXNCeVR5cGUoKmluaXQudHlwZSwgbV9lbnRyaWVzVG9EZWxpdmVy KTsKKyAgICAgICAgICAgIGF1dG8gYmVnaW4gPSBtX2VudHJpZXNUb0RlbGl2ZXIuYmVnaW4oKTsK KyAgICAgICAgICAgIGF1dG8gb2xkRW5kID0gYmVnaW4gKyBvbGRTaXplOworICAgICAgICAgICAg YXV0byBlbmQgPSBtX2VudHJpZXNUb0RlbGl2ZXIuZW5kKCk7CisgICAgICAgICAgICBpZiAob2xk RW5kICE9IGVuZCkgeworICAgICAgICAgICAgICAgIHN0ZDo6c3RhYmxlX3NvcnQob2xkRW5kLCBl bmQsIFBlcmZvcm1hbmNlRW50cnk6OnN0YXJ0VGltZUNvbXBhcmVMZXNzVGhhbik7CisgICAgICAg ICAgICAgICAgc3RkOjppbnBsYWNlX21lcmdlKGJlZ2luLCBvbGRFbmQsIGVuZCwgUGVyZm9ybWFu Y2VFbnRyeTo6c3RhcnRUaW1lQ29tcGFyZUxlc3NUaGFuKTsKKyAgICAgICAgICAgIH0KICAgICAg ICAgfQogICAgICAgICBtX3R5cGVGaWx0ZXIuYWRkKGZpbHRlcik7CiAgICAgfQo=