215596 2020-08-17 17:02:34 -0700 [Mac] Unhandled keyDown: events cause a system beep in full screen mode 2020-08-18 09:01:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble darin eric.carlson peng.liu6 webkit-bug-importer oldest_to_newest 1680976 0 jer.noble 2020-08-17 17:02:34 -0700 [Mac] Unhandled keyDown: events cause a system beep in full screen mode 1680977 1 jer.noble 2020-08-17 17:04:29 -0700 <rdar://problem/65823962> 1680978 2 406754 jer.noble 2020-08-17 17:05:19 -0700 Created attachment 406754 Patch 1680985 3 406754 darin 2020-08-17 17:30:38 -0700 Comment on attachment 406754 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406754&action=review > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:229 > + UNUSED_PARAM(eventMethod); Comment would be welcome. 1681069 4 jer.noble 2020-08-18 08:33:03 -0700 (In reply to Darin Adler from comment #3) > Comment on attachment 406754 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406754&action=review > > > Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:229 > > + UNUSED_PARAM(eventMethod); > > Comment would be welcome. Sure thing. I wavered on whether to add a "why" comment here. 1681075 5 406787 jer.noble 2020-08-18 08:38:36 -0700 Created attachment 406787 Patch for landing 1681083 6 ews-feeder 2020-08-18 09:01:45 -0700 Committed r265816: <https://trac.webkit.org/changeset/265816> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406787. 406754 2020-08-17 17:05:19 -0700 2020-08-18 08:38:35 -0700 Patch bug-215596-20200817170518.patch text/plain 1371 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGIzNzliYzBiODE3MDYyYzEz NmY3NTQzYWI4NmMxOWZiODFjMzFjMjcuLmFhZTkwZGFkNTVlZWM1YzE1NjU0NjI1ZWE3MTA3ZDAx MzhhNjI2OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDgtMTcgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gVW5oYW5kbGVkIGtleURv d246IGV2ZW50cyBjYXVzZSBhIHN5c3RlbSBiZWVwIGluIGZ1bGwgc2NyZWVuIG1vZGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTU5NgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNjU4MjM5NjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0Nv bnRyb2xsZXIubW06CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgbm9S ZXNwb25kZXJGb3I6XSk6CisKIDIwMjAtMDctMzEgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBs ZS5jb20+CiAKICAgICAgICAgW01hY10gQWRkIEV4cGVyaW1lbnRhbCBGZWF0dXJlIHByZWZlcmVu Y2UgZm9yIFNXIFZQOQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dL RnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9t YWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQppbmRleCA1NmFlZjNmZWU1ZGZjNTE2 MDYwZTFkY2JiNmJlYjA4ZmYzNTQ1NGJhLi43MjU1OTczZjljMGI0Y2IzZTI4ZTc3NmU4NDFjNzU1 ZDYzNzg3YTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tGdWxs U2NyZWVuV2luZG93Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9t YWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQpAQCAtMjIxLDYgKzIyMSwxNCBAQCAt ICh2b2lkKWNhbmNlbE9wZXJhdGlvbjooaWQpc2VuZGVyCiAgICAgfQogfQogCisjcHJhZ21hIG1h cmsgLQorI3ByYWdtYSBtYXJrIE5TUmVzcG9uZGVyIG92ZXJyaWRlcworCistICh2b2lkKW5vUmVz cG9uZGVyRm9yOihTRUwpZXZlbnRNZXRob2QKK3sKKyAgICBVTlVTRURfUEFSQU0oZXZlbnRNZXRo b2QpOworfQorCiAjcHJhZ21hIG1hcmsgLQogI3ByYWdtYSBtYXJrIEV4cG9zZWQgSW50ZXJmYWNl CiAK 406787 2020-08-18 08:38:36 -0700 2020-08-18 09:01:45 -0700 Patch for landing bug-215596-20200818083835.patch text/plain 1709 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1MTcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGIzNzliYzBiODE3MDYyYzEz NmY3NTQzYWI4NmMxOWZiODFjMzFjMjcuLmRiODk4ZmI0MWVlMGI0NDIzYTY5YzNjZWJjNDVhM2M3 NWNiYmIwZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDgtMTcgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgW01hY10gVW5oYW5kbGVkIGtleURv d246IGV2ZW50cyBjYXVzZSBhIHN5c3RlbSBiZWVwIGluIGZ1bGwgc2NyZWVuIG1vZGUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTU5NgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vNjU4MjM5NjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g QWRsZXIuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRy b2xsZXIubW06CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgbm9SZXNw b25kZXJGb3I6XSk6CisKIDIwMjAtMDctMzEgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5j b20+CiAKICAgICAgICAgW01hY10gQWRkIEV4cGVyaW1lbnRhbCBGZWF0dXJlIHByZWZlcmVuY2Ug Zm9yIFNXIFZQOQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvbWFjL1dLRnVs bFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMv V0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQppbmRleCA1NmFlZjNmZWU1ZGZjNTE2MDYw ZTFkY2JiNmJlYjA4ZmYzNTQ1NGJhLi4zODg4OTllYmI4MzEyODkyODQxMjAyZjM5NzJhZjY1MzY1 MmNhNmNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9tYWMv V0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlci5tbQpAQCAtMjIxLDYgKzIyMSwxOCBAQCAtICh2 b2lkKWNhbmNlbE9wZXJhdGlvbjooaWQpc2VuZGVyCiAgICAgfQogfQogCisjcHJhZ21hIG1hcmsg LQorI3ByYWdtYSBtYXJrIE5TUmVzcG9uZGVyIG92ZXJyaWRlcworCistICh2b2lkKW5vUmVzcG9u ZGVyRm9yOihTRUwpZXZlbnRNZXRob2QKK3sKKyAgICAvLyBUaGUgZGVmYXVsdCBiZWhhdmlvciBv ZiB0aGUgbGFzdCBsaW5rIGluIHRoZSByZXNwb25kZXIgY2hhaW4gaXMgdG8gY2FsbCBOU0JlZXAo KSBpZiB0aGUKKyAgICAvLyBldmVudCBpbiBxdWVzdGlvbiBpcyBhIC1rZXlEb3duOi4gQWRkaW5n IGEgbm8tb3Agb3ZlcnJpZGUgb2YgLW5vUmVzcG9uZGVyRm9yOiBpbiBhIHN1YmNsYXNzCisgICAg Ly8gb2YgTlNXaW5kb3dDb250cm9sbGVyLCB3aGljaCBpcyB0eXBpY2FsbHkgdGhlIGxhc3QgbGlu ayBpbiBhIHJlc3BvbmRlciBjaGFpbiwgYXZvaWRzIHRoZQorICAgIC8vIE5TQmVlcCgpIHdoZW4g LWtleURvd246IGdvZXMgdW5oYW5kbGVkLgorICAgIFVOVVNFRF9QQVJBTShldmVudE1ldGhvZCk7 Cit9CisKICNwcmFnbWEgbWFyayAtCiAjcHJhZ21hIG1hcmsgRXhwb3NlZCBJbnRlcmZhY2UKIAo=