215592 2020-08-17 16:12:23 -0700 Assert failure after r265715 2020-08-17 17:50:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham darin jbedard jiewen_tan ryanhaddad webkit-bug-importer oldest_to_newest 1680959 0 pvollan 2020-08-17 16:12:23 -0700 The change set r265715 introduced an assert failure in AuthenticationManager::initializeConnection. 1680963 1 406751 pvollan 2020-08-17 16:16:43 -0700 Created attachment 406751 Patch 1680980 2 406751 pvollan 2020-08-17 17:22:39 -0700 Comment on attachment 406751 Patch Thanks for reviewing! 1680990 3 ews-feeder 2020-08-17 17:49:05 -0700 Committed r265792: <https://trac.webkit.org/changeset/265792> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406751. 1680994 4 webkit-bug-importer 2020-08-17 17:50:15 -0700 <rdar://problem/67283921> 406751 2020-08-17 16:16:43 -0700 2020-08-17 17:49:05 -0700 Patch bug-215592-20200817161642.patch text/plain 7587 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjU3ODApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIwLTA4LTE3ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBc3NlcnQgZmFpbHVyZSBhZnRl ciByMjY1NzE1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTU1OTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgY2hhbmdlIHNldCByMjY1NzE1IGludHJvZHVjZWQgYW4gYXNzZXJ0IGZhaWx1cmUgaW4g QXV0aGVudGljYXRpb25NYW5hZ2VyOjppbml0aWFsaXplQ29ubmVjdGlvbi4gVGhpcworICAgICAg ICBoYXBwZW5zIGJlY2F1c2UgYWZ0ZXIgcjI2NTcxNSB0aGUgbmV3IFhQQyBldmVudCBoYW5kbGVy IHNldCBpbiBBdXRoZW50aWNhdGlvbk1hbmFnZXI6OmluaXRpYWxpemVDb25uZWN0aW9uLAorICAg ICAgICB3aWxsIG5vIGxvbmdlciBiZSBjYWxsZWQgb24gdGhlIG1haW4gdGhyZWFkLiBUaGlzIHBh dGNoIGFkZHJlc3NlcyB0aGlzIGlzc3VlIGJ5IGRpc3BhdGNoaW5nIHRoaXMgd29yayBvbgorICAg ICAgICB0aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVkIGJ5 IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogU2hhcmVkL0F1dGhlbnRpY2F0aW9uL2NvY29h L0F1dGhlbnRpY2F0aW9uTWFuYWdlckNvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpBdXRoZW50 aWNhdGlvbk1hbmFnZXI6OmluaXRpYWxpemVDb25uZWN0aW9uKToKKwogMjAyMC0wOC0xNyAgUGVy IEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBBdm9p ZCB3YWl0aW5nIGZvciBMYXVuY2ggU2VydmljZXMgb24gZXZlcnkgbG9hZApJbmRleDogU291cmNl L1dlYktpdC9TaGFyZWQvQXV0aGVudGljYXRpb24vY29jb2EvQXV0aGVudGljYXRpb25NYW5hZ2Vy Q29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9TaGFyZWQvQXV0aGVudGljYXRp b24vY29jb2EvQXV0aGVudGljYXRpb25NYW5hZ2VyQ29jb2EubW0JKHJldmlzaW9uIDI2NTYxMSkK KysrIFNvdXJjZS9XZWJLaXQvU2hhcmVkL0F1dGhlbnRpY2F0aW9uL2NvY29hL0F1dGhlbnRpY2F0 aW9uTWFuYWdlckNvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zOSw3ICszOSw3IEBAIG5hbWVz cGFjZSBXZWJLaXQgewogCiB2b2lkIEF1dGhlbnRpY2F0aW9uTWFuYWdlcjo6aW5pdGlhbGl6ZUNv bm5lY3Rpb24oSVBDOjpDb25uZWN0aW9uKiBjb25uZWN0aW9uKQogewotICAgIEFTU0VSVChpc01h aW5UaHJlYWQoKSk7CisgICAgUkVMRUFTRV9BU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogCiAgICAg aWYgKCFjb25uZWN0aW9uIHx8ICFjb25uZWN0aW9uLT54cGNDb25uZWN0aW9uKCkpIHsKICAgICAg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CkBAIC01MCw1NCArNTAsNTYgQEAgdm9pZCBBdXRoZW50 aWNhdGlvbk1hbmFnZXI6OmluaXRpYWxpemVDbwogICAgIC8vIFRoZSBmb2xsb3dpbmcgeHBjIGV2 ZW50IGhhbmRsZXIgb3ZlcndyaXRlcyB0aGUgYm9vc3RyYXAgZXZlbnQgaGFuZGxlciBhbmQgaXMg b25seSB1c2VkCiAgICAgLy8gdG8gY2FwdHVyZSBjbGllbnQgY2VydGlmaWNhdGUgY3JlZGVudGlh bC4KICAgICB4cGNfY29ubmVjdGlvbl9zZXRfZXZlbnRfaGFuZGxlcihjb25uZWN0aW9uLT54cGND b25uZWN0aW9uKCksIF4oeHBjX29iamVjdF90IGV2ZW50KSB7Ci0gICAgICAgIEFTU0VSVChpc01h aW5UaHJlYWQoKSk7CisgICAgICAgIGNhbGxPbk1haW5UaHJlYWQoW2V2ZW50ID0gT1NPYmplY3RQ dHIoZXZlbnQpLCB3ZWFrVGhpcyA9IHdlYWtUaGlzXSB7CisgICAgICAgICAgICBSRUxFQVNFX0FT U0VSVChpc01haW5UaHJlYWQoKSk7CiAKLSAgICAgICAgeHBjX3R5cGVfdCB0eXBlID0geHBjX2dl dF90eXBlKGV2ZW50KTsKLSAgICAgICAgaWYgKHR5cGUgPT0gWFBDX1RZUEVfRVJST1IgfHwgIXdl YWtUaGlzKQotICAgICAgICAgICAgcmV0dXJuOwotCi0gICAgICAgIGlmICh0eXBlICE9IFhQQ19U WVBFX0RJQ1RJT05BUlkgfHwgc3RyY21wKHhwY19kaWN0aW9uYXJ5X2dldF9zdHJpbmcoZXZlbnQs IENsaWVudENlcnRpZmljYXRlQXV0aGVudGljYXRpb246OlhQQ01lc3NhZ2VOYW1lS2V5KSwgQ2xp ZW50Q2VydGlmaWNhdGVBdXRoZW50aWNhdGlvbjo6WFBDTWVzc2FnZU5hbWVWYWx1ZSkpIHsKLSAg ICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotICAgICAgICAgICAgcmV0dXJuOwotICAg ICAgICB9Ci0KLSAgICAgICAgYXV0byBjaGFsbGVuZ2VJRCA9IHhwY19kaWN0aW9uYXJ5X2dldF91 aW50NjQoZXZlbnQsIENsaWVudENlcnRpZmljYXRlQXV0aGVudGljYXRpb246OlhQQ0NoYWxsZW5n ZUlES2V5KTsKLSAgICAgICAgaWYgKCFjaGFsbGVuZ2VJRCkKLSAgICAgICAgICAgIHJldHVybjsK LQotICAgICAgICBhdXRvIHhwY0VuZFBvaW50ID0geHBjX2RpY3Rpb25hcnlfZ2V0X3ZhbHVlKGV2 ZW50LCBDbGllbnRDZXJ0aWZpY2F0ZUF1dGhlbnRpY2F0aW9uOjpYUENTZWNLZXlQcm94eUVuZHBv aW50S2V5KTsKLSAgICAgICAgaWYgKCF4cGNFbmRQb2ludCB8fCB4cGNfZ2V0X3R5cGUoeHBjRW5k UG9pbnQpICE9IFhQQ19UWVBFX0VORFBPSU5UKQotICAgICAgICAgICAgcmV0dXJuOwotICAgICAg ICBhdXRvIGVuZFBvaW50ID0gYWRvcHROUyhbW05TWFBDTGlzdGVuZXJFbmRwb2ludCBhbGxvY10g aW5pdF0pOwotICAgICAgICBbZW5kUG9pbnQgX3NldEVuZHBvaW50OnhwY0VuZFBvaW50XTsKLSAg ICAgICAgTlNFcnJvciAqZXJyb3IgPSBuaWw7Ci0gICAgICAgIGF1dG8gaWRlbnRpdHkgPSBhZG9w dENGKFtTZWNLZXlQcm94eSBjcmVhdGVJZGVudGl0eUZyb21FbmRwb2ludDplbmRQb2ludC5nZXQo KSBlcnJvcjomZXJyb3JdKTsKLSAgICAgICAgaWYgKCFpZGVudGl0eSB8fCBlcnJvcikgewotICAg ICAgICAgICAgTE9HX0VSUk9SKCJDb3VsZG4ndCBjcmVhdGUgaWRlbnRpdHkgZnJvbSBlbmQgcG9p bnQ6ICVAIiwgZXJyb3IpOwotICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICB9Ci0KLSAgICAg ICAgYXV0byBjZXJ0aWZpY2F0ZURhdGFBcnJheSA9IHhwY19kaWN0aW9uYXJ5X2dldF9hcnJheShl dmVudCwgQ2xpZW50Q2VydGlmaWNhdGVBdXRoZW50aWNhdGlvbjo6WFBDQ2VydGlmaWNhdGVzS2V5 KTsKLSAgICAgICAgaWYgKCFjZXJ0aWZpY2F0ZURhdGFBcnJheSkKLSAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgTlNNdXRhYmxlQXJyYXkgKmNlcnRpZmljYXRlcyA9IG5pbDsKLSAgICAgICAg aWYgKGF1dG8gdG90YWwgPSB4cGNfYXJyYXlfZ2V0X2NvdW50KGNlcnRpZmljYXRlRGF0YUFycmF5 KSkgewotICAgICAgICAgICAgY2VydGlmaWNhdGVzID0gW05TTXV0YWJsZUFycmF5IGFycmF5V2l0 aENhcGFjaXR5OnRvdGFsXTsKLSAgICAgICAgICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgdG90 YWw7IGkrKykgewotICAgICAgICAgICAgICAgIGF1dG8gY2VydGlmaWNhdGVEYXRhID0geHBjX2Fy cmF5X2dldF92YWx1ZShjZXJ0aWZpY2F0ZURhdGFBcnJheSwgaSk7Ci0gICAgICAgICAgICAgICAg YXV0byBjZkRhdGEgPSBhZG9wdENGKENGRGF0YUNyZWF0ZShudWxscHRyLCByZWludGVycHJldF9j YXN0PGNvbnN0IFVJbnQ4Kj4oeHBjX2RhdGFfZ2V0X2J5dGVzX3B0cihjZXJ0aWZpY2F0ZURhdGEp KSwgeHBjX2RhdGFfZ2V0X2xlbmd0aChjZXJ0aWZpY2F0ZURhdGEpKSk7Ci0gICAgICAgICAgICAg ICAgYXV0byBjZXJ0aWZpY2F0ZSA9IGFkb3B0Q0YoU2VjQ2VydGlmaWNhdGVDcmVhdGVXaXRoRGF0 YShudWxscHRyLCBjZkRhdGEuZ2V0KCkpKTsKLSAgICAgICAgICAgICAgICBpZiAoIWNlcnRpZmlj YXRlKQotICAgICAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICAgICAgW2NlcnRp ZmljYXRlcyBhZGRPYmplY3Q6KF9fYnJpZGdlIGlkKWNlcnRpZmljYXRlLmdldCgpXTsKKyAgICAg ICAgICAgIHhwY190eXBlX3QgdHlwZSA9IHhwY19nZXRfdHlwZShldmVudC5nZXQoKSk7CisgICAg ICAgICAgICBpZiAodHlwZSA9PSBYUENfVFlQRV9FUlJPUiB8fCAhd2Vha1RoaXMpCisgICAgICAg ICAgICAgICAgcmV0dXJuOworCisgICAgICAgICAgICBpZiAodHlwZSAhPSBYUENfVFlQRV9ESUNU SU9OQVJZIHx8IHN0cmNtcCh4cGNfZGljdGlvbmFyeV9nZXRfc3RyaW5nKGV2ZW50LmdldCgpLCBD bGllbnRDZXJ0aWZpY2F0ZUF1dGhlbnRpY2F0aW9uOjpYUENNZXNzYWdlTmFtZUtleSksIENsaWVu dENlcnRpZmljYXRlQXV0aGVudGljYXRpb246OlhQQ01lc3NhZ2VOYW1lVmFsdWUpKSB7CisgICAg ICAgICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICAgICAgfQotICAgICAgICB9CiAKLSAgICAgICAgYXV0byBwZXJzaXN0ZW5jZSA9 IHhwY19kaWN0aW9uYXJ5X2dldF91aW50NjQoZXZlbnQsIENsaWVudENlcnRpZmljYXRlQXV0aGVu dGljYXRpb246OlhQQ1BlcnNpc3RlbmNlS2V5KTsKLSAgICAgICAgaWYgKHBlcnNpc3RlbmNlID4g c3RhdGljX2Nhc3Q8dWludDY0X3Q+KE5TVVJMQ3JlZGVudGlhbFBlcnNpc3RlbmNlU3luY2hyb25p emFibGUpKQotICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgYXV0byBjaGFsbGVuZ2VJ RCA9IHhwY19kaWN0aW9uYXJ5X2dldF91aW50NjQoZXZlbnQuZ2V0KCksIENsaWVudENlcnRpZmlj YXRlQXV0aGVudGljYXRpb246OlhQQ0NoYWxsZW5nZUlES2V5KTsKKyAgICAgICAgICAgIGlmICgh Y2hhbGxlbmdlSUQpCisgICAgICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgICAgICBhdXRv IHhwY0VuZFBvaW50ID0geHBjX2RpY3Rpb25hcnlfZ2V0X3ZhbHVlKGV2ZW50LmdldCgpLCBDbGll bnRDZXJ0aWZpY2F0ZUF1dGhlbnRpY2F0aW9uOjpYUENTZWNLZXlQcm94eUVuZHBvaW50S2V5KTsK KyAgICAgICAgICAgIGlmICgheHBjRW5kUG9pbnQgfHwgeHBjX2dldF90eXBlKHhwY0VuZFBvaW50 KSAhPSBYUENfVFlQRV9FTkRQT0lOVCkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAg ICAgICBhdXRvIGVuZFBvaW50ID0gYWRvcHROUyhbW05TWFBDTGlzdGVuZXJFbmRwb2ludCBhbGxv Y10gaW5pdF0pOworICAgICAgICAgICAgW2VuZFBvaW50IF9zZXRFbmRwb2ludDp4cGNFbmRQb2lu dF07CisgICAgICAgICAgICBOU0Vycm9yICplcnJvciA9IG5pbDsKKyAgICAgICAgICAgIGF1dG8g aWRlbnRpdHkgPSBhZG9wdENGKFtTZWNLZXlQcm94eSBjcmVhdGVJZGVudGl0eUZyb21FbmRwb2lu dDplbmRQb2ludC5nZXQoKSBlcnJvcjomZXJyb3JdKTsKKyAgICAgICAgICAgIGlmICghaWRlbnRp dHkgfHwgZXJyb3IpIHsKKyAgICAgICAgICAgICAgICBMT0dfRVJST1IoIkNvdWxkbid0IGNyZWF0 ZSBpZGVudGl0eSBmcm9tIGVuZCBwb2ludDogJUAiLCBlcnJvcik7CisgICAgICAgICAgICAgICAg cmV0dXJuOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICBhdXRvIGNlcnRpZmljYXRlRGF0 YUFycmF5ID0geHBjX2RpY3Rpb25hcnlfZ2V0X2FycmF5KGV2ZW50LmdldCgpLCBDbGllbnRDZXJ0 aWZpY2F0ZUF1dGhlbnRpY2F0aW9uOjpYUENDZXJ0aWZpY2F0ZXNLZXkpOworICAgICAgICAgICAg aWYgKCFjZXJ0aWZpY2F0ZURhdGFBcnJheSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAg ICAgICAgICBOU011dGFibGVBcnJheSAqY2VydGlmaWNhdGVzID0gbmlsOworICAgICAgICAgICAg aWYgKGF1dG8gdG90YWwgPSB4cGNfYXJyYXlfZ2V0X2NvdW50KGNlcnRpZmljYXRlRGF0YUFycmF5 KSkgeworICAgICAgICAgICAgICAgIGNlcnRpZmljYXRlcyA9IFtOU011dGFibGVBcnJheSBhcnJh eVdpdGhDYXBhY2l0eTp0b3RhbF07CisgICAgICAgICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7 IGkgPCB0b3RhbDsgaSsrKSB7CisgICAgICAgICAgICAgICAgICAgIGF1dG8gY2VydGlmaWNhdGVE YXRhID0geHBjX2FycmF5X2dldF92YWx1ZShjZXJ0aWZpY2F0ZURhdGFBcnJheSwgaSk7CisgICAg ICAgICAgICAgICAgICAgIGF1dG8gY2ZEYXRhID0gYWRvcHRDRihDRkRhdGFDcmVhdGUobnVsbHB0 ciwgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBVSW50OCo+KHhwY19kYXRhX2dldF9ieXRlc19wdHIo Y2VydGlmaWNhdGVEYXRhKSksIHhwY19kYXRhX2dldF9sZW5ndGgoY2VydGlmaWNhdGVEYXRhKSkp OworICAgICAgICAgICAgICAgICAgICBhdXRvIGNlcnRpZmljYXRlID0gYWRvcHRDRihTZWNDZXJ0 aWZpY2F0ZUNyZWF0ZVdpdGhEYXRhKG51bGxwdHIsIGNmRGF0YS5nZXQoKSkpOworICAgICAgICAg ICAgICAgICAgICBpZiAoIWNlcnRpZmljYXRlKQorICAgICAgICAgICAgICAgICAgICAgICAgcmV0 dXJuOworICAgICAgICAgICAgICAgICAgICBbY2VydGlmaWNhdGVzIGFkZE9iamVjdDooX19icmlk Z2UgaWQpY2VydGlmaWNhdGUuZ2V0KCldOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAg IH0KKworICAgICAgICAgICAgYXV0byBwZXJzaXN0ZW5jZSA9IHhwY19kaWN0aW9uYXJ5X2dldF91 aW50NjQoZXZlbnQuZ2V0KCksIENsaWVudENlcnRpZmljYXRlQXV0aGVudGljYXRpb246OlhQQ1Bl cnNpc3RlbmNlS2V5KTsKKyAgICAgICAgICAgIGlmIChwZXJzaXN0ZW5jZSA+IHN0YXRpY19jYXN0 PHVpbnQ2NF90PihOU1VSTENyZWRlbnRpYWxQZXJzaXN0ZW5jZVN5bmNocm9uaXphYmxlKSkKKyAg ICAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgd2Vha1RoaXMtPmNvbXBsZXRlQXV0aGVu dGljYXRpb25DaGFsbGVuZ2UoY2hhbGxlbmdlSUQsIEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlRGlz cG9zaXRpb246OlVzZUNyZWRlbnRpYWwsIFdlYkNvcmU6OkNyZWRlbnRpYWwoYWRvcHROUyhbW05T VVJMQ3JlZGVudGlhbCBhbGxvY10gaW5pdFdpdGhJZGVudGl0eTppZGVudGl0eS5nZXQoKSBjZXJ0 aWZpY2F0ZXM6Y2VydGlmaWNhdGVzIHBlcnNpc3RlbmNlOihOU1VSTENyZWRlbnRpYWxQZXJzaXN0 ZW5jZSlwZXJzaXN0ZW5jZV0pLmdldCgpKSk7CisgICAgICAgICAgICB3ZWFrVGhpcy0+Y29tcGxl dGVBdXRoZW50aWNhdGlvbkNoYWxsZW5nZShjaGFsbGVuZ2VJRCwgQXV0aGVudGljYXRpb25DaGFs bGVuZ2VEaXNwb3NpdGlvbjo6VXNlQ3JlZGVudGlhbCwgV2ViQ29yZTo6Q3JlZGVudGlhbChhZG9w dE5TKFtbTlNVUkxDcmVkZW50aWFsIGFsbG9jXSBpbml0V2l0aElkZW50aXR5OmlkZW50aXR5Lmdl dCgpIGNlcnRpZmljYXRlczpjZXJ0aWZpY2F0ZXMgcGVyc2lzdGVuY2U6KE5TVVJMQ3JlZGVudGlh bFBlcnNpc3RlbmNlKXBlcnNpc3RlbmNlXSkuZ2V0KCkpKTsKKyAgICAgICAgfSk7CiAgICAgfSk7 CiB9CiAK