215574 2020-08-17 09:49:03 -0700 WaveShaperNode should not output silence when it has no input or when input is silence 2020-08-17 12:15:29 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212611 1 cdumez cdumez clark_wang eric.carlson ews-watchlist ggaren glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1680834 0 cdumez 2020-08-17 09:49:03 -0700 WaveShaperNode should not output silence when it has no input or when input is silence. It should still apply its curve to the silent input. 1680836 1 406722 cdumez 2020-08-17 09:55:00 -0700 Created attachment 406722 Patch 1680874 2 ews-feeder 2020-08-17 12:14:45 -0700 Committed r265765: <https://trac.webkit.org/changeset/265765> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406722. 1680875 3 webkit-bug-importer 2020-08-17 12:15:29 -0700 <rdar://problem/67262554> 406722 2020-08-17 09:55:00 -0700 2020-08-17 12:14:45 -0700 Patch bug-215574-20200817095459.patch text/plain 7260 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWVjYjA2MTkxMjk3MGI2 YjMyOTM5MjE4NWEwZDZjYTgwMzdkNmIzNy4uYjQ5NTU1M2IzN2JjYjY1NWNhMWZjYjEzZjZkODQ0 YWRhZjExODc4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIwLTA4LTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgV2F2ZVNoYXBlck5vZGUgc2hv dWxkIG5vdCBvdXRwdXQgc2lsZW5jZSB3aGVuIGl0IGhhcyBubyBpbnB1dCBvciB3aGVuIGlucHV0 IGlzIHNpbGVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxNTU3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdhdmVTaGFwZXJOb2RlIHNob3VsZCBub3Qgb3V0cHV0IHNpbGVuY2Ugd2hlbiBpdCBoYXMg bm8gaW5wdXQgb3Igd2hlbiBpbnB1dCBpcyBzaWxlbmNlLgorICAgICAgICBJdCBzaG91bGQgc3Rp bGwgYXBwbHkgaXRzIGN1cnZlIHRvIHRoZSBzaWxlbnQgaW5wdXQuCisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLCByZWJhc2VsaW5lZCBleGlzdGluZyB0ZXN0LgorCisgICAgICAgICogTW9kdWxlcy93 ZWJhdWRpby9BdWRpb05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9Ob2RlOjpkaXNh YmxlT3V0cHV0c0lmTmVjZXNzYXJ5KToKKyAgICAgICAgRG8gbm90IGRpc2FibGUgdGhlIFdhdmVT aGFwZXJOb2RlJ3Mgb3V0cHV0IHdoZW4gaXRzIGhhcyBubyBpbnB1dC4gVGhlIFdhdmVTaGFwZXJO b2RlCisgICAgICAgIG1heSBzdGlsbCBwcm92aWRlIG5vbi1zaWxlbnQgb3V0cHV0IHdoZW4gaXQg aGFzIG5vIGlucHV0LgorCisgICAgICAgICogTW9kdWxlcy93ZWJhdWRpby9XYXZlU2hhcGVyTm9k ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXYXZlU2hhcGVyTm9kZTo6cHJvcGFnYXRlc1NpbGVu Y2UgY29uc3QpOgorICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vV2F2ZVNoYXBlck5vZGUuaDoK KyAgICAgICAgT3ZlcnJpZGUgcHJvcGFnYXRlc1NpbGVuY2UoKSB0byByZXR1cm4gZmFsc2Ugd2hl biB0aGUgV2F2ZVNoYXBlck5vZGUgaGFzIGEgY3VydmUgdG8gYXBwbHksCisgICAgICAgIHNvIHRo YXQgd2UgYXNrIHRoZSBub2RlIHRvIHByb2Nlc3MgdGhlIGlucHV0IGV2ZW4gd2hlbiBpdCBpcyBz aWxlbmNlLgorCiAyMDIwLTA4LTE0ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgT2ZmbGluZUF1ZGlvQ29udGV4dC5kZXN0aW5hdGlvbiBoYXMgaW5jb3JyZWN0IG51 bWJlciBvZiBjaGFubmVscyAmIGNoYW5uZWwgY291bnQgbW9kZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy93ZWJhdWRpby9BdWRpb05vZGUuY3BwCmluZGV4IDgyNzlkNDYxNTJiNmQ2NzJjNmM3 YjI1ZDg1YWMzY2E1MmY5MTk0YTIuLjg4ODM1Y2NkZTZlOGZiNGM3MjM1NWFmM2M0NTg4YzQxM2Zk NDU0MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9O b2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvTm9kZS5j cHAKQEAgLTQyMyw3ICs0MjMsOSBAQCB2b2lkIEF1ZGlvTm9kZTo6ZGlzYWJsZU91dHB1dHNJZk5l Y2Vzc2FyeSgpCiAgICAgICAgIC8vIGJlY2F1c2UgdGhleSBubyBsb25nZXIgaGF2ZSBhbnkgaW5w dXQgY29ubmVjdGlvbnMuIFRoaXMgbmVlZHMgdG8gYmUgaGFuZGxlZCBtb3JlIGdlbmVyYWxseSB3 aGVyZSBBdWRpb05vZGVzIGhhdmUKICAgICAgICAgLy8gYSB0YWlsVGltZSBhdHRyaWJ1dGUuIFRo ZW4gdGhlIEF1ZGlvTm9kZSBvbmx5IG5lZWRzIHRvIHJlbWFpbiAiYWN0aXZlIiBmb3IgdGFpbFRp bWUgc2Vjb25kcyBhZnRlciB0aGVyZSBhcmUgbm8KICAgICAgICAgLy8gbG9uZ2VyIGFueSBhY3Rp dmUgY29ubmVjdGlvbnMuCi0gICAgICAgIGlmIChub2RlVHlwZSgpICE9IE5vZGVUeXBlQ29udm9s dmVyICYmIG5vZGVUeXBlKCkgIT0gTm9kZVR5cGVEZWxheSkgeworICAgICAgICAvLyBBbHNvLCBX YXZlU2hhcGVyTm9kZSBtYXkgcHJvZHVjZSBub24tc2lsZW5jZSBldmVuIHdoZW4gaXQgbm8gbG9u Z2VyIGhhcyBhbnkgb3V0cHV0LiBGb3IgdGhpcyByZWFzb24sIHdlIGNhbm5vdAorICAgICAgICAv LyBkaXNhYmxlIGl0IGVpdGhlci4KKyAgICAgICAgaWYgKG5vZGVUeXBlKCkgIT0gTm9kZVR5cGVD b252b2x2ZXIgJiYgbm9kZVR5cGUoKSAhPSBOb2RlVHlwZURlbGF5ICYmIG5vZGVUeXBlKCkgIT0g Tm9kZVR5cGVXYXZlU2hhcGVyKSB7CiAgICAgICAgICAgICBtX2lzRGlzYWJsZWQgPSB0cnVlOwog ICAgICAgICAgICAgZm9yIChhdXRvJiBvdXRwdXQgOiBtX291dHB1dHMpCiAgICAgICAgICAgICAg ICAgb3V0cHV0LT5kaXNhYmxlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL1dhdmVTaGFwZXJOb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi YXVkaW8vV2F2ZVNoYXBlck5vZGUuY3BwCmluZGV4IGJjZmIzYWMxZDQ3ZTZkY2JhMGRjMWY0MmNm NDlhMGFiMjMyMDgwZmIuLjVjMjNmYWEyNzIxZWIyNzA1ZTNmNWZiMTU2OTIwOTcyMTVkZDkxODcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vV2F2ZVNoYXBlck5v ZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vV2F2ZVNoYXBlck5v ZGUuY3BwCkBAIC0xMzIsNiArMTMyLDEyIEBAIGF1dG8gV2F2ZVNoYXBlck5vZGU6Om92ZXJzYW1w bGUoKSBjb25zdCAtPiBPdmVyU2FtcGxlVHlwZQogICAgIHJldHVybiBPdmVyU2FtcGxlVHlwZTo6 Tm9uZTsKIH0KIAorYm9vbCBXYXZlU2hhcGVyTm9kZTo6cHJvcGFnYXRlc1NpbGVuY2UoKSBjb25z dAoreworICAgIGF1dG8gY3VydmUgPSBjb25zdF9jYXN0PFdhdmVTaGFwZXJOb2RlKj4odGhpcykt PmN1cnZlKCk7CisgICAgcmV0dXJuICFjdXJ2ZSB8fCAhY3VydmUtPmxlbmd0aCgpOworfQorCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFCTEUoV0VCX0FVRElPKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9XYXZlU2hhcGVyTm9kZS5o IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9XYXZlU2hhcGVyTm9kZS5oCmluZGV4 IDY2MGNhNGJlMTUzYTRlNTQyYzVkNDBlZWNmMDEwOTZlNjM3OTEwYjguLjczMDZkNmFjOTA5NWQy MmJjNWQ3NjQ0YjU0YTVmOWU1MDM3ZGFkZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01v ZHVsZXMvd2ViYXVkaW8vV2F2ZVNoYXBlck5vZGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3dlYmF1ZGlvL1dhdmVTaGFwZXJOb2RlLmgKQEAgLTUxLDYgKzUxLDggQEAgcHVibGljOgog cHJpdmF0ZTogICAgCiAgICAgZXhwbGljaXQgV2F2ZVNoYXBlck5vZGUoQmFzZUF1ZGlvQ29udGV4 dCYpOwogCisgICAgYm9vbCBwcm9wYWdhdGVzU2lsZW5jZSgpIGNvbnN0IGZpbmFsOworCiAgICAg V2F2ZVNoYXBlclByb2Nlc3Nvciogd2F2ZVNoYXBlclByb2Nlc3NvcigpIHsgcmV0dXJuIHN0YXRp Y19jYXN0PFdhdmVTaGFwZXJQcm9jZXNzb3IqPihwcm9jZXNzb3IoKSk7IH0KIH07CiAKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9p bXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDU5ZTc1ZTUzZTIxMTQ4ODAzYjYyNTYxZmU2MGU0 MmY2MzZkZmY0YWEuLmUwMmNlOTRkMjZhNTU5ZGNlMTBiN2Q1MmIxODMwNWZlNzhmM2ZhZTMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA4LTE3 ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgV2F2ZVNoYXBlck5v ZGUgc2hvdWxkIG5vdCBvdXRwdXQgc2lsZW5jZSB3aGVuIGl0IGhhcyBubyBpbnB1dCBvciB3aGVu IGlucHV0IGlzIHNpbGVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNTU3NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlYmFzZWxpbmUgZXhpc3RpbmcgdGVzdCBub3cgdGhhdCBhbGwgY2hlY2tzIGFy ZSBwYXNzaW5nLgorCisgICAgICAgICogd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1ZGlvL3RoZS1h dWRpby1hcGkvdGhlLXdhdmVzaGFwZXJub2RlLWludGVyZmFjZS9zaWxlbnQtaW5wdXRzLWV4cGVj dGVkLnR4dDoKKwogMjAyMC0wOC0xNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgog CiAgICAgICAgIE9mZmxpbmVBdWRpb0NvbnRleHQuZGVzdGluYXRpb24gaGFzIGluY29ycmVjdCBu dW1iZXIgb2YgY2hhbm5lbHMgJiBjaGFubmVsIGNvdW50IG1vZGUKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVkaW8vdGhlLWF1ZGlv LWFwaS90aGUtd2F2ZXNoYXBlcm5vZGUtaW50ZXJmYWNlL3NpbGVudC1pbnB1dHMtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJhdWRp by90aGUtYXVkaW8tYXBpL3RoZS13YXZlc2hhcGVybm9kZS1pbnRlcmZhY2Uvc2lsZW50LWlucHV0 cy1leHBlY3RlZC50eHQKaW5kZXggMWU0Nzk2NjE4ZDU5ZDgzZGE4OTRlMmFjMjM5OTU2YTNmODA2 NzlkNS4uNjkxYTYzODk2YTU2OTA4ZGY1Y2I2YmU1YTM0ODg1M2ZmNjgyY2NiYyAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy93ZWJhdWRpby90 aGUtYXVkaW8tYXBpL3RoZS13YXZlc2hhcGVybm9kZS1pbnRlcmZhY2Uvc2lsZW50LWlucHV0cy1l eHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy93ZWJhdWRpby90aGUtYXVkaW8tYXBpL3RoZS13YXZlc2hhcGVybm9kZS1pbnRlcmZhY2Uv c2lsZW50LWlucHV0cy1leHBlY3RlZC50eHQKQEAgLTUsMzEgKzUsMTMgQEAgUEFTUyBFeGVjdXRp bmcgInRlc3QtMSIKIFBBU1MgRXhlY3V0aW5nICJ0ZXN0LTIiIAogUEFTUyBBdWRpdCByZXBvcnQg CiBQQVNTID4gW3Rlc3QtMF0gY3VydmUgb3V0cHV0IGlzIG5vbi16ZXJvIGZvciBzaWxlbnQgaW5w dXRzIAotRkFJTCBYIFdhdmVTaGFwZXIgd2l0aCBzaWxlbnQgaW5wdXRzIGFuZCBjdXJ2ZSB7IjAi OjAuNSwiMSI6MC41LCIyIjowLjV9OiBFeHBlY3RlZCAwLjUgZm9yIGFsbCB2YWx1ZXMgYnV0IGZv dW5kIDE2MDAwIHVuZXhwZWN0ZWQgdmFsdWVzOiAKLQlJbmRleAlBY3R1YWwKLQlbMF0JMAotCVsx XQkwCi0JWzJdCTAKLQlbM10JMAotCS4uLmFuZCAxNTk5NiBtb3JlIGVycm9ycy4gYXNzZXJ0X3Ry dWU6IGV4cGVjdGVkIHRydWUgZ290IGZhbHNlCi1GQUlMIDwgW3Rlc3QtMF0gMSBvdXQgb2YgMSBh c3NlcnRpb25zIHdlcmUgZmFpbGVkLiBhc3NlcnRfdHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFs c2UKK1BBU1MgICBXYXZlU2hhcGVyIHdpdGggc2lsZW50IGlucHV0cyBhbmQgY3VydmUgeyIwIjow LjUsIjEiOjAuNSwiMiI6MC41fSBjb250YWlucyBvbmx5IHRoZSBjb25zdGFudCAwLjUuIAorUEFT UyA8IFt0ZXN0LTBdIEFsbCBhc3NlcnRpb25zIHBhc3NlZC4gKHRvdGFsIDEgYXNzZXJ0aW9ucykg CiBQQVNTID4gW3Rlc3QtMV0gMnggY3VydmUgb3V0cHV0IGlzIG5vbi16ZXJvIGZvciBzaWxlbnQg aW5wdXRzIAotRkFJTCBYIFdhdmVTaGFwZXIgd2l0aCAyeCBvdmVyc2FtcGxlLCBzaWxlbnQgaW5w dXRzLCBhbmQgY3VydmUgeyIwIjowLjUsIjEiOjAuNSwiMiI6MC41fTogRXhwZWN0ZWQgMC41IGZv ciBhbGwgdmFsdWVzIGJ1dCBmb3VuZCAxNjAwMCB1bmV4cGVjdGVkIHZhbHVlczogCi0JSW5kZXgJ QWN0dWFsCi0JWzBdCTAKLQlbMV0JMAotCVsyXQkwCi0JWzNdCTAKLQkuLi5hbmQgMTU5OTYgbW9y ZSBlcnJvcnMuIGFzc2VydF90cnVlOiBleHBlY3RlZCB0cnVlIGdvdCBmYWxzZQotRkFJTCA8IFt0 ZXN0LTFdIDEgb3V0IG9mIDEgYXNzZXJ0aW9ucyB3ZXJlIGZhaWxlZC4gYXNzZXJ0X3RydWU6IGV4 cGVjdGVkIHRydWUgZ290IGZhbHNlCitQQVNTICAgV2F2ZVNoYXBlciB3aXRoIDJ4IG92ZXJzYW1w bGUsIHNpbGVudCBpbnB1dHMsIGFuZCBjdXJ2ZSB7IjAiOjAuNSwiMSI6MC41LCIyIjowLjV9IGNv bnRhaW5zIG9ubHkgdGhlIGNvbnN0YW50IDAuNS4gCitQQVNTIDwgW3Rlc3QtMV0gQWxsIGFzc2Vy dGlvbnMgcGFzc2VkLiAodG90YWwgMSBhc3NlcnRpb25zKSAKIFBBU1MgPiBbdGVzdC0yXSBjdXJ2 ZSBvdXRwdXQgaXMgbm9uLXplcm8gZm9yIG5vIGlucHV0cyAKLUZBSUwgWCBXYXZlU2hhcGVyIHdp dGggbm8gaW5wdXRzIGFuZCBjdXJ2ZSB7IjAiOjAuNSwiMSI6MC41LCIyIjowLjV9OiBFeHBlY3Rl ZCAwLjUgZm9yIGFsbCB2YWx1ZXMgYnV0IGZvdW5kIDE2MDAwIHVuZXhwZWN0ZWQgdmFsdWVzOiAK LQlJbmRleAlBY3R1YWwKLQlbMF0JMAotCVsxXQkwCi0JWzJdCTAKLQlbM10JMAotCS4uLmFuZCAx NTk5NiBtb3JlIGVycm9ycy4gYXNzZXJ0X3RydWU6IGV4cGVjdGVkIHRydWUgZ290IGZhbHNlCi1G QUlMIDwgW3Rlc3QtMl0gMSBvdXQgb2YgMSBhc3NlcnRpb25zIHdlcmUgZmFpbGVkLiBhc3NlcnRf dHJ1ZTogZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKLUZBSUwgIyBBVURJVCBUQVNLIFJVTk5FUiBG SU5JU0hFRDogMyBvdXQgb2YgMyB0YXNrcyB3ZXJlIGZhaWxlZC4gYXNzZXJ0X3RydWU6IGV4cGVj dGVkIHRydWUgZ290IGZhbHNlCitQQVNTICAgV2F2ZVNoYXBlciB3aXRoIG5vIGlucHV0cyBhbmQg Y3VydmUgeyIwIjowLjUsIjEiOjAuNSwiMiI6MC41fSBjb250YWlucyBvbmx5IHRoZSBjb25zdGFu dCAwLjUuIAorUEFTUyA8IFt0ZXN0LTJdIEFsbCBhc3NlcnRpb25zIHBhc3NlZC4gKHRvdGFsIDEg YXNzZXJ0aW9ucykgCitQQVNTICMgQVVESVQgVEFTSyBSVU5ORVIgRklOSVNIRUQ6IDMgdGFza3Mg cmFuIHN1Y2Nlc3NmdWxseS4gCiAK