21557 2008-10-12 11:49:12 -0700 REGRESSION: generated-layer-scrollbar-crash.html is crashing 2008-10-12 15:54:47 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P1 Major --- 1 darin darin hyatt oldest_to_newest 95049 0 darin 2008-10-12 11:49:12 -0700 The regression test is failing because of new code in RenderLayer::styleChanged. 95050 1 darin 2008-10-12 11:58:03 -0700 This crash is caused by the code that tries to get the pseudo style for the scroll bar and resizer in RenderLayer::styleChanged. It's being called on a RenderView, which has a document for its element and thus can't be styled. I suspect that's a bug, but it's easy to fix this code to be robust in cases like this, which is what I did. 95051 2 24304 darin 2008-10-12 11:58:26 -0700 Created attachment 24304 patch 95091 3 24304 mrowe 2008-10-12 15:45:38 -0700 Comment on attachment 24304 patch r=me 95093 4 darin 2008-10-12 15:54:47 -0700 http://trac.webkit.org/changeset/37533 24304 2008-10-12 11:58:26 -0700 2008-10-12 15:45:38 -0700 patch LayoutTestCrashPatch.txt text/plain 1686 darin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNzUyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMDgtMTAtMTIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4 IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU1NworICAgICAgICAg IEJ1ZyAyMTU1NzogUkVHUkVTU0lPTjogZ2VuZXJhdGVkLWxheWVyLXNjcm9sbGJhci1jcmFzaC5o dG1sIGlzIGNyYXNoaW5nCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlck9iamVjdDo6Z2V0UHNldWRvU3R5bGUpOiBLZWVwIHdh bGtpbmcgdXAgdGhlIHBhcmVudCBjaGFpbgorICAgICAgICB1bnRpbCB3ZSBoaXQgYW4gRWxlbWVu dC4gTm93YWRheXMsIE5vZGU6OmlzRWxlbWVudE5vZGUoKSBpcyBqdXN0IGFzIGVmZmljaWVudAor ICAgICAgICBhcyBSZW5kZXJPYmplY3Q6OmlzVGV4dCgpLCBhbmQgdGhpcyBndWFyYW50ZWVzIHRo YXQgdGhlIG5vZGUgY2FuIGJlIGNhc3QgdG8KKyAgICAgICAgRWxlbWVudCosIHdoaWNoIGlzIGRv bmUganVzdCBiZWxvdy4gVGhlIHJlYXNvbiB0aGlzIGlzIGhpdCBpcyB0aGF0IFJlbmRlckxheWVy CisgICAgICAgIGNhbiBjYWxsIGdldFBzZXVkb1N0eWxlIG9uIGEgUmVuZGVyVmlldywgd2hpY2gg aGFzIHRoZSBkb2N1bWVudCBhcyBpdHMKKyAgICAgICAgZWxlbWVudCgpIC0tIGFuZCBhIGRvY3Vt ZW50IGlzIG5laXRoZXIgYSBUZXh0IG5vZGUgbm9yIGFuIEVsZW1lbnQuIEEgbG9vc2UKKyAgICAg ICAgZW5kIGlzIHRoYXQgdGhpcyBzZWVtcyB0byBtZWFuIHlvdSBjYW4ndCBzdHlsZSB0aGUgc2Ny b2xsYmFyIGNvcm5lciBvciB0aGUKKyAgICAgICAgcmVzaXplciBvbiBhIFJlbmRlclZpZXcuIEh5 YXR0IG1heSB3YW50IHRvIGxvb2sgaW50byB0aGF0IGxhdGVyLgorCiAyMDA4LTEwLTEyICBCcmFk IEdhcmNpYSAgPGJnYXJjaWFAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJp biBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkocmV2aXNpb24gMzc1 MjMpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yODM1LDcgKzI4MzUsNyBAQCBSZW5kZXJTdHlsZSogUmVuZGVyT2JqZWN0OjpnZXRQc2V1 ZG9TdHlsCiAgICAgICAgIHJldHVybiByZXN1bHQ7CiAKICAgICBOb2RlKiBub2RlID0gZWxlbWVu dCgpOwotICAgIGlmIChub2RlICYmIGlzVGV4dCgpKQorICAgIHdoaWxlIChub2RlICYmICFub2Rl LT5pc0VsZW1lbnROb2RlKCkpCiAgICAgICAgIG5vZGUgPSBub2RlLT5wYXJlbnROb2RlKCk7CiAg ICAgaWYgKCFub2RlKQogICAgICAgICByZXR1cm4gMDsK