215533 2020-08-14 18:48:40 -0700 [AS Layout Tests] 6 WPT css-backgrounds tests consistently failing 2020-08-16 12:11:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino ews-watchlist fmalita gyuyoung.kim pdr sabouhallawa schenney sergio webkit-bug-importer youennf oldest_to_newest 1680568 0 dino 2020-08-14 18:48:40 -0700 [AS Layout Tests] 6 WPT css-backgrounds tests consistently failing 1680569 1 dino 2020-08-14 18:49:07 -0700 <rdar://66660924> 1680570 2 406647 dino 2020-08-14 18:55:21 -0700 Created attachment 406647 Patch 1680620 3 406647 youennf 2020-08-15 09:32:21 -0700 Comment on attachment 406647 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406647&action=review > Source/WebCore/svg/graphics/SVGImage.cpp:175 > + return IntSize(300, 150); Are these values used elsewhere? Is it worth using constants or a specific routine to document/centralize these values? 1680673 4 406647 dino 2020-08-16 11:56:30 -0700 Comment on attachment 406647 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406647&action=review >> Source/WebCore/svg/graphics/SVGImage.cpp:175 >> + return IntSize(300, 150); > > Are these values used elsewhere? Is it worth using constants or a specific routine to document/centralize these values? They are probably used in a bunch of spots, yeah. We could make a constant. 1680675 5 ews-feeder 2020-08-16 12:11:11 -0700 Committed r265742: <https://trac.webkit.org/changeset/265742> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406647. 406647 2020-08-14 18:55:21 -0700 2020-08-16 12:11:12 -0700 Patch bug-215533-20200815115519.patch text/plain 5627 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTQ3YzgwZGMxOGI3YjRl M2UyNGIyOWJmN2NjMDg1YmVjNDQ3YmI4Mi4uYzljNTMzYTIyZTIxOTI0YWYyZmZjOWEzNjQ4ZmUz NTZmZGY0NzE5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIwLTA4LTE0ICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbQVMgTGF5b3V0IFRlc3RzXSA2 IFdQVCBjc3MtYmFja2dyb3VuZHMgdGVzdHMgY29uc2lzdGVudGx5IGZhaWxpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTUzMworICAgICAgICBy ZGFyOi8vNjY2NjA5MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBIHN0YXRpY19jYXN0IGZyb20gZmxvYXQgdG8gaW50LCB3aGVyZSB0aGUgZmxvYXQg dmFsdWUgaXMgbGFyZ2VyIHRoYW4gTUFYX0lOVCwgcHJvZHVjZXMKKyAgICAgICAgZGlmZmVyZW50 IHJlc3VsdHMgb24geDg2XzY0IGFuZCBhcm02NGUuIFVuZm9ydHVuYXRlbHksIGZpeGluZyB0aGlz IGV4cG9zZWQgdGhlIGZhY3QKKyAgICAgICAgdGhhdCB3ZSB3ZXJlIGFjY2lkZW50YWxseSBwYXNz aW5nIHRoZSB0ZXN0cyBiZWxvdyBvbiBJbnRlbC4KKworICAgICAgICBUaGlzIGNvbW1pdCBhZGRy ZXNzZXMgdGhlIGNhc3RpbmcgaXNzdWUgYW5kIG1hcmtzIHRoZSB0ZXN0cyBhcyBub3cgYWNjdXJh dGVseQorICAgICAgICBmYWlsaW5nLiBEZXRhaWxzIG9uIHRoZSBuZXcgYnVnIGF0OiB3ZWJraXQu b3JnL2IvMjA2NzUzCisKKyAgICAgICAgQ292ZXJlZCBieToKKyAgICAgICAgaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWJhY2tncm91bmRzL2JhY2tncm91bmQtc2l6ZS92 ZWN0b3IvdGFsbC0tY29udGFpbi0taGVpZ2h0Lmh0bWwKKyAgICAgICAgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWJhY2tncm91bmRzL2JhY2tncm91bmQtc2l6ZS92ZWN0 b3IvdGFsbC0tY29udGFpbi0td2lkdGguaHRtbAorICAgICAgICBpbXBvcnRlZC93M2Mvd2ViLXBs YXRmb3JtLXRlc3RzL2Nzcy9jc3MtYmFja2dyb3VuZHMvYmFja2dyb3VuZC1zaXplL3ZlY3Rvci93 aWRlLS1jb250YWluLS1oZWlnaHQuaHRtbAorICAgICAgICBpbXBvcnRlZC93M2Mvd2ViLXBsYXRm b3JtLXRlc3RzL2Nzcy9jc3MtYmFja2dyb3VuZHMvYmFja2dyb3VuZC1zaXplL3ZlY3Rvci93aWRl LS1jb250YWluLS13aWR0aC5odG1sCisKKyAgICAgICAgKiBzdmcvZ3JhcGhpY3MvU1ZHSW1hZ2Uu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHSW1hZ2U6OmNvbnRhaW5lclNpemUgY29uc3QpOiBE b24ndCBzdGF0aWNfY2FzdCBmcm9tIGZsb2F0IHRvIGludC4gUmF0aGVyLCB1c2UKKyAgICAgICAg dGhlIGV4cGxpY2l0IEludFNpemUgY29uc3RydWN0b3IuCisKIDIwMjAtMDgtMTEgIFRpbW90aHkg SGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIERlZmVycmVkIFdLVXNlclNj cmlwdHMgYXJlIGV4cG9uZW50aWFsbHkgaW5qZWN0ZWQgb24gcHJlbG9hZGVkIHBhZ2VzIHdpdGgg ZnJhbWVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKaW5kZXggMjg2 MzMwZTg3NTRmMjM4OTdmZjFmNTExZTlkNDI2ZWRmZWMzY2Q5Yi4uYmNmNzczMTIyMzgxMzdmY2Vm ZjMzNzFhMDY2Y2Y5ZjYwM2JiYzQyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL2dy YXBoaWNzL1NWR0ltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZH SW1hZ2UuY3BwCkBAIC0xNzAsMTEgKzE3MCwxMSBAQCBJbnRTaXplIFNWR0ltYWdlOjpjb250YWlu ZXJTaXplKCkgY29uc3QKICAgICBlbHNlCiAgICAgICAgIGN1cnJlbnRTaXplID0gcm9vdEVsZW1l bnQtPmN1cnJlbnRWaWV3Qm94UmVjdCgpLnNpemUoKTsKIAotICAgIGlmICghY3VycmVudFNpemUu aXNFbXB0eSgpKQotICAgICAgICByZXR1cm4gSW50U2l6ZShzdGF0aWNfY2FzdDxpbnQ+KGNlaWxm KGN1cnJlbnRTaXplLndpZHRoKCkpKSwgc3RhdGljX2Nhc3Q8aW50PihjZWlsZihjdXJyZW50U2l6 ZS5oZWlnaHQoKSkpKTsKKyAgICAvLyBVc2UgdGhlIGRlZmF1bHQgQ1NTIGludHJpbnNpYyBzaXpl IGlmIHRoZSBhYm92ZSBmYWlsZWQuCisgICAgaWYgKGN1cnJlbnRTaXplLmlzRW1wdHkoKSkKKyAg ICAgICAgcmV0dXJuIEludFNpemUoMzAwLCAxNTApOwogCi0gICAgLy8gQXMgbGFzdCByZXNvcnQs IHVzZSBDU1MgZGVmYXVsdCBpbnRyaW5zaWMgc2l6ZS4KLSAgICByZXR1cm4gSW50U2l6ZSgzMDAs IDE1MCk7CisgICAgcmV0dXJuIEludFNpemUoY3VycmVudFNpemUpOwogfQogCiBJbWFnZURyYXdS ZXN1bHQgU1ZHSW1hZ2U6OmRyYXdGb3JDb250YWluZXIoR3JhcGhpY3NDb250ZXh0JiBjb250ZXh0 LCBjb25zdCBGbG9hdFNpemUgY29udGFpbmVyU2l6ZSwgZmxvYXQgY29udGFpbmVyWm9vbSwgY29u c3QgVVJMJiBpbml0aWFsRnJhZ21lbnRVUkwsIGNvbnN0IEZsb2F0UmVjdCYgZHN0UmVjdCwKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCA2ZDUwMDI4OGM0NzllNjU3OTkyZjlhODM2M2Y4OTgyZTA0MjU1YWMwLi4wYzI3NTg1ZmYy NzEyNjc5ZDMyZTEwNzRkZWY2MDlhMWZmOTc3MzU0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIw MjAtMDgtMTQgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFtBUyBM YXlvdXQgVGVzdHNdIDYgV1BUIGNzcy1iYWNrZ3JvdW5kcyB0ZXN0cyBjb25zaXN0ZW50bHkgZmFp bGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1 NTMzCisgICAgICAgIHJkYXI6Ly82NjY2MDkyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczogTWFyayBzb21lIHRlc3Rz IGFzIGZhaWxpbmcuCisKIDIwMjAtMDgtMTEgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0dUS11bV1BFXSBSZWJhc2VsaW5lIG91dGRhdGVkIGJhc2VsaW5lcwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rl c3RFeHBlY3RhdGlvbnMKaW5kZXggYzZmOWI5MTEwMzliYjc2MjZlYmYwYTI2YTY2M2JlMWUwNmI3 ODFiMS4uYzY5NWVjOTFjZTVlNjVmYzNkYTFhNDBhZDU1Yzg3ZjQyNWUwMzQzNCAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhw ZWN0YXRpb25zCkBAIC0zNTU0LDcgKzM1NTQsNyBAQCB3ZWJraXQub3JnL2IvMjA2NzUzIGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1iYWNrZ3JvdW5kcy9iYWNrZ3JvdQog d2Via2l0Lm9yZy9iLzIwNjc1MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9j c3MtYmFja2dyb3VuZHMvYmFja2dyb3VuZC1zaXplL3ZlY3Rvci93aWRlLS1jb3Zlci0tcGVyY2Vu dC13aWR0aC1ub25wZXJjZW50LWhlaWdodC12aWV3Ym94Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJl IF0KIHdlYmtpdC5vcmcvYi8yMDY3NTMgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9j c3MvY3NzLWJhY2tncm91bmRzL2JhY2tncm91bmQtc2l6ZS92ZWN0b3Ivd2lkZS0tY292ZXItLXBl cmNlbnQtd2lkdGgtb21pdHRlZC1oZWlnaHQtdmlld2JveC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVy ZSBdCiB3ZWJraXQub3JnL2IvMjA2NzUzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv Y3NzL2Nzcy1iYWNrZ3JvdW5kcy9iYWNrZ3JvdW5kLXNpemUvdmVjdG9yL3dpZGUtLWNvdmVyLS1w ZXJjZW50LXdpZHRoLXBlcmNlbnQtaGVpZ2h0LXZpZXdib3guaHRtbCBbIEltYWdlT25seUZhaWx1 cmUgXQotd2Via2l0Lm9yZy9iLzIwNjc1MyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2Nzcy9jc3MtYmFja2dyb3VuZHMvYmFja2dyb3VuZC1zaXplL3ZlY3Rvci93aWRlLS1jb3Zlci0t d2lkdGguaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQord2Via2l0Lm9yZy9iLzIwNjc1MyBpbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtYmFja2dyb3VuZHMvYmFja2dyb3Vu ZC1zaXplL3ZlY3Rvci93aWRlLS1jb3Zlci0td2lkdGguaHRtbCBbIFBhc3MgSW1hZ2VPbmx5RmFp bHVyZSBdCiB3ZWJraXQub3JnL2IvMjA2NzUzIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVz dHMvY3NzL2Nzcy1iYWNrZ3JvdW5kcy9ib3JkZXItaW1hZ2UtcmVwZWF0LXJvdW5kLmh0bWwgWyBJ bWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMDY3NTMgaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWJhY2tncm91bmRzL2JvcmRlci1pbWFnZS1yb3VuZC1hbmQt c3RyZXRjaC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjA2NzUzIGlt cG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1iYWNrZ3JvdW5kcy9ib3JkZXIt aW1hZ2Utc2xpY2UtMDAzLnhodCBbIEltYWdlT25seUZhaWx1cmUgXQpAQCAtNDUyNiwzICs0NTI2 LDkgQEAgd2Via2l0Lm9yZy9iLzIxNDQ2NyBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2h0bWwvY2FudmFzL2VsZW1lbnQvZHJhd2luZy0KIAogIyBXZWJLaXQyIG9ubHkuCiBqcy90aHJv dy1sYXJnZS1zdHJpbmctb29tLmh0bWwgWyBTa2lwIF0KKword2Via2l0Lm9yZy9iLzIxNTUzMSBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtYmFja2dyb3VuZHMvYmFja2dy b3VuZC1zaXplL3ZlY3Rvci90YWxsLS1jb250YWluLS1oZWlnaHQuaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQord2Via2l0Lm9yZy9iLzIxNTUzMSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2Nzcy9jc3MtYmFja2dyb3VuZHMvYmFja2dyb3VuZC1zaXplL3ZlY3Rvci90YWxsLS1jb250 YWluLS13aWR0aC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMjE1NTMx IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1iYWNrZ3JvdW5kcy9iYWNr Z3JvdW5kLXNpemUvdmVjdG9yL3dpZGUtLWNvbnRhaW4tLWhlaWdodC5odG1sIFsgSW1hZ2VPbmx5 RmFpbHVyZSBdCit3ZWJraXQub3JnL2IvMjE1NTMxIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvY3NzL2Nzcy1iYWNrZ3JvdW5kcy9iYWNrZ3JvdW5kLXNpemUvdmVjdG9yL3dpZGUtLWNv bnRhaW4tLXdpZHRoLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KKwo=