215529 2020-08-14 18:13:54 -0700 Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s 2020-08-16 14:27:53 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cmarcelo ews-watchlist fred.wang ggaren jamesr luiz nham simon.fraser thorton tonikitoo webkit-bug-importer oldest_to_newest 1680550 0 simon.fraser 2020-08-14 18:13:54 -0700 Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s 1680552 1 406641 simon.fraser 2020-08-14 18:16:47 -0700 Created attachment 406641 Patch 1680554 2 simon.fraser 2020-08-14 18:17:53 -0700 <rdar://problem/66866163> 1680585 3 406641 ggaren 2020-08-14 21:15:42 -0700 Comment on attachment 406641 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406641&action=review r=me > Source/WebCore/page/scrolling/ScrollingTree.h:212 > + bool isRecentlyActive(); > + WEBCORE_EXPORT void setRecentlyActive(); Should we make these names more specific to wheel events? isProcessingWheelEvent() willProcessWheelEvent() > Source/WebCore/page/scrolling/ScrollingTree.h:278 > + Lock m_lastEventTimeMutex; > + MonotonicTime m_lastEventTime; Should we make these names more specific to wheel events? m_lastWheelEventTimeMutex m_lastWheelEventTime 1680595 4 simon.fraser 2020-08-14 22:14:14 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 406641 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406641&action=review > > r=me > > > Source/WebCore/page/scrolling/ScrollingTree.h:212 > > + bool isRecentlyActive(); > > + WEBCORE_EXPORT void setRecentlyActive(); > > Should we make these names more specific to wheel events? > > isProcessingWheelEvent() > willProcessWheelEvent() > > > Source/WebCore/page/scrolling/ScrollingTree.h:278 > > + Lock m_lastEventTimeMutex; > > + MonotonicTime m_lastEventTime; > > Should we make these names more specific to wheel events? > > m_lastWheelEventTimeMutex > m_lastWheelEventTime Perhaps, though the ScrollingThread exists only to process wheel events, so I don't feel the need to qualify further. 1680687 5 simon.fraser 2020-08-16 14:27:53 -0700 https://trac.webkit.org/changeset/265743/webkit 406641 2020-08-14 18:16:47 -0700 2020-08-14 21:15:42 -0700 Patch bug-215529-20200814181647.patch text/plain 6432 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDhmYzJjN2VjN2FiNjM4 MGJmM2I4NDdhZDdhNzk5Mjg5OWI5YTdiMC4uNDQ3MzczM2I1Nzk4NzA4OTJlOWQ3YzE4MGNlODIz N2U5YTE3MWE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA4LTE0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNjcm9sbGluZyBz eW5jIGNoYW5nZXMgaW4gcjI2MTk4NSByZWdyZXNzZWQgQ1BVIHVzYWdlIGJ5IH4yIG1zL3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNTUyOQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vNjY4NjYxNjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgcjI2MTk4NSBhZGRlZCB0d28gY29kZSBwYXRocyB0aGF0 IHdha2UgdXAgdGhlIHNjcm9sbGluZyB0aHJlYWQgb24gZXZlcnkKKyAgICAgICAgcmVuZGVyaW5n IHVwZGF0ZSAodHJpZ2dlcmVkIGJ5IGRpc3BsYXlEaWRSZWZyZXNoKCkpLiBPbmUgaXMgYSBwaW5n IGZyb20KKyAgICAgICAgdGhlIEV2ZW50RGlzcGF0Y2hlciB0aHJlYWQsIHRoZSBvdGhlciBpcyBh IHdha2UtYW5kLWJsb2NrIGZyb20gdGhlIG1haW4KKyAgICAgICAgdGhyZWFkLiBJZiB0aGUgc2Ny b2xsaW5nIHRocmVhZCBpc24ndCBhY3RpdmUgKG5vIHdoZWVsIGV2ZW50cyByZWNlaXZlZCByZWNl bnRseSksCisgICAgICAgIHdlIGNhbiBhdm9pZCBib3RoIG9mIHRoZXNlIHRvIHJlZHVjZSB0aGUg bnVtYmVyIG9mIENQVSBjb3JlIHdha2V1cHMuCisKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ1RyZWU6OmlzUmVj ZW50bHlBY3RpdmUpOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZTo6c2V0UmVjZW50 bHlBY3RpdmUpOgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuaDoKKyAg ICAgICAgKiBwYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6VGhyZWFkZWRTY3JvbGxpbmdUcmVlOjp3aWxsU3RhcnRSZW5kZXJpbmdVcGRh dGUpOgorICAgICAgICAoV2ViQ29yZTo6VGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpkaXNwbGF5RGlk UmVmcmVzaCk6CisKIDIwMjAtMDgtMTIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLCBhZGRyZXNzIHBvc3QtbGFuZGluZyByZXZpZXcgY29tbWVu dCBmcm9tIFNhbSBXZWluaWcgZm9yIHIyNjU1MzYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGM5ZjM3YmExZWM4MDNh ZDRkZGViNjE1N2IwY2E2NmE0YTUxNzY3NGQuLmJkZmI5MjZjNGU5Mjc4NjgzYmNhMGVmYmVjNzc0 ZGNjNmE2MDcwODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDgtMTQgIFNpbW9u IEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgU2Nyb2xsaW5nIHN5 bmMgY2hhbmdlcyBpbiByMjYxOTg1IHJlZ3Jlc3NlZCBDUFUgdXNhZ2UgYnkgfjIgbXMvcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1NTI5CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82Njg2NjE2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIHIyNjE5ODUgYWRkZWQgdHdvIGNvZGUgcGF0 aHMgdGhhdCB3YWtlIHVwIHRoZSBzY3JvbGxpbmcgdGhyZWFkIG9uIGV2ZXJ5CisgICAgICAgIHJl bmRlcmluZyB1cGRhdGUgKHRyaWdnZXJlZCBieSBkaXNwbGF5RGlkUmVmcmVzaCgpKS4gT25lIGlz IGEgcGluZyBmcm9tCisgICAgICAgIHRoZSBFdmVudERpc3BhdGNoZXIgdGhyZWFkLCB0aGUgb3Ro ZXIgaXMgYSB3YWtlLWFuZC1ibG9jayBmcm9tIHRoZSBtYWluCisgICAgICAgIHRocmVhZC4gSWYg dGhlIHNjcm9sbGluZyB0aHJlYWQgaXNuJ3QgYWN0aXZlIChubyB3aGVlbCBldmVudHMgcmVjZWl2 ZWQgcmVjZW50bHkpLAorICAgICAgICB3ZSBjYW4gYXZvaWQgYm90aCBvZiB0aGVzZSB0byByZWR1 Y2UgdGhlIG51bWJlciBvZiBDUFUgY29yZSB3YWtldXBzLgorCisgICAgICAgICogV2ViUHJvY2Vz cy9XZWJQYWdlL0V2ZW50RGlzcGF0Y2hlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkV2ZW50RGlz cGF0Y2hlcjo6d2hlZWxFdmVudCk6CisKIDIwMjAtMDgtMTIgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlZnJlc2ggV3JpdGFibGVTdHJlYW0gdXAgdG8gc3Bl YwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJl ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmNwcApp bmRleCBjMmJiMTRlMGM4M2I0N2JjZWZkNTI4YWM1MjM2ZGQzYjZhNTJhZDk4Li42YzBhMWM5ZDhh NDM2NDQ3ZmJmNWVhMWIzNjUzYTU3ZGRkNzc2Y2MzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmNwcApAQCAtNjAwLDYgKzYwMCwyMCBAQCBQbGF0 Zm9ybURpc3BsYXlJRCBTY3JvbGxpbmdUcmVlOjpkaXNwbGF5SUQoKQogICAgIHJldHVybiBtX3Ry ZWVTdGF0ZS5kaXNwbGF5SUQ7CiB9CiAKK2Jvb2wgU2Nyb2xsaW5nVHJlZTo6aXNSZWNlbnRseUFj dGl2ZSgpCit7CisgICAgTG9ja0hvbGRlciBsb2NrZXIobV9sYXN0RXZlbnRUaW1lTXV0ZXgpOwor ICAgIGNvbnN0ZXhwciBhdXRvIGFjdGl2aXR5SW50ZXJ2YWwgPSA1MF9tczsgLy8gRHVyYXRpb24g b2YgYSBmZXcgZnJhbWVzIHNvIHRoYXQgd2Ugc3RheSBhY3RpdmUgZm9yIHNlcXVlbmNlIG9mIHdo ZWVsIGV2ZW50cy4KKyAgICAKKyAgICByZXR1cm4gKE1vbm90b25pY1RpbWU6Om5vdygpIC0gbV9s YXN0RXZlbnRUaW1lKSA8IGFjdGl2aXR5SW50ZXJ2YWw7Cit9CisKK3ZvaWQgU2Nyb2xsaW5nVHJl ZTo6c2V0UmVjZW50bHlBY3RpdmUoKQoreworICAgIExvY2tIb2xkZXIgbG9ja2VyKG1fbGFzdEV2 ZW50VGltZU11dGV4KTsKKyAgICBtX2xhc3RFdmVudFRpbWUgPSBNb25vdG9uaWNUaW1lOjpub3co KTsKK30KKwogT3B0aW9uYWw8dW5zaWduZWQ+IFNjcm9sbGluZ1RyZWU6Om5vbWluYWxGcmFtZXNQ ZXJTZWNvbmQoKQogewogICAgIExvY2tIb2xkZXIgbG9ja2VyKG1fdHJlZVN0YXRlTXV0ZXgpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5o IGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZS5oCmluZGV4IDFi ODQ1MDdiZWE1MGZmM2Y5YWVhNTQ3MWRmOWE1NGZiNzljNDY4MDguLmFmODkwNGUxMmNlNGZmZTk4 OWM5ZmM2Mjk4MGJhOThlMTU1NDY2MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9s bGluZy9TY3JvbGxpbmdUcmVlLmgKQEAgLTIwNyw2ICsyMDcsOSBAQCBwdWJsaWM6CiAKICAgICB2 b2lkIHdpbmRvd1NjcmVlbkRpZENoYW5nZShQbGF0Zm9ybURpc3BsYXlJRCwgT3B0aW9uYWw8dW5z aWduZWQ+IG5vbWluYWxGcmFtZXNQZXJTZWNvbmQpOwogICAgIFBsYXRmb3JtRGlzcGxheUlEIGRp c3BsYXlJRCgpOworICAgIAorICAgIGJvb2wgaXNSZWNlbnRseUFjdGl2ZSgpOworICAgIFdFQkNP UkVfRVhQT1JUIHZvaWQgc2V0UmVjZW50bHlBY3RpdmUoKTsKIAogcHJvdGVjdGVkOgogICAgIEZs b2F0UG9pbnQgbWFpbkZyYW1lU2Nyb2xsUG9zaXRpb24oKSBjb25zdDsKQEAgLTI3MSw2ICsyNzQs OSBAQCBwcml2YXRlOgogICAgIExvY2sgbV9zd2lwZVN0YXRlTXV0ZXg7CiAgICAgU3dpcGVTdGF0 ZSBtX3N3aXBlU3RhdGU7CiAKKyAgICBMb2NrIG1fbGFzdEV2ZW50VGltZU11dGV4OworICAgIE1v bm90b25pY1RpbWUgbV9sYXN0RXZlbnRUaW1lOworCiBwcm90ZWN0ZWQ6CiAgICAgYm9vbCBtX2Fs bG93TGF0Y2hpbmcgeyB0cnVlIH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwCmluZGV4IGM2N2M5MmU2OWU0ODUw OWZhZGZiOWFkMWE4OGE4ZDAzNjY1YmFjOTAuLjE3MWU5M2IzODlkZDRlY2RjYTI4M2YxMzk4OTE3 ODM0OTZjOTVjMDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Ro cmVhZGVkU2Nyb2xsaW5nVHJlZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxp bmcvVGhyZWFkZWRTY3JvbGxpbmdUcmVlLmNwcApAQCAtMjA0LDYgKzIwNCw5IEBAIHZvaWQgVGhy ZWFkZWRTY3JvbGxpbmdUcmVlOjp3aWxsU3RhcnRSZW5kZXJpbmdVcGRhdGUoKQogewogICAgIEFT U0VSVChpc01haW5UaHJlYWQoKSk7CiAKKyAgICBpZiAoIWlzUmVjZW50bHlBY3RpdmUoKSkKKyAg ICAgICAgcmV0dXJuOworCiAgICAgdHJhY2VQb2ludChTY3JvbGxpbmdUaHJlYWRSZW5kZXJVcGRh dGVTeW5jU3RhcnQpOwogCiAgICAgLy8gV2FpdCBmb3IgdGhlIHNjcm9sbGluZyB0aHJlYWQgdG8g YWNxdWlyZSBtX3RyZWVNdXRleC4gVGhpcyBlbnN1cmVzIHRoYXQgYW55IHBlbmRpbmcgd2hlZWwg ZXZlbnRzIGFyZSBwcm9jZXNzZWQuCkBAIC0zMTUsMTYgKzMxOCwxNyBAQCB2b2lkIFRocmVhZGVk U2Nyb2xsaW5nVHJlZTo6ZGlzcGxheURpZFJlZnJlc2hPblNjcm9sbGluZ1RocmVhZCgpCiAKIHZv aWQgVGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpkaXNwbGF5RGlkUmVmcmVzaChQbGF0Zm9ybURpc3Bs YXlJRCBkaXNwbGF5SUQpCiB7CisgICAgLy8gV2UncmUgb24gdGhlIEV2ZW50RGlzcGF0Y2hlciB0 aHJlYWQgaGVyZS4KKwogICAgIGlmIChkaXNwbGF5SUQgIT0gdGhpcy0+ZGlzcGxheUlEKCkpCiAg ICAgICAgIHJldHVybjsKKyAgICAKKyAgICBpZiAoIWlzUmVjZW50bHlBY3RpdmUoKSkKKyAgICAg ICAgcmV0dXJuOwogCi0gICAgLy8gV2UncmUgb24gdGhlIEV2ZW50RGlzcGF0Y2hlciB0aHJlYWQg aGVyZS4KLQotI2lmIEVOQUJMRShTQ1JPTExJTkdfVEhSRUFEKQogICAgIFNjcm9sbGluZ1RocmVh ZDo6ZGlzcGF0Y2goW3Byb3RlY3RlZFRoaXMgPSBtYWtlUmVmKCp0aGlzKV0oKSB7CiAgICAgICAg IHByb3RlY3RlZFRoaXMtPmRpc3BsYXlEaWRSZWZyZXNoT25TY3JvbGxpbmdUaHJlYWQoKTsKICAg ICB9KTsKLSNlbmRpZgogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3BwIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvRXZlbnREaXNwYXRjaGVyLmNwcAppbmRleCA0 NTQyZmM2YzFjODkwZjFhZWYwNDE2MDYwNWI2MDk4YjIxNDc0YzdiLi5kMjAxNzNmODcxMjAwM2Uz N2ZlMGZiNDc5MDM4NmZmNjgyZTE4MjgxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJQYWdlL0V2ZW50RGlzcGF0Y2hlci5jcHAKQEAgLTEzOSw2ICsxMzksOCBAQCB2 b2lkIEV2ZW50RGlzcGF0Y2hlcjo6d2hlZWxFdmVudChQYWdlSWRlbnRpZmllciBwYWdlSUQsIGNv bnN0IFdlYldoZWVsRXZlbnQmIHdoZQogICAgICAgICBpZiAoIXByb2Nlc3NpbmdTdGVwcy5jb250 YWlucyhXaGVlbEV2ZW50UHJvY2Vzc2luZ1N0ZXBzOjpTY3JvbGxpbmdUaHJlYWQpKQogICAgICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgICAgIHNjcm9sbGluZ1RyZWUtPnNldFJlY2VudGx5 QWN0aXZlKCk7CisKICAgICAgICAgU2Nyb2xsaW5nVGhyZWFkOjpkaXNwYXRjaChbc2Nyb2xsaW5n VHJlZSwgd2hlZWxFdmVudCwgcGxhdGZvcm1XaGVlbEV2ZW50LCBwYWdlSUQsIHByb3RlY3RlZFRo aXMgPSBtYWtlUmVmKCp0aGlzKV0gewogICAgICAgICAgICAgYXV0byByZXN1bHQgPSBzY3JvbGxp bmdUcmVlLT5oYW5kbGVXaGVlbEV2ZW50KHBsYXRmb3JtV2hlZWxFdmVudCk7CiAK