215519 2020-08-14 11:50:19 -0700 Use closeReason provided in didCloseWithCode delegate for the NSURLSessionWebSocket code path 2020-08-21 12:16:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jmehta webkit-unassigned achristensen webkit-bug-importer youennf oldest_to_newest 1680383 0 jmehta 2020-08-14 11:50:19 -0700 Use closeReason provided in didCloseWithCode delegate. Currently we're looking at the task's closeReason (which is not wrong), but making sure that we use the close code and reason provided in the delegate callback to ensure there is no weird bug that we hit in the future 1680384 1 406612 jmehta 2020-08-14 11:51:09 -0700 Created attachment 406612 Using the closeReason in the delegate 1680408 2 406612 achristensen 2020-08-14 12:38:20 -0700 Comment on attachment 406612 Using the closeReason in the delegate View in context: https://bugs.webkit.org/attachment.cgi?id=406612&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1021 > + auto closeReason = adoptNS([[NSString alloc] initWithData:reason encoding:NSUTF8StringEncoding]); ASSERT([reason isEqualToData:task.closeReason]); That'll catch these future bugs you mentioned. 1680413 3 jmehta 2020-08-14 13:02:03 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 406612 [details] > Using the closeReason in the delegate > > View in context: > https://bugs.webkit.org/attachment.cgi?id=406612&action=review > > > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1021 > > + auto closeReason = adoptNS([[NSString alloc] initWithData:reason encoding:NSUTF8StringEncoding]); > > ASSERT([reason isEqualToData:task.closeReason]); > That'll catch these future bugs you mentioned. That sounds good 1681887 4 406984 jmehta 2020-08-20 17:43:20 -0700 Created attachment 406984 Updating patch to add assertions and ChangeLog 1682008 5 webkit-bug-importer 2020-08-21 11:51:14 -0700 <rdar://problem/67570472> 1682011 6 ews-feeder 2020-08-21 12:16:36 -0700 Committed r266011: <https://trac.webkit.org/changeset/266011> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406984. 406612 2020-08-14 11:51:09 -0700 2020-08-20 17:43:20 -0700 Using the closeReason in the delegate file_215519.txt text/plain 1023 jmehta ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nl c3Npb25Db2NvYS5tbSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29y a1Nlc3Npb25Db2NvYS5tbQ0KaW5kZXggNzhmZDJkMjM1ZTguLjNkODcyNThmOWMyIDEwMDY0NA0K LS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNv Y29hLm1tDQorKysgYi9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtT ZXNzaW9uQ29jb2EubW0NCkBAIC0xMDE4LDggKzEwMTgsOCBAQCBzdGF0aWMgaW5saW5lIHZvaWQg cHJvY2Vzc1NlcnZlclRydXN0RXZhbHVhdGlvbihOZXR3b3JrU2Vzc2lvbkNvY29hJiBzZXNzaW9u LCBTZQ0KIC0gKHZvaWQpVVJMU2Vzc2lvbjooTlNVUkxTZXNzaW9uICopc2Vzc2lvbiB3ZWJTb2Nr ZXRUYXNrOihOU1VSTFNlc3Npb25XZWJTb2NrZXRUYXNrICopdGFzayBkaWRDbG9zZVdpdGhDb2Rl OihOU1VSTFNlc3Npb25XZWJTb2NrZXRDbG9zZUNvZGUpY2xvc2VDb2RlIHJlYXNvbjooTlNEYXRh ICopcmVhc29uDQogew0KICAgICBpZiAoYXV0byogd2ViU29ja2V0VGFzayA9IFtzZWxmIGV4aXN0 aW5nV2ViU29ja2V0VGFzazp0YXNrXSkgew0KLSAgICAgICAgYXV0byByZWFzb24gPSBhZG9wdE5T KFtbTlNTdHJpbmcgYWxsb2NdIGluaXRXaXRoRGF0YTpbdGFzayBjbG9zZVJlYXNvbl0gZW5jb2Rp bmc6TlNVVEY4U3RyaW5nRW5jb2RpbmddKTsNCi0gICAgICAgIHdlYlNvY2tldFRhc2stPmRpZENs b3NlKGNsb3NlQ29kZSwgcmVhc29uLmdldCgpKTsNCisgICAgICAgIGF1dG8gY2xvc2VSZWFzb24g PSBhZG9wdE5TKFtbTlNTdHJpbmcgYWxsb2NdIGluaXRXaXRoRGF0YTpyZWFzb24gZW5jb2Rpbmc6 TlNVVEY4U3RyaW5nRW5jb2RpbmddKTsNCisgICAgICAgIHdlYlNvY2tldFRhc2stPmRpZENsb3Nl KGNsb3NlQ29kZSwgY2xvc2VSZWFzb24uZ2V0KCkpOw0KICAgICB9DQogfQ0KICNlbmRpZg0K 406984 2020-08-20 17:43:20 -0700 2020-08-21 12:16:37 -0700 Updating patch to add assertions and ChangeLog file_215519.txt text/plain 2241 jmehta Y29tbWl0IDgxYzg0YjI3ZWIwNTA3ZjJkMjRiNDhmYzA0ZjdiZWZiYTFmNTNjYTYNCkF1dGhvcjog Sml0ZW4gTWVodGEgPGptZWh0YUBhcHBsZS5jb20+DQpEYXRlOiAgIFRodSBBdWcgMjAgMTQ6MjM6 MTYgMjAyMCAtMDcwMA0KDQogICAgIFVzZSBjbG9zZVJlYXNvbiBwcm92aWRlZCBpbiBkaWRDbG9z ZVdpdGhDb2RlIGRlbGVnYXRlIGZvciB0aGUgTlNVUkxTZXNzaW9uV2ViU29ja2V0IGNvZGUgcGF0 aA0KDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZw0KaW5kZXggNjMwZGM0NTg1NzIuLmJkZGE3MmI3ODBlIDEwMDY0NA0KLS0tIGEv U291cmNlL1dlYktpdC9DaGFuZ2VMb2cNCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nDQpA QCAtMSwzICsxLDE2IEBADQorMjAyMC0wOC0yMCAgSml0ZW4gTWVodGEgIDxqbWVodGFAYXBwbGUu Y29tPg0KKw0KKyAgICAgICAgVXNlIGNsb3NlUmVhc29uIHByb3ZpZGVkIGluIGRpZENsb3NlV2l0 aENvZGUgZGVsZWdhdGUgZm9yIHRoZSBOU1VSTFNlc3Npb25XZWJTb2NrZXQgY29kZSBwYXRoDQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1NTE5DQor DQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisNCisgICAgICAgIENvdmVy ZWQgYnkgZXhpc3RpbmcgcHJvdG9jb2wgdGVzdHMgd2l0aCBOU1VSTFNlc3Npb24gY29kZSBwYXRo IGVuYWJsZWQuDQorICAgICAgICBodHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL3dvcmtl cnMvY2xvc2UtY29kZS1hbmQtcmVhc29uLmh0bWwNCisNCisgICAgICAgICogTmV0d29ya1Byb2Nl c3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbToNCisgICAgICAgICgtW1dLTmV0d29ya1Nl c3Npb25EZWxlZ2F0ZSBVUkxTZXNzaW9uOndlYlNvY2tldFRhc2s6ZGlkQ2xvc2VXaXRoQ29kZTpy ZWFzb246XSk6DQorDQogMjAyMC0wNy0xMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29t Pg0KIA0KICAgICAgICAgQWRkIG1vcmUgbG9nZ2luZyBmb3IgbmF2aWdhdGlvbiBwb2xpY3kgZGVj aXNpb25zIG9uIFVJUHJvY2VzcyBzaWRlDQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3 b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tIGIvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tDQppbmRleCA3OGZkMmQy MzVlOC4uMmRiYzk1NmFlNjUgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9j ZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0NCisrKyBiL1NvdXJjZS9XZWJLaXQvTmV0 d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5tbQ0KQEAgLTEwMTgsOCArMTAx OCwxMCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgcHJvY2Vzc1NlcnZlclRydXN0RXZhbHVhdGlvbihO ZXR3b3JrU2Vzc2lvbkNvY29hJiBzZXNzaW9uLCBTZQ0KIC0gKHZvaWQpVVJMU2Vzc2lvbjooTlNV UkxTZXNzaW9uICopc2Vzc2lvbiB3ZWJTb2NrZXRUYXNrOihOU1VSTFNlc3Npb25XZWJTb2NrZXRU YXNrICopdGFzayBkaWRDbG9zZVdpdGhDb2RlOihOU1VSTFNlc3Npb25XZWJTb2NrZXRDbG9zZUNv ZGUpY2xvc2VDb2RlIHJlYXNvbjooTlNEYXRhICopcmVhc29uDQogew0KICAgICBpZiAoYXV0byog d2ViU29ja2V0VGFzayA9IFtzZWxmIGV4aXN0aW5nV2ViU29ja2V0VGFzazp0YXNrXSkgew0KLSAg ICAgICAgYXV0byByZWFzb24gPSBhZG9wdE5TKFtbTlNTdHJpbmcgYWxsb2NdIGluaXRXaXRoRGF0 YTpbdGFzayBjbG9zZVJlYXNvbl0gZW5jb2Rpbmc6TlNVVEY4U3RyaW5nRW5jb2RpbmddKTsNCi0g ICAgICAgIHdlYlNvY2tldFRhc2stPmRpZENsb3NlKGNsb3NlQ29kZSwgcmVhc29uLmdldCgpKTsN CisgICAgICAgIEFTU0VSVChbcmVhc29uIGlzRXF1YWxUb0RhdGE6dGFzay5jbG9zZVJlYXNvbl0p Ow0KKyAgICAgICAgQVNTRVJUKGNsb3NlQ29kZSA9PSBbdGFzayBjbG9zZUNvZGVdKTsNCisgICAg ICAgIGF1dG8gY2xvc2VSZWFzb24gPSBhZG9wdE5TKFtbTlNTdHJpbmcgYWxsb2NdIGluaXRXaXRo RGF0YTpyZWFzb24gZW5jb2Rpbmc6TlNVVEY4U3RyaW5nRW5jb2RpbmddKTsNCisgICAgICAgIHdl YlNvY2tldFRhc2stPmRpZENsb3NlKGNsb3NlQ29kZSwgY2xvc2VSZWFzb24uZ2V0KCkpOw0KICAg ICB9DQogfQ0KICNlbmRpZg0K