215512 2020-08-14 10:26:27 -0700 [ARMv7][JSC] Conservative GC is not considering `r7` as a root 2020-08-14 12:14:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1680316 0 ticaiolima 2020-08-14 10:26:27 -0700 We need to consider callee-saved registers as a root for conservative GC, but we are skipping `r7` on ARMv7. 1680330 1 406603 ticaiolima 2020-08-14 10:38:50 -0700 Created attachment 406603 Patch 1680331 2 ticaiolima 2020-08-14 10:40:30 -0700 The motivation for this patch is a crash on WPE 2.22 <https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/655>. 1680333 3 406603 ysuzuki 2020-08-14 10:43:12 -0700 Comment on attachment 406603 Patch r=me 1680335 4 406603 mark.lam 2020-08-14 10:43:41 -0700 Comment on attachment 406603 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406603&action=review > Source/JavaScriptCore/ChangeLog:8 > + Since `r7` is a calle-saved register on ARMv7 /calle/callee/ 1680381 5 406611 ticaiolima 2020-08-14 11:47:49 -0700 Created attachment 406611 Patch 1680399 6 ews-feeder 2020-08-14 12:13:26 -0700 Committed r265692: <https://trac.webkit.org/changeset/265692> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406611. 1680400 7 webkit-bug-importer 2020-08-14 12:14:18 -0700 <rdar://problem/67088331> 406603 2020-08-14 10:38:50 -0700 2020-08-14 11:47:44 -0700 Patch bug-215512-20200814143848.patch text/plain 1788 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1Njc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NTIyNDhjOGI5ZDI0NTJjYzQ3NTMzZGRiYWI1MGY1ZWYwZGNmMjYxLi43YTczNGUwODA1ODIxNWY3 MTIwZmIyMTBiMjlmMTQwN2E0M2FhM2E0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAyMC0wOC0xNCAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0FSTXY3XVtKU0NdIFdlIGNvbnNlcnZhdGl2ZSBHQyBpcyBub3QgY29uc2lk ZXJpbmcgYHI3YCBhcyBhIHJvb3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxNTUxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFNpbmNlIGByN2AgaXMgYSBjYWxsZS1zYXZlZCByZWdpc3RlciBvbiBBUk12 NworICAgICAgICB3ZSBuZWVkIHRvIGNvbnNpZGVyIGl0IGFzIGEgY29uc2VydmF0aXZlIHJvb3Qu CisKKyAgICAgICAgU2VlIHRoZSBzdGF0ZW1lbnQgIkEgc3Vicm91dGluZSBtdXN0IHByZXNlcnZl CisgICAgICAgIHRoZSBjb250ZW50cyBvZiB0aGUgcmVnaXN0ZXJzIHI0LXI4LCByMTAsIHIxMQor ICAgICAgICBhbmQgU1AgKGFuZCByOSBpbiBQQ1MgdmFyaWFudHMgdGhhdCBkZXNpZ25hdGUKKyAg ICAgICAgcjkgYXMgdjYpIGZvcm0gcGFnZSAxNSBvZgorICAgICAgICBodHRwczovL2RldmVsb3Bl ci5hcm0uY29tL2RvY3VtZW50YXRpb24vaWhpMDA0Mi9mLy4KKworICAgICAgICAqIGhlYXAvUmVn aXN0ZXJTdGF0ZS5oOgorCiAyMDIwLTA4LTEzICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KIAogICAgICAgICBDYWNoZSBTdHJ1Y3R1cmU6OmF0dHJpYnV0ZUNoYW5nZVRy YW5zaXRpb24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvUmVnaXN0 ZXJTdGF0ZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvUmVnaXN0ZXJTdGF0ZS5oCmlu ZGV4IGIzMDM3ZGJhMThjZjRkOWJjNWFiNWMyNTE2OGQ3NjcwYTU3MzFkMjkuLjQxZGUxZjY4OWY4 MDA2YWM3MzBiZDVkZTk2ZTdmOTQ3ODAzMmU2ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9oZWFwL1JlZ2lzdGVyU3RhdGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aGVhcC9SZWdpc3RlclN0YXRlLmgKQEAgLTc4LDYgKzc4LDcgQEAgc3RydWN0IFJlZ2lzdGVyU3Rh dGUgewogICAgIHVpbnQzMl90IHI0OwogICAgIHVpbnQzMl90IHI1OwogICAgIHVpbnQzMl90IHI2 OworICAgIHVpbnQzMl90IHI3OwogICAgIHVpbnQzMl90IHI4OwogICAgIHVpbnQzMl90IHI5Owog ICAgIHVpbnQzMl90IHIxMDsKQEAgLTkyLDYgKzkzLDcgQEAgc3RydWN0IFJlZ2lzdGVyU3RhdGUg ewogICAgIFNBVkVfUkVHKHI0LCByZWdpc3RlcnMucjQpOyBcCiAgICAgU0FWRV9SRUcocjUsIHJl Z2lzdGVycy5yNSk7IFwKICAgICBTQVZFX1JFRyhyNiwgcmVnaXN0ZXJzLnI2KTsgXAorICAgIFNB VkVfUkVHKHI3LCByZWdpc3RlcnMucjcpOyBcCiAgICAgU0FWRV9SRUcocjgsIHJlZ2lzdGVycy5y OCk7IFwKICAgICBTQVZFX1JFRyhyOSwgcmVnaXN0ZXJzLnI5KTsgXAogICAgIFNBVkVfUkVHKHIx MCwgcmVnaXN0ZXJzLnIxMCk7IFwK 406611 2020-08-14 11:47:49 -0700 2020-08-14 12:13:26 -0700 Patch bug-215512-20200814154747.patch text/plain 1785 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1Njc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NTIyNDhjOGI5ZDI0NTJjYzQ3NTMzZGRiYWI1MGY1ZWYwZGNmMjYxLi5kZTljOGZmMzA4MTVlODEy N2I0MGVhZDIzYzNmZGNkNGEyNjE0MjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAyMC0wOC0xNCAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0FSTXY3XVtKU0NdIENvbnNlcnZhdGl2ZSBHQyBpcyBub3QgY29uc2lkZXJp bmcgYHI3YCBhcyBhIHJvb3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxNTUxMgorCisgICAgICAgIFJldmlld2VkIGJ5IFl1c3VrZSBTdXp1a2kuCisK KyAgICAgICAgU2luY2UgYHI3YCBpcyBhIGNhbGxlZS1zYXZlZCByZWdpc3RlciBvbiBBUk12Nwor ICAgICAgICB3ZSBuZWVkIHRvIGNvbnNpZGVyIGl0IGFzIGEgY29uc2VydmF0aXZlIHJvb3QuCisK KyAgICAgICAgU2VlIHRoZSBzdGF0ZW1lbnQgIkEgc3Vicm91dGluZSBtdXN0IHByZXNlcnZlCisg ICAgICAgIHRoZSBjb250ZW50cyBvZiB0aGUgcmVnaXN0ZXJzIHI0LXI4LCByMTAsIHIxMQorICAg ICAgICBhbmQgU1AgKGFuZCByOSBpbiBQQ1MgdmFyaWFudHMgdGhhdCBkZXNpZ25hdGUKKyAgICAg ICAgcjkgYXMgdjYpIGZvcm0gcGFnZSAxNSBvZgorICAgICAgICBodHRwczovL2RldmVsb3Blci5h cm0uY29tL2RvY3VtZW50YXRpb24vaWhpMDA0Mi9mLy4KKworICAgICAgICAqIGhlYXAvUmVnaXN0 ZXJTdGF0ZS5oOgorCiAyMDIwLTA4LTEzICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdt YWlsLmNvbT4KIAogICAgICAgICBDYWNoZSBTdHJ1Y3R1cmU6OmF0dHJpYnV0ZUNoYW5nZVRyYW5z aXRpb24oKQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvUmVnaXN0ZXJT dGF0ZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvUmVnaXN0ZXJTdGF0ZS5oCmluZGV4 IGIzMDM3ZGJhMThjZjRkOWJjNWFiNWMyNTE2OGQ3NjcwYTU3MzFkMjkuLjQxZGUxZjY4OWY4MDA2 YWM3MzBiZDVkZTk2ZTdmOTQ3ODAzMmU2ODYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL1JlZ2lzdGVyU3RhdGUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9SZWdpc3RlclN0YXRlLmgKQEAgLTc4LDYgKzc4LDcgQEAgc3RydWN0IFJlZ2lzdGVyU3RhdGUg ewogICAgIHVpbnQzMl90IHI0OwogICAgIHVpbnQzMl90IHI1OwogICAgIHVpbnQzMl90IHI2Owor ICAgIHVpbnQzMl90IHI3OwogICAgIHVpbnQzMl90IHI4OwogICAgIHVpbnQzMl90IHI5OwogICAg IHVpbnQzMl90IHIxMDsKQEAgLTkyLDYgKzkzLDcgQEAgc3RydWN0IFJlZ2lzdGVyU3RhdGUgewog ICAgIFNBVkVfUkVHKHI0LCByZWdpc3RlcnMucjQpOyBcCiAgICAgU0FWRV9SRUcocjUsIHJlZ2lz dGVycy5yNSk7IFwKICAgICBTQVZFX1JFRyhyNiwgcmVnaXN0ZXJzLnI2KTsgXAorICAgIFNBVkVf UkVHKHI3LCByZWdpc3RlcnMucjcpOyBcCiAgICAgU0FWRV9SRUcocjgsIHJlZ2lzdGVycy5yOCk7 IFwKICAgICBTQVZFX1JFRyhyOSwgcmVnaXN0ZXJzLnI5KTsgXAogICAgIFNBVkVfUkVHKHIxMCwg cmVnaXN0ZXJzLnIxMCk7IFwK