215488 2020-08-13 20:25:01 -0700 The PiP button on the fullscreen youtube player disappears after starting a new video in a playlist 2020-08-14 16:36:30 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build iPhone / iPad Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=215526 InRadar P2 Normal --- 1 peng.liu6 peng.liu6 darin eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1680201 0 peng.liu6 2020-08-13 20:25:01 -0700 The PiP button on the fullscreen youtube player disappears after starting a new video in a playlist 1680202 1 webkit-bug-importer 2020-08-13 20:25:51 -0700 <rdar://problem/67039225> 1680214 2 406570 peng.liu6 2020-08-13 21:13:57 -0700 Created attachment 406570 Patch 1680236 3 406577 peng.liu6 2020-08-14 00:15:54 -0700 Created attachment 406577 update the change log 1680377 4 406577 eric.carlson 2020-08-14 11:33:28 -0700 Comment on attachment 406577 update the change log Great ChangeLog! 1680393 5 ews-feeder 2020-08-14 11:57:30 -0700 Committed r265690: <https://trac.webkit.org/changeset/265690> All reviewed patches have been landed. Closing bug and clearing flags on attachment 406577. 1680480 6 406577 darin 2020-08-14 15:37:18 -0700 Comment on attachment 406577 update the change log View in context: https://bugs.webkit.org/attachment.cgi?id=406577&action=review > Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:73 > - if (m_mediaElement == mediaElement) > + if (m_mediaElement == mediaElement) { > + if (m_mediaElement) { > + for (auto client : m_clients) > + client->isPictureInPictureSupportedChanged(isPictureInPictureSupported()); > + } > return; > + } Adding this guaranteed side effect of this function seems like a difficult-to-maintain oblique way to fix this, especially since there is no regression test. I’d like us to find a way to make a regression test. I’d also like to make this not depend on side effects like this. Requiring that setting something to an existing value has a side effect means the function should probably be named differently and is not a simple setter. So one solution would be to rename the function. 1680519 7 406577 peng.liu6 2020-08-14 16:36:07 -0700 Comment on attachment 406577 update the change log View in context: https://bugs.webkit.org/attachment.cgi?id=406577&action=review >> Source/WebCore/platform/cocoa/PlaybackSessionModelMediaElement.mm:73 >> + } > > Adding this guaranteed side effect of this function seems like a difficult-to-maintain oblique way to fix this, especially since there is no regression test. > > I’d like us to find a way to make a regression test. > > I’d also like to make this not depend on side effects like this. Requiring that setting something to an existing value has a side effect means the function should probably be named differently and is not a simple setter. So one solution would be to rename the function. Agree. Filed bug 215526 to track the task. 406570 2020-08-13 21:13:57 -0700 2020-08-14 00:15:53 -0700 Patch bug-215488-20200813211356.patch text/plain 3376 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDllYTllY2E1NWFjYWEy Y2U3ODViZWM1MWE3MDQxNjYyMjdhMGU4ZS4uODcyNzlmYzlmOTE2ZjA5YzA2YTkwY2EzNTQ0M2Ji NTM4NzU4ZGE1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDIwLTA4LTEzICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIFBpUCBidXR0b24gb24g dGhlIGZ1bGxzY3JlZW4geW91dHViZSBwbGF5ZXIgZGlzYXBwZWFycyBhZnRlciBzdGFydGluZyBh IG5ldyB2aWRlbyBpbiBhIHBsYXlsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTU0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXaGVuIGEgZnVsbHNjcmVlbiB2aWRlbyBwbGF5ZXIgKGUuZy4sIFlv dVR1YmUuY29tKSBzdGFydHMgYSBuZXcgdmlkZW8gaW4gYSBwbGF5bGlzdCwKKyAgICAgICAgaXQg bWF5IHJldXNlIHRoZSB2aWRlbyBlbGVtZW50LCBzbyBtX21lZGlhRWxlbWVudCBvZiB0aGUgUGxh eWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQKKyAgICAgICAgaW5zdGFuY2Ugd29uJ3QgY2hh bmdlLiBIb3dldmVyLCB0aGUgdmlkZW8gZWxlbWVudCB3aWxsIGV4aXQgdmlkZW8gZnVsbHNjcmVl biBzdGFuZGJ5CisgICAgICAgIGFuZCB0aGVuIGVudGVyIHZpZGVvIGZ1bGxzY3JlZW4gc3RhbmRi eS4gVGhvc2UgdHJhbnNpdGlvbnMgYXJlIGludmlzaWJsZSB0byB1c2Vycy4KKyAgICAgICAgQnV0 IHRoZSBjb3JyZXNwb25kaW5nIFBsYXliYWNrU2Vzc2lvbk1vZGVsQ29udGV4dCBpbnN0YW5jZSB3 aWxsIGJlIGRlc3Ryb3llZCBhbmQgYSBuZXcKKyAgICAgICAgaW5zdGFuY2Ugd2lsbCBiZSBjcmVh dGVkLgorCisgICAgICAgIEJ5IGRlZmF1bHQsIHRoZSBtZW1iZXIgdmFyaWFibGUgbV9waWN0dXJl SW5QaWN0dXJlU3VwcG9ydGVkIG9mIHRoZSBQbGF5YmFja1Nlc3Npb25Nb2RlbENvbnRleHQKKyAg ICAgICAgaW5zdGFuY2UgaXMgZmFsc2UuIEFmdGVyIGEgbmV3IHZpZGVvIHN0YXJ0cyB0byBwbGF5 LCB0aGUgZnVuY3Rpb24KKyAgICAgICAgUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQ6 OnNldE1lZGlhRWxlbWVudCgpIHdvbid0IGFzayB0aGUgUGxheWJhY2tTZXNzaW9uTWFuYWdlcgor ICAgICAgICB0byBzZW5kIGEgUGxheWJhY2tTZXNzaW9uTWFuYWdlclByb3h5OjpQaWN0dXJlSW5Q aWN0dXJlU3VwcG9ydGVkQ2hhbmdlZCBtZXNzYWdlIHRvIG5vdGlmeQorICAgICAgICB0aGUgUGxh eWJhY2tTZXNzaW9uTW9kZWxDb250ZXh0IGluc3RhbmNlIGluIHRoZSBVSSBwcm9jZXNzIHRvIHVw ZGF0ZSBtX3BpY3R1cmVJblBpY3R1cmVTdXBwb3J0ZWQKKyAgICAgICAgdG8gdHJ1ZSBiZWNhdXNl IHdlIGRvbid0IGNoYW5nZSBtX21lZGlhRWxlbWVudC4gVGhlcmVmb3JlLCB0aGUgUGxheWJhY2tT ZXNzaW9uTW9kZWxDb250ZXh0CisgICAgICAgIGluc3RhbmNlIHdpbGwgdGVsbCB0aGUgV0tGdWxs U2NyZWVuVmlld0NvbnRyb2xsZXIgaW5zdGFuY2UgdGhhdCBwaWN0dXJlLWluLXBpY3R1cmUgaXMg bm90CisgICAgICAgIHN1cHBvcnRlZCwgd2hpY2ggaW4gdHVybiB3aWxsIGhpZGUgdGhlIHBpY3R1 cmUtaW4tcGljdHVyZSBidXR0b24uCisKKyAgICAgICAgV2l0aCB0aGlzIHBhdGNoLCBQbGF5YmFj a1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudDo6c2V0TWVkaWFFbGVtZW50KCkgd2lsbCBhc2sgdGhl CisgICAgICAgIFBsYXliYWNrU2Vzc2lvbk1hbmFnZXIgaW5zdGFuY2UgdG8gc2VuZCBhbiBJUEMg bWVzc2FnZSBpZiBtX21lZGlhRWxlbWVudCBpcyBub3QgbnVsbHB0cgorICAgICAgICBldmVuIHdl IGRvbid0IGNoYW5nZSB0aGUgbWVkaWEgZWxlbWVudC4gU28gdGhhdCB0aGUgUGxheWJhY2tTZXNz aW9uTW9kZWxDb250ZXh0IGluc3RhbmNlCisgICAgICAgIGluIHRoZSBVSSBwcm9jZXNzIHdpbGwg YWx3YXlzIGhhdmUgYSBjb25zaXN0ZW50IHN0YXRlIGFzIHRoZSBQbGF5YmFja1Nlc3Npb25Nb2Rl bE1lZGlhRWxlbWVudAorICAgICAgICBpbnN0YW5jZSBpbiB0aGUgV2ViIHByb2Nlc3MuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9QbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudC5t bToKKyAgICAgICAgKFdlYkNvcmU6OlBsYXliYWNrU2Vzc2lvbk1vZGVsTWVkaWFFbGVtZW50Ojpz ZXRNZWRpYUVsZW1lbnQpOgorCiAyMDIwLTA4LTEyICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIHRoZSBzdXBwb3J0IHRvIHJldHVybiB0byBlbGVtZW50IGZ1 bGxzY3JlZW4gZnJvbSBwaWN0dXJlLWluLXBpY3R1cmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2NvY29hL1BsYXliYWNrU2Vzc2lvbk1vZGVsTWVkaWFFbGVtZW50Lm1tIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVs ZW1lbnQubW0KaW5kZXggOTVkY2I2NmYxZTJiZjM2MzhiYTdkYmJiMzVhYWM5NDI5ZDVhZTQxNi4u ZjJiM2Q4N2Q0YjQ4YjUxMWUzYmVlYWZiZDJkOTM3MDg4NDk5ZGM3OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1l bnQubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvUGxheWJhY2tTZXNzaW9u TW9kZWxNZWRpYUVsZW1lbnQubW0KQEAgLTY0LDggKzY0LDEzIEBAIFBsYXliYWNrU2Vzc2lvbk1v ZGVsTWVkaWFFbGVtZW50Ojp+UGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQoKQogCiB2 b2lkIFBsYXliYWNrU2Vzc2lvbk1vZGVsTWVkaWFFbGVtZW50OjpzZXRNZWRpYUVsZW1lbnQoSFRN TE1lZGlhRWxlbWVudCogbWVkaWFFbGVtZW50KQogewotICAgIGlmIChtX21lZGlhRWxlbWVudCA9 PSBtZWRpYUVsZW1lbnQpCisgICAgaWYgKG1fbWVkaWFFbGVtZW50ID09IG1lZGlhRWxlbWVudCkg eworICAgICAgICBpZiAobV9tZWRpYUVsZW1lbnQpIHsKKyAgICAgICAgICAgIGZvciAoYXV0byBj bGllbnQgOiBtX2NsaWVudHMpCisgICAgICAgICAgICAgICAgY2xpZW50LT5pc1BpY3R1cmVJblBp Y3R1cmVTdXBwb3J0ZWRDaGFuZ2VkKGlzUGljdHVyZUluUGljdHVyZVN1cHBvcnRlZCgpKTsKKyAg ICAgICAgfQogICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgYXV0byYgZXZlbnRzID0gZXZl bnROYW1lcygpOwogCg== 406577 2020-08-14 00:15:54 -0700 2020-08-14 11:57:30 -0700 update the change log bug-215488-20200814001553.patch text/plain 3417 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjY1NTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDllYTllY2E1NWFjYWEy Y2U3ODViZWM1MWE3MDQxNjYyMjdhMGU4ZS4uMzQwOWYzNDUwYTU5M2JhNWQ5NDlhYTdjMzg5YjU4 MDAxNTFhMzQ4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDIwLTA4LTEzICBQZW5n IExpdSAgPHBlbmcubGl1NkBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIFBpUCBidXR0b24gb24g dGhlIGZ1bGxzY3JlZW4geW91dHViZSBwbGF5ZXIgZGlzYXBwZWFycyBhZnRlciBzdGFydGluZyBh IG5ldyB2aWRlbyBpbiBhIHBsYXlsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMTU0ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBXaGVuIGEgZnVsbHNjcmVlbiB2aWRlbyBwbGF5ZXIgKGUuZy4sIFlv dVR1YmUuY29tKSBjb21wbGV0ZXMgdGhlIGN1cnJlbnQgdmlkZW8gYW5kIHN0YXJ0cworICAgICAg ICB0aGUgbmV4dCBvbmUgaW4gYSBwbGF5bGlzdCwgaXQgbWF5IHJldXNlIHRoZSB2aWRlbyBlbGVt ZW50LCBzbyBtX21lZGlhRWxlbWVudCBvZiB0aGUKKyAgICAgICAgUGxheWJhY2tTZXNzaW9uTW9k ZWxNZWRpYUVsZW1lbnQgaW5zdGFuY2Ugd29uJ3QgY2hhbmdlLiBIb3dldmVyLCB0aGUgdmlkZW8g ZWxlbWVudAorICAgICAgICB3aWxsIGV4aXQgdmlkZW8gZnVsbHNjcmVlbiBzdGFuZGJ5IGFuZCB0 aGVuIGVudGVyIHZpZGVvIGZ1bGxzY3JlZW4gc3RhbmRieS4gVGhvc2UKKyAgICAgICAgdHJhbnNp dGlvbnMgYXJlIGludmlzaWJsZSB0byB1c2Vycy4gQnV0IHRoZSBjb3JyZXNwb25kaW5nIFBsYXli YWNrU2Vzc2lvbk1vZGVsQ29udGV4dAorICAgICAgICBpbnN0YW5jZSB3aWxsIGJlIGRlc3Ryb3ll ZCBhbmQgYSBuZXcgaW5zdGFuY2Ugd2lsbCBiZSBjcmVhdGVkLgorCisgICAgICAgIEJ5IGRlZmF1 bHQsIHRoZSBtZW1iZXIgdmFyaWFibGUgbV9waWN0dXJlSW5QaWN0dXJlU3VwcG9ydGVkIG9mIHRo ZSBQbGF5YmFja1Nlc3Npb25Nb2RlbENvbnRleHQKKyAgICAgICAgaW5zdGFuY2UgaXMgImZhbHNl Ii4gQWZ0ZXIgYSBuZXcgdmlkZW8gc3RhcnRzIHRvIHBsYXksIHRoZSBmdW5jdGlvbgorICAgICAg ICBQbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudDo6c2V0TWVkaWFFbGVtZW50KCkgd29u J3QgYXNrIHRoZSBQbGF5YmFja1Nlc3Npb25NYW5hZ2VyCisgICAgICAgIHRvIHNlbmQgYSBQbGF5 YmFja1Nlc3Npb25NYW5hZ2VyUHJveHk6OlBpY3R1cmVJblBpY3R1cmVTdXBwb3J0ZWRDaGFuZ2Vk IG1lc3NhZ2UKKyAgICAgICAgKGJlY2F1c2Ugd2UgZG9uJ3QgY2hhbmdlIG1fbWVkaWFFbGVtZW50 KSB0byBub3RpZnkgdGhlIFBsYXliYWNrU2Vzc2lvbk1vZGVsQ29udGV4dAorICAgICAgICBpbnN0 YW5jZSBpbiB0aGUgVUkgcHJvY2VzcyB0aGF0IG1fcGljdHVyZUluUGljdHVyZVN1cHBvcnRlZCBz aG91bGQgYmUgInRydWUiLiBUaGVyZWZvcmUsCisgICAgICAgIHRoZSBQbGF5YmFja1Nlc3Npb25N b2RlbENvbnRleHQgaW5zdGFuY2Ugd2lsbCB0ZWxsIHRoZSBXS0Z1bGxTY3JlZW5WaWV3Q29udHJv bGxlciBpbnN0YW5jZQorICAgICAgICB0aGF0IHBpY3R1cmUtaW4tcGljdHVyZSBpcyBub3Qgc3Vw cG9ydGVkLCB3aGljaCBpbiB0dXJuIHdpbGwgaGlkZSB0aGUgcGljdHVyZS1pbi1waWN0dXJlIGJ1 dHRvbi4KKworICAgICAgICBXaXRoIHRoaXMgcGF0Y2gsIFBsYXliYWNrU2Vzc2lvbk1vZGVsTWVk aWFFbGVtZW50OjpzZXRNZWRpYUVsZW1lbnQoKSB3aWxsIGFzayB0aGUKKyAgICAgICAgUGxheWJh Y2tTZXNzaW9uTWFuYWdlciBpbnN0YW5jZSB0byBzZW5kIGFuIElQQyBtZXNzYWdlIGlmIG1fbWVk aWFFbGVtZW50IGlzIG5vdCBudWxscHRyCisgICAgICAgIGV2ZW4gd2UgZG9uJ3QgY2hhbmdlIHRo ZSBtZWRpYSBlbGVtZW50LiBTbyB0aGF0IHRoZSBQbGF5YmFja1Nlc3Npb25Nb2RlbENvbnRleHQg aW5zdGFuY2UKKyAgICAgICAgaW4gdGhlIFVJIHByb2Nlc3Mgd2lsbCBhbHdheXMgaGF2ZSBhIGNv bnNpc3RlbnQgc3RhdGUgYXMgdGhlIFBsYXliYWNrU2Vzc2lvbk1vZGVsTWVkaWFFbGVtZW50Cisg ICAgICAgIGluc3RhbmNlIGluIHRoZSBXZWIgcHJvY2Vzcy4KKworICAgICAgICAqIHBsYXRmb3Jt L2NvY29hL1BsYXliYWNrU2Vzc2lvbk1vZGVsTWVkaWFFbGVtZW50Lm1tOgorICAgICAgICAoV2Vi Q29yZTo6UGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQ6OnNldE1lZGlhRWxlbWVudCk6 CisKIDIwMjAtMDgtMTIgIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KIAogICAgICAg ICBBZGQgdGhlIHN1cHBvcnQgdG8gcmV0dXJuIHRvIGVsZW1lbnQgZnVsbHNjcmVlbiBmcm9tIHBp Y3R1cmUtaW4tcGljdHVyZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29j b2EvUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQubW0gYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9jb2NvYS9QbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudC5tbQppbmRleCA5 NWRjYjY2ZjFlMmJmMzYzOGJhN2RiYmIzNWFhYzk0MjlkNWFlNDE2Li5mMmIzZDg3ZDRiNDhiNTEx ZTNiZWVhZmJkMmQ5MzcwODg0OTlkYzc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9jb2NvYS9QbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudC5tbQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9QbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVu dC5tbQpAQCAtNjQsOCArNjQsMTMgQEAgUGxheWJhY2tTZXNzaW9uTW9kZWxNZWRpYUVsZW1lbnQ6 On5QbGF5YmFja1Nlc3Npb25Nb2RlbE1lZGlhRWxlbWVudCgpCiAKIHZvaWQgUGxheWJhY2tTZXNz aW9uTW9kZWxNZWRpYUVsZW1lbnQ6OnNldE1lZGlhRWxlbWVudChIVE1MTWVkaWFFbGVtZW50KiBt ZWRpYUVsZW1lbnQpCiB7Ci0gICAgaWYgKG1fbWVkaWFFbGVtZW50ID09IG1lZGlhRWxlbWVudCkK KyAgICBpZiAobV9tZWRpYUVsZW1lbnQgPT0gbWVkaWFFbGVtZW50KSB7CisgICAgICAgIGlmICht X21lZGlhRWxlbWVudCkgeworICAgICAgICAgICAgZm9yIChhdXRvIGNsaWVudCA6IG1fY2xpZW50 cykKKyAgICAgICAgICAgICAgICBjbGllbnQtPmlzUGljdHVyZUluUGljdHVyZVN1cHBvcnRlZENo YW5nZWQoaXNQaWN0dXJlSW5QaWN0dXJlU3VwcG9ydGVkKCkpOworICAgICAgICB9CiAgICAgICAg IHJldHVybjsKKyAgICB9CiAKICAgICBhdXRvJiBldmVudHMgPSBldmVudE5hbWVzKCk7CiAK