215457 2020-08-13 11:42:48 -0700 Regression(r265580): apply-watchlist is broken 2020-08-13 12:43:56 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain hi jbedard ryanhaddad simon.fraser webkit-bug-importer oldest_to_newest 1680028 0 aakash_jain 2020-08-13 11:42:48 -0700 r265580 broke apply-watchlist. e.g.: https://ews-build.webkit.org/#/builders/21/builds/25487 Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 80, in <module> main() File "Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py", line 48, in run cc_and_messages = self._tool.watch_list().determine_cc_and_messages(diff) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/memoized.py", line 45, in __call__ result = self._function(*args) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/host.py", line 108, in watch_list return WatchListParser().parse(watch_list_contents) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 70, in parse dictionary = self._eval_watch_list(watch_list_contents) File "/Volumes/Data/worker/Apply-WatchList-EWS/build/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py", line 86, in _eval_watch_list return eval(watch_list_contents, {'__builtins__': None}, None) File "<string>", line 211 "WebInspectorTests" { ^ SyntaxError: invalid syntax 1680031 1 406526 aakash_jain 2020-08-13 11:45:01 -0700 Created attachment 406526 Patch 1680032 2 aakash_jain 2020-08-13 11:45:55 -0700 Committed r265616: <https://trac.webkit.org/changeset/265616> 1680033 3 webkit-bug-importer 2020-08-13 11:46:18 -0700 <rdar://problem/67005950> 1680038 4 hi 2020-08-13 11:59:35 -0700 ah crap my bad :( 1680039 5 aakash_jain 2020-08-13 12:11:26 -0700 Retried all the failed builds at https://ews-build.webkit.org/#/builders/Apply-WatchList-EWS 1680045 6 simon.fraser 2020-08-13 12:43:56 -0700 Should we have style checker syntax-check watchlist, as it does for contributors.json? 406526 2020-08-13 11:45:01 -0700 2020-08-13 11:45:01 -0700 Patch bug-215457-20200813144500.patch text/plain 1292 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NTYxNSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDIwLTA4LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBSZWdyZXNzaW9uKHIyNjU1ODApOiBhcHBseS13YXRjaGxpc3QgaXMgYnJv a2VuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTU0 NTcKKworICAgICAgICBVbnJldmlld2VkIGluZnJhc3RydWN0dXJlIGZpeC4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3Q6CisKIDIwMjAtMDgtMTMg IEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtld3NdIGVt YWlsIG5vdGlmaWNhdGlvbnMgc2hvdWxkIGluY2x1ZGUgQnVnemlsbGEgbGluayB0byB0aGUgcGF0 Y2gKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NvbmZpZy93YXRjaGxpc3QK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY29uZmlnL3dhdGNo bGlzdAkocmV2aXNpb24gMjY1NjE1KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y29uZmlnL3dhdGNobGlzdAkod29ya2luZyBjb3B5KQpAQCAtMjA4LDcgKzIwOCw3IEBACiAgICAg ICAgICAgICAgICAgICAgICAgICByInxTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJl bmRlcmluZ0NvbnRleHRcLmlkbCIKICAgICAgICAgICAgICAgICAgICAgICAgIHIifFNvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2VcLmlkbCIsCiAgICAg ICAgIH0sCi0gICAgICAgICJXZWJJbnNwZWN0b3JUZXN0cyIgeworICAgICAgICAiV2ViSW5zcGVj dG9yVGVzdHMiOiB7CiAgICAgICAgICAgICAiZmlsZW5hbWUiOiByIkxheW91dFRlc3RzL2luc3Bl Y3RvciIKICAgICAgICAgICAgICAgICAgICAgICAgIHIifExheW91dFRlc3RzL2h0dHAvdGVzdHMv aW5zcGVjdG9yIgogICAgICAgICAgICAgICAgICAgICAgICAgciJ8TGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9pbnNwZWN0b3IiLAo=