215449 2020-08-13 07:17:23 -0700 [ews] Improve wording for test failure email 2020-08-13 09:34:52 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1679971 0 aakash_jain 2020-08-13 07:17:23 -0700 Improve wording for test failure emails by EWS. 1679972 1 406512 aakash_jain 2020-08-13 07:20:15 -0700 Created attachment 406512 Patch 1679990 2 406512 jbedard 2020-08-13 08:45:08 -0700 Comment on attachment 406512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406512&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:2159 > + email_text = 'EWS has detected layout test failure{} on {} while testing Patch {}'.format(pluralSuffix, builder_name, patch_id) Should we link the patch ID to bugzilla? 1679993 3 406512 aakash_jain 2020-08-13 08:57:35 -0700 Comment on attachment 406512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=406512&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:2159 >> + email_text = 'EWS has detected layout test failure{} on {} while testing Patch {}'.format(pluralSuffix, builder_name, patch_id) > > Should we link the patch ID to bugzilla? Good idea, let me do that in subsequent patch. 1679995 4 aakash_jain 2020-08-13 08:59:37 -0700 Committed r265609: <https://trac.webkit.org/changeset/265609> 1679996 5 webkit-bug-importer 2020-08-13 09:00:26 -0700 <rdar://problem/66994254> 1680008 6 aakash_jain 2020-08-13 09:34:52 -0700 > > Should we link the patch ID to bugzilla? > > Good idea, let me do that in subsequent patch. Doing it in Bug 215455. 406512 2020-08-13 07:20:15 -0700 2020-08-13 08:45:08 -0700 Patch bug-215449-20200813102014.patch text/plain 3095 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI2NTYwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTA4LTEzICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBJbXByb3ZlIHdvcmRpbmcgZm9yIHRlc3QgZmFpbHVyZSBlbWFp bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE1NDQ5 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHk6CisgICAgICAgIChBbmFseXplTGF5b3V0 VGVzdHNSZXN1bHRzLnNlbmRfZW1haWxfZm9yX25ld190ZXN0X2ZhaWx1cmVzKTogUGx1cmFsaXpl ICd0ZXN0IGZhaWx1cmUnIGFjY29yZGluZ2x5LgorICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0 L2V3cy1idWlsZC9zZW5kX2VtYWlsLnB5OgorICAgICAgICAoc2VuZF9lbWFpbCk6IERyaXZlLWJ5 IGZpeC4KKwogMjAyMC0wOC0xMiAgS2VpdGggUm9sbGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAK ICAgICAgICAgUmVtb3ZlIHRoZSBuZWVkIGZvciBkZWZpbmluZyBVU0VfTkVXX0JVSUxEX1NZU1RF TQpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3NlbmRfZW1haWwucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3NlbmRfZW1h aWwucHkJKHJldmlzaW9uIDI2NTYwNCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1i dWlsZC9zZW5kX2VtYWlsLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNiwxMCArMzYsMTAgQEAgZGVm IHNlbmRfZW1haWwodG9fZW1haWxzLCBzdWJqZWN0LCB0ZXh0KQogICAgIGlmIGlzX3Rlc3RfbW9k ZV9lbmFibGVkOgogICAgICAgICByZXR1cm4KICAgICBpZiBub3QgdG9fZW1haWxzOgotICAgICAg ICBwcmludCgnU2tpcHBpbmcgZW1haWwgc2luY2Ugbm8gcmVjaXBpZW50IGlzIHNwZWNpZmllZCcp CisgICAgICAgIHByaW50KCdFcnJvcjogc2tpcHBpbmcgZW1haWwgc2luY2Ugbm8gcmVjaXBpZW50 IGlzIHNwZWNpZmllZCcpCiAgICAgICAgIHJldHVybgogICAgIGlmIG5vdCBzdWJqZWN0IG9yIG5v dCB0ZXh0OgotICAgICAgICBwcmludCgnU2tpcHBpbmcgZW1haWwgc2luY2Ugbm8gc3ViamVjdCBv ciB0ZXh0IGlzIHNwZWNpZmllZCcpCisgICAgICAgIHByaW50KCdFcnJvcjogc2tpcHBpbmcgZW1h aWwgc2luY2Ugbm8gc3ViamVjdCBvciB0ZXh0IGlzIHNwZWNpZmllZCcpCiAgICAgICAgIHJldHVy bgogCiAgICAgdGV4dCA9IHRleHQuZW5jb2RlKCd1dGYtOCcpCkluZGV4OiBUb29scy9CdWlsZFNs YXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNjU2MDQpCisrKyBUb29s cy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAg LTIxNTQsMTEgKzIxNTQsMTIgQEAgY2xhc3MgQW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cyhidWls ZHN0ZQogICAgICAgICAgICAgICAgIGhpc3RvcnlfdXJsID0gJ3t9P3N1aXRlPWxheW91dC10ZXN0 cyZ0ZXN0PXt9Jy5mb3JtYXQoUkVTVUxUU19EQl9VUkwsIHRlc3RfbmFtZSkKICAgICAgICAgICAg ICAgICB0ZXN0X25hbWVzX3N0cmluZyArPSAnXG4tIHt9ICg8YSBocmVmPSJ7fSI+dGVzdCBoaXN0 b3J5PC9hPiknLmZvcm1hdCh0ZXN0X25hbWUsIGhpc3RvcnlfdXJsKQogCisgICAgICAgICAgICBw bHVyYWxTdWZmaXggPSAncycgaWYgbGVuKHRlc3RfbmFtZXMpID4gMSBlbHNlICcnCiAgICAgICAg ICAgICBlbWFpbF9zdWJqZWN0ID0gJ0xheW91dCB0ZXN0IGZhaWx1cmUgZm9yIFBhdGNoIHt9OiB7 fSAnLmZvcm1hdChwYXRjaF9pZCwgYnVnX3RpdGxlKQotICAgICAgICAgICAgZW1haWxfdGV4dCA9 ICdFV1MgaGFzIGRldGVjdGVkIHRlc3QgZmFpbHVyZSBvbiB7fSB3aGlsZSB0ZXN0aW5nIFBhdGNo IHt9Jy5mb3JtYXQoYnVpbGRlcl9uYW1lLCBwYXRjaF9pZCkKKyAgICAgICAgICAgIGVtYWlsX3Rl eHQgPSAnRVdTIGhhcyBkZXRlY3RlZCBsYXlvdXQgdGVzdCBmYWlsdXJle30gb24ge30gd2hpbGUg dGVzdGluZyBQYXRjaCB7fScuZm9ybWF0KHBsdXJhbFN1ZmZpeCwgYnVpbGRlcl9uYW1lLCBwYXRj aF9pZCkKICAgICAgICAgICAgIGVtYWlsX3RleHQgKz0gJyBmb3IgPGEgaHJlZj0ie30iPkJ1ZyB7 fTwvYT4uJy5mb3JtYXQoQnVnemlsbGEuYnVnX3VybChidWdfaWQpLCBidWdfaWQpCiAgICAgICAg ICAgICBlbWFpbF90ZXh0ICs9ICdcblxuRnVsbCBkZXRhaWxzIGFyZSBhdmFpbGFibGUgYXQ6IHt9 XG5cblBhdGNoIGF1dGhvcjoge30nLmZvcm1hdChidWlsZF91cmwsIHBhdGNoX2F1dGhvcikKLSAg ICAgICAgICAgIGVtYWlsX3RleHQgKz0gJ1xuXG5MYXlvdXQgdGVzdCBmYWlsdXJlOlxue30nLmZv cm1hdCh0ZXN0X25hbWVzX3N0cmluZykKKyAgICAgICAgICAgIGVtYWlsX3RleHQgKz0gJ1xuXG5M YXlvdXQgdGVzdCBmYWlsdXJle306XG57fScuZm9ybWF0KHBsdXJhbFN1ZmZpeCwgdGVzdF9uYW1l c19zdHJpbmcpCiAgICAgICAgICAgICBlbWFpbF90ZXh0ICs9ICdcblxuVG8gdW5zdWJzY3JpYmxl IGZyb20gdGhlc2Ugbm90aWZpY2F0aW9ucyBvciB0byBwcm92aWRlIGFueSBmZWVkYmFjayBwbGVh c2UgZW1haWwgYWFrYXNoX2phaW5AYXBwbGUuY29tJwogICAgICAgICAgICAgc2VuZF9lbWFpbChb cGF0Y2hfYXV0aG9yXSwgZW1haWxfc3ViamVjdCwgZW1haWxfdGV4dCkKICAgICAgICAgZXhjZXB0 IEV4Y2VwdGlvbiBhcyBlOgo=