<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>215440</bug_id>
          
          <creation_ts>2020-08-12 21:27:55 -0700</creation_ts>
          <short_desc>Add settings for Copy WebKit Permalink</short_desc>
          <delta_ts>2020-08-24 21:57:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>215796</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Devin Rousso">hi</reporter>
          <assigned_to name="Devin Rousso">hi</assigned_to>
          <cc>dbates</cc>
    
    <cc>hi</cc>
    
    <cc>joepeck</cc>
    
    <cc>keith_miller</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1679916</commentid>
    <comment_count>0</comment_count>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-08-12 21:27:55 -0700</bug_when>
    <thetext>.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1679917</commentid>
    <comment_count>1</comment_count>
      <attachid>406495</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-08-12 21:34:03 -0700</bug_when>
    <thetext>Created attachment 406495
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1679921</commentid>
    <comment_count>2</comment_count>
      <attachid>406495</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-08-12 21:47:40 -0700</bug_when>
    <thetext>Comment on attachment 406495
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406495&amp;action=review

&gt; Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.sublime-settings:3
&gt; +    &quot;include_revision&quot;: true,

I was tempted to have this default to `false` as it&apos;s significantly more performant for me, but I erred on the side of caution in preserving existing functionality.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1679926</commentid>
    <comment_count>3</comment_count>
      <attachid>406495</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2020-08-12 22:03:41 -0700</bug_when>
    <thetext>Comment on attachment 406495
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=406495&amp;action=review

Patch looks good.

&gt; Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py:38
&gt; +class Settings:

Ok as is. Consider inherit from object.

&gt;&gt; Tools/CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.sublime-settings:3
&gt;&gt; +    &quot;include_revision&quot;: true,
&gt; 
&gt; I was tempted to have this default to `false` as it&apos;s significantly more performant for me, but I erred on the side of caution in preserving existing functionality.

👍</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1679928</commentid>
    <comment_count>4</comment_count>
      <attachid>406498</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2020-08-12 22:21:42 -0700</bug_when>
    <thetext>Created attachment 406498
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1679933</commentid>
    <comment_count>5</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-08-12 23:07:01 -0700</bug_when>
    <thetext>Committed r265601: &lt;https://trac.webkit.org/changeset/265601&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 406498.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1679934</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-08-12 23:07:17 -0700</bug_when>
    <thetext>&lt;rdar://problem/66963933&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>406495</attachid>
            <date>2020-08-12 21:34:03 -0700</date>
            <delta_ts>2020-08-12 22:21:42 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-215440-20200812213402.patch</filename>
            <type>text/plain</type>
            <size>6327</size>
            <attacher name="Devin Rousso">hi</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmODRm
YzUyZTdiMjkyNDY3M2ZhNDBhNjBlMmY4ZGIwNTQwYmU2Y2YxLi4wMDAzZjlmNzQ5MjJjMGVkNzNi
ZTdjZGQ5YmQ4YTY1NmFmNGVhNDQ5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv
VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEgQEAKKzIwMjAtMDgtMTIgIERldmluIFJvdXNz
byAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzZXR0aW5ncyBmb3IgQ29weSBX
ZWJLaXQgUGVybWFsaW5rCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0yMTU0NDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIENvcHlQZXJtYWxpbmsvU3VibGltZSBUZXh0L0NvcHlXZWJLaXRQZXJtYWxpbmsv
Q29udGV4dC5zdWJsaW1lLXNldHRpbmdzOiBBZGRlZC4KKworICAgICAgICAqIENvcHlQZXJtYWxp
bmsvU3VibGltZSBUZXh0L0NvcHlXZWJLaXRQZXJtYWxpbmsvQ29weVdlYktpdFBlcm1hbGluay5w
eToKKyAgICAgICAgKHBsdWdpbl9sb2FkZWQpOiBBZGRlZC4KKyAgICAgICAgKHBsdWdpbl91bmxv
YWRlZCk6IEFkZGVkLgorICAgICAgICAoU2V0dGluZ3MpOiBBZGRlZC4KKyAgICAgICAgKFNldHRp
bmdzLl9faW5pdF9fKTogQWRkZWQuCisgICAgICAgIChTZXR0aW5ncy51bmxvYWQpOiBBZGRlZC4K
KyAgICAgICAgKFNldHRpbmdzLmluY2x1ZGVfcmV2aXNpb24pOiBBZGRlZC4KKyAgICAgICAgKFNl
dHRpbmdzLl9nZXQpOiBBZGRlZC4KKyAgICAgICAgKFNldHRpbmdzLl9zZXQpOiBBZGRlZC4KKyAg
ICAgICAgSGVscGVyIGNsYXNzIGZvciBjYWNoaW5nIHNldHRpbmdzIHZhbHVlcy4KKworICAgICAg
ICAoQ29weVdlYktpdFBlcm1hbGlua0NvbW1hbmQucnVuKToKKyAgICAgICAgKENvcHlXZWJLaXRQ
ZXJtYWxpbmtDb21tYW5kLnJldmlzaW9uX2luZm9fZm9yX3BhdGgpOgorICAgICAgICAoQ29weVdl
YktpdFBlcm1hbGlua0NvbW1hbmQucGVybWFsaW5rX2Zvcl9wYXRoKToKKyAgICAgICAgT25seSBp
bmNsdWRlIHRoZSBjdXJyZW50IHJldmlzaW9uIGluIHRoZSBVUkwgaWYgdGhlIGBpbmNsdWRlX3Jl
dmlzaW9uYCBzZXR0aW5nIGlzIHRydWUuCisgICAgICAgIFR1cm5pbmcgdGhpcyBvZmYgaXMgZGVz
aXJhYmxlIGFzIGdldHRpbmcgdGhlIGN1cnJlbnQgcmV2aXNpb24gb2Z0ZW4gdGFrZXMgYSBmZXcg
c2Vjb25kcy4KKworICAgICAgICAqIENvcHlQZXJtYWxpbmsvU3VibGltZSBUZXh0L0lOU1RBTEw6
CisKIDIwMjAtMDgtMTIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAg
ICAgIFVwZGF0ZSBteSB3YXRjaGxpc3QgZW50cmllcyBhbmQgYWRkIHNvbWUgYWRkaXRpb25hbCBX
ZWIgSW5zcGVjdG9yIGRlZmluaXRpb25zCmRpZmYgLS1naXQgYS9Ub29scy9Db3B5UGVybWFsaW5r
L1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvcHlXZWJLaXRQZXJtYWxpbmsucHkg
Yi9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0Nv
cHlXZWJLaXRQZXJtYWxpbmsucHkKaW5kZXggZWYxYmVlYmE1ZTU5NWVhN2E0YzUyOTA1OTgwMGEw
MDViMGE2Nzg3NC4uMTgwYTE3ODQ4MmQ3YzBjNmY2NGExMDRkMjYyY2JkYTI1ZGI3YjFmMSAxMDA2
NDQKLS0tIGEvVG9vbHMvQ29weVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1h
bGluay9Db3B5V2ViS2l0UGVybWFsaW5rLnB5CQorKysgYi9Ub29scy9Db3B5UGVybWFsaW5rL1N1
YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvcHlXZWJLaXRQZXJtYWxpbmsucHkJCkBA
IC0yNiw2ICsyNiw0NCBAQCBpbXBvcnQgc3VibGltZQogaW1wb3J0IHN1YmxpbWVfcGx1Z2luCiBp
bXBvcnQgc3VicHJvY2VzcwogCitnbG9iYWwgc19zZXR0aW5ncworCitkZWYgcGx1Z2luX2xvYWRl
ZCgpOgorICAgIGdsb2JhbCBzX3NldHRpbmdzCisgICAgc19zZXR0aW5ncyA9IFNldHRpbmdzKCkK
KworZGVmIHBsdWdpbl91bmxvYWRlZCgpOgorICAgIHNfc2V0dGluZ3MudW5sb2FkKCkKKworY2xh
c3MgU2V0dGluZ3M6CisgICAgZGVmIF9faW5pdF9fKHNlbGYpOgorICAgICAgICBzZWxmLl9zZXR0
aW5ncyA9IHN1YmxpbWUubG9hZF9zZXR0aW5ncygnQ29weVdlYktpdFBlcm1hbGluay5zdWJsaW1l
LXNldHRpbmdzJykKKyAgICAgICAgc2VsZi5fY2FjaGUgPSB7fQorCisgICAgZGVmIHVubG9hZChz
ZWxmKToKKyAgICAgICAgZm9yIGtleSBpbiBzZWxmLl9jYWNoZToKKyAgICAgICAgICAgIHNlbGYu
X3NldHRpbmdzLmNsZWFyX29uX2NoYW5nZShrZXkpCisKKyAgICBAcHJvcGVydHkKKyAgICBkZWYg
aW5jbHVkZV9yZXZpc2lvbihzZWxmKToKKyAgICAgICAgcmV0dXJuIHNlbGYuX2dldCgnaW5jbHVk
ZV9yZXZpc2lvbicsIGRlZmF1bHQ9VHJ1ZSkKKworICAgIEBpbmNsdWRlX3JldmlzaW9uLnNldHRl
cgorICAgIGRlZiBpbmNsdWRlX3JldmlzaW9uKHNlbGYsIHZhbHVlKToKKyAgICAgICAgc2VsZi5f
c2V0KCdpbmNsdWRlX3JldmlzaW9uJywgdmFsdWUpCisKKyAgICBkZWYgX2dldChzZWxmLCBrZXks
IGRlZmF1bHQ9Tm9uZSk6CisgICAgICAgIGlmIGtleSBub3QgaW4gc2VsZi5fY2FjaGU6CisgICAg
ICAgICAgICBzZWxmLl9zZXR0aW5ncy5hZGRfb25fY2hhbmdlKGtleSwgbGFtYmRhIDogc2VsZi5f
Y2FjaGUucG9wKGtleSwgTm9uZSkpCisgICAgICAgICAgICBzZWxmLl9jYWNoZVtrZXldID0gc2Vs
Zi5fc2V0dGluZ3MuZ2V0KGtleSwgZGVmYXVsdCkKKyAgICAgICAgcmV0dXJuIHNlbGYuX2NhY2hl
W2tleV0KKworICAgIGRlZiBfc2V0KHNlbGYsIGtleSwgdmFsdWUpOgorICAgICAgICBpZiBrZXkg
aW4gc2VsZi5fY2FjaGUgYW5kIHNlbGYuX2NhY2hlW2tleV0gPT0gdmFsdWU6CisgICAgICAgICAg
ICByZXR1cm4KKworICAgICAgICBzZWxmLl9jYWNoZVtrZXldID0gdmFsdWUKKyAgICAgICAgc2Vs
Zi5fc2V0dGluZ3Muc2V0KGtleSwgdmFsdWUpCiAKIGNsYXNzIENvcHlXZWJLaXRQZXJtYWxpbmtD
b21tYW5kKHN1YmxpbWVfcGx1Z2luLlRleHRDb21tYW5kKToKICAgICBkZWYgcnVuKHNlbGYsIGVk
aXQsIGFubm90YXRlX2JsYW1lPUZhbHNlKToKQEAgLTM3LDcgKzc1LDcgQEAgY2xhc3MgQ29weVdl
YktpdFBlcm1hbGlua0NvbW1hbmQoc3VibGltZV9wbHVnaW4uVGV4dENvbW1hbmQpOgogICAgICAg
ICBzZWxmLl9kaXJlY3RvcnlfaW5fY2hlY2tvdXQgPSBkb2N1bWVudF9wYXRoIGlmIG9zLnBhdGgu
aXNkaXIoZG9jdW1lbnRfcGF0aCkgZWxzZSBvcy5wYXRoLmRpcm5hbWUoZG9jdW1lbnRfcGF0aCkK
ICAgICAgICAgc2VsZi5kZXRlcm1pbmVfdmNzX2Zyb21fcGF0aChkb2N1bWVudF9wYXRoKQogCi0g
ICAgICAgIGlmIG5vdCBzZWxmLnBhdGhfaXNfaW5fd2Via2l0X2NoZWNrb3V0KGRvY3VtZW50X3Bh
dGgpOgorICAgICAgICBpZiBzX3NldHRpbmdzLmluY2x1ZGVfcmV2aXNpb24gYW5kIG5vdCBzZWxm
LnBhdGhfaXNfaW5fd2Via2l0X2NoZWNrb3V0KGRvY3VtZW50X3BhdGgpOgogICAgICAgICAgICAg
cmV0dXJuCiAKICAgICAgICAgbGluZV9udW1iZXIsIF8gPSBzZWxmLnZpZXcucm93Y29sKHNlbGYu
dmlldy5zZWwoKVswXS5iZWdpbigpKSAgIyBaZXJvLWJhc2VkCkBAIC05MSwxMCArMTI5LDExIEBA
IGNsYXNzIENvcHlXZWJLaXRQZXJtYWxpbmtDb21tYW5kKHN1YmxpbWVfcGx1Z2luLlRleHRDb21t
YW5kKToKICAgICAgICAgcmV0dXJuICcnCiAKICAgICBkZWYgcmV2aXNpb25faW5mb19mb3JfcGF0
aChzZWxmLCBwYXRoKToKLSAgICAgICAgaWYgc2VsZi5faXNfc3ZuIG9yIHNlbGYuX2lzX2dpdF9z
dm46Ci0gICAgICAgICAgICByZXR1cm4gc2VsZi5zdm5fcmV2aXNpb25faW5mb19mb3JfcGF0aChw
YXRoKQotICAgICAgICBpZiBzZWxmLl9pc19naXQ6Ci0gICAgICAgICAgICByZXR1cm4gc2VsZi5n
aXRfcmV2aXNpb25faW5mb19mb3JfcGF0aChwYXRoKQorICAgICAgICBpZiBzX3NldHRpbmdzLmlu
Y2x1ZGVfcmV2aXNpb246CisgICAgICAgICAgICBpZiBzZWxmLl9pc19zdm4gb3Igc2VsZi5faXNf
Z2l0X3N2bjoKKyAgICAgICAgICAgICAgICByZXR1cm4gc2VsZi5zdm5fcmV2aXNpb25faW5mb19m
b3JfcGF0aChwYXRoKQorICAgICAgICAgICAgaWYgc2VsZi5faXNfZ2l0OgorICAgICAgICAgICAg
ICAgIHJldHVybiBzZWxmLmdpdF9yZXZpc2lvbl9pbmZvX2Zvcl9wYXRoKHBhdGgpCiAgICAgICAg
IHJldHVybiB7fQogCiAgICAgZGVmIHN2bl9yZXZpc2lvbl9pbmZvX2Zvcl9wYXRoKHNlbGYsIHBh
dGgpOgpAQCAtMTQ4LDkgKzE4Nyw5IEBAIGNsYXNzIENvcHlXZWJLaXRQZXJtYWxpbmtDb21tYW5k
KHN1YmxpbWVfcGx1Z2luLlRleHRDb21tYW5kKToKIAogICAgIEBzdGF0aWNtZXRob2QKICAgICBk
ZWYgcGVybWFsaW5rX2Zvcl9wYXRoKHBhdGgsIGxpbmVfbnVtYmVyLCByZXZpc2lvbl9pbmZvLCBh
bm5vdGF0ZV9ibGFtZSk6Ci0gICAgICAgIHJldmlzaW9uID0gJz9yZXY9JyArIHN0cihyZXZpc2lv
bl9pbmZvWydyZXZpc2lvbiddKSBpZiByZXZpc2lvbl9pbmZvWydyZXZpc2lvbiddIGVsc2UgJycK
KyAgICAgICAgcmV2aXNpb24gPSAnP3Jldj0nICsgc3RyKHJldmlzaW9uX2luZm9bJ3JldmlzaW9u
J10pIGlmICdyZXZpc2lvbicgaW4gcmV2aXNpb25faW5mbyBlbHNlICcnCiAgICAgICAgIGxpbmVf
bnVtYmVyID0gJyNMJyArIHN0cihsaW5lX251bWJlcikgaWYgbGluZV9udW1iZXIgZWxzZSAnJwot
ICAgICAgICBicmFuY2ggPSByZXZpc2lvbl9pbmZvWydicmFuY2gnXSBvciAndHJ1bmsnCisgICAg
ICAgIGJyYW5jaCA9IHJldmlzaW9uX2luZm8uZ2V0KCdicmFuY2gnLCAndHJ1bmsnKQogICAgICAg
ICBhbm5vdGF0ZV9ibGFtZSA9ICcmYW5ub3RhdGU9YmxhbWUnIGlmIGFubm90YXRlX2JsYW1lIGVs
c2UgJycKICAgICAgICAgcmV0dXJuICdodHRwczovL3RyYWMud2Via2l0Lm9yZy9icm93c2VyL3t9
L3t9e317fXt9Jy5mb3JtYXQoYnJhbmNoLCBwYXRoLCByZXZpc2lvbiwgYW5ub3RhdGVfYmxhbWUs
IGxpbmVfbnVtYmVyKQogCmRpZmYgLS1naXQgYS9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUg
VGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvcHlXZWJLaXRQZXJtYWxpbmsuc3VibGltZS1zZXR0
aW5ncyBiL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBUZXh0L0NvcHlXZWJLaXRQZXJtYWxp
bmsvQ29weVdlYktpdFBlcm1hbGluay5zdWJsaW1lLXNldHRpbmdzCm5ldyBmaWxlIG1vZGUgMTAw
NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc4NzNh
MzExOGY3NWIyNTk0ZTllMmE0NTQ5YTdkYWIxNjZkZDQ2YWQKLS0tIC9kZXYvbnVsbAorKysgYi9U
b29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvcHlX
ZWJLaXRQZXJtYWxpbmsuc3VibGltZS1zZXR0aW5ncwkKQEAgLTAsMCArMSw0IEBACit7CisgICAg
Ly8gQ29udHJvbHMgd2hldGhlciB0aGUgU1ZOIHJldmlzaW9uIGlzIGluY2x1ZGVkIGluIHRoZSBV
UkwuCisgICAgImluY2x1ZGVfcmV2aXNpb24iOiB0cnVlLAorfQpcIE5vIG5ld2xpbmUgYXQgZW5k
IG9mIGZpbGUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBUZXh0L0lO
U1RBTEwgYi9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9JTlNUQUxMCmluZGV4IDE0
NDExZmIwYzU2MTg3ZGM4YTBmNzQ0ZmNkNDY0NTI1Mzc2M2U0MWUuLmMxYWYyMDIzYzViMjAzZDZh
N2YzNzU4OGQ5ZjhmNTlmYmU5NGRiNmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NvcHlQZXJtYWxpbmsv
U3VibGltZSBUZXh0L0lOU1RBTEwJCisrKyBiL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBU
ZXh0L0lOU1RBTEwJCkBAIC0xNCwzICsxNCw3IEBAIENvcHkgV2ViS2l0IFBlcm1hbGluayBhbmQg
Q29weSBXZWJLaXQgUGVybWFsaW5rIHRvIEJsYW1lIGFyZSBhbHNvIGF2YWlsYWJsZSBhcyBhCiAK
IFdpdGhvdXQgYmxhbWUgYW5ub3RhdGlvbnM6IENvbW1hbmQgKyBTaGlmdCArIENvbnRyb2wgKyBD
CiBXaXRoIGJsYW1lIGFubm90YXRpb25zOiBDb21tYW5kICsgU2hpZnQgKyBDb250cm9sICsgT3B0
aW9uICsgQworCis9PSBTZXR0aW5ncyA9PQorCitDb3B5IGBDb3B5V2ViS2l0UGVybWFsaW5rLnN1
YmxpbWUtc2V0dGluZ3NgICAobG9jYXRlZCBpbiB0aGUgc2FtZSBkaXJlY3RvcnkgYXMgdGhpcyBm
aWxlKSB0byB5b3VyIGBQYWNrYWdlcy9Vc2VyYCBkaXJlY3RvcnkgYW5kIG1ha2UgY2hhbmdlcy4K
</data>
<flag name="review"
          id="421887"
          type_id="1"
          status="+"
          setter="dbates"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>406498</attachid>
            <date>2020-08-12 22:21:42 -0700</date>
            <delta_ts>2020-08-12 23:07:01 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-215440.patch</filename>
            <type>text/plain</type>
            <size>6333</size>
            <attacher name="Devin Rousso">hi</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmODRm
YzUyZTdiMjkyNDY3M2ZhNDBhNjBlMmY4ZGIwNTQwYmU2Y2YxLi4wMDAzZjlmNzQ5MjJjMGVkNzNi
ZTdjZGQ5YmQ4YTY1NmFmNGVhNDQ5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv
VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzEgQEAKKzIwMjAtMDgtMTIgIERldmluIFJvdXNz
byAgPGRyb3Vzc29AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzZXR0aW5ncyBmb3IgQ29weSBX
ZWJLaXQgUGVybWFsaW5rCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0yMTU0NDAKKworICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCisKKyAg
ICAgICAgKiBDb3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0Nv
bnRleHQuc3VibGltZS1zZXR0aW5nczogQWRkZWQuCisKKyAgICAgICAgKiBDb3B5UGVybWFsaW5r
L1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvcHlXZWJLaXRQZXJtYWxpbmsucHk6
CisgICAgICAgIChwbHVnaW5fbG9hZGVkKTogQWRkZWQuCisgICAgICAgIChwbHVnaW5fdW5sb2Fk
ZWQpOiBBZGRlZC4KKyAgICAgICAgKFNldHRpbmdzKTogQWRkZWQuCisgICAgICAgIChTZXR0aW5n
cy5fX2luaXRfXyk6IEFkZGVkLgorICAgICAgICAoU2V0dGluZ3MudW5sb2FkKTogQWRkZWQuCisg
ICAgICAgIChTZXR0aW5ncy5pbmNsdWRlX3JldmlzaW9uKTogQWRkZWQuCisgICAgICAgIChTZXR0
aW5ncy5fZ2V0KTogQWRkZWQuCisgICAgICAgIChTZXR0aW5ncy5fc2V0KTogQWRkZWQuCisgICAg
ICAgIEhlbHBlciBjbGFzcyBmb3IgY2FjaGluZyBzZXR0aW5ncyB2YWx1ZXMuCisKKyAgICAgICAg
KENvcHlXZWJLaXRQZXJtYWxpbmtDb21tYW5kLnJ1bik6CisgICAgICAgIChDb3B5V2ViS2l0UGVy
bWFsaW5rQ29tbWFuZC5yZXZpc2lvbl9pbmZvX2Zvcl9wYXRoKToKKyAgICAgICAgKENvcHlXZWJL
aXRQZXJtYWxpbmtDb21tYW5kLnBlcm1hbGlua19mb3JfcGF0aCk6CisgICAgICAgIE9ubHkgaW5j
bHVkZSB0aGUgY3VycmVudCByZXZpc2lvbiBpbiB0aGUgVVJMIGlmIHRoZSBgaW5jbHVkZV9yZXZp
c2lvbmAgc2V0dGluZyBpcyB0cnVlLgorICAgICAgICBUdXJuaW5nIHRoaXMgb2ZmIGlzIGRlc2ly
YWJsZSBhcyBnZXR0aW5nIHRoZSBjdXJyZW50IHJldmlzaW9uIG9mdGVuIHRha2VzIGEgZmV3IHNl
Y29uZHMuCisKKyAgICAgICAgKiBDb3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9JTlNUQUxMOgor
CiAyMDIwLTA4LTEyICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAg
ICBVcGRhdGUgbXkgd2F0Y2hsaXN0IGVudHJpZXMgYW5kIGFkZCBzb21lIGFkZGl0aW9uYWwgV2Vi
IEluc3BlY3RvciBkZWZpbml0aW9ucwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ29weVBlcm1hbGluay9T
dWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGluay9Db3B5V2ViS2l0UGVybWFsaW5rLnB5IGIv
VG9vbHMvQ29weVBlcm1hbGluay9TdWJsaW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGluay9Db3B5
V2ViS2l0UGVybWFsaW5rLnB5CmluZGV4IGVmMWJlZWJhNWU1OTVlYTdhNGM1MjkwNTk4MDBhMDA1
YjBhNjc4NzQuLjE4MGExNzg0ODJkN2MwYzZmNjRhMTA0ZDI2MmNiZGEyNWRiN2IxZjEgMTAwNjQ0
Ci0tLSBhL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBUZXh0L0NvcHlXZWJLaXRQZXJtYWxp
bmsvQ29weVdlYktpdFBlcm1hbGluay5weQkKKysrIGIvVG9vbHMvQ29weVBlcm1hbGluay9TdWJs
aW1lIFRleHQvQ29weVdlYktpdFBlcm1hbGluay9Db3B5V2ViS2l0UGVybWFsaW5rLnB5CQpAQCAt
MjYsNiArMjYsNDQgQEAgaW1wb3J0IHN1YmxpbWUKIGltcG9ydCBzdWJsaW1lX3BsdWdpbgogaW1w
b3J0IHN1YnByb2Nlc3MKIAorZ2xvYmFsIHNfc2V0dGluZ3MKKworZGVmIHBsdWdpbl9sb2FkZWQo
KToKKyAgICBnbG9iYWwgc19zZXR0aW5ncworICAgIHNfc2V0dGluZ3MgPSBTZXR0aW5ncygpCisK
K2RlZiBwbHVnaW5fdW5sb2FkZWQoKToKKyAgICBzX3NldHRpbmdzLnVubG9hZCgpCisKK2NsYXNz
IFNldHRpbmdzKG9iamVjdCk6CisgICAgZGVmIF9faW5pdF9fKHNlbGYpOgorICAgICAgICBzZWxm
Ll9zZXR0aW5ncyA9IHN1YmxpbWUubG9hZF9zZXR0aW5ncygnQ29weVdlYktpdFBlcm1hbGluay5z
dWJsaW1lLXNldHRpbmdzJykKKyAgICAgICAgc2VsZi5fY2FjaGUgPSB7fQorCisgICAgZGVmIHVu
bG9hZChzZWxmKToKKyAgICAgICAgZm9yIGtleSBpbiBzZWxmLl9jYWNoZToKKyAgICAgICAgICAg
IHNlbGYuX3NldHRpbmdzLmNsZWFyX29uX2NoYW5nZShrZXkpCisKKyAgICBAcHJvcGVydHkKKyAg
ICBkZWYgaW5jbHVkZV9yZXZpc2lvbihzZWxmKToKKyAgICAgICAgcmV0dXJuIHNlbGYuX2dldCgn
aW5jbHVkZV9yZXZpc2lvbicsIGRlZmF1bHQ9VHJ1ZSkKKworICAgIEBpbmNsdWRlX3JldmlzaW9u
LnNldHRlcgorICAgIGRlZiBpbmNsdWRlX3JldmlzaW9uKHNlbGYsIHZhbHVlKToKKyAgICAgICAg
c2VsZi5fc2V0KCdpbmNsdWRlX3JldmlzaW9uJywgdmFsdWUpCisKKyAgICBkZWYgX2dldChzZWxm
LCBrZXksIGRlZmF1bHQ9Tm9uZSk6CisgICAgICAgIGlmIGtleSBub3QgaW4gc2VsZi5fY2FjaGU6
CisgICAgICAgICAgICBzZWxmLl9zZXR0aW5ncy5hZGRfb25fY2hhbmdlKGtleSwgbGFtYmRhIDog
c2VsZi5fY2FjaGUucG9wKGtleSwgTm9uZSkpCisgICAgICAgICAgICBzZWxmLl9jYWNoZVtrZXld
ID0gc2VsZi5fc2V0dGluZ3MuZ2V0KGtleSwgZGVmYXVsdCkKKyAgICAgICAgcmV0dXJuIHNlbGYu
X2NhY2hlW2tleV0KKworICAgIGRlZiBfc2V0KHNlbGYsIGtleSwgdmFsdWUpOgorICAgICAgICBp
ZiBrZXkgaW4gc2VsZi5fY2FjaGUgYW5kIHNlbGYuX2NhY2hlW2tleV0gPT0gdmFsdWU6CisgICAg
ICAgICAgICByZXR1cm4KKworICAgICAgICBzZWxmLl9jYWNoZVtrZXldID0gdmFsdWUKKyAgICAg
ICAgc2VsZi5fc2V0dGluZ3Muc2V0KGtleSwgdmFsdWUpCiAKIGNsYXNzIENvcHlXZWJLaXRQZXJt
YWxpbmtDb21tYW5kKHN1YmxpbWVfcGx1Z2luLlRleHRDb21tYW5kKToKICAgICBkZWYgcnVuKHNl
bGYsIGVkaXQsIGFubm90YXRlX2JsYW1lPUZhbHNlKToKQEAgLTM3LDcgKzc1LDcgQEAgY2xhc3Mg
Q29weVdlYktpdFBlcm1hbGlua0NvbW1hbmQoc3VibGltZV9wbHVnaW4uVGV4dENvbW1hbmQpOgog
ICAgICAgICBzZWxmLl9kaXJlY3RvcnlfaW5fY2hlY2tvdXQgPSBkb2N1bWVudF9wYXRoIGlmIG9z
LnBhdGguaXNkaXIoZG9jdW1lbnRfcGF0aCkgZWxzZSBvcy5wYXRoLmRpcm5hbWUoZG9jdW1lbnRf
cGF0aCkKICAgICAgICAgc2VsZi5kZXRlcm1pbmVfdmNzX2Zyb21fcGF0aChkb2N1bWVudF9wYXRo
KQogCi0gICAgICAgIGlmIG5vdCBzZWxmLnBhdGhfaXNfaW5fd2Via2l0X2NoZWNrb3V0KGRvY3Vt
ZW50X3BhdGgpOgorICAgICAgICBpZiBzX3NldHRpbmdzLmluY2x1ZGVfcmV2aXNpb24gYW5kIG5v
dCBzZWxmLnBhdGhfaXNfaW5fd2Via2l0X2NoZWNrb3V0KGRvY3VtZW50X3BhdGgpOgogICAgICAg
ICAgICAgcmV0dXJuCiAKICAgICAgICAgbGluZV9udW1iZXIsIF8gPSBzZWxmLnZpZXcucm93Y29s
KHNlbGYudmlldy5zZWwoKVswXS5iZWdpbigpKSAgIyBaZXJvLWJhc2VkCkBAIC05MSwxMCArMTI5
LDExIEBAIGNsYXNzIENvcHlXZWJLaXRQZXJtYWxpbmtDb21tYW5kKHN1YmxpbWVfcGx1Z2luLlRl
eHRDb21tYW5kKToKICAgICAgICAgcmV0dXJuICcnCiAKICAgICBkZWYgcmV2aXNpb25faW5mb19m
b3JfcGF0aChzZWxmLCBwYXRoKToKLSAgICAgICAgaWYgc2VsZi5faXNfc3ZuIG9yIHNlbGYuX2lz
X2dpdF9zdm46Ci0gICAgICAgICAgICByZXR1cm4gc2VsZi5zdm5fcmV2aXNpb25faW5mb19mb3Jf
cGF0aChwYXRoKQotICAgICAgICBpZiBzZWxmLl9pc19naXQ6Ci0gICAgICAgICAgICByZXR1cm4g
c2VsZi5naXRfcmV2aXNpb25faW5mb19mb3JfcGF0aChwYXRoKQorICAgICAgICBpZiBzX3NldHRp
bmdzLmluY2x1ZGVfcmV2aXNpb246CisgICAgICAgICAgICBpZiBzZWxmLl9pc19zdm4gb3Igc2Vs
Zi5faXNfZ2l0X3N2bjoKKyAgICAgICAgICAgICAgICByZXR1cm4gc2VsZi5zdm5fcmV2aXNpb25f
aW5mb19mb3JfcGF0aChwYXRoKQorICAgICAgICAgICAgaWYgc2VsZi5faXNfZ2l0OgorICAgICAg
ICAgICAgICAgIHJldHVybiBzZWxmLmdpdF9yZXZpc2lvbl9pbmZvX2Zvcl9wYXRoKHBhdGgpCiAg
ICAgICAgIHJldHVybiB7fQogCiAgICAgZGVmIHN2bl9yZXZpc2lvbl9pbmZvX2Zvcl9wYXRoKHNl
bGYsIHBhdGgpOgpAQCAtMTQ4LDkgKzE4Nyw5IEBAIGNsYXNzIENvcHlXZWJLaXRQZXJtYWxpbmtD
b21tYW5kKHN1YmxpbWVfcGx1Z2luLlRleHRDb21tYW5kKToKIAogICAgIEBzdGF0aWNtZXRob2QK
ICAgICBkZWYgcGVybWFsaW5rX2Zvcl9wYXRoKHBhdGgsIGxpbmVfbnVtYmVyLCByZXZpc2lvbl9p
bmZvLCBhbm5vdGF0ZV9ibGFtZSk6Ci0gICAgICAgIHJldmlzaW9uID0gJz9yZXY9JyArIHN0cihy
ZXZpc2lvbl9pbmZvWydyZXZpc2lvbiddKSBpZiByZXZpc2lvbl9pbmZvWydyZXZpc2lvbiddIGVs
c2UgJycKKyAgICAgICAgcmV2aXNpb24gPSAnP3Jldj0nICsgc3RyKHJldmlzaW9uX2luZm9bJ3Jl
dmlzaW9uJ10pIGlmICdyZXZpc2lvbicgaW4gcmV2aXNpb25faW5mbyBlbHNlICcnCiAgICAgICAg
IGxpbmVfbnVtYmVyID0gJyNMJyArIHN0cihsaW5lX251bWJlcikgaWYgbGluZV9udW1iZXIgZWxz
ZSAnJwotICAgICAgICBicmFuY2ggPSByZXZpc2lvbl9pbmZvWydicmFuY2gnXSBvciAndHJ1bmsn
CisgICAgICAgIGJyYW5jaCA9IHJldmlzaW9uX2luZm8uZ2V0KCdicmFuY2gnLCAndHJ1bmsnKQog
ICAgICAgICBhbm5vdGF0ZV9ibGFtZSA9ICcmYW5ub3RhdGU9YmxhbWUnIGlmIGFubm90YXRlX2Js
YW1lIGVsc2UgJycKICAgICAgICAgcmV0dXJuICdodHRwczovL3RyYWMud2Via2l0Lm9yZy9icm93
c2VyL3t9L3t9e317fXt9Jy5mb3JtYXQoYnJhbmNoLCBwYXRoLCByZXZpc2lvbiwgYW5ub3RhdGVf
YmxhbWUsIGxpbmVfbnVtYmVyKQogCmRpZmYgLS1naXQgYS9Ub29scy9Db3B5UGVybWFsaW5rL1N1
YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5rL0NvcHlXZWJLaXRQZXJtYWxpbmsuc3VibGlt
ZS1zZXR0aW5ncyBiL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBUZXh0L0NvcHlXZWJLaXRQ
ZXJtYWxpbmsvQ29weVdlYktpdFBlcm1hbGluay5zdWJsaW1lLXNldHRpbmdzCm5ldyBmaWxlIG1v
ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu
Ljc4NzNhMzExOGY3NWIyNTk0ZTllMmE0NTQ5YTdkYWIxNjZkZDQ2YWQKLS0tIC9kZXYvbnVsbAor
KysgYi9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9Db3B5V2ViS2l0UGVybWFsaW5r
L0NvcHlXZWJLaXRQZXJtYWxpbmsuc3VibGltZS1zZXR0aW5ncwkKQEAgLTAsMCArMSw0IEBACit7
CisgICAgLy8gQ29udHJvbHMgd2hldGhlciB0aGUgU1ZOIHJldmlzaW9uIGlzIGluY2x1ZGVkIGlu
IHRoZSBVUkwuCisgICAgImluY2x1ZGVfcmV2aXNpb24iOiB0cnVlLAorfQpcIE5vIG5ld2xpbmUg
YXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdpdCBhL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3VibGltZSBU
ZXh0L0lOU1RBTEwgYi9Ub29scy9Db3B5UGVybWFsaW5rL1N1YmxpbWUgVGV4dC9JTlNUQUxMCmlu
ZGV4IDE0NDExZmIwYzU2MTg3ZGM4YTBmNzQ0ZmNkNDY0NTI1Mzc2M2U0MWUuLmMxYWYyMDIzYzVi
MjAzZDZhN2YzNzU4OGQ5ZjhmNTlmYmU5NGRiNmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NvcHlQZXJt
YWxpbmsvU3VibGltZSBUZXh0L0lOU1RBTEwJCisrKyBiL1Rvb2xzL0NvcHlQZXJtYWxpbmsvU3Vi
bGltZSBUZXh0L0lOU1RBTEwJCkBAIC0xNCwzICsxNCw3IEBAIENvcHkgV2ViS2l0IFBlcm1hbGlu
ayBhbmQgQ29weSBXZWJLaXQgUGVybWFsaW5rIHRvIEJsYW1lIGFyZSBhbHNvIGF2YWlsYWJsZSBh
cyBhCiAKIFdpdGhvdXQgYmxhbWUgYW5ub3RhdGlvbnM6IENvbW1hbmQgKyBTaGlmdCArIENvbnRy
b2wgKyBDCiBXaXRoIGJsYW1lIGFubm90YXRpb25zOiBDb21tYW5kICsgU2hpZnQgKyBDb250cm9s
ICsgT3B0aW9uICsgQworCis9PSBTZXR0aW5ncyA9PQorCitDb3B5IGBDb3B5V2ViS2l0UGVybWFs
aW5rLnN1YmxpbWUtc2V0dGluZ3NgICAobG9jYXRlZCBpbiB0aGUgc2FtZSBkaXJlY3RvcnkgYXMg
dGhpcyBmaWxlKSB0byB5b3VyIGBQYWNrYWdlcy9Vc2VyYCBkaXJlY3RvcnkgYW5kIG1ha2UgY2hh
bmdlcy4K
</data>

          </attachment>
      

    </bug>

</bugzilla>